203025 2019-10-15 22:20:39 -0700 Web Inspector: Network: updates when toggling resource caching should be sent to every connected target 2019-10-17 02:08:57 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200384 InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1580451 0 hi 2019-10-15 22:20:39 -0700 (In reply to Joseph Pecoraro from comment <https://webkit.org/b/200384#36>) > > Source/WebInspectorUI/UserInterface/Base/Main.js:2759 > > + let target = WI.assumingMainTarget(); > > + target.NetworkAgent.setResourceCachingDisabled(WI.settings.resourceCachingDisabled.value); > > Whoa! NetworkAgent should work across multiple targets. So this is probably an existing bug and should just iterate all targets. (this could be pulled out into its own bug fix) > > for (let target of WI.targets) { > if (target.NetworkAgent) > target.NetworkAgent.setResourceCachingDisabled(WI.settings. resourceCachingDisabled.value); > } 1580724 1 381121 hi 2019-10-16 15:21:05 -0700 Created attachment 381121 Patch This patch requires <https://webkit.org/b/200384>. 1580725 2 381121 joepeck 2019-10-16 15:23:26 -0700 Comment on attachment 381121 Patch r=me 1580914 3 381121 commit-queue 2019-10-17 02:05:51 -0700 Comment on attachment 381121 Patch Clearing flags on attachment: 381121 Committed r251229: <https://trac.webkit.org/changeset/251229> 1580915 4 commit-queue 2019-10-17 02:05:53 -0700 All reviewed patches have been landed. Closing bug. 1580916 5 webkit-bug-importer 2019-10-17 02:08:57 -0700 <rdar://problem/56363111> 381121 2019-10-16 15:21:05 -0700 2019-10-17 02:05:51 -0700 Patch 203025.diff text/plain 1432 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdiYTc4OTNjMzRkLi40YmRjYjgyOWExOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMTAtMTYgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE5l dHdvcms6IHVwZGF0ZXMgd2hlbiB0b2dnbGluZyByZXNvdXJjZSBjYWNoaW5nIHNob3VsZCBiZSBz ZW50IHRvIGV2ZXJ5IGNvbm5lY3RlZCB0YXJnZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzAyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAg ICAgIChXSS5fcmVzb3VyY2VDYWNoaW5nRGlzYWJsZWRTZXR0aW5nQ2hhbmdlZCk6CisKIDIwMTkt MTAtMTUgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IERlYnVnZ2VyOiBwcmV2ZW50IHNvdXJjZSBtYXBwZWQgcmVzb3VyY2VzIGZyb20g YmVpbmcgYmxhY2tib3hlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQmFzZS9NYWluLmpzCmluZGV4IGVmOWQ1MjFiZjg2Li41OWI3NmJjZjRhYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMjcz MSw4ICsyNzMxLDggQEAgV0kuX2VuYWJsZUNvbnRyb2xGbG93UHJvZmlsZXJTZXR0aW5nQ2hhbmdl ZCA9IGZ1bmN0aW9uKGV2ZW50KQogCiBXSS5fcmVzb3VyY2VDYWNoaW5nRGlzYWJsZWRTZXR0aW5n Q2hhbmdlZCA9IGZ1bmN0aW9uKGV2ZW50KQogewotICAgIGxldCB0YXJnZXQgPSBXSS5hc3N1bWlu Z01haW5UYXJnZXQoKTsKLSAgICB0YXJnZXQuTmV0d29ya0FnZW50LnNldFJlc291cmNlQ2FjaGlu Z0Rpc2FibGVkKFdJLnNldHRpbmdzLnJlc291cmNlQ2FjaGluZ0Rpc2FibGVkLnZhbHVlKTsKKyAg ICBmb3IgKGxldCB0YXJnZXQgb2YgV0kudGFyZ2V0cykKKyAgICAgICAgdGFyZ2V0Lk5ldHdvcmtB Z2VudC5zZXRSZXNvdXJjZUNhY2hpbmdEaXNhYmxlZChXSS5zZXR0aW5ncy5yZXNvdXJjZUNhY2hp bmdEaXNhYmxlZC52YWx1ZSk7CiB9OwogCiBXSS5tZWFzdXJlRWxlbWVudCA9IGZ1bmN0aW9uKGVs ZW1lbnQpCg==