20302 2008-08-06 07:51:20 -0700 Wrong signbit implementation for solaris platform 2011-03-24 13:12:05 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 alexey.ushakov webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 87961 0 alexey.ushakov 2008-08-06 07:51:20 -0700 Solaris platform has incomplete implementation for signbit finction in JavaScriptCore/wtf/MathExtras.h. Here is correct implementation of this function: inline bool signbit(double num) { return copysign(1.0, num) < 0; } 87964 1 22680 alexey.ushakov 2008-08-06 07:54:33 -0700 Created attachment 22680 signbit patch for solaris platform 372854 2 86785 bentaylor.solx86 2011-03-24 09:48:48 -0700 Created attachment 86785 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Add a correct patch that includes a ChangeLog and proper patch using the webkit tools. This was done against webkit head and compiles correctly on Solaris 10/SS12 against qt-4.7.1 372859 3 86785 darin 2011-03-24 09:53:43 -0700 Comment on attachment 86785 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler View in context: https://bugs.webkit.org/attachment.cgi?id=86785&action=review > Source/JavaScriptCore/wtf/MathExtras.h:93 > -inline bool signbit(double x) { return x < 0.0; } // FIXME: Wrong for negative 0. > +inline bool signbit(double num) { return copysign(1.0, num) < 0; } I guess you copied the version from MSVC, which is why the variable name is now num. I would prefer that this file use "x" more consistently or use a word like "number" rather than "num". 372883 4 86789 bentaylor.solx86 2011-03-24 10:12:06 -0700 Created attachment 86789 Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler, fixed variable "num" to be "x" Updated patch per request 372980 5 86789 commit-queue 2011-03-24 12:14:25 -0700 Comment on attachment 86789 Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler, fixed variable "num" to be "x" Clearing flags on attachment: 86789 Committed r81882: <http://trac.webkit.org/changeset/81882> 372981 6 commit-queue 2011-03-24 12:14:29 -0700 All reviewed patches have been landed. Closing bug. 373025 7 webkit.review.bot 2011-03-24 13:12:05 -0700 http://trac.webkit.org/changeset/81882 might have broken Qt Linux Release The following tests are not passing: editing/pasteboard/5065605.html editing/pasteboard/display-block-on-spans.html editing/pasteboard/paste-text-011.html editing/pasteboard/paste-text-at-tabspan-002.html 22680 2008-08-06 07:54:33 -0700 2010-06-10 15:54:20 -0700 signbit patch for solaris platform signbit.patch text/plain 459 alexey.ushakov PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaCAgICAgKHJldmlz aW9uIDM1NTM0KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaCAgICAgKHdvcmtp bmcgY29weSkKQEAgLTc1LDcgKzc1LDcgQEAKIGlubGluZSBib29sIGlzaW5mKGRvdWJsZSB4KSB7 IHJldHVybiAhZmluaXRlKHgpICYmICFpc25hbmQoeCk7IH0KICNlbmRpZgogI2lmbmRlZiBzaWdu Yml0Ci1pbmxpbmUgYm9vbCBzaWduYml0KGRvdWJsZSB4KSB7IHJldHVybiB4IDwgMC4wOyB9IC8v IEZJWE1FOiBXcm9uZyBmb3IgbmVnYXRpdmUgMC4KK2lubGluZSBib29sIHNpZ25iaXQoZG91Ymxl IG51bSkgeyByZXR1cm4gY29weXNpZ24oMS4wLCBudW0pIDwgMDsgfQogI2VuZGlmCiAKICNlbmRp ZgoK 86785 2011-03-24 09:48:48 -0700 2011-03-24 10:12:06 -0700 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler webkit-bug-20302-JavaScriptCore-wtf-MathExtras.h-SolarisSignbit.diff text/plain 1114 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODE4NjgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDMtMjQgIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMDIKKyAgICAgICAgQ29ycmVjdCBpbXBs ZW1lbnRhdGlvbiBvZiBzaWduYml0IG9uIFNvbGFyaXMKKworICAgICAgICAqIHd0Zi9NYXRoRXh0 cmFzLmg6CisgICAgICAgIChzaWduYml0KToKKwogMjAxMS0wMy0yMyAgTWFyayBSb3dlICA8bXJv d2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgJKHJldmlzaW9uIDgxODYxKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgJKHdvcmtpbmcgY29weSkKQEAg LTkwLDcgKzkwLDcgQEAgaW5saW5lIGJvb2wgaXNmaW5pdGUoZG91YmxlIHgpIHsgcmV0dXJuIAog aW5saW5lIGJvb2wgaXNpbmYoZG91YmxlIHgpIHsgcmV0dXJuICFmaW5pdGUoeCkgJiYgIWlzbmFu ZCh4KTsgfQogI2VuZGlmCiAjaWZuZGVmIHNpZ25iaXQKLWlubGluZSBib29sIHNpZ25iaXQoZG91 YmxlIHgpIHsgcmV0dXJuIHggPCAwLjA7IH0gLy8gRklYTUU6IFdyb25nIGZvciBuZWdhdGl2ZSAw LgoraW5saW5lIGJvb2wgc2lnbmJpdChkb3VibGUgbnVtKSB7IHJldHVybiBjb3B5c2lnbigxLjAs IG51bSkgPCAwOyB9CiAjZW5kaWYKIAogI2VuZGlmCg== 86789 2011-03-24 10:12:06 -0700 2011-03-24 12:14:25 -0700 Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler, fixed variable "num" to be "x" webkit-bug-20302-JavaScriptCore-wtf-MathExtras.h-SolarisSignbit.diff text/plain 1110 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODE4NjgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDMtMjQgIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMDIKKyAgICAgICAgQ29ycmVjdCBpbXBs ZW1lbnRhdGlvbiBvZiBzaWduYml0IG9uIFNvbGFyaXMKKworICAgICAgICAqIHd0Zi9NYXRoRXh0 cmFzLmg6CisgICAgICAgIChzaWduYml0KToKKwogMjAxMS0wMy0yMyAgTWFyayBSb3dlICA8bXJv d2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgJKHJldmlzaW9uIDgxODYxKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgJKHdvcmtpbmcgY29weSkKQEAg LTkwLDcgKzkwLDcgQEAgaW5saW5lIGJvb2wgaXNmaW5pdGUoZG91YmxlIHgpIHsgcmV0dXJuIAog aW5saW5lIGJvb2wgaXNpbmYoZG91YmxlIHgpIHsgcmV0dXJuICFmaW5pdGUoeCkgJiYgIWlzbmFu ZCh4KTsgfQogI2VuZGlmCiAjaWZuZGVmIHNpZ25iaXQKLWlubGluZSBib29sIHNpZ25iaXQoZG91 YmxlIHgpIHsgcmV0dXJuIHggPCAwLjA7IH0gLy8gRklYTUU6IFdyb25nIGZvciBuZWdhdGl2ZSAw LgoraW5saW5lIGJvb2wgc2lnbmJpdChkb3VibGUgeCkgeyByZXR1cm4gY29weXNpZ24oMS4wLCB4 KSA8IDA7IH0KICNlbmRpZgogCiAjZW5kaWYK