203007 2019-10-15 14:47:35 -0700 Web Inspector: Debugger: prevent source mapped resources from being blackboxed 2019-10-15 17:02:18 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1580278 0 hi 2019-10-15 14:47:35 -0700 Since source mapped resources are entirely a frontend concept, it doesn't make sense to allow them to be blackboxed. We shouldn't show any <(*)> eye for them. 1580283 1 381025 hi 2019-10-15 14:51:28 -0700 Created attachment 381025 Patch 1580285 2 381025 mattbaker 2019-10-15 14:54:18 -0700 Comment on attachment 381025 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381025&action=review r=me > Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:79 > + return false; Style: simple getters should be one line. 1580351 3 381025 hi 2019-10-15 16:08:45 -0700 Comment on attachment 381025 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381025&action=review >> Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:79 >> + return false; > > Style: simple getters should be one line. Although the code for this is very basic, I wouldn't consider this to be "simple", as I find it's harder to immediately grok when it's on one line. ``` get supportsScriptBlackboxing() { return false; } ``` vs ``` get supportsScriptBlackboxing() { return false; } ``` In the first case, I have to find where the `() {` are to distinguish between the function name and it's body, whereas in the second case it's immediately obvious since they're on different lines. In my mind, a "simple" getter is one where the function name is the exact same as the member variable being used in the function's body. ``` get element() { return this._element; } set element(x) { this._element = x; } ``` We're not very consistent for this in Web Inspector code, so I'm going to land this as-is until there's a discussion/consensus. 1580383 4 381025 commit-queue 2019-10-15 17:01:42 -0700 Comment on attachment 381025 Patch Clearing flags on attachment: 381025 Committed r251170: <https://trac.webkit.org/changeset/251170> 1580384 5 commit-queue 2019-10-15 17:01:43 -0700 All reviewed patches have been landed. Closing bug. 1580386 6 webkit-bug-importer 2019-10-15 17:02:18 -0700 <rdar://problem/56314273> 381025 2019-10-15 14:51:28 -0700 2019-10-15 17:01:42 -0700 Patch bug-203007-20191015145128.patch text/plain 1764 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlmYTJlN2E0YjAzNzEwYTEzMDBiZjUxZTQ1NTFl NDhjMWEwZTIzMzcuLjY4ZGZkNDIzODZhNDA1MTlmYjZhNDc4MmY5NDEzZDk2ZTcxMjk2MzUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEwLTE1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE ZWJ1Z2dlcjogcHJldmVudCBzb3VyY2UgbWFwcGVkIHJlc291cmNlcyBmcm9tIGJlaW5nIGJsYWNr Ym94ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MzAwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNp bmNlIHNvdXJjZSBtYXBwZWQgcmVzb3VyY2VzIGFyZSBlbnRpcmVseSBhIGZyb250ZW5kIGNvbmNl cHQsIGl0IGRvZXNuJ3QgbWFrZSBzZW5zZSB0bworICAgICAgICBhbGxvdyB0aGVtIHRvIGJlIGJs YWNrYm94ZWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9Tb3VyY2VNYXBSZXNv dXJjZS5qczoKKyAgICAgICAgKFdJLlNvdXJjZU1hcFJlc291cmNlLnByb3RvdHlwZS5nZXQgc3Vw cG9ydHNTY3JpcHRCbGFja2JveGluZyk6CisKIDIwMTktMTAtMTUgIERldmluIFJvdXNzbyAgPGRy b3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IExvY2FsIFJlc291cmNl IE92ZXJyaWRlczogYXV0b21hdGljYWxseSBjcmVhdGUgYW4gaW1hZ2UvZm9udCBsb2NhbCBvdmVy cmlkZSB3aGVuIGRyYWdnaW5nIGNvbnRlbnQgb3ZlciBhIG5vbi1vdmVycmlkZGVuIHJlc291cmNl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv U291cmNlTWFwUmVzb3VyY2UuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Nb2RlbHMvU291cmNlTWFwUmVzb3VyY2UuanMKaW5kZXggZTEzMzNhNGQ3MWIyMWFkYjIzNDQx NTkzZjE4Y2FkMzBlZGE3MGRkNy4uMDkxMTlhMTc5N2NlOGJiY2IzYzU3ZGM3NWE2YTBiNDk3NTRi YmJkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k ZWxzL1NvdXJjZU1hcFJlc291cmNlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL01vZGVscy9Tb3VyY2VNYXBSZXNvdXJjZS5qcwpAQCAtNzQsNiArNzQsMTEgQEAg V0kuU291cmNlTWFwUmVzb3VyY2UgPSBjbGFzcyBTb3VyY2VNYXBSZXNvdXJjZSBleHRlbmRzIFdJ LlJlc291cmNlCiAgICAgICAgIHJldHVybiByZXNvdXJjZVVSTENvbXBvbmVudHMucGF0aC5zdWJz dHJpbmcoc291cmNlTWFwcGluZ0Jhc2VQYXRoVVJMQ29tcG9uZW50cy5wYXRoLmxlbmd0aCwgcmVz b3VyY2VVUkxDb21wb25lbnRzLmxlbmd0aCk7CiAgICAgfQogCisgICAgZ2V0IHN1cHBvcnRzU2Ny aXB0QmxhY2tib3hpbmcoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKwog ICAgIHJlcXVlc3RDb250ZW50RnJvbUJhY2tlbmQoKQogICAgIHsKICAgICAgICAgLy8gUmV2ZXJ0 IHRoZSBtYXJrQXNGaW5pc2hlZCB0aGF0IHdhcyBkb25lIGluIHRoZSBjb25zdHJ1Y3Rvci4K