202995 2019-10-15 10:40:32 -0700 [Tools] Add a driver for cog for benchmark_runner.py 2019-10-16 10:40:30 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra psaavedra clopez commit-queue ews-watchlist glenn jbedard webkit-bug-importer zan oldest_to_newest 1580165 0 psaavedra 2019-10-15 10:40:32 -0700 SSIA 1580167 1 381000 psaavedra 2019-10-15 10:51:03 -0700 Created attachment 381000 patch 1580170 2 381000 jbedard 2019-10-15 10:56:48 -0700 Comment on attachment 381000 patch View in context: https://bugs.webkit.org/attachment.cgi?id=381000&action=review > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py:49 > + super(CogBrowserDriver, self).launch_url(url, options, Should be super(CogFdoBrowserDriver, ...) 1580472 3 psaavedra 2019-10-16 00:20:38 -0700 It sE1003(In reply to Jonathan Bedard from comment #2) > Comment on attachment 381000 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381000&action=review > > > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py:49 > > + super(CogBrowserDriver, self).launch_url(url, options, > > Should be super(CogFdoBrowserDriver, ...) pylint is blaming against the usage of super() in the launch_url() function. I explitelly invoked the grandfathers method class to bypass the logic introduced in the CogBrowserDriver class which is the parent class. Anyway, for the sake of simplicity, I will rewrite the patch to inherit directly from the LinuxBrowserDriver. This introduces a couple of lines more but still is a simply code and probably less prone to future mistakes. 1580473 4 381060 psaavedra 2019-10-16 00:24:23 -0700 Created attachment 381060 patch 1580512 5 381066 psaavedra 2019-10-16 04:53:17 -0700 Created attachment 381066 patch 1580566 6 381066 commit-queue 2019-10-16 10:26:17 -0700 Comment on attachment 381066 patch Clearing flags on attachment: 381066 Committed r251191: <https://trac.webkit.org/changeset/251191> 1580567 7 commit-queue 2019-10-16 10:26:19 -0700 All reviewed patches have been landed. Closing bug. 1580575 8 webkit-bug-importer 2019-10-16 10:40:30 -0700 <rdar://problem/56337507> 381000 2019-10-15 10:51:03 -0700 2019-10-16 00:24:19 -0700 patch bug-202995-20191015195102.patch text/plain 3716 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQzNWQwNzcwYTQ2ZjRhNTBmMTc5MTFhMTBmYThiMmU0 ODY2ZTg4OC4uOTc3MDJiMGMwYjM5YmY3ZWFhZWMwY2YyNDZhYjA5MDI3YWJmMjgxZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTEwLTE1ICBQYWJsbyBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtUb29sc10gQWRkIGEgZHJpdmVyIGZvciBjb2cgZm9yIGJlbmNobWFya19ydW5u ZXIucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw Mjk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2Jyb3dzZXJfZHJpdmVyL2xpbnV4X2Nv Z19kcml2ZXIucHk6IEFkZGVkLgorICAgICAgICAoQ29nQnJvd3NlckRyaXZlcik6CisgICAgICAg IChDb2dCcm93c2VyRHJpdmVyLmxhdW5jaF91cmwpOgorICAgICAgICAoQ29nQnJvd3NlckRyaXZl ci5sYXVuY2hfZHJpdmVyKToKKyAgICAgICAgKENvZ0Zkb0Jyb3dzZXJEcml2ZXIpOgorICAgICAg ICAoQ29nRmRvQnJvd3NlckRyaXZlci5sYXVuY2hfdXJsKToKKwogMjAxOS0xMC0xNSAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFBhc3MgQ09S Uy1lbmFibGVkIHNjaGVtZXMgdGhyb3VnaCBXZWJQcm9jZXNzIGluc3RlYWQgb2YgaGF2aW5nIHRo ZW0gTmV0d29ya1Byb2Nlc3MtZ2xvYmFsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvbGludXhfY29nX2RyaXZlci5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2VyX2RyaXZlci9s aW51eF9jb2dfZHJpdmVyLnB5Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA3MzRlNzE3OTkyZjhmNmE5Zjc2NTgwODY2 OTA0MWI4YWM4YmNhZDIKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvbGludXhfY29nX2RyaXZlci5weQpAQCAt MCwwICsxLDUxIEBACisjIENvcHlyaWdodCAoQykgMjAxOSBJZ2FsaWEgUy5MLiBBbGwgcmlnaHRz IHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorIyBtZXQ6CisjCisj ICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJv dmUgY29weXJpZ2h0CisjIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lci4KKyMKKyMgICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFy eSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorIyBjb3B5cmlnaHQgbm90aWNlLCB0aGlz IGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisjIGluIHRo ZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUK KyMgZGlzdHJpYnV0aW9uLgorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBD T1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisjICJBUyBJUyIgQU5EIEFOWSBFWFBS RVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQg VE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNT IEZPUgorIyBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQg U0hBTEwgVEhFIENPUFlSSUdIVAorIyBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZP UiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyMgU1BFQ0lBTCwgRVhFTVBMQVJZ LCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1JVEVE IFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9G IFVTRSwKKyMgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dF VkVSIENBVVNFRCBBTkQgT04gQU5ZCisjIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4g Q09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdMSUdF TkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisjIE9G IFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VD SCBEQU1BR0UuCisKK2Zyb20gbGludXhfYnJvd3Nlcl9kcml2ZXIgaW1wb3J0IExpbnV4QnJvd3Nl ckRyaXZlcgorCisKK2NsYXNzIENvZ0Jyb3dzZXJEcml2ZXIoTGludXhCcm93c2VyRHJpdmVyKToK KyAgICBicm93c2VyX25hbWUgPSAnY29nJworICAgIHByb2Nlc3Nfc2VhcmNoX2xpc3QgPSBbJ2Nv ZycsICdkaW5naHknXQorCisgICAgZGVmIGxhdW5jaF91cmwoc2VsZiwgdXJsLCBvcHRpb25zLCBi cm93c2VyX2J1aWxkX3BhdGgsIGJyb3dzZXJfcGF0aCk6CisgICAgICAgIHNlbGYuX2Jyb3dzZXJf YXJndW1lbnRzID0gW3VybF0KKyAgICAgICAgc3VwZXIoQ29nQnJvd3NlckRyaXZlciwgc2VsZiku bGF1bmNoX3VybCh1cmwsIG9wdGlvbnMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgYnJvd3Nlcl9idWlsZF9wYXRoLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJyb3dzZXJfcGF0aCkKKworICAgIGRlZiBs YXVuY2hfZHJpdmVyKHNlbGYsIHVybCwgb3B0aW9ucywgYnJvd3Nlcl9idWlsZF9wYXRoKToKKyAg ICAgICAgcmFpc2UgVmFsdWVFcnJvcigiQnJvd3NlciB7YnJvd3Nlcn0gaXMgbm90IGF2YWlsYWJs ZSB3aXRoIHdlYmRyaXZlciIuZm9ybWF0KGJyb3dzZXI9c2VsZi5icm93c2VyX25hbWUpKQorCisK K2NsYXNzIENvZ0Zkb0Jyb3dzZXJEcml2ZXIoQ29nQnJvd3NlckRyaXZlcik6CisgICAgYnJvd3Nl cl9uYW1lID0gJ2NvZy1mZG8nCisKKyAgICBkZWYgbGF1bmNoX3VybChzZWxmLCB1cmwsIG9wdGlv bnMsIGJyb3dzZXJfYnVpbGRfcGF0aCwgYnJvd3Nlcl9wYXRoKToKKyAgICAgICAgc2VsZi5fYnJv d3Nlcl9hcmd1bWVudHMgPSBbJy0tcGxhdGZvcm09ZmRvJywgdXJsXQorICAgICAgICBzdXBlcihD b2dCcm93c2VyRHJpdmVyLCBzZWxmKS5sYXVuY2hfdXJsKHVybCwgb3B0aW9ucywKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBicm93c2VyX2J1aWxkX3Bh dGgsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJv d3Nlcl9wYXRoKQo= 381060 2019-10-16 00:24:23 -0700 2019-10-16 04:53:13 -0700 patch bug-202995-20191016092422.patch text/plain 3951 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQzNWQwNzcwYTQ2ZjRhNTBmMTc5MTFhMTBmYThiMmU0 ODY2ZTg4OC4uOTc3MDJiMGMwYjM5YmY3ZWFhZWMwY2YyNDZhYjA5MDI3YWJmMjgxZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTEwLTE1ICBQYWJsbyBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtUb29sc10gQWRkIGEgZHJpdmVyIGZvciBjb2cgZm9yIGJlbmNobWFya19ydW5u ZXIucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw Mjk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2Jyb3dzZXJfZHJpdmVyL2xpbnV4X2Nv Z19kcml2ZXIucHk6IEFkZGVkLgorICAgICAgICAoQ29nQnJvd3NlckRyaXZlcik6CisgICAgICAg IChDb2dCcm93c2VyRHJpdmVyLmxhdW5jaF91cmwpOgorICAgICAgICAoQ29nQnJvd3NlckRyaXZl ci5sYXVuY2hfZHJpdmVyKToKKyAgICAgICAgKENvZ0Zkb0Jyb3dzZXJEcml2ZXIpOgorICAgICAg ICAoQ29nRmRvQnJvd3NlckRyaXZlci5sYXVuY2hfdXJsKToKKwogMjAxOS0xMC0xNSAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFBhc3MgQ09S Uy1lbmFibGVkIHNjaGVtZXMgdGhyb3VnaCBXZWJQcm9jZXNzIGluc3RlYWQgb2YgaGF2aW5nIHRo ZW0gTmV0d29ya1Byb2Nlc3MtZ2xvYmFsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvbGludXhfY29nX2RyaXZlci5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2VyX2RyaXZlci9s aW51eF9jb2dfZHJpdmVyLnB5Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk2MDRmNmMyMTZlNzJmMTM1YWMwOWZjYmE0 M2JjMGU4MDg5ZGUyYTIKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvbGludXhfY29nX2RyaXZlci5weQpAQCAt MCwwICsxLDU1IEBACisjIENvcHlyaWdodCAoQykgMjAxOSBJZ2FsaWEgUy5MLiBBbGwgcmlnaHRz IHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorIyBtZXQ6CisjCisj ICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJv dmUgY29weXJpZ2h0CisjIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lci4KKyMKKyMgICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFy eSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorIyBjb3B5cmlnaHQgbm90aWNlLCB0aGlz IGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisjIGluIHRo ZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUK KyMgZGlzdHJpYnV0aW9uLgorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBD T1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisjICJBUyBJUyIgQU5EIEFOWSBFWFBS RVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQg VE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNT IEZPUgorIyBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQg U0hBTEwgVEhFIENPUFlSSUdIVAorIyBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZP UiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyMgU1BFQ0lBTCwgRVhFTVBMQVJZ LCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1JVEVE IFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9G IFVTRSwKKyMgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dF VkVSIENBVVNFRCBBTkQgT04gQU5ZCisjIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4g Q09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdMSUdF TkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisjIE9G IFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VD SCBEQU1BR0UuCisKK2Zyb20gbGludXhfYnJvd3Nlcl9kcml2ZXIgaW1wb3J0IExpbnV4QnJvd3Nl ckRyaXZlcgorCisKK2NsYXNzIENvZ0Jyb3dzZXJEcml2ZXIoTGludXhCcm93c2VyRHJpdmVyKToK KyAgICBicm93c2VyX25hbWUgPSAnY29nJworICAgIHByb2Nlc3Nfc2VhcmNoX2xpc3QgPSBbJ2Nv ZycsICdkaW5naHknXQorCisgICAgZGVmIGxhdW5jaF91cmwoc2VsZiwgdXJsLCBvcHRpb25zLCBi cm93c2VyX2J1aWxkX3BhdGgsIGJyb3dzZXJfcGF0aCk6CisgICAgICAgIHNlbGYuX2Jyb3dzZXJf YXJndW1lbnRzID0gW3VybF0KKyAgICAgICAgc3VwZXIoQ29nQnJvd3NlckRyaXZlciwgc2VsZiku bGF1bmNoX3VybCh1cmwsIG9wdGlvbnMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgYnJvd3Nlcl9idWlsZF9wYXRoLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJyb3dzZXJfcGF0aCkKKworICAgIGRlZiBs YXVuY2hfZHJpdmVyKHNlbGYsIHVybCwgb3B0aW9ucywgYnJvd3Nlcl9idWlsZF9wYXRoKToKKyAg ICAgICAgcmFpc2UgVmFsdWVFcnJvcigiQnJvd3NlciB7YnJvd3Nlcn0gaXMgbm90IGF2YWlsYWJs ZSB3aXRoIHdlYmRyaXZlciIuZm9ybWF0KGJyb3dzZXI9c2VsZi5icm93c2VyX25hbWUpKQorCisK K2NsYXNzIENvZ0Zkb0Jyb3dzZXJEcml2ZXIoTGludXhCcm93c2VyRHJpdmVyKToKKyAgICBicm93 c2VyX25hbWUgPSAnY29nLWZkbycKKyAgICBwcm9jZXNzX3NlYXJjaF9saXN0ID0gWydjb2cnLCAn ZGluZ2h5J10KKworICAgIGRlZiBsYXVuY2hfdXJsKHNlbGYsIHVybCwgb3B0aW9ucywgYnJvd3Nl cl9idWlsZF9wYXRoLCBicm93c2VyX3BhdGgpOgorICAgICAgICBzZWxmLl9icm93c2VyX2FyZ3Vt ZW50cyA9IFsnLS1wbGF0Zm9ybT1mZG8nLCB1cmxdCisgICAgICAgIHN1cGVyKENvZ0Zkb0Jyb3dz ZXJEcml2ZXIsIHNlbGYpLmxhdW5jaF91cmwodXJsLCBvcHRpb25zLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJyb3dzZXJfYnVpbGRfcGF0aCwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBicm93 c2VyX3BhdGgpCisKKyAgICBkZWYgbGF1bmNoX2RyaXZlcihzZWxmLCB1cmwsIG9wdGlvbnMsIGJy b3dzZXJfYnVpbGRfcGF0aCk6CisgICAgICAgIHJhaXNlIFZhbHVlRXJyb3IoIkJyb3dzZXIge2Jy b3dzZXJ9IGlzIG5vdCBhdmFpbGFibGUgd2l0aCB3ZWJkcml2ZXIiLmZvcm1hdChicm93c2VyPXNl bGYuYnJvd3Nlcl9uYW1lKSkK 381066 2019-10-16 04:53:17 -0700 2019-10-16 10:26:17 -0700 patch bug-202995-20191016135316.patch text/plain 3931 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQzNWQwNzcwYTQ2ZjRhNTBmMTc5MTFhMTBmYThiMmU0 ODY2ZTg4OC4uOTc3MDJiMGMwYjM5YmY3ZWFhZWMwY2YyNDZhYjA5MDI3YWJmMjgxZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTEwLTE1ICBQYWJsbyBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtUb29sc10gQWRkIGEgZHJpdmVyIGZvciBjb2cgZm9yIGJlbmNobWFya19ydW5u ZXIucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw Mjk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2Jyb3dzZXJfZHJpdmVyL2xpbnV4X2Nv Z19kcml2ZXIucHk6IEFkZGVkLgorICAgICAgICAoQ29nQnJvd3NlckRyaXZlcik6CisgICAgICAg IChDb2dCcm93c2VyRHJpdmVyLmxhdW5jaF91cmwpOgorICAgICAgICAoQ29nQnJvd3NlckRyaXZl ci5sYXVuY2hfZHJpdmVyKToKKyAgICAgICAgKENvZ0Zkb0Jyb3dzZXJEcml2ZXIpOgorICAgICAg ICAoQ29nRmRvQnJvd3NlckRyaXZlci5sYXVuY2hfdXJsKToKKwogMjAxOS0xMC0xNSAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFBhc3MgQ09S Uy1lbmFibGVkIHNjaGVtZXMgdGhyb3VnaCBXZWJQcm9jZXNzIGluc3RlYWQgb2YgaGF2aW5nIHRo ZW0gTmV0d29ya1Byb2Nlc3MtZ2xvYmFsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvbGludXhfY29nX2RyaXZlci5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2VyX2RyaXZlci9s aW51eF9jb2dfZHJpdmVyLnB5Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI5MGFhNDRjOTg2MDg1ZGQyYTkzZjU0ZWFh OTJiNzZjNjczNzIzZmUKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvbGludXhfY29nX2RyaXZlci5weQpAQCAt MCwwICsxLDU1IEBACisjIENvcHlyaWdodCAoQykgMjAxOSBJZ2FsaWEgUy5MLiBBbGwgcmlnaHRz IHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorIyBtZXQ6CisjCisj ICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJv dmUgY29weXJpZ2h0CisjIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lci4KKyMKKyMgICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFy eSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorIyBjb3B5cmlnaHQgbm90aWNlLCB0aGlz IGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisjIGluIHRo ZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUK KyMgZGlzdHJpYnV0aW9uLgorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBD T1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisjICJBUyBJUyIgQU5EIEFOWSBFWFBS RVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQg VE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNT IEZPUgorIyBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQg U0hBTEwgVEhFIENPUFlSSUdIVAorIyBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZP UiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyMgU1BFQ0lBTCwgRVhFTVBMQVJZ LCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1JVEVE IFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9G IFVTRSwKKyMgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dF VkVSIENBVVNFRCBBTkQgT04gQU5ZCisjIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4g Q09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdMSUdF TkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisjIE9G IFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VD SCBEQU1BR0UuCisKK2Zyb20gbGludXhfYnJvd3Nlcl9kcml2ZXIgaW1wb3J0IExpbnV4QnJvd3Nl ckRyaXZlcgorCisKK2NsYXNzIENvZ0Jyb3dzZXJEcml2ZXIoTGludXhCcm93c2VyRHJpdmVyKToK KyAgICBicm93c2VyX25hbWUgPSAnY29nJworICAgIHByb2Nlc3Nfc2VhcmNoX2xpc3QgPSBbJ2Nv ZyddCisKKyAgICBkZWYgbGF1bmNoX3VybChzZWxmLCB1cmwsIG9wdGlvbnMsIGJyb3dzZXJfYnVp bGRfcGF0aCwgYnJvd3Nlcl9wYXRoKToKKyAgICAgICAgc2VsZi5fYnJvd3Nlcl9hcmd1bWVudHMg PSBbdXJsXQorICAgICAgICBzdXBlcihDb2dCcm93c2VyRHJpdmVyLCBzZWxmKS5sYXVuY2hfdXJs KHVybCwgb3B0aW9ucywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBicm93c2VyX2J1aWxkX3BhdGgsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgYnJvd3Nlcl9wYXRoKQorCisgICAgZGVmIGxhdW5jaF9kcml2 ZXIoc2VsZiwgdXJsLCBvcHRpb25zLCBicm93c2VyX2J1aWxkX3BhdGgpOgorICAgICAgICByYWlz ZSBWYWx1ZUVycm9yKCJCcm93c2VyIHticm93c2VyfSBpcyBub3QgYXZhaWxhYmxlIHdpdGggd2Vi ZHJpdmVyIi5mb3JtYXQoYnJvd3Nlcj1zZWxmLmJyb3dzZXJfbmFtZSkpCisKKworY2xhc3MgQ29n RmRvQnJvd3NlckRyaXZlcihMaW51eEJyb3dzZXJEcml2ZXIpOgorICAgIGJyb3dzZXJfbmFtZSA9 ICdjb2ctZmRvJworICAgIHByb2Nlc3Nfc2VhcmNoX2xpc3QgPSBbJ2NvZyddCisKKyAgICBkZWYg bGF1bmNoX3VybChzZWxmLCB1cmwsIG9wdGlvbnMsIGJyb3dzZXJfYnVpbGRfcGF0aCwgYnJvd3Nl cl9wYXRoKToKKyAgICAgICAgc2VsZi5fYnJvd3Nlcl9hcmd1bWVudHMgPSBbJy0tcGxhdGZvcm09 ZmRvJywgdXJsXQorICAgICAgICBzdXBlcihDb2dGZG9Ccm93c2VyRHJpdmVyLCBzZWxmKS5sYXVu Y2hfdXJsKHVybCwgb3B0aW9ucywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBicm93c2VyX2J1aWxkX3BhdGgsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJvd3Nlcl9wYXRoKQorCisgICAgZGVm IGxhdW5jaF9kcml2ZXIoc2VsZiwgdXJsLCBvcHRpb25zLCBicm93c2VyX2J1aWxkX3BhdGgpOgor ICAgICAgICByYWlzZSBWYWx1ZUVycm9yKCJCcm93c2VyIHticm93c2VyfSBpcyBub3QgYXZhaWxh YmxlIHdpdGggd2ViZHJpdmVyIi5mb3JtYXQoYnJvd3Nlcj1zZWxmLmJyb3dzZXJfbmFtZSkpCg==