202986 2019-10-15 06:39:46 -0700 Interpreter: Don't assert that reference is nonnull 2019-10-15 14:28:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Trivial --- 1 angelos webkit-unassigned commit-queue ews-watchlist guijemont keith_miller lingcherd_ho mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1580070 0 angelos 2019-10-15 06:39:46 -0700 Interpreter: Don't assert that reference is nonnull 1580076 1 380982 angelos 2019-10-15 06:46:37 -0700 Created attachment 380982 Patch 1580094 2 380982 mark.lam 2019-10-15 07:46:29 -0700 Comment on attachment 380982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380982&action=review Did you mean to get a review for this patch? If so, you should flag it as r? (see the r: box). > Source/JavaScriptCore/ChangeLog:9 > + Interpreter: Don't assert that reference is nonnull > + https://bugs.webkit.org/show_bug.cgi?id=202986 > + > + Reviewed by NOBODY (OOPS!). > + > + * interpreter/FrameTracers.h: > + (JSC::NativeCallFrameTracer::NativeCallFrameTracer): Please add a comment here to explain your change. 1580103 3 380986 angelos 2019-10-15 08:15:39 -0700 Created attachment 380986 Patch 1580104 4 angelos 2019-10-15 08:17:37 -0700 Oops. Should be better now. 1580108 5 380986 keith_miller 2019-10-15 08:48:29 -0700 Comment on attachment 380986 Patch r=me. 1580127 6 380986 commit-queue 2019-10-15 09:35:12 -0700 Comment on attachment 380986 Patch Clearing flags on attachment: 380986 Committed r251139: <https://trac.webkit.org/changeset/251139> 1580128 7 commit-queue 2019-10-15 09:35:15 -0700 All reviewed patches have been landed. Closing bug. 1580262 8 lingcherd_ho 2019-10-15 14:28:26 -0700 <rdar://problem/56294960> 1580263 9 webkit-bug-importer 2019-10-15 14:28:35 -0700 <rdar://problem/56308232> 380982 2019-10-15 06:46:37 -0700 2019-10-15 08:15:32 -0700 Patch bug-202986-20191015154634.patch text/plain 1363 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NzUzMWQ1MzAwZDU3M2QzZWM4ZTc5YzhjZDc1YWMyMTMwYzQ5Nzg2Li45NGM1NDhjOGIyYjMwMWRj NmQ2YjQ4MmM1M2QwNDE4NzMyMTljNTE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0xMC0xNSAgQW5nZWxvcyBPaWtvbm9tb3BvdWxvcyAgPGFvaWtvbm9t b3BvdWxvc0BpZ2FsaWEuY29tPgorCisgICAgICAgIEludGVycHJldGVyOiBEb24ndCBhc3NlcnQg dGhhdCByZWZlcmVuY2UgaXMgbm9ubnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAyOTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9GcmFtZVRyYWNlcnMuaDoKKyAgICAgICAg KEpTQzo6TmF0aXZlQ2FsbEZyYW1lVHJhY2VyOjpOYXRpdmVDYWxsRnJhbWVUcmFjZXIpOgorCiAy MDE5LTEwLTE0ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjUxMDkwLgpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ZyYW1lVHJhY2Vycy5oIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2ludGVycHJldGVyL0ZyYW1lVHJhY2Vycy5oCmluZGV4IDFkZThlNGFkNTdlYjgy MjU3N2VkZjI4NjVlNTI5ZmYwZWVmOTdmMmEuLjExZjdiOGEyYTMwNTk4YmEzNWE3YjRmZTUwOTg0 Mjg1NGFkY2EyNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRl ci9GcmFtZVRyYWNlcnMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIv RnJhbWVUcmFjZXJzLmgKQEAgLTg1LDcgKzg1LDYgQEAgY2xhc3MgTmF0aXZlQ2FsbEZyYW1lVHJh Y2VyIHsKIHB1YmxpYzoKICAgICBBTFdBWVNfSU5MSU5FIE5hdGl2ZUNhbGxGcmFtZVRyYWNlcihW TSYgdm0sIENhbGxGcmFtZSogY2FsbEZyYW1lKQogICAgIHsKLSAgICAgICAgQVNTRVJUKCZ2bSk7 CiAgICAgICAgIEFTU0VSVChjYWxsRnJhbWUpOwogICAgICAgICBBU1NFUlQocmVpbnRlcnByZXRf Y2FzdDx2b2lkKj4oY2FsbEZyYW1lKSA8IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHZtLnRvcEVu dHJ5RnJhbWUpKTsKICAgICAgICAgYXNzZXJ0U3RhY2tQb2ludGVySXNBbGlnbmVkKCk7Cg== 380986 2019-10-15 08:15:39 -0700 2019-10-15 09:35:12 -0700 Patch bug-202986-20191015171537.patch text/plain 1507 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NzUzMWQ1MzAwZDU3M2QzZWM4ZTc5YzhjZDc1YWMyMTMwYzQ5Nzg2Li40NGM4NDRkZTczOTQ5ZWRh MjliYWViNjExNTVhNTBhNDQzNjQ2MjQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0xMC0xNSAgQW5nZWxvcyBPaWtvbm9tb3BvdWxvcyAgPGFvaWtvbm9t b3BvdWxvc0BpZ2FsaWEuY29tPgorCisgICAgICAgIEludGVycHJldGVyOiBEb24ndCBhc3NlcnQg dGhhdCByZWZlcmVuY2UgaXMgbm9ubnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAyOTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRysrIDkuMiBjYW4gYXNzdW1lIHRoYXQgdGhlIGFkZHJlc3Mgb2Yg YSByZWZlcmVuY2UgaXMgbm9ubnVsbCBhbmQKKyAgICAgICAgZW1pdHMgbXVsdGlwbGUgd2Fybmlu Z3MgdG8gdGhhdCBlZmZlY3QgaW4gLS1kZWJ1ZyBidWlsZHMuCisKKyAgICAgICAgKiBpbnRlcnBy ZXRlci9GcmFtZVRyYWNlcnMuaDoKKyAgICAgICAgKEpTQzo6TmF0aXZlQ2FsbEZyYW1lVHJhY2Vy OjpOYXRpdmVDYWxsRnJhbWVUcmFjZXIpOgorCiAyMDE5LTEwLTE0ICBDb21taXQgUXVldWUgIDxj b21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMjUxMDkwLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVy L0ZyYW1lVHJhY2Vycy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ZyYW1l VHJhY2Vycy5oCmluZGV4IDFkZThlNGFkNTdlYjgyMjU3N2VkZjI4NjVlNTI5ZmYwZWVmOTdmMmEu LjExZjdiOGEyYTMwNTk4YmEzNWE3YjRmZTUwOTg0Mjg1NGFkY2EyNGEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9GcmFtZVRyYWNlcnMuaAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvRnJhbWVUcmFjZXJzLmgKQEAgLTg1LDcgKzg1 LDYgQEAgY2xhc3MgTmF0aXZlQ2FsbEZyYW1lVHJhY2VyIHsKIHB1YmxpYzoKICAgICBBTFdBWVNf SU5MSU5FIE5hdGl2ZUNhbGxGcmFtZVRyYWNlcihWTSYgdm0sIENhbGxGcmFtZSogY2FsbEZyYW1l KQogICAgIHsKLSAgICAgICAgQVNTRVJUKCZ2bSk7CiAgICAgICAgIEFTU0VSVChjYWxsRnJhbWUp OwogICAgICAgICBBU1NFUlQocmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oY2FsbEZyYW1lKSA8IHJl aW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHZtLnRvcEVudHJ5RnJhbWUpKTsKICAgICAgICAgYXNzZXJ0 U3RhY2tQb2ludGVySXNBbGlnbmVkKCk7Cg==