202983 2019-10-15 02:13:00 -0700 SincResampler does not need to create a new AudioBus for each consumeSource call 2019-10-29 19:19:20 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson ews-watchlist glenn jbedard jer.noble jlewis3 philipj sergio tsavell webkit-bug-importer oldest_to_newest 1580043 0 youennf 2019-10-15 02:13:00 -0700 SincResampler does not need to create a new AudioBus for each consumeSource call 1580044 1 380974 youennf 2019-10-15 02:16:19 -0700 Created attachment 380974 Patch 1580922 2 381185 youennf 2019-10-17 02:36:14 -0700 Created attachment 381185 Patch 1581065 3 381185 commit-queue 2019-10-17 11:19:15 -0700 Comment on attachment 381185 Patch Clearing flags on attachment: 381185 Committed r251249: <https://trac.webkit.org/changeset/251249> 1581066 4 commit-queue 2019-10-17 11:19:16 -0700 All reviewed patches have been landed. Closing bug. 1581068 5 webkit-bug-importer 2019-10-17 11:20:17 -0700 <rdar://problem/56377728> 1585218 6 jbedard 2019-10-29 19:19:20 -0700 We have a test failure in TestWebKitAPI.PreferredAudioBufferSize.AudioElement on Catalina, https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.PreferredAudioBufferSize.AudioElement. It started out flakey, but now it's consistent....I'm not convinced this is the regression point, but looking at the commits around the time the failure started, it seems like the best candidate. 380974 2019-10-15 02:16:19 -0700 2019-10-17 02:35:55 -0700 Patch bug-202983-20191015111617.patch text/plain 2568 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M5MGYxMjhhN2E4ZTM3 OWM4ZjllZjRmMmI3NjI1YjVjNzY2YmI4NS4uMTFlZGU4M2QzNWFhMWY4OGM1MTEzMzEzMGRjNzVh YmJmNWQyYzliNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTEwLTE1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBTaW5jUmVzYW1wbGVyIGRv ZXMgbm90IG5lZWQgdG8gY3JlYXRlIGEgbmV3IEF1ZGlvQnVzIGZvciBlYWNoIGNvbnN1bWVTb3Vy Y2UgY2FsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAyOTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb2NhdGUgYW4gaW50ZXJuYWwgQXVkaW9CdXMgb25jZSBhbmQgZm9yIGFsbC4KKyAgICAgICAg Tm8gb2JzZXJ2YWJsZSBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9h dWRpby9TaW5jUmVzYW1wbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNpbmNSZXNhbXBsZXI6 OmNvbnN1bWVTb3VyY2UpOgorICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL1NpbmNSZXNhbXBsZXIu aDoKKwogMjAxOS0xMC0xNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAg ICAgICAgTXVsdGlDaGFubmVsUmVzYW1wbGVyIGRvZXMgbm90IG5lZWQgdG8gcmVjcmVhdGUgYSBD aGFubmVsUHJvdmlkZXIgZm9yIGV2ZXJ5IHByb2Nlc3MgY2FsbApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vU2luY1Jlc2FtcGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9hdWRpby9TaW5jUmVzYW1wbGVyLmNwcAppbmRleCA1ZDA4ZGU1Y2FkYWZiMTA0 NjczZjQ0ZDM4ZjM0NGUxOTdkMWUxZjllLi41MjA1MjdiNTRiYTU3ODZkOGNlYmRmYWI1M2E0NTY4 YTkzZGU2ZWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9TaW5j UmVzYW1wbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9TaW5jUmVz YW1wbGVyLmNwcApAQCAtMTMwLDE0ICsxMzAsMTUgQEAgdm9pZCBTaW5jUmVzYW1wbGVyOjpjb25z dW1lU291cmNlKGZsb2F0KiBidWZmZXIsIHVuc2lnbmVkIG51bWJlck9mU291cmNlRnJhbWVzKQog ICAgIEFTU0VSVChtX3NvdXJjZVByb3ZpZGVyKTsKICAgICBpZiAoIW1fc291cmNlUHJvdmlkZXIp CiAgICAgICAgIHJldHVybjsKLSAgICAKKwogICAgIC8vIFdyYXAgdGhlIHByb3ZpZGVkIGJ1ZmZl ciBieSBhbiBBdWRpb0J1cyBmb3IgdXNlIGJ5IHRoZSBzb3VyY2UgcHJvdmlkZXIuCi0gICAgYXV0 byBidXMgPSBBdWRpb0J1czo6Y3JlYXRlKDEsIG51bWJlck9mU291cmNlRnJhbWVzLCBmYWxzZSk7 CisgICAgaWYgKCFtX2ludGVybmFsQnVzIHx8IG1faW50ZXJuYWxCdXMtPmxlbmd0aCgpICE9IG51 bWJlck9mU291cmNlRnJhbWVzKQorICAgICAgICBtX2ludGVybmFsQnVzID0gQXVkaW9CdXM6OmNy ZWF0ZSgxLCBudW1iZXJPZlNvdXJjZUZyYW1lcywgZmFsc2UpOwogCiAgICAgLy8gRklYTUU6IEZp bmQgYSB3YXkgdG8gbWFrZSB0aGUgZm9sbG93aW5nIGNvbnN0LWNvcnJlY3Q6Ci0gICAgYnVzLT5z ZXRDaGFubmVsTWVtb3J5KDAsIGJ1ZmZlciwgbnVtYmVyT2ZTb3VyY2VGcmFtZXMpOworICAgIG1f aW50ZXJuYWxCdXMtPnNldENoYW5uZWxNZW1vcnkoMCwgYnVmZmVyLCBudW1iZXJPZlNvdXJjZUZy YW1lcyk7CiAgICAgCi0gICAgbV9zb3VyY2VQcm92aWRlci0+cHJvdmlkZUlucHV0KGJ1cy5nZXQo KSwgbnVtYmVyT2ZTb3VyY2VGcmFtZXMpOworICAgIG1fc291cmNlUHJvdmlkZXItPnByb3ZpZGVJ bnB1dChtX2ludGVybmFsQnVzLmdldCgpLCBudW1iZXJPZlNvdXJjZUZyYW1lcyk7CiB9CiAKIG5h bWVzcGFjZSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9TaW5j UmVzYW1wbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9TaW5jUmVzYW1wbGVy LmgKaW5kZXggYzEzMmY1ZDk3NjJjNzU2NmIyMzI1YzA2NGIyOGRlOGI2ZTM5MDFmYy4uNjM1M2Vi YjdjZDExZTFmN2JkYWI5YThiZWZkMzQ2ODAyZGQzZjI0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vU2luY1Jlc2FtcGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2F1ZGlvL1NpbmNSZXNhbXBsZXIuaApAQCAtODAsNiArODAsOCBAQCBwcm90ZWN0 ZWQ6CiAKICAgICAvLyBUaGUgYnVmZmVyIGlzIHByaW1lZCBvbmNlIGF0IHRoZSB2ZXJ5IGJlZ2lu bmluZyBvZiBwcm9jZXNzaW5nLgogICAgIGJvb2wgbV9pc0J1ZmZlclByaW1lZDsKKworICAgIFJl ZlB0cjxBdWRpb0J1cz4gbV9pbnRlcm5hbEJ1czsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNv cmUK 381185 2019-10-17 02:36:14 -0700 2019-10-17 11:19:15 -0700 Patch bug-202983-20191017113612.patch text/plain 2671 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDAyZGUxYjdhZjdjZmY0 MGQwZDMwNzJlNmZkZTZjZjhmZWZiOTY0NC4uYjc5MzdmZTFjOTFkNTBmYzY5ZDcxNzJiNDM1ODA2 Mzc1NDNiYTg0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTEwLTE3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBTaW5jUmVzYW1wbGVyIGRv ZXMgbm90IG5lZWQgdG8gY3JlYXRlIGEgbmV3IEF1ZGlvQnVzIGZvciBlYWNoIGNvbnN1bWVTb3Vy Y2UgY2FsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAyOTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb2NhdGUgYW4gaW50ZXJuYWwgQXVkaW9CdXMgb25jZSBhbmQgZm9yIGFsbC4KKyAgICAgICAg Tm8gb2JzZXJ2YWJsZSBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9h dWRpby9TaW5jUmVzYW1wbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNpbmNSZXNhbXBsZXI6 OmNvbnN1bWVTb3VyY2UpOgorICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL1NpbmNSZXNhbXBsZXIu aDoKKwogMjAxOS0xMC0xNyAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAg ICAgICAgU2hhcmUgY29kZSBiZXR3ZWVuIEF1ZGlvRGVzdGluYXRpb25JT1MgYW5kIEF1ZGlvRGVz dGluYXRpb25NYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1Np bmNSZXNhbXBsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vU2luY1Jlc2Ft cGxlci5jcHAKaW5kZXggNWQwOGRlNWNhZGFmYjEwNDY3M2Y0NGQzOGYzNDRlMTk3ZDFlMWY5ZS4u NTIwNTI3YjU0YmE1Nzg2ZDhjZWJkZmFiNTNhNDU2OGE5M2RlNmVkOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vU2luY1Jlc2FtcGxlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vU2luY1Jlc2FtcGxlci5jcHAKQEAgLTEzMCwxNCArMTMw LDE1IEBAIHZvaWQgU2luY1Jlc2FtcGxlcjo6Y29uc3VtZVNvdXJjZShmbG9hdCogYnVmZmVyLCB1 bnNpZ25lZCBudW1iZXJPZlNvdXJjZUZyYW1lcykKICAgICBBU1NFUlQobV9zb3VyY2VQcm92aWRl cik7CiAgICAgaWYgKCFtX3NvdXJjZVByb3ZpZGVyKQogICAgICAgICByZXR1cm47Ci0gICAgCisK ICAgICAvLyBXcmFwIHRoZSBwcm92aWRlZCBidWZmZXIgYnkgYW4gQXVkaW9CdXMgZm9yIHVzZSBi eSB0aGUgc291cmNlIHByb3ZpZGVyLgotICAgIGF1dG8gYnVzID0gQXVkaW9CdXM6OmNyZWF0ZSgx LCBudW1iZXJPZlNvdXJjZUZyYW1lcywgZmFsc2UpOworICAgIGlmICghbV9pbnRlcm5hbEJ1cyB8 fCBtX2ludGVybmFsQnVzLT5sZW5ndGgoKSAhPSBudW1iZXJPZlNvdXJjZUZyYW1lcykKKyAgICAg ICAgbV9pbnRlcm5hbEJ1cyA9IEF1ZGlvQnVzOjpjcmVhdGUoMSwgbnVtYmVyT2ZTb3VyY2VGcmFt ZXMsIGZhbHNlKTsKIAogICAgIC8vIEZJWE1FOiBGaW5kIGEgd2F5IHRvIG1ha2UgdGhlIGZvbGxv d2luZyBjb25zdC1jb3JyZWN0OgotICAgIGJ1cy0+c2V0Q2hhbm5lbE1lbW9yeSgwLCBidWZmZXIs IG51bWJlck9mU291cmNlRnJhbWVzKTsKKyAgICBtX2ludGVybmFsQnVzLT5zZXRDaGFubmVsTWVt b3J5KDAsIGJ1ZmZlciwgbnVtYmVyT2ZTb3VyY2VGcmFtZXMpOwogICAgIAotICAgIG1fc291cmNl UHJvdmlkZXItPnByb3ZpZGVJbnB1dChidXMuZ2V0KCksIG51bWJlck9mU291cmNlRnJhbWVzKTsK KyAgICBtX3NvdXJjZVByb3ZpZGVyLT5wcm92aWRlSW5wdXQobV9pbnRlcm5hbEJ1cy5nZXQoKSwg bnVtYmVyT2ZTb3VyY2VGcmFtZXMpOwogfQogCiBuYW1lc3BhY2UgewpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vU2luY1Jlc2FtcGxlci5oIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYXVkaW8vU2luY1Jlc2FtcGxlci5oCmluZGV4IGMxMzJmNWQ5NzYyYzc1NjZi MjMyNWMwNjRiMjhkZThiNmUzOTAxZmMuLmIxNmViNTEzMjU4OGRiNWYxYTkxODU1NjBjZGU5N2Q4 MWRjNGRhMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1NpbmNS ZXNhbXBsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9TaW5jUmVzYW1w bGVyLmgKQEAgLTMxLDYgKzMxLDcgQEAKIAogI2luY2x1ZGUgIkF1ZGlvQXJyYXkuaCIKICNpbmNs dWRlICJBdWRpb1NvdXJjZVByb3ZpZGVyLmgiCisjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTgwLDYgKzgxLDggQEAgcHJvdGVjdGVkOgogCiAgICAg Ly8gVGhlIGJ1ZmZlciBpcyBwcmltZWQgb25jZSBhdCB0aGUgdmVyeSBiZWdpbm5pbmcgb2YgcHJv Y2Vzc2luZy4KICAgICBib29sIG1faXNCdWZmZXJQcmltZWQ7CisKKyAgICBSZWZQdHI8QXVkaW9C dXM+IG1faW50ZXJuYWxCdXM7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==