202982 2019-10-15 02:08:12 -0700 MultiChannelResampler does not need to recreate a ChannelProvider for every process call 2019-10-17 03:30:14 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1580040 0 youennf 2019-10-15 02:08:12 -0700 MultiChannelResampler does not need to recreate a ChannelProvider for every process call 1580041 1 380973 youennf 2019-10-15 02:10:56 -0700 Created attachment 380973 Patch 1580064 2 380973 eric.carlson 2019-10-15 05:42:06 -0700 Comment on attachment 380973 Patch r=me 1580924 3 380973 commit-queue 2019-10-17 03:29:59 -0700 Comment on attachment 380973 Patch Clearing flags on attachment: 380973 Committed r251230: <https://trac.webkit.org/changeset/251230> 1580925 4 commit-queue 2019-10-17 03:30:01 -0700 All reviewed patches have been landed. Closing bug. 1580926 5 webkit-bug-importer 2019-10-17 03:30:14 -0700 <rdar://problem/56364814> 380973 2019-10-15 02:10:56 -0700 2019-10-17 03:29:59 -0700 Patch bug-202982-20191015111054.patch text/plain 6209 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQyYzY4NDdhNDI0Yzlh Y2NlN2IwMGViNTVhOTNkYzU4ZDhjNGU0ZS4uM2M5MGYxMjhhN2E4ZTM3OWM4ZjllZjRmMmI3NjI1 YjVjNzY2YmI4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTEwLTE1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNdWx0aUNoYW5uZWxSZXNh bXBsZXIgZG9lcyBub3QgbmVlZCB0byByZWNyZWF0ZSBhIENoYW5uZWxQcm92aWRlciBmb3IgZXZl cnkgcHJvY2VzcyBjYWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDI5ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXZSBubyBsb25nZXIgYWxsb2NhdGUgYSBuZXcgQ2hhbm5lbFByb3ZpZGVyIGZvciBl dmVyeSBwcm9jZXNzIGNhbGwuCisgICAgICAgIE5vIG9ic2VydmFibGUgY2hhbmdlIG9mIGJlaGF2 aW9yLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vTXVsdGlDaGFubmVsUmVzYW1wbGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok11bHRpQ2hhbm5lbFJlc2FtcGxlcjo6Q2hhbm5lbFByb3Zp ZGVyOjpDaGFubmVsUHJvdmlkZXIpOgorICAgICAgICAoV2ViQ29yZTo6TXVsdGlDaGFubmVsUmVz YW1wbGVyOjpDaGFubmVsUHJvdmlkZXI6OnNldFByb3ZpZGVyKToKKyAgICAgICAgKFdlYkNvcmU6 Ok11bHRpQ2hhbm5lbFJlc2FtcGxlcjo6TXVsdGlDaGFubmVsUmVzYW1wbGVyKToKKyAgICAgICAg KFdlYkNvcmU6Ok11bHRpQ2hhbm5lbFJlc2FtcGxlcjo6cHJvY2Vzcyk6CisgICAgICAgICogcGxh dGZvcm0vYXVkaW8vTXVsdGlDaGFubmVsUmVzYW1wbGVyLmg6CisKIDIwMTktMTAtMTQgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkF1ZGlvU291cmNlUHJv dmlkZXJBVkZPYmpDOjpwcm92aWRlSW5wdXQgc2hvdWxkIHNldCBpdHMgV2ViQXVkaW9CdWZmZXJM aXN0IHBhcmFtZXRlcnMgY29ycmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9NdWx0aUNoYW5uZWxSZXNhbXBsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vTXVsdGlDaGFubmVsUmVzYW1wbGVyLmNwcAppbmRleCA1YmY5YWI5NWQwMTU3 NTAwODE1ZDYxMzFhYjFkODk3NDFiZTFmZTI5Li41ZTYyNjhkM2JiMTNiNWYyNzFkMmU2YTg5NjAy ODBlNzUzYjlkYTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9N dWx0aUNoYW5uZWxSZXNhbXBsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1 ZGlvL011bHRpQ2hhbm5lbFJlc2FtcGxlci5jcHAKQEAgLTM2LDE5ICszNiwyMSBAQAogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKLW5hbWVzcGFjZSB7Ci0KIC8vIENoYW5uZWxQcm92aWRlciBwcm92 aWRlcyBhIHNpbmdsZSBjaGFubmVsIG9mIGF1ZGlvIGRhdGEgKG9uZSBjaGFubmVsIGF0IGEgdGlt ZSkgZm9yIGVhY2ggY2hhbm5lbAogLy8gb2YgZGF0YSBwcm92aWRlZCB0byB1cyBpbiBhIG11bHRp LWNoYW5uZWwgcHJvdmlkZXIuCi0KLWNsYXNzIENoYW5uZWxQcm92aWRlciA6IHB1YmxpYyBBdWRp b1NvdXJjZVByb3ZpZGVyIHsKK2NsYXNzIE11bHRpQ2hhbm5lbFJlc2FtcGxlcjo6Q2hhbm5lbFBy b3ZpZGVyIDogcHVibGljIEF1ZGlvU291cmNlUHJvdmlkZXIgeworICAgIFdURl9NQUtFX0ZBU1Rf QUxMT0NBVEVEOwogcHVibGljOgotICAgIENoYW5uZWxQcm92aWRlcihBdWRpb1NvdXJjZVByb3Zp ZGVyKiBtdWx0aUNoYW5uZWxQcm92aWRlciwgdW5zaWduZWQgbnVtYmVyT2ZDaGFubmVscykKLSAg ICAgICAgOiBtX211bHRpQ2hhbm5lbFByb3ZpZGVyKG11bHRpQ2hhbm5lbFByb3ZpZGVyKQotICAg ICAgICAsIG1fbnVtYmVyT2ZDaGFubmVscyhudW1iZXJPZkNoYW5uZWxzKQotICAgICAgICAsIG1f Y3VycmVudENoYW5uZWwoMCkKLSAgICAgICAgLCBtX2ZyYW1lc1RvUHJvY2VzcygwKQorICAgIGV4 cGxpY2l0IENoYW5uZWxQcm92aWRlcih1bnNpZ25lZCBudW1iZXJPZkNoYW5uZWxzKQorICAgICAg ICA6IG1fbnVtYmVyT2ZDaGFubmVscyhudW1iZXJPZkNoYW5uZWxzKQorICAgIHsKKyAgICB9CisK KyAgICB2b2lkIHNldFByb3ZpZGVyKEF1ZGlvU291cmNlUHJvdmlkZXIqIG11bHRpQ2hhbm5lbFBy b3ZpZGVyKQogICAgIHsKKyAgICAgICAgbV9jdXJyZW50Q2hhbm5lbCA9IDA7CisgICAgICAgIG1f ZnJhbWVzVG9Qcm9jZXNzID0gMDsKKyAgICAgICAgbV9tdWx0aUNoYW5uZWxQcm92aWRlciA9IG11 bHRpQ2hhbm5lbFByb3ZpZGVyOwogICAgIH0KIAogICAgIC8vIHByb3ZpZGVJbnB1dCgpIHdpbGwg YmUgY2FsbGVkIG9uY2UgZm9yIGVhY2ggY2hhbm5lbCwgc3RhcnRpbmcgd2l0aCB0aGUgZmlyc3Qg Y2hhbm5lbC4KQEAgLTgzLDIzICs4NSwyNCBAQCBwdWJsaWM6CiAgICAgfQogCiBwcml2YXRlOgot ICAgIEF1ZGlvU291cmNlUHJvdmlkZXIqIG1fbXVsdGlDaGFubmVsUHJvdmlkZXI7CisgICAgQXVk aW9Tb3VyY2VQcm92aWRlciogbV9tdWx0aUNoYW5uZWxQcm92aWRlciB7IG51bGxwdHIgfTsKICAg ICBSZWZQdHI8QXVkaW9CdXM+IG1fbXVsdGlDaGFubmVsQnVzOwotICAgIHVuc2lnbmVkIG1fbnVt YmVyT2ZDaGFubmVsczsKLSAgICB1bnNpZ25lZCBtX2N1cnJlbnRDaGFubmVsOwotICAgIHNpemVf dCBtX2ZyYW1lc1RvUHJvY2VzczsgLy8gVXNlZCB0byB2ZXJpZnkgdGhhdCBhbGwgY2hhbm5lbHMg YXNrIGZvciB0aGUgc2FtZSBhbW91bnQuCisgICAgdW5zaWduZWQgbV9udW1iZXJPZkNoYW5uZWxz IHsgMCB9OworICAgIHVuc2lnbmVkIG1fY3VycmVudENoYW5uZWwgeyAwIH07CisgICAgc2l6ZV90 IG1fZnJhbWVzVG9Qcm9jZXNzIHsgMCB9OyAvLyBVc2VkIHRvIHZlcmlmeSB0aGF0IGFsbCBjaGFu bmVscyBhc2sgZm9yIHRoZSBzYW1lIGFtb3VudC4KIH07CiAKLX0gLy8gbmFtZXNwYWNlCi0KIE11 bHRpQ2hhbm5lbFJlc2FtcGxlcjo6TXVsdGlDaGFubmVsUmVzYW1wbGVyKGRvdWJsZSBzY2FsZUZh Y3RvciwgdW5zaWduZWQgbnVtYmVyT2ZDaGFubmVscykKICAgICA6IG1fbnVtYmVyT2ZDaGFubmVs cyhudW1iZXJPZkNoYW5uZWxzKQorICAgICwgbV9jaGFubmVsUHJvdmlkZXIobWFrZVVuaXF1ZTxD aGFubmVsUHJvdmlkZXI+KG1fbnVtYmVyT2ZDaGFubmVscykpCiB7CiAgICAgLy8gQ3JlYXRlIGVh Y2ggY2hhbm5lbCdzIHJlc2FtcGxlci4KICAgICBmb3IgKHVuc2lnbmVkIGNoYW5uZWxJbmRleCA9 IDA7IGNoYW5uZWxJbmRleCA8IG51bWJlck9mQ2hhbm5lbHM7ICsrY2hhbm5lbEluZGV4KQogICAg ICAgICBtX2tlcm5lbHMuYXBwZW5kKG1ha2VVbmlxdWU8U2luY1Jlc2FtcGxlcj4oc2NhbGVGYWN0 b3IpKTsKIH0KIAorTXVsdGlDaGFubmVsUmVzYW1wbGVyOjp+TXVsdGlDaGFubmVsUmVzYW1wbGVy KCkgPSBkZWZhdWx0OworCiB2b2lkIE11bHRpQ2hhbm5lbFJlc2FtcGxlcjo6cHJvY2VzcyhBdWRp b1NvdXJjZVByb3ZpZGVyKiBwcm92aWRlciwgQXVkaW9CdXMqIGRlc3RpbmF0aW9uLCBzaXplX3Qg ZnJhbWVzVG9Qcm9jZXNzKQogewogICAgIEFTU0VSVChtX251bWJlck9mQ2hhbm5lbHMgPT0gZGVz dGluYXRpb24tPm51bWJlck9mQ2hhbm5lbHMoKSk7CkBAIC0xMDcsMTcgKzExMCwxOSBAQCB2b2lk IE11bHRpQ2hhbm5lbFJlc2FtcGxlcjo6cHJvY2VzcyhBdWRpb1NvdXJjZVByb3ZpZGVyKiBwcm92 aWRlciwgQXVkaW9CdXMqIGRlcwogICAgIC8vIFRoZSBwcm92aWRlciBjYW4gcHJvdmlkZSB1cyB3 aXRoIG11bHRpLWNoYW5uZWwgYXVkaW8gZGF0YS4gQnV0IGVhY2ggb2Ygb3VyIHNpbmdsZS1jaGFu bmVsIHJlc2FtcGxlcnMgKGtlcm5lbHMpCiAgICAgLy8gYmVsb3cgcmVxdWlyZXMgYSBwcm92aWRl ciB3aGljaCBwcm92aWRlcyBhIHNpbmdsZSB1bmlxdWUgY2hhbm5lbCBvZiBkYXRhLgogICAgIC8v IGNoYW5uZWxQcm92aWRlciB3cmFwcyB0aGUgb3JpZ2luYWwgbXVsdGktY2hhbm5lbCBwcm92aWRl ciBhbmQgZGlzaGVzIG91dCBvbmUgY2hhbm5lbCBhdCBhIHRpbWUuCi0gICAgQ2hhbm5lbFByb3Zp ZGVyIGNoYW5uZWxQcm92aWRlcihwcm92aWRlciwgbV9udW1iZXJPZkNoYW5uZWxzKTsKKyAgICBt X2NoYW5uZWxQcm92aWRlci0+c2V0UHJvdmlkZXIocHJvdmlkZXIpOwogCiAgICAgZm9yICh1bnNp Z25lZCBjaGFubmVsSW5kZXggPSAwOyBjaGFubmVsSW5kZXggPCBtX251bWJlck9mQ2hhbm5lbHM7 ICsrY2hhbm5lbEluZGV4KSB7CiAgICAgICAgIC8vIERlcGVuZGluZyBvbiB0aGUgc2FtcGxlLXJh dGUgc2NhbGUgZmFjdG9yLCBhbmQgdGhlIGludGVybmFsIGJ1ZmZlcmluZyB1c2VkIGluIGEgU2lu Y1Jlc2FtcGxlcgogICAgICAgICAvLyBrZXJuZWwsIHRoaXMgY2FsbCB0byBwcm9jZXNzKCkgd2ls bCBvbmx5IHNvbWV0aW1lcyBjYWxsIHByb3ZpZGVJbnB1dCgpIG9uIHRoZSBjaGFubmVsUHJvdmlk ZXIuCiAgICAgICAgIC8vIEhvd2V2ZXIsIGlmIGl0IGNhbGxzIHByb3ZpZGVJbnB1dCgpIGZvciB0 aGUgZmlyc3QgY2hhbm5lbCwgdGhlbiBpdCB3aWxsIGNhbGwgaXQgZm9yIHRoZSByZW1haW5pbmcK ICAgICAgICAgLy8gY2hhbm5lbHMsIHNpbmNlIHRoZXkgYWxsIGJ1ZmZlciBpbiB0aGUgc2FtZSB3 YXkgYW5kIGFyZSBwcm9jZXNzaW5nIHRoZSBzYW1lIG51bWJlciBvZiBmcmFtZXMuCi0gICAgICAg IG1fa2VybmVsc1tjaGFubmVsSW5kZXhdLT5wcm9jZXNzKCZjaGFubmVsUHJvdmlkZXIsCisgICAg ICAgIG1fa2VybmVsc1tjaGFubmVsSW5kZXhdLT5wcm9jZXNzKG1fY2hhbm5lbFByb3ZpZGVyLmdl dCgpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZXN0aW5hdGlv bi0+Y2hhbm5lbChjaGFubmVsSW5kZXgpLT5tdXRhYmxlRGF0YSgpLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBmcmFtZXNUb1Byb2Nlc3MpOwogICAgIH0KKworICAg IG1fY2hhbm5lbFByb3ZpZGVyLT5zZXRQcm92aWRlcihudWxscHRyKTsKIH0KIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v TXVsdGlDaGFubmVsUmVzYW1wbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9N dWx0aUNoYW5uZWxSZXNhbXBsZXIuaAppbmRleCA2MTQ2ZTkyNWMwNmEyZGRhNzZjYjQxMmYwY2Mx ZTBhMjQ2YWM4MGQwLi5hYzgxYmVjNGJlMGI0MGQyODQxNzY5YWU4YWNhMDcxODY4YmFiMGNmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NdWx0aUNoYW5uZWxSZXNh bXBsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NdWx0aUNoYW5uZWxS ZXNhbXBsZXIuaApAQCAtMzYsMTIgKzM2LDEzIEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNs YXNzIEF1ZGlvQnVzOwotICAgIAorCiBjbGFzcyBNdWx0aUNoYW5uZWxSZXNhbXBsZXIgZmluYWwg ewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOiAgIAogICAgIGV4cGxpY2l0 IE11bHRpQ2hhbm5lbFJlc2FtcGxlcihkb3VibGUgc2NhbGVGYWN0b3IsIHVuc2lnbmVkIG51bWJl ck9mQ2hhbm5lbHMpOwotICAgIAorICAgIH5NdWx0aUNoYW5uZWxSZXNhbXBsZXIoKTsKKwogICAg IC8vIFByb2Nlc3MgZ2l2ZW4gQXVkaW9Tb3VyY2VQcm92aWRlciBmb3Igc3RyZWFtaW5nIGFwcGxp Y2F0aW9ucy4KICAgICB2b2lkIHByb2Nlc3MoQXVkaW9Tb3VyY2VQcm92aWRlciosIEF1ZGlvQnVz KiBkZXN0aW5hdGlvbiwgc2l6ZV90IGZyYW1lc1RvUHJvY2Vzcyk7CiAKQEAgLTU0LDYgKzU1LDkg QEAgcHJpdmF0ZToKICAgICBWZWN0b3I8c3RkOjp1bmlxdWVfcHRyPFNpbmNSZXNhbXBsZXI+PiBt X2tlcm5lbHM7CiAgICAgCiAgICAgdW5zaWduZWQgbV9udW1iZXJPZkNoYW5uZWxzOworCisgICAg Y2xhc3MgQ2hhbm5lbFByb3ZpZGVyOworICAgIHN0ZDo6dW5pcXVlX3B0cjxDaGFubmVsUHJvdmlk ZXI+IG1fY2hhbm5lbFByb3ZpZGVyOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=