202973 2019-10-14 22:32:39 -0700 Add dumping for Animation and AnimationList 2019-10-15 15:31:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue dino lingcherd_ho simon.fraser webkit-bug-importer oldest_to_newest 1579996 0 simon.fraser 2019-10-14 22:32:39 -0700 Add dumping for Animation and AnimationList 1579997 1 380964 simon.fraser 2019-10-14 22:33:09 -0700 Created attachment 380964 Patch 1580229 2 380964 dino 2019-10-15 13:37:21 -0700 Comment on attachment 380964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380964&action=review > Source/WebCore/platform/animation/AnimationList.cpp:71 > + for (size_t i = 0; i < animationList.size(); ++i) { Maybe we should put iterators on AnimationList? 1580253 3 380964 commit-queue 2019-10-15 14:18:44 -0700 Comment on attachment 380964 Patch Clearing flags on attachment: 380964 Committed r251158: <https://trac.webkit.org/changeset/251158> 1580254 4 commit-queue 2019-10-15 14:18:45 -0700 All reviewed patches have been landed. Closing bug. 1580333 5 lingcherd_ho 2019-10-15 15:31:17 -0700 <rdar://problem/56307776> 380964 2019-10-14 22:33:09 -0700 2019-10-15 14:18:44 -0700 Patch bug-202973-20191014223309.patch text/plain 5257 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzgxZGFmMjlmNjFmNTU3 NmIwNmUzMWZmMGNkOTNiZTAwZDlmMzk2My4uNTMxMTcxNTY2MjVlM2ZmNTI3ZjE5ZDA5NWNjMTgz M2U5MWZjMWQ2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTEwLTE0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBkdW1waW5n IGZvciBBbmltYXRpb24gYW5kIEFuaW1hdGlvbkxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjk3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgQW5pbWF0aW9uLCBBbmltYXRpb25MaXN0IGFu ZCByZWxhdGVkIGVudW1zIGR1bXBhYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vYW5pbWF0aW9u L0FuaW1hdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpvcGVyYXRvcjw8KToKKyAgICAgICAg KiBwbGF0Zm9ybS9hbmltYXRpb24vQW5pbWF0aW9uLmg6CisgICAgICAgICogcGxhdGZvcm0vYW5p bWF0aW9uL0FuaW1hdGlvbkxpc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6b3BlcmF0b3I8PCk6 CisgICAgICAgICogcGxhdGZvcm0vYW5pbWF0aW9uL0FuaW1hdGlvbkxpc3QuaDoKKwogMjAxOS0x MC0xNCAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAg ICAgIE91dHNldHMgZm9yIHJlZmVyZW5jZWQgU1ZHIGZpbHRlcnMgYXJlIGFsd2F5cyB6ZXJvCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hbmltYXRpb24vQW5pbWF0aW9uLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2FuaW1hdGlvbi9BbmltYXRpb24uY3BwCmluZGV4 IDFmOGNhZDBlZmFiMTg5OTUzNDMxMWJhM2M0ZmQ4NTQ2ZTMwMDcxM2MuLjFmMTYxZjZiYTlkMTMw Yjc3ZjFmYTVjZmE3NjNiN2ZiMmI3ODVmZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2FuaW1hdGlvbi9BbmltYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2FuaW1hdGlvbi9BbmltYXRpb24uY3BwCkBAIC0yMyw2ICsyMyw3IEBACiAjaW5jbHVkZSAi QW5pbWF0aW9uLmgiCiAKICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KKyNpbmNsdWRl IDx3dGYvdGV4dC9UZXh0U3RyZWFtLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtMTM4 LDQgKzEzOSw0MyBAQCBjb25zdCBTdHJpbmcmIEFuaW1hdGlvbjo6aW5pdGlhbE5hbWUoKQogICAg IHJldHVybiBpbml0aWFsVmFsdWU7CiB9CiAKK1RleHRTdHJlYW0mIG9wZXJhdG9yPDwoVGV4dFN0 cmVhbSYgdHMsIEFuaW1hdGlvbjo6QW5pbWF0aW9uTW9kZSBtb2RlKQoreworICAgIHN3aXRjaCAo bW9kZSkgeworICAgIGNhc2UgQW5pbWF0aW9uOjpBbmltYXRlQWxsOiB0cyA8PCAiYWxsIjsgYnJl YWs7CisgICAgY2FzZSBBbmltYXRpb246OkFuaW1hdGVOb25lOiB0cyA8PCAibm9uZSI7IGJyZWFr OworICAgIGNhc2UgQW5pbWF0aW9uOjpBbmltYXRlU2luZ2xlUHJvcGVydHk6IHRzIDw8ICJzaW5n bGUgcHJvcGVydHkiOyBicmVhazsKKyAgICBjYXNlIEFuaW1hdGlvbjo6QW5pbWF0ZVVua25vd25Q cm9wZXJ0eTogdHMgPDwgInVua25vd24gcHJvcGVydHkiOyBicmVhazsKKyAgICB9CisgICAgcmV0 dXJuIHRzOworfQorCitUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFRleHRTdHJlYW0mIHRzLCBBbmlt YXRpb246OkFuaW1hdGlvbkRpcmVjdGlvbiBkaXJlY3Rpb24pCit7CisgICAgc3dpdGNoIChkaXJl Y3Rpb24pIHsKKyAgICBjYXNlIEFuaW1hdGlvbjo6QW5pbWF0aW9uRGlyZWN0aW9uTm9ybWFsOiB0 cyA8PCAibm9ybWFsIjsgYnJlYWs7CisgICAgY2FzZSBBbmltYXRpb246OkFuaW1hdGlvbkRpcmVj dGlvbkFsdGVybmF0ZTogdHMgPDwgImFsdGVybmF0ZSI7IGJyZWFrOworICAgIGNhc2UgQW5pbWF0 aW9uOjpBbmltYXRpb25EaXJlY3Rpb25SZXZlcnNlOiB0cyA8PCAicmV2ZXJzZSI7IGJyZWFrOwor ICAgIGNhc2UgQW5pbWF0aW9uOjpBbmltYXRpb25EaXJlY3Rpb25BbHRlcm5hdGVSZXZlcnNlOiB0 cyA8PCAiYWx0ZXJuYXRlLXJldmVyc2UiOyBicmVhazsKKyAgICB9CisgICAgcmV0dXJuIHRzOwor fQorCitUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFRleHRTdHJlYW0mIHRzLCBjb25zdCBBbmltYXRp b24mIGFuaW1hdGlvbikKK3sKKyAgICB0cy5kdW1wUHJvcGVydHkoInByb3BlcnR5IiwgZ2V0UHJv cGVydHlOYW1lKGFuaW1hdGlvbi5wcm9wZXJ0eSgpKSk7CisgICAgdHMuZHVtcFByb3BlcnR5KCJu YW1lIiwgYW5pbWF0aW9uLm5hbWUoKSk7CisgICAgdHMuZHVtcFByb3BlcnR5KCJpdGVyYXRpb24g Y291bnQiLCBhbmltYXRpb24uaXRlcmF0aW9uQ291bnQoKSk7CisgICAgdHMuZHVtcFByb3BlcnR5 KCJkZWxheSIsIGFuaW1hdGlvbi5pdGVyYXRpb25Db3VudCgpKTsKKyAgICB0cy5kdW1wUHJvcGVy dHkoImR1cmF0aW9uIiwgYW5pbWF0aW9uLmR1cmF0aW9uKCkpOworICAgIGlmIChhbmltYXRpb24u dGltaW5nRnVuY3Rpb24oKSkKKyAgICAgICAgdHMuZHVtcFByb3BlcnR5KCJ0aW1pbmcgZnVuY3Rp b24iLCAqYW5pbWF0aW9uLnRpbWluZ0Z1bmN0aW9uKCkpOworICAgIHRzLmR1bXBQcm9wZXJ0eSgi bW9kZSIsIGFuaW1hdGlvbi5hbmltYXRpb25Nb2RlKCkpOworICAgIHRzLmR1bXBQcm9wZXJ0eSgi ZGlyZWN0aW9uIiwgYW5pbWF0aW9uLmRpcmVjdGlvbigpKTsKKyAgICB0cy5kdW1wUHJvcGVydHko ImZpbGwtbW9kZSIsIGFuaW1hdGlvbi5maWxsTW9kZSgpKTsKKyAgICB0cy5kdW1wUHJvcGVydHko InBsYXktc3RhdGUiLCBhbmltYXRpb24ucGxheVN0YXRlKCkpOworCisgICAgcmV0dXJuIHRzOwor fQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9hbmltYXRpb24vQW5pbWF0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h bmltYXRpb24vQW5pbWF0aW9uLmgKaW5kZXggNTZiYzg3ZDg3MmM4ZWY1MTA5NWE5OGIwMjZlODk2 N2M2NTliZGJjYS4uY2FmNjk0YzljMjBjNGM1OGZlZDE4NzNiMDIyZjgwMDU5NTNhNmRhZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYW5pbWF0aW9uL0FuaW1hdGlvbi5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2FuaW1hdGlvbi9BbmltYXRpb24uaApAQCAtMTk5 LDQgKzE5OSw5IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPFRpbWluZ0Z1bmN0aW9uPiBpbml0 aWFsVGltaW5nRnVuY3Rpb24oKSB7IHJldHVybiBDdWJpY0JlemllclRpbWluZ0Z1bmN0aW9uOjpj cmVhdGUoKTsgfQogfTsKIAorV1RGOjpUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFdURjo6VGV4dFN0 cmVhbSYsIEFuaW1hdGlvblBsYXlTdGF0ZSk7CitXVEY6OlRleHRTdHJlYW0mIG9wZXJhdG9yPDwo V1RGOjpUZXh0U3RyZWFtJiwgQW5pbWF0aW9uOjpBbmltYXRpb25Nb2RlKTsKK1dURjo6VGV4dFN0 cmVhbSYgb3BlcmF0b3I8PChXVEY6OlRleHRTdHJlYW0mLCBBbmltYXRpb246OkFuaW1hdGlvbkRp cmVjdGlvbik7CitXVEY6OlRleHRTdHJlYW0mIG9wZXJhdG9yPDwoV1RGOjpUZXh0U3RyZWFtJiwg Y29uc3QgQW5pbWF0aW9uJik7CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2FuaW1hdGlvbi9BbmltYXRpb25MaXN0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2FuaW1hdGlvbi9BbmltYXRpb25MaXN0LmNwcAppbmRleCAw YTMyMDIyNTQ1OWIxZmQwNjYyNjVlZjJjZDdhNTlkZTcyMjU3MjRhLi5hZjNiNTE5NTE2MjYwYzU3 Y2E1MjU2ZDY1OGVmOTQxZDEzMTUzMjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hbmltYXRpb24vQW5pbWF0aW9uTGlzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYW5pbWF0aW9uL0FuaW1hdGlvbkxpc3QuY3BwCkBAIC0yMiw2ICsyMiw4IEBACiAjaW5j bHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiQW5pbWF0aW9uTGlzdC5oIgogCisjaW5jbHVkZSA8 d3RmL3RleHQvVGV4dFN0cmVhbS5oPgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICNkZWZpbmUg RklMTF9VTlNFVF9QUk9QRVJUWSh0ZXN0LCBwcm9wR2V0LCBwcm9wU2V0KSBcCkBAIC02Myw0ICs2 NSwxNiBAQCBib29sIEFuaW1hdGlvbkxpc3Q6Om9wZXJhdG9yPT0oY29uc3QgQW5pbWF0aW9uTGlz dCYgb3RoZXIpIGNvbnN0CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKK1RleHRTdHJlYW0mIG9wZXJh dG9yPDwoVGV4dFN0cmVhbSYgdHMsIGNvbnN0IEFuaW1hdGlvbkxpc3QmIGFuaW1hdGlvbkxpc3Qp Cit7CisgICAgdHMgPDwgIlsiOworICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgYW5pbWF0aW9u TGlzdC5zaXplKCk7ICsraSkgeworICAgICAgICBpZiAoaSA+IDApCisgICAgICAgICAgICB0cyA8 PCAiLCAiOworICAgICAgICB0cyA8PCBhbmltYXRpb25MaXN0LmFuaW1hdGlvbihpKTsKKyAgICB9 CisgICAgdHMgPDwgIl0iOworICAgIHJldHVybiB0czsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYW5pbWF0aW9uL0FuaW1h dGlvbkxpc3QuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2FuaW1hdGlvbi9BbmltYXRpb25M aXN0LmgKaW5kZXggNjZkOTQ3N2Y3ZTg4NDljZDgzZTVkOWJkZmI3NWI3MTEzMTM0NmUyNC4uYzkz YWY4ZDEzZGIwOWQ2YjU0NTczZmRiMWJjNGU0MGIwZjZhM2ZjOCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYW5pbWF0aW9uL0FuaW1hdGlvbkxpc3QuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hbmltYXRpb24vQW5pbWF0aW9uTGlzdC5oCkBAIC02MCw1ICs2MCw2 IEBAIHByaXZhdGU6CiAgICAgVmVjdG9yPFJlZjxBbmltYXRpb24+LCAwLCBDcmFzaE9uT3ZlcmZs b3csIDA+IG1fYW5pbWF0aW9uczsKIH07ICAgIAogCitXVEY6OlRleHRTdHJlYW0mIG9wZXJhdG9y PDwoV1RGOjpUZXh0U3RyZWFtJiwgY29uc3QgQW5pbWF0aW9uTGlzdCYpOwogCiB9IC8vIG5hbWVz cGFjZSBXZWJDb3JlCg==