202969 2019-10-14 21:26:26 -0700 Add support to TextStream for dumping HashMap<> and HashSet<> 2019-10-19 11:41:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser benjamin cdumez cmarcelo commit-queue dbates dino ews-watchlist simon.fraser webkit-bug-importer oldest_to_newest 1579983 0 simon.fraser 2019-10-14 21:26:26 -0700 Add support to TextStream for dumping HashMap<> and HashSet<> 1579984 1 380960 simon.fraser 2019-10-14 21:27:45 -0700 Created attachment 380960 Patch 1580230 2 380960 dino 2019-10-15 13:42:24 -0700 Comment on attachment 380960 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380960&action=review > Source/WTF/wtf/text/TextStream.h:181 > + if (item) > + return ts << item.value(); Shouldn't this make it clear that it was an optional value? e.g. item.value() << "<Opt>" or something? > Source/WTF/wtf/text/TextStream.h:207 > + for (const auto& keyValuePair : map) { Wish there were forEach-like functions on Hash* 1581703 3 380960 commit-queue 2019-10-19 11:40:43 -0700 Comment on attachment 380960 Patch Clearing flags on attachment: 380960 Committed r251325: <https://trac.webkit.org/changeset/251325> 1581704 4 commit-queue 2019-10-19 11:40:45 -0700 All reviewed patches have been landed. Closing bug. 1581705 5 webkit-bug-importer 2019-10-19 11:41:13 -0700 <rdar://problem/56436596> 380960 2019-10-14 21:27:45 -0700 2019-10-19 11:40:43 -0700 Patch bug-202969-20191014212745.patch text/plain 3482 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVjM2NmZGZkYWQ4MWI1ZTM4ZWVmMWFi NmNlMmRkOGYxY2JiZjFkM2QuLjI4MDFkNjI5NzA2MDk3MzNkYjY3ZGViZjZlYTEzNjNiZGZlZjVh ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMTAtMTQgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHN1cHBvcnQgdG8gVGV4dFN0cmVhbSBm b3IgZHVtcGluZyBIYXNoTWFwPD4gYW5kIEhhc2hTZXQ8PgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyOTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBNYWtlIGl0IHBvc3NpYmxlIHRvIG91 dHB1dCBIYXNoTWFwPD4gYW5kIEhhc2hTZXQ8PiB0byBUZXh0U3RyZWFtLAorICAgICAgICBzbyBs b25nIGFzIGtleSBhbmQgdmFsdWUgdHlwZXMgYXJlIHN0cmVhbWFibGUuIEFsc28gaW1wbGVtZW50 IG9wZXJhdG9yPDwoY2hhcikKKyAgICAgICAgc28gdGhhdCBjaGFycyBzaG93IGFzIEFTQ0lJLCBy YXRoZXIgdGhhbiBudW1iZXJzLgorCisgICAgICAgICogd3RmL3RleHQvVGV4dFN0cmVhbS5jcHA6 CisgICAgICAgIChXVEY6OlRleHRTdHJlYW06Om9wZXJhdG9yPDwpOgorICAgICAgICAqIHd0Zi90 ZXh0L1RleHRTdHJlYW0uaDoKKyAgICAgICAgKFdURjo6b3BlcmF0b3I8PCk6CisKIDIwMTktMTAt MTQgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBz b21lIHN1cHBvcnQgZm9yIDwgaU9TIDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0 L1RleHRTdHJlYW0uY3BwIGIvU291cmNlL1dURi93dGYvdGV4dC9UZXh0U3RyZWFtLmNwcAppbmRl eCA1YWY5NDYyNTVhYTMyYTZkYjAxZjkyMjBjMDNiOTM1NTBhMmY4MjJmLi5mOWY0Y2ZlM2MwMGE2 Y2QzN2I5M2ZmODE0NzkyYjUxZDAyMjU0YThhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90 ZXh0L1RleHRTdHJlYW0uY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvVGV4dFN0cmVhbS5j cHAKQEAgLTQ2LDYgKzQ2LDEyIEBAIFRleHRTdHJlYW0mIFRleHRTdHJlYW06Om9wZXJhdG9yPDwo Ym9vbCBiKQogICAgIHJldHVybiAqdGhpcyA8PCAoYiA/ICIxIiA6ICIwIik7CiB9CiAKK1RleHRT dHJlYW0mIFRleHRTdHJlYW06Om9wZXJhdG9yPDwoY2hhciBjKQoreworICAgIG1fdGV4dC5hcHBl bmQoYyk7CisgICAgcmV0dXJuICp0aGlzOworfQorCiBUZXh0U3RyZWFtJiBUZXh0U3RyZWFtOjpv cGVyYXRvcjw8KGludCBpKQogewogICAgIG1fdGV4dC5hcHBlbmROdW1iZXIoaSk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1RleHRTdHJlYW0uaCBiL1NvdXJjZS9XVEYvd3RmL3Rl eHQvVGV4dFN0cmVhbS5oCmluZGV4IGFiYzY4MjRjZjg0NDJiMGNiNjYzYzE0ZmViMjcwMjZjZTcw ZTNlMGUuLjMxNmU1NjE2ZWVhYzdmZDM2Y2U4ZDg2NjBhMDE0NmJjNTkyZTZmYjUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvVGV4dFN0cmVhbS5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L3RleHQvVGV4dFN0cmVhbS5oCkBAIC01Nyw2ICs1Nyw3IEBAIHB1YmxpYzoKICAgICB9CiAKICAg ICBXVEZfRVhQT1JUX1BSSVZBVEUgVGV4dFN0cmVhbSYgb3BlcmF0b3I8PChib29sKTsKKyAgICBX VEZfRVhQT1JUX1BSSVZBVEUgVGV4dFN0cmVhbSYgb3BlcmF0b3I8PChjaGFyKTsKICAgICBXVEZf RVhQT1JUX1BSSVZBVEUgVGV4dFN0cmVhbSYgb3BlcmF0b3I8PChpbnQpOwogICAgIFdURl9FWFBP UlRfUFJJVkFURSBUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KHVuc2lnbmVkKTsKICAgICBXVEZfRVhQ T1JUX1BSSVZBVEUgVGV4dFN0cmVhbSYgb3BlcmF0b3I8PChsb25nKTsKQEAgLTE3Myw2ICsxNzQs MTUgQEAgaW5saW5lIFRleHRTdHJlYW0mIGluZGVudChUZXh0U3RyZWFtJiB0cykKICAgICByZXR1 cm4gdHM7CiB9CiAKK3RlbXBsYXRlPHR5cGVuYW1lIEl0ZW0+CitUZXh0U3RyZWFtJiBvcGVyYXRv cjw8KFRleHRTdHJlYW0mIHRzLCBjb25zdCBPcHRpb25hbDxJdGVtPiYgaXRlbSkKK3sKKyAgICBp ZiAoaXRlbSkKKyAgICAgICAgcmV0dXJuIHRzIDw8IGl0ZW0udmFsdWUoKTsKKyAgICAKKyAgICBy ZXR1cm4gdHMgPDwgIm51bGxvcHQiOworfQorCiB0ZW1wbGF0ZTx0eXBlbmFtZSBJdGVtPgogVGV4 dFN0cmVhbSYgb3BlcmF0b3I8PChUZXh0U3RyZWFtJiB0cywgY29uc3QgVmVjdG9yPEl0ZW0+JiB2 ZWN0b3IpCiB7CkBAIC0xODgsNiArMTk4LDM4IEBAIFRleHRTdHJlYW0mIG9wZXJhdG9yPDwoVGV4 dFN0cmVhbSYgdHMsIGNvbnN0IFZlY3RvcjxJdGVtPiYgdmVjdG9yKQogICAgIHJldHVybiB0cyA8 PCAiXSI7CiB9CiAKK3RlbXBsYXRlPHR5cGVuYW1lIEtleUFyZywgdHlwZW5hbWUgTWFwcGVkQXJn LCB0eXBlbmFtZSBIYXNoQXJnLCB0eXBlbmFtZSBLZXlUcmFpdHNBcmcsIHR5cGVuYW1lIE1hcHBl ZFRyYWl0c0FyZz4KK1RleHRTdHJlYW0mIG9wZXJhdG9yPDwoVGV4dFN0cmVhbSYgdHMsIGNvbnN0 IEhhc2hNYXA8S2V5QXJnLCBNYXBwZWRBcmcsIEhhc2hBcmcsIEtleVRyYWl0c0FyZywgTWFwcGVk VHJhaXRzQXJnPiYgbWFwKQoreworICAgIHRzIDw8ICJ7IjsKKworICAgIGJvb2wgZmlyc3QgPSB0 cnVlOworICAgIGZvciAoY29uc3QgYXV0byYga2V5VmFsdWVQYWlyIDogbWFwKSB7CisgICAgICAg IHRzIDw8IGtleVZhbHVlUGFpci5rZXkgPDwgIjogIiA8PCBrZXlWYWx1ZVBhaXIudmFsdWU7Cisg ICAgICAgIGlmICghZmlyc3QpCisgICAgICAgICAgICB0cyA8PCAiLCAiOworICAgICAgICBmaXJz dCA9IGZhbHNlOworICAgIH0KKworICAgIHJldHVybiB0cyA8PCAifSI7Cit9CisKK3RlbXBsYXRl PHR5cGVuYW1lIFZhbHVlQXJnLCB0eXBlbmFtZSBIYXNoQXJnLCB0eXBlbmFtZSBUcmFpdHNBcmc+ CitUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFRleHRTdHJlYW0mIHRzLCBjb25zdCBIYXNoU2V0PFZh bHVlQXJnLCBIYXNoQXJnLCBUcmFpdHNBcmc+JiBzZXQpCit7CisgICAgdHMgPDwgIlsiOworCisg ICAgYm9vbCBmaXJzdCA9IHRydWU7CisgICAgZm9yIChjb25zdCBhdXRvJiBpdGVtIDogc2V0KSB7 CisgICAgICAgIHRzIDw8IGl0ZW07CisgICAgICAgIGlmICghZmlyc3QpCisgICAgICAgICAgICB0 cyA8PCAiLCAiOworICAgICAgICBmaXJzdCA9IGZhbHNlOworICAgIH0KKworICAgIHJldHVybiB0 cyA8PCAiXSI7Cit9CisKIHRlbXBsYXRlPHR5cGVuYW1lIE9wdGlvbj4KIFRleHRTdHJlYW0mIG9w ZXJhdG9yPDwoVGV4dFN0cmVhbSYgdHMsIGNvbnN0IE9wdGlvblNldDxPcHRpb24+JiBvcHRpb25z KQogewo=