202967 2019-10-14 21:11:09 -0700 Don't mutate a NinePieceImage to create a mask default image 2019-10-15 15:19:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue dino esprehn+autocc ews-watchlist glenn gyuyoung.kim koivisto kondapallykalyan lingcherd_ho macpherson menard pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1579976 0 simon.fraser 2019-10-14 21:11:09 -0700 Don't mutate a NinePieceImage to create a mask default image 1579977 1 380957 simon.fraser 2019-10-14 21:12:35 -0700 Created attachment 380957 Patch 1580227 2 380957 dino 2019-10-15 13:33:08 -0700 Comment on attachment 380957 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380957&action=review > Source/WebCore/ChangeLog:10 > + argument that cna make the mask flavor of image. typo: can > Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:37 > +#include <wtf/text/TextStream.h> Why? 1580244 3 380957 commit-queue 2019-10-15 14:06:38 -0700 Comment on attachment 380957 Patch Clearing flags on attachment: 380957 Committed r251156: <https://trac.webkit.org/changeset/251156> 1580245 4 commit-queue 2019-10-15 14:06:40 -0700 All reviewed patches have been landed. Closing bug. 1580314 5 lingcherd_ho 2019-10-15 15:19:18 -0700 <rdar://problem/56307299> 380957 2019-10-14 21:12:35 -0700 2019-10-15 14:06:38 -0700 Patch bug-202967-20191014211234.patch text/plain 7058 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzgxZGFmMjlmNjFmNTU3 NmIwNmUzMWZmMGNkOTNiZTAwZDlmMzk2My4uYjU3MWRlMzMwZWRhNDU3MWZlNmVhMWZjYjZmODcw MmE4MjMwN2RhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE5LTEwLTE0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IG11dGF0 ZSBhIE5pbmVQaWVjZUltYWdlIHRvIGNyZWF0ZSBhIG1hc2sgZGVmYXVsdCBpbWFnZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyOTY3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIGV2ZXJ5IFN0eWxl UmFyZU5vbkluaGVyaXRlZERhdGEsIHRoZSBtYXNrQm94SW1hZ2UgdW5kZXJnb2VzIGNvcHktb24t d3JpdGUKKyAgICAgICAgdmlhIG1hc2tCb3hJbWFnZS5zZXRNYXNrRGVmYXVsdHMoKS4gRml4IGJ5 IGdpdmluZyBOaW5lUGllY2VJbWFnZSBhIGNvbnN0cnVjdG9yCisgICAgICAgIGFyZ3VtZW50IHRo YXQgY25hIG1ha2UgdGhlIG1hc2sgZmxhdm9yIG9mIGltYWdlLgorCisgICAgICAgICogY3NzL1N0 eWxlQnVpbGRlckNvbnZlcnRlci5oOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVCdWlsZGVyQ29u dmVydGVyOjpjb252ZXJ0Qm9yZGVyTWFzayk6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZUJ1aWxk ZXJDb252ZXJ0ZXI6OmNvbnZlcnRSZWZsZWN0aW9uKToKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5 bGUvTmluZVBpZWNlSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmluZVBpZWNlSW1hZ2U6 OmRlZmF1bHRNYXNrRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpOaW5lUGllY2VJbWFnZTo6Tmlu ZVBpZWNlSW1hZ2UpOgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9OaW5lUGllY2VJbWFnZS5o OgorICAgICAgICAoV2ViQ29yZTo6TmluZVBpZWNlSW1hZ2U6OnNldE1hc2tEZWZhdWx0cyk6IERl bGV0ZWQuCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERh dGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YTo6U3R5 bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSk6CisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1N0eWxl UmVmbGVjdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVSZWZsZWN0aW9uOjpTdHlsZVJl ZmxlY3Rpb24pOgorCiAyMDE5LTEwLTE0ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3 YUBhcHBsZS5jb20+CiAKICAgICAgICAgT3V0c2V0cyBmb3IgcmVmZXJlbmNlZCBTVkcgZmlsdGVy cyBhcmUgYWx3YXlzIHplcm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUJ1 aWxkZXJDb252ZXJ0ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUJ1aWxkZXJDb252ZXJ0 ZXIuaAppbmRleCBmZDQ0YTliZDU4Mzc1NDBhM2Q3ODMxZmQ2N2Q5YTAwY2JkOTIwOGM5Li44MmI0 NmZlMGQxMmJkMzNjODU3NDY3ZWI1M2I5ZjIyZTc3YmJjMmZjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVCdWlsZGVyQ29udmVydGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUv Y3NzL1N0eWxlQnVpbGRlckNvbnZlcnRlci5oCkBAIC00NTYsOCArNDU2LDcgQEAgaW5saW5lIE5p bmVQaWVjZUltYWdlIFN0eWxlQnVpbGRlckNvbnZlcnRlcjo6Y29udmVydEJvcmRlckltYWdlKFN0 eWxlUmVzb2x2ZXImIHMKIHRlbXBsYXRlPENTU1Byb3BlcnR5SUQgcHJvcGVydHk+CiBpbmxpbmUg TmluZVBpZWNlSW1hZ2UgU3R5bGVCdWlsZGVyQ29udmVydGVyOjpjb252ZXJ0Qm9yZGVyTWFzayhT dHlsZVJlc29sdmVyJiBzdHlsZVJlc29sdmVyLCBDU1NWYWx1ZSYgdmFsdWUpCiB7Ci0gICAgTmlu ZVBpZWNlSW1hZ2UgaW1hZ2U7Ci0gICAgaW1hZ2Uuc2V0TWFza0RlZmF1bHRzKCk7CisgICAgTmlu ZVBpZWNlSW1hZ2UgaW1hZ2UoTmluZVBpZWNlSW1hZ2U6OlR5cGU6Ok1hc2spOwogICAgIHN0eWxl UmVzb2x2ZXIuc3R5bGVNYXAoKS0+bWFwTmluZVBpZWNlSW1hZ2UocHJvcGVydHksICZ2YWx1ZSwg aW1hZ2UpOwogICAgIHJldHVybiBpbWFnZTsKIH0KQEAgLTc1Miw4ICs3NTEsNyBAQCBpbmxpbmUg UmVmUHRyPFN0eWxlUmVmbGVjdGlvbj4gU3R5bGVCdWlsZGVyQ29udmVydGVyOjpjb252ZXJ0UmVm bGVjdGlvbihTdHlsZVJlcwogICAgIHJlZmxlY3Rpb24tPnNldERpcmVjdGlvbihyZWZsZWN0VmFs dWUuZGlyZWN0aW9uKCkpOwogICAgIHJlZmxlY3Rpb24tPnNldE9mZnNldChyZWZsZWN0VmFsdWUu b2Zmc2V0KCkuY29udmVydFRvTGVuZ3RoPEZpeGVkSW50ZWdlckNvbnZlcnNpb24gfCBQZXJjZW50 Q29udmVyc2lvbiB8IENhbGN1bGF0ZWRDb252ZXJzaW9uPihzdHlsZVJlc29sdmVyLnN0YXRlKCku Y3NzVG9MZW5ndGhDb252ZXJzaW9uRGF0YSgpKSk7CiAKLSAgICBOaW5lUGllY2VJbWFnZSBtYXNr OwotICAgIG1hc2suc2V0TWFza0RlZmF1bHRzKCk7CisgICAgTmluZVBpZWNlSW1hZ2UgbWFzayhO aW5lUGllY2VJbWFnZTo6VHlwZTo6TWFzayk7CiAgICAgc3R5bGVSZXNvbHZlci5zdHlsZU1hcCgp LT5tYXBOaW5lUGllY2VJbWFnZShDU1NQcm9wZXJ0eVdlYmtpdEJveFJlZmxlY3QsIHJlZmxlY3RW YWx1ZS5tYXNrKCksIG1hc2spOwogICAgIHJlZmxlY3Rpb24tPnNldE1hc2sobWFzayk7CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9OaW5lUGllY2VJbWFnZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvTmluZVBpZWNlSW1hZ2UuY3BwCmlu ZGV4IGJjNTQxOTdjNjA3YzZiY2EwZDllMTAxYWU1YTIwNGYxZjg3OTU3MTQuLmFlNTQ0NDk3ZGI1 YThmNGJiZjkyNTE4ZDdjNDVjMDAyOWJlMWFhZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdHlsZS9OaW5lUGllY2VJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL05pbmVQaWVjZUltYWdlLmNwcApAQCAtNDAsOCArNDAsMTggQEAgaW5s aW5lIERhdGFSZWY8TmluZVBpZWNlSW1hZ2U6OkRhdGE+JiBOaW5lUGllY2VJbWFnZTo6ZGVmYXVs dERhdGEoKQogICAgIHJldHVybiBkYXRhLmdldCgpOwogfQogCi1OaW5lUGllY2VJbWFnZTo6Tmlu ZVBpZWNlSW1hZ2UoKQotICAgIDogbV9kYXRhKGRlZmF1bHREYXRhKCkpCitpbmxpbmUgRGF0YVJl ZjxOaW5lUGllY2VJbWFnZTo6RGF0YT4mIE5pbmVQaWVjZUltYWdlOjpkZWZhdWx0TWFza0RhdGEo KQoreworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxEYXRhUmVmPERhdGE+PiBtYXNrRGF0YSB7 IERhdGE6OmNyZWF0ZSgpIH07CisgICAgYXV0byYgZGF0YSA9IG1hc2tEYXRhLmdldCgpLmFjY2Vz cygpOworICAgIGRhdGEuaW1hZ2VTbGljZXMgPSBMZW5ndGhCb3goMCk7CisgICAgZGF0YS5maWxs ID0gdHJ1ZTsKKyAgICBkYXRhLmJvcmRlclNsaWNlcyA9IExlbmd0aEJveCgpOworICAgIHJldHVy biBtYXNrRGF0YS5nZXQoKTsKK30KKworTmluZVBpZWNlSW1hZ2U6Ok5pbmVQaWVjZUltYWdlKFR5 cGUgaW1hZ2VUeXBlKQorICAgIDogbV9kYXRhKGltYWdlVHlwZSA9PSBUeXBlOjpOb3JtYWwgPyBk ZWZhdWx0RGF0YSgpIDogZGVmYXVsdE1hc2tEYXRhKCkpCiB7CiB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9OaW5lUGllY2VJbWFnZS5oIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N0eWxlL05pbmVQaWVjZUltYWdlLmgKaW5kZXggMTMzYjlhMTkzZDdk ODM1MjJhNGYwYTczYzE5MjdiZjU0NjIwYTA1NC4uZmYyYjJmNGI4NTZmZjA0MGYxYmNjZDNkMTFm MTJlNmRjYjk5MDgwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxl L05pbmVQaWVjZUltYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL05p bmVQaWVjZUltYWdlLmgKQEAgLTEwNiw3ICsxMDYsMTIgQEAgaW5saW5lIE9wdGlvbmFsPFBoeXNp Y2FsQm94U2lkZT4gaW1hZ2VQaWVjZVZlcnRpY2FsU2lkZShJbWFnZVBpZWNlIHBpZWNlKQogCiBj bGFzcyBOaW5lUGllY2VJbWFnZSB7CiBwdWJsaWM6Ci0gICAgTmluZVBpZWNlSW1hZ2UoKTsKKyAg ICBlbnVtIGNsYXNzIFR5cGUgeworICAgICAgICBOb3JtYWwsCisgICAgICAgIE1hc2sKKyAgICB9 OworCisgICAgTmluZVBpZWNlSW1hZ2UoVHlwZSA9IFR5cGU6Ok5vcm1hbCk7CiAgICAgTmluZVBp ZWNlSW1hZ2UoUmVmUHRyPFN0eWxlSW1hZ2U+JiYsIExlbmd0aEJveCBpbWFnZVNsaWNlcywgYm9v bCBmaWxsLCBMZW5ndGhCb3ggYm9yZGVyU2xpY2VzLCBMZW5ndGhCb3ggb3V0c2V0LCBOaW5lUGll Y2VJbWFnZVJ1bGUgaG9yaXpvbnRhbFJ1bGUsIE5pbmVQaWVjZUltYWdlUnVsZSB2ZXJ0aWNhbFJ1 bGUpOwogCiAgICAgYm9vbCBvcGVyYXRvcj09KGNvbnN0IE5pbmVQaWVjZUltYWdlJiBvdGhlcikg Y29uc3QgeyByZXR1cm4gbV9kYXRhID09IG90aGVyLm1fZGF0YTsgfQpAQCAtMTU2LDEzICsxNjEs NiBAQCBwdWJsaWM6CiAgICAgICAgIG1fZGF0YS5hY2Nlc3MoKS52ZXJ0aWNhbFJ1bGUgPSBvdGhl ci5tX2RhdGEtPnZlcnRpY2FsUnVsZTsKICAgICB9CiAKLSAgICB2b2lkIHNldE1hc2tEZWZhdWx0 cygpCi0gICAgewotICAgICAgICBtX2RhdGEuYWNjZXNzKCkuaW1hZ2VTbGljZXMgPSBMZW5ndGhC b3goMCk7Ci0gICAgICAgIG1fZGF0YS5hY2Nlc3MoKS5maWxsID0gdHJ1ZTsKLSAgICAgICAgbV9k YXRhLmFjY2VzcygpLmJvcmRlclNsaWNlcyA9IExlbmd0aEJveCgpOwotICAgIH0KLQogICAgIHN0 YXRpYyBMYXlvdXRVbml0IGNvbXB1dGVPdXRzZXQoY29uc3QgTGVuZ3RoJiBvdXRzZXRTaWRlLCBM YXlvdXRVbml0IGJvcmRlclNpZGUpCiAgICAgewogICAgICAgICBpZiAob3V0c2V0U2lkZS5pc1Jl bGF0aXZlKCkpCkBAIC0yMTEsNiArMjA5LDcgQEAgcHJpdmF0ZToKICAgICB9OwogCiAgICAgc3Rh dGljIERhdGFSZWY8RGF0YT4mIGRlZmF1bHREYXRhKCk7CisgICAgc3RhdGljIERhdGFSZWY8RGF0 YT4mIGRlZmF1bHRNYXNrRGF0YSgpOwogCiAgICAgRGF0YVJlZjxEYXRhPiBtX2RhdGE7CiB9Owpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbklu aGVyaXRlZERhdGEuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFy ZU5vbkluaGVyaXRlZERhdGEuY3BwCmluZGV4IGJkZDAxOTE1YWEyNzhkZDZhNjY0OGZmNGMzZmJk YjNmY2NkMTQyYTAuLmZiMzIwODIzMzc0MjhiMTFmZDY4MTUyMDdhZmU1MTNmNDJjZjEwMWYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhl cml0ZWREYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVS YXJlTm9uSW5oZXJpdGVkRGF0YS5jcHAKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNsdWRlICJTdHls ZVNjcm9sbFNuYXBQb2ludHMuaCIKICNpbmNsdWRlIDx3dGYvUG9pbnRlckNvbXBhcmlzb24uaD4K ICNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CisjaW5jbHVkZSA8d3RmL3RleHQvVGV4dFN0cmVhbS5o PgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTYzLDYgKzY0LDcgQEAgU3R5bGVSYXJlTm9u SW5oZXJpdGVkRGF0YTo6U3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSgpCiAjZW5kaWYKICAgICAs IHdpbGxDaGFuZ2UoUmVuZGVyU3R5bGU6OmluaXRpYWxXaWxsQ2hhbmdlKCkpCiAgICAgLCBtYXNr KEZpbGxMYXllclR5cGU6Ok1hc2spCisgICAgLCBtYXNrQm94SW1hZ2UoTmluZVBpZWNlSW1hZ2U6 OlR5cGU6Ok1hc2spCiAgICAgLCBvYmplY3RQb3NpdGlvbihSZW5kZXJTdHlsZTo6aW5pdGlhbE9i amVjdFBvc2l0aW9uKCkpCiAgICAgLCBzaGFwZU91dHNpZGUoUmVuZGVyU3R5bGU6OmluaXRpYWxT aGFwZU91dHNpZGUoKSkKICAgICAsIHNoYXBlTWFyZ2luKFJlbmRlclN0eWxlOjppbml0aWFsU2hh cGVNYXJnaW4oKSkKQEAgLTExMCw3ICsxMTIsNiBAQCBTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRh OjpTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhKCkKICAgICAsIGNvbHVtbkdhcChSZW5kZXJTdHls ZTo6aW5pdGlhbENvbHVtbkdhcCgpKQogICAgICwgcm93R2FwKFJlbmRlclN0eWxlOjppbml0aWFs Um93R2FwKCkpCiB7Ci0gICAgbWFza0JveEltYWdlLnNldE1hc2tEZWZhdWx0cygpOwogfQogCiBp bmxpbmUgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YTo6U3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0 YShjb25zdCBTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhJiBvKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmVmbGVjdGlvbi5oIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmVmbGVjdGlvbi5oCmluZGV4IDFiODhjYTQyZDk3NDJm MmFjMjU4MDQ3YWMxZTVkNDliYzNjNWI0MTQuLjk2ZTNlM2JkZmE0NDc1ZGZkYzlmODNhZGFkNGQ3 NjM4Mzg4ZDI3MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9T dHlsZVJlZmxlY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5 bGVSZWZsZWN0aW9uLmgKQEAgLTU1LDggKzU1LDggQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBT dHlsZVJlZmxlY3Rpb24oKQogICAgICAgICA6IG1fb2Zmc2V0KDAsIEZpeGVkKQorICAgICAgICAs IG1fbWFzayhOaW5lUGllY2VJbWFnZTo6VHlwZTo6TWFzaykKICAgICB7Ci0gICAgICAgICBtX21h c2suc2V0TWFza0RlZmF1bHRzKCk7CiAgICAgfQogICAgIAogICAgIFJlZmxlY3Rpb25EaXJlY3Rp b24gbV9kaXJlY3Rpb24geyBSZWZsZWN0aW9uRGlyZWN0aW9uOjpCZWxvdyB9Owo=