202962 2019-10-14 16:34:16 -0700 Add some PencilKit extension points 2019-10-21 23:05:48 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aestes jlewis3 webkit-bug-importer oldest_to_newest 1579891 0 dbates 2019-10-14 16:34:16 -0700 Add some PencilKit extension points. 1579892 1 dbates 2019-10-14 16:34:31 -0700 This is the WebKit part corresponding to <rdar://problem/56261392>. 1579893 2 webkit-bug-importer 2019-10-14 16:34:51 -0700 <rdar://problem/56269759> 1579895 3 380933 dbates 2019-10-14 16:37:49 -0700 Created attachment 380933 Patch 1579911 4 380933 dbates 2019-10-14 17:09:43 -0700 Comment on attachment 380933 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380933&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:153 > +#if HAVE(PENCILKIT_ADDITIONS) Actually, maybe it would be better to check for the header itself to avoid breaking builds internally at least temporarily. Then change it back after the dust settles. 1582022 5 dbates 2019-10-21 14:06:15 -0700 (In reply to Daniel Bates from comment #4) > Comment on attachment 380933 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380933&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:153 > > +#if HAVE(PENCILKIT_ADDITIONS) > > Actually, maybe it would be better to check for the header itself to avoid > breaking builds internally at least temporarily. Then change it back after > the dust settles. No need to do this. Everything will work out™ since HAVE_PENCILKIT_ADDITIONS is a new guard. 1582024 6 380933 dbates 2019-10-21 14:07:44 -0700 Comment on attachment 380933 Patch Clearing flags on attachment: 380933 Committed r251381: <https://trac.webkit.org/changeset/251381> 1582025 7 dbates 2019-10-21 14:07:45 -0700 All reviewed patches have been landed. Closing bug. 1582244 8 jlewis3 2019-10-21 21:46:05 -0700 Reverted r251381 for reason: This broke an internal build. Committed r251415: <https://trac.webkit.org/changeset/251415> 1582258 9 dbates 2019-10-21 23:05:48 -0700 Committed r251419: <https://trac.webkit.org/changeset/251419> 380933 2019-10-14 16:37:49 -0700 2019-10-21 14:07:44 -0700 Patch bug-202962-20191014163748.patch text/plain 2307 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlhZWJkMTU4ZjdlZmVkNjAy NThjMGM2ZWQzM2FhY2Y1NDg5OTY5Y2UuLjRiNjJiZjFmZDcyYWIyNzdmZGFmZWVmZDRlZmM0YWVk NjA4NDIyMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMTAtMTQgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBzb21lIFBlbmNpbEtpdCBl eHRlbnNpb24gcG9pbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDI5NjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU2MjY5NzU5PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgdGhlIFdl YktpdCBwYXJ0IGNvcnJlc3BvbmRpbmcgdG8gPHJkYXI6Ly9wcm9ibGVtLzU2MjYxMzkyPi4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAg ICAgICAoLVtXS0NvbnRlbnRWaWV3IHNldHVwSW50ZXJhY3Rpb25dKTogQ2FsbCBleHRlbnNpb24g cG9pbnQuCisgICAgICAgICgtW1dLQ29udGVudFZpZXcgY2xlYW51cEludGVyYWN0aW9uXSk6IERp dHRvLgorCiAyMDE5LTA5LTEzICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAog ICAgICAgICBTdXBwb3J0IGJ1aWxkaW5nIFdlYktpdCBmb3IgTWFjIENhdGFseXN0IGZyb20gWGNv ZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCmluZGV4IGY0ZTRlYTk5YzI2YjQzOTA4MDZjNWFkYWU5NmZiYjYyMjE3 OGYzZGMuLmQ2ZjY4ZTE3NWE0MzFiNzM5Y2M2NTQ3ZTAxYzg3MzEyYjNhODkyNTEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQpAQCAtMTUwLDYgKzE1MCwxMCBAQAogI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zL1dL UGxhdGZvcm1GaWxlVXBsb2FkUGFuZWwubW0+CiAjZW5kaWYKIAorI2lmIEhBVkUoUEVOQ0lMS0lU X0FERElUSU9OUykKKyNpbXBvcnQgPFdlYktpdEFkZGl0aW9ucy9XZWJLaXRQZW5jaWxBZGRpdGlv bnMuaD4KKyNlbmRpZgorCiAjaWYgRU5BQkxFKFBPSU5URVJfRVZFTlRTKQogI2ltcG9ydCAiUmVt b3RlU2Nyb2xsaW5nQ29vcmRpbmF0b3JQcm94eS5oIgogI2ltcG9ydCA8V2ViQ29yZS9Ub3VjaEFj dGlvbi5oPgpAQCAtODAwLDYgKzgwNCwxMCBAQCAtICh2b2lkKXNldHVwSW50ZXJhY3Rpb24KICAg ICBbc2VsZiBzZXR1cERyYWdBbmREcm9wSW50ZXJhY3Rpb25zXTsKICNlbmRpZgogCisjaWYgSEFW RShQRU5DSUxLSVRfQURESVRJT05TKQorICAgIFtzZWxmIHNldHVwUGVuY2lsSW50ZXJhY3Rpb25d OworI2VuZGlmCisKICAgICBfdHdvRmluZ2VyU2luZ2xlVGFwR2VzdHVyZVJlY29nbml6ZXIgPSBh ZG9wdE5TKFtbVUlUYXBHZXN0dXJlUmVjb2duaXplciBhbGxvY10gaW5pdFdpdGhUYXJnZXQ6c2Vs ZiBhY3Rpb246QHNlbGVjdG9yKF90d29GaW5nZXJTaW5nbGVUYXBHZXN0dXJlUmVjb2duaXplZDop XSk7CiAgICAgW190d29GaW5nZXJTaW5nbGVUYXBHZXN0dXJlUmVjb2duaXplciBzZXRBbGxvd2Fi bGVNb3ZlbWVudDo2MF07CiAgICAgW190d29GaW5nZXJTaW5nbGVUYXBHZXN0dXJlUmVjb2duaXpl ciBfc2V0QWxsb3dhYmxlU2VwYXJhdGlvbjoxNTBdOwpAQCAtOTUyLDYgKzk2MCwxMCBAQCAtICh2 b2lkKWNsZWFudXBJbnRlcmFjdGlvbgogICAgIFtzZWxmIHRlYXJkb3duRHJhZ0FuZERyb3BJbnRl cmFjdGlvbnNdOwogI2VuZGlmCiAKKyNpZiBIQVZFKFBFTkNJTEtJVF9BRERJVElPTlMpCisgICAg W3NlbGYgY2xlYW51cFBlbmNpbEludGVyYWN0aW9uXTsKKyNlbmRpZgorCiAgICAgX2luc3BlY3Rv ck5vZGVTZWFyY2hFbmFibGVkID0gTk87CiAgICAgaWYgKF9pbnNwZWN0b3JOb2RlU2VhcmNoR2Vz dHVyZVJlY29nbml6ZXIpIHsKICAgICAgICAgW19pbnNwZWN0b3JOb2RlU2VhcmNoR2VzdHVyZVJl Y29nbml6ZXIgc2V0RGVsZWdhdGU6bmlsXTsK