202961 2019-10-14 16:30:07 -0700 REGRESSION(251087): Several API tests are failing 2019-10-15 14:18:36 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue lingcherd_ho tsavell webkit-bug-importer oldest_to_newest 1579888 0 pvollan 2019-10-14 16:30:07 -0700 r251087 introduced assert failures in debug mode: TestWebKitAPI.WebKit.GetPIDAfterAbortedProcessLaunch ASSERTION FAILED: m_connection Source/WebKit/UIProcess/AuxiliaryProcessProxy.h(69) : IPC::Connection *WebKit::AuxiliaryProcessProxy::connection() const 1 0x10eebb759 WTFCrash 2 0x11c8aaa0b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11d16c957 WebKit::AuxiliaryProcessProxy::connection() const 4 0x11d3c99d6 WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle(WebKit::WebProcessProxy&, WTF::URL const&, WTF::URL const&, WebKit::SandboxExtension::Handle&) 5 0x11d3cd8e8 WebKit::WebPageProxy::reload(WTF::OptionSet<WebCore::ReloadOption>) 6 0x11d5fbc8b WKPageReload 7 0x10d267133 TestWebKitAPI::WebKit_GetPIDAfterAbortedProcessLaunch_Test::TestBody() 1579894 1 380932 pvollan 2019-10-14 16:34:58 -0700 Created attachment 380932 Patch 1579906 2 380932 bfulgham 2019-10-14 16:44:20 -0700 Comment on attachment 380932 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380932&action=review r=me > Source/WebKit/UIProcess/WebPageProxy.cpp:1094 > + if (process.isLaunching() || process.wasTerminated()) Whoops! 1579907 3 380932 pvollan 2019-10-14 16:45:07 -0700 Comment on attachment 380932 Patch Thanks for reviewing! 1579935 4 380932 commit-queue 2019-10-14 18:04:07 -0700 Comment on attachment 380932 Patch Clearing flags on attachment: 380932 Committed r251116: <https://trac.webkit.org/changeset/251116> 1579936 5 commit-queue 2019-10-14 18:04:08 -0700 All reviewed patches have been landed. Closing bug. 1580252 6 lingcherd_ho 2019-10-15 14:18:30 -0700 <rdar://problem/56272662> 380932 2019-10-14 16:34:58 -0700 2019-10-14 18:04:07 -0700 Patch bug-202961-20191014163457.patch text/plain 1685 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTExMDgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTEwLTE0ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKDI1MTA4Nyk6 IFNldmVyYWwgQVBJIHRlc3RzIGFyZSBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWJQYWdlUHJveHk6Om1heWJlSW5pdGlhbGl6ZVNhbmRi b3hFeHRlbnNpb25IYW5kbGUgcmV0dXJucyBlYXJseSBpZiB0aGUgV2ViQ29udGVudCBwcm9jZXNz IGlzIGN1cnJlbnRseSBsYXVuY2hpbmcsCisgICAgICAgIHNpbmNlIHRoZSBhdWRpdCB0b2tlbiBp cyBuZWVkZWQgdG8gY3JlYXRlIHRoZSBzYW5kYm94IGV4dGVuc2lvbi4gVGhlIGF1ZGl0IHRva2Vu IHdpbGwgbm90IGJlIGF2YWlsYWJsZSB1bnRpbCB0aGUKKyAgICAgICAgcHJvY2VzcyBoYXMgZmlu aXNoZWQgbGF1bmNoaW5nLiBJbiB0aGUgc2FtZSB3YXksIHRoZSBtZXRob2Qgc2hvdWxkIHJldHVy biBlYXJseSBpZiB0aGUgV2ViQ29udGVudCBwcm9jZXNzIGhhcworICAgICAgICB0ZXJtaW5hdGVk LgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYlBhZ2VQcm94eTo6bWF5YmVJbml0aWFsaXplU2FuZGJveEV4dGVuc2lvbkhhbmRsZSk6 CisKIDIwMTktMTAtMTQgIERhdmlkIFF1ZXNhZGEgIDxkYXZpZF9xdWVzYWRhQGFwcGxlLmNvbT4K IAogICAgICAgICBSZW1vdmUgV2ViQ29yZTo6SU9TQXBwbGljYXRpb246OmlzV2ViQXBwKCkKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gMjUx MTAyKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTA5MSw3ICsxMDkxLDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6Om1heWJlSW5p dGlhbGl6ZVNhbmRibwogI2lmIEhBVkUoU0FOREJPWF9JU1NVRV9SRUFEX0VYVEVOU0lPTl9UT19Q Uk9DRVNTX0JZX0FVRElUX1RPS0VOKQogICAgIC8vIElmIHRoZSBwcm9jZXNzIGlzIHN0aWxsIGxh dW5jaGluZyB0aGVuIGl0IGRvZXMgbm90IGhhdmUgYSBQSUQgeWV0LiBXZSB3aWxsIHRha2UgY2Fy ZSBvZiBjcmVhdGluZyB0aGUgc2FuZGJveCBleHRlbnNpb24KICAgICAvLyBvbmNlIHRoZSBwcm9j ZXNzIGhhcyBmaW5pc2hlZCBsYXVuY2hpbmcuCi0gICAgaWYgKHByb2Nlc3MuaXNMYXVuY2hpbmco KSkKKyAgICBpZiAocHJvY2Vzcy5pc0xhdW5jaGluZygpIHx8IHByb2Nlc3Mud2FzVGVybWluYXRl ZCgpKQogICAgICAgICByZXR1cm47CiAjZW5kaWYKIAo=