202955 2019-10-14 14:41:57 -0700 results.webkit.org: Add os version to various unix ports 2019-10-15 14:33:48 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=202928 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain clopez commit-queue ews-watchlist glenn lingcherd_ho webkit-bug-importer oldest_to_newest 1579832 0 jbedard 2019-10-14 14:41:57 -0700 Without an os_version, a port cannot upload test results. 1579834 1 380922 jbedard 2019-10-14 14:46:48 -0700 Created attachment 380922 Patch 1579863 2 380927 jbedard 2019-10-14 15:45:45 -0700 Created attachment 380927 Patch 1579864 3 jbedard 2019-10-14 15:50:06 -0700 As per a discussion Carlos and I had in https://bugs.webkit.org/show_bug.cgi?id=202928, '#1 SMP Debian 4.19.37-5+deb10u2~bpo9+1 (2019-08-16)' (which is GTK's version) would have broken the original logic, so I changed it to a regex. 1580184 4 380927 aakash_jain 2019-10-15 11:16:24 -0700 Comment on attachment 380927 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380927&action=review rs=me > Tools/Scripts/webkitpy/common/system/platforminfo.py:69 > + self.os_version = Version.from_string(version.group(0)) should we log something in case version is not found? 1580190 5 jbedard 2019-10-15 11:28:19 -0700 (In reply to Aakash Jain from comment #4) > Comment on attachment 380927 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380927&action=review > > rs=me > > > Tools/Scripts/webkitpy/common/system/platforminfo.py:69 > > + self.os_version = Version.from_string(version.group(0)) > > should we log something in case version is not found? Seems pretty reasonable to do that in the debug channel. 1580197 6 381006 jbedard 2019-10-15 11:42:49 -0700 Created attachment 381006 Patch for landing 1580207 7 commit-queue 2019-10-15 12:13:00 -0700 The commit-queue encountered the following flaky tests while processing attachment 381006: imported/w3c/web-platform-tests/content-security-policy/navigate-to/href-location-blocked.sub.html bug 203000 (author: dbates@webkit.org) The commit-queue is continuing to process your patch. 1580208 8 381006 commit-queue 2019-10-15 12:13:42 -0700 Comment on attachment 381006 Patch for landing Clearing flags on attachment: 381006 Committed r251150: <https://trac.webkit.org/changeset/251150> 1580209 9 commit-queue 2019-10-15 12:13:44 -0700 All reviewed patches have been landed. Closing bug. 1580270 10 lingcherd_ho 2019-10-15 14:33:33 -0700 <rdar://problem/56302308> 1580271 11 webkit-bug-importer 2019-10-15 14:33:48 -0700 <rdar://problem/56308441> 380922 2019-10-14 14:46:48 -0700 2019-10-14 15:45:44 -0700 Patch bug-202955-20191014144647.patch text/plain 1980 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTA5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTEwLTE0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IEFkZCBvcyB2ZXJzaW9uIHRvIHZhcmlv dXMgdW5peCBwb3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAyOTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5Ogor ICAgICAgICAoUGxhdGZvcm1JbmZvLl9faW5pdF9fKTogVXNlIHBsYXRmb3JtLnJlbGVhc2UoKSB0 byBkZWZpbmVkIHRoZSBvc192ZXJzaW9uLgorCiAyMDE5LTEwLTE0ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTjogW2lPUyAx Mz9dIFRlc3RXZWJLaXRBUEkuU2hhcmVkQnVmZmVyVGVzdC50cnlDcmVhdGVBcnJheUJ1ZmZlckxh cmdlU2VnbWVudHMgaXMgZmFpbGluZwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5CShyZXZpc2lvbiAyNTEwNzEpCisr KyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC01NCw3ICs1NCw2IEBAIGNsYXNzIFBsYXRmb3JtSW5mbyhvYmplY3Qp OgogICAgICAgICBzZWxmLl9leGVjdXRpdmUgPSBleGVjdXRpdmUKICAgICAgICAgc2VsZi5fcGxh dGZvcm1fbW9kdWxlID0gcGxhdGZvcm1fbW9kdWxlCiAgICAgICAgIHNlbGYub3NfbmFtZSA9IHNl bGYuX2RldGVybWluZV9vc19uYW1lKHN5c19tb2R1bGUucGxhdGZvcm0pCi0gICAgICAgIHNlbGYu b3NfdmVyc2lvbiA9IE5vbmUKIAogICAgICAgICBzZWxmLl9pc19jeWd3aW4gPSBzeXNfbW9kdWxl LnBsYXRmb3JtID09ICdjeWd3aW4nCiAKQEAgLTYyLDExICs2MSw5IEBAIGNsYXNzIFBsYXRmb3Jt SW5mbyhvYmplY3QpOgogICAgICAgICAgICAgc2VsZi5vc192ZXJzaW9uID0gVmVyc2lvbi5mcm9t X3N0cmluZyhwbGF0Zm9ybV9tb2R1bGUubWFjX3ZlcigpWzBdKQogICAgICAgICBlbGlmIHNlbGYu b3NfbmFtZS5zdGFydHN3aXRoKCd3aW4nKToKICAgICAgICAgICAgIHNlbGYub3NfdmVyc2lvbiA9 IHNlbGYuX3dpbl92ZXJzaW9uKCkKLSAgICAgICAgZWxpZiBzZWxmLm9zX25hbWUgPT0gJ2xpbnV4 JyBvciBzZWxmLm9zX25hbWUgPT0gJ2ZyZWVic2QnIG9yIHNlbGYub3NfbmFtZSA9PSAnb3BlbmJz ZCcgb3Igc2VsZi5vc19uYW1lID09ICduZXRic2QnOgotICAgICAgICAgICAgcmV0dXJuCiAgICAg ICAgIGVsc2U6CiAgICAgICAgICAgICAjIE1vc3Qgb3RoZXIgcGxhdGZvcm1zIChuYW1lbHkgaU9T KSByZXR1cm4gY29uZm9ybWluZyB2ZXJzaW9uIHN0cmluZ3MuCi0gICAgICAgICAgICBzZWxmLm9z X3ZlcnNpb24gPSBWZXJzaW9uLmZyb21fc3RyaW5nKHBsYXRmb3JtX21vZHVsZS5yZWxlYXNlKCkp CisgICAgICAgICAgICBzZWxmLm9zX3ZlcnNpb24gPSBWZXJzaW9uLmZyb21fc3RyaW5nKHBsYXRm b3JtX21vZHVsZS5yZWxlYXNlKCkuc3BsaXQoJy0nKVswXSkKIAogICAgIGRlZiBpc19tYWMoc2Vs Zik6CiAgICAgICAgIHJldHVybiBzZWxmLm9zX25hbWUgPT0gJ21hYycK 380927 2019-10-14 15:45:45 -0700 2019-10-15 11:42:47 -0700 Patch bug-202955-20191014154544.patch text/plain 1767 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTA5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTEwLTE0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IEFkZCBvcyB2ZXJzaW9uIHRvIHZhcmlv dXMgdW5peCBwb3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAyOTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5Ogor ICAgICAgICAoUGxhdGZvcm1JbmZvLl9faW5pdF9fKTogVXNlIHBsYXRmb3JtLnJlbGVhc2UoKSB0 byBkZWZpbmVkIHRoZSBvc192ZXJzaW9uLgorCiAyMDE5LTEwLTE0ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTjogW2lPUyAx Mz9dIFRlc3RXZWJLaXRBUEkuU2hhcmVkQnVmZmVyVGVzdC50cnlDcmVhdGVBcnJheUJ1ZmZlckxh cmdlU2VnbWVudHMgaXMgZmFpbGluZwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5CShyZXZpc2lvbiAyNTEwNzEpCisr KyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC02MiwxMSArNjIsMTEgQEAgY2xhc3MgUGxhdGZvcm1JbmZvKG9iamVj dCk6CiAgICAgICAgICAgICBzZWxmLm9zX3ZlcnNpb24gPSBWZXJzaW9uLmZyb21fc3RyaW5nKHBs YXRmb3JtX21vZHVsZS5tYWNfdmVyKClbMF0pCiAgICAgICAgIGVsaWYgc2VsZi5vc19uYW1lLnN0 YXJ0c3dpdGgoJ3dpbicpOgogICAgICAgICAgICAgc2VsZi5vc192ZXJzaW9uID0gc2VsZi5fd2lu X3ZlcnNpb24oKQotICAgICAgICBlbGlmIHNlbGYub3NfbmFtZSA9PSAnbGludXgnIG9yIHNlbGYu b3NfbmFtZSA9PSAnZnJlZWJzZCcgb3Igc2VsZi5vc19uYW1lID09ICdvcGVuYnNkJyBvciBzZWxm Lm9zX25hbWUgPT0gJ25ldGJzZCc6Ci0gICAgICAgICAgICByZXR1cm4KICAgICAgICAgZWxzZToK ICAgICAgICAgICAgICMgTW9zdCBvdGhlciBwbGF0Zm9ybXMgKG5hbWVseSBpT1MpIHJldHVybiBj b25mb3JtaW5nIHZlcnNpb24gc3RyaW5ncy4KLSAgICAgICAgICAgIHNlbGYub3NfdmVyc2lvbiA9 IFZlcnNpb24uZnJvbV9zdHJpbmcocGxhdGZvcm1fbW9kdWxlLnJlbGVhc2UoKSkKKyAgICAgICAg ICAgIHZlcnNpb24gPSByZS5zZWFyY2gocidcZCsuXGQrLlxkKycsIHBsYXRmb3JtX21vZHVsZS5y ZWxlYXNlKCkpCisgICAgICAgICAgICBpZiB2ZXJzaW9uOgorICAgICAgICAgICAgICAgIHNlbGYu b3NfdmVyc2lvbiA9IFZlcnNpb24uZnJvbV9zdHJpbmcodmVyc2lvbi5ncm91cCgwKSkKIAogICAg IGRlZiBpc19tYWMoc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLm9zX25hbWUgPT0gJ21hYycK 381006 2019-10-15 11:42:49 -0700 2019-10-15 12:13:42 -0700 Patch for landing bug-202955-20191015114248.patch text/plain 2216 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTE0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTEwLTE1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IEFkZCBvcyB2ZXJzaW9uIHRvIHZhcmlv dXMgdW5peCBwb3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAyOTU1CisKKyAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgQWFrYXNoIEphaW4uCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5 OgorICAgICAgICAoUGxhdGZvcm1JbmZvLl9faW5pdF9fKTogVXNlIHBsYXRmb3JtLnJlbGVhc2Uo KSB0byBkZWZpbmVkIHRoZSBvc192ZXJzaW9uLgorCiAyMDE5LTEwLTE1ICBKaWV3ZW4gVGFuICA8 amlld2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkF1dGhuXSBXcml0ZSBtb3JlIHRl c3RzIGZvciBfV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsCkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm8ucHkJKHJldmlzaW9u IDI1MTE0OCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9y bWluZm8ucHkJKHdvcmtpbmcgY29weSkKQEAgLTI3LDYgKzI3LDcgQEAKICMgKElOQ0xVRElORyBO RUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNF CiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkg T0YgU1VDSCBEQU1BR0UuCiAKK2ltcG9ydCBsb2dnaW5nCiBpbXBvcnQgcmUKIGltcG9ydCBzeXMK IApAQCAtMzUsNiArMzYsOSBAQCBmcm9tIHdlYmtpdHB5LmNvbW1vbi52ZXJzaW9uX25hbWVfbWFw IGltCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlIGltcG9ydCBFeGVjdXRp dmUKIAogCitfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCisKKwogY2xhc3MgUGxh dGZvcm1JbmZvKG9iamVjdCk6CiAgICAgTUFYID0gMjE0NzQ4MzY0NwogCkBAIC02MiwxMSArNjYs MTMgQEAgY2xhc3MgUGxhdGZvcm1JbmZvKG9iamVjdCk6CiAgICAgICAgICAgICBzZWxmLm9zX3Zl cnNpb24gPSBWZXJzaW9uLmZyb21fc3RyaW5nKHBsYXRmb3JtX21vZHVsZS5tYWNfdmVyKClbMF0p CiAgICAgICAgIGVsaWYgc2VsZi5vc19uYW1lLnN0YXJ0c3dpdGgoJ3dpbicpOgogICAgICAgICAg ICAgc2VsZi5vc192ZXJzaW9uID0gc2VsZi5fd2luX3ZlcnNpb24oKQotICAgICAgICBlbGlmIHNl bGYub3NfbmFtZSA9PSAnbGludXgnIG9yIHNlbGYub3NfbmFtZSA9PSAnZnJlZWJzZCcgb3Igc2Vs Zi5vc19uYW1lID09ICdvcGVuYnNkJyBvciBzZWxmLm9zX25hbWUgPT0gJ25ldGJzZCc6Ci0gICAg ICAgICAgICByZXR1cm4KICAgICAgICAgZWxzZToKICAgICAgICAgICAgICMgTW9zdCBvdGhlciBw bGF0Zm9ybXMgKG5hbWVseSBpT1MpIHJldHVybiBjb25mb3JtaW5nIHZlcnNpb24gc3RyaW5ncy4K LSAgICAgICAgICAgIHNlbGYub3NfdmVyc2lvbiA9IFZlcnNpb24uZnJvbV9zdHJpbmcocGxhdGZv cm1fbW9kdWxlLnJlbGVhc2UoKSkKKyAgICAgICAgICAgIHZlcnNpb24gPSByZS5zZWFyY2gocidc ZCsuXGQrLlxkKycsIHBsYXRmb3JtX21vZHVsZS5yZWxlYXNlKCkpCisgICAgICAgICAgICBpZiB2 ZXJzaW9uOgorICAgICAgICAgICAgICAgIHNlbGYub3NfdmVyc2lvbiA9IFZlcnNpb24uZnJvbV9z dHJpbmcodmVyc2lvbi5ncm91cCgwKSkKKyAgICAgICAgICAgIGVsc2U6CisgICAgICAgICAgICAg ICAgX2xvZy5kZWJ1ZygnTm8gT1MgdmVyc2lvbiBudW1iZXIgZm91bmQnKQogCiAgICAgZGVmIGlz X21hYyhzZWxmKToKICAgICAgICAgcmV0dXJuIHNlbGYub3NfbmFtZSA9PSAnbWFjJwo=