20293 2008-08-05 17:05:59 -0700 Crash in JavaScript codegen for eval("const a;") 2008-08-05 17:42:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 1 zwarich webkit-unassigned ggaren mjs oliver oldest_to_newest 87907 0 zwarich 2008-08-05 17:05:59 -0700 Executing eval("const a;") crashes WebKit, both in the JS shell and in the browser. 87908 1 22666 zwarich 2008-08-05 17:14:00 -0700 Created attachment 22666 Stack trace The reason for the crash is pretty obvious. The eval path assumes that there is an initializer. I'll change it so it returns undefined otherwise. 87910 2 22668 zwarich 2008-08-05 17:29:53 -0700 Created attachment 22668 Proposed patch 87911 3 22668 darin 2008-08-05 17:31:22 -0700 Comment on attachment 22668 Proposed patch r=me 87912 4 zwarich 2008-08-05 17:42:08 -0700 Landed in r35584. 22666 2008-08-05 17:14:00 -0700 2008-08-05 17:14:00 -0700 Stack trace stacktrace.txt text/plain 3800 zwarich UHJvY2VzczogICAgICAgICBqc2MgWzQ0MjldClBhdGg6ICAgICAgICAgICAgL1VzZXJzL0NhbWVy b24vV2ViS2l0L1dlYktpdEJ1aWxkL0RlYnVnL2pzYwpJZGVudGlmaWVyOiAgICAgIGpzYwpWZXJz aW9uOiAgICAgICAgID8/PyAoPz8/KQpDb2RlIFR5cGU6ICAgICAgIFg4NiAoTmF0aXZlKQpQYXJl bnQgUHJvY2VzczogIGJhc2ggWzYxNF0KCkRhdGUvVGltZTogICAgICAgMjAwOC0wOC0wNSAyMDow NjoxOC42MDggLTA0MDAKT1MgVmVyc2lvbjogICAgICBNYWMgT1MgWCAxMC41LjQgKDlFMTcpClJl cG9ydCBWZXJzaW9uOiAgNgoKRXhjZXB0aW9uIFR5cGU6ICBFWENfQkFEX0FDQ0VTUyAoU0lHQlVT KQpFeGNlcHRpb24gQ29kZXM6IEtFUk5fUFJPVEVDVElPTl9GQUlMVVJFIGF0IDB4MDAwMDAwMDAw MDAwMDAwOApDcmFzaGVkIFRocmVhZDogIDAKClRocmVhZCAwIENyYXNoZWQ6CjAgICBjb20uYXBw bGUuSmF2YVNjcmlwdENvcmUgICAgICAJMHgwMDMzNWQ1NSBLSlM6Ok5vZGU6OmxpbmVObygpIGNv bnN0ICsgOSAobm9kZXMuaDoxODQpCjEgICBjb20uYXBwbGUuSmF2YVNjcmlwdENvcmUgICAgICAJ MHgwMDM1MjgzMCBLSlM6OkNvZGVHZW5lcmF0b3I6OmVtaXROb2RlKEtKUzo6UmVnaXN0ZXJJRCos IEtKUzo6Tm9kZSopICsgMTkwIChDb2RlR2VuZXJhdG9yLmg6MTczKQoyICAgY29tLmFwcGxlLkph dmFTY3JpcHRDb3JlICAgICAgCTB4MDAzNTI4ZDAgS0pTOjpDb2RlR2VuZXJhdG9yOjplbWl0Tm9k ZShLSlM6Ok5vZGUqKSArIDMyIChDb2RlR2VuZXJhdG9yLmg6MTgzKQozICAgY29tLmFwcGxlLkph dmFTY3JpcHRDb3JlICAgICAgCTB4MDAzMTZhOWUgS0pTOjpDb25zdERlY2xOb2RlOjplbWl0Q29k ZVNpbmdsZShLSlM6OkNvZGVHZW5lcmF0b3ImKSArIDE5NiAobm9kZXMuY3BwOjEwMTgpCjQgICBj b20uYXBwbGUuSmF2YVNjcmlwdENvcmUgICAgICAJMHgwMDJlN2I4NiBLSlM6OkNvbnN0RGVjbE5v ZGU6OmVtaXRDb2RlKEtKUzo6Q29kZUdlbmVyYXRvciYsIEtKUzo6UmVnaXN0ZXJJRCopICsgNDgg KG5vZGVzLmNwcDoxMDI2KQo1ICAgY29tLmFwcGxlLkphdmFTY3JpcHRDb3JlICAgICAgCTB4MDAz NTI4YTggS0pTOjpDb2RlR2VuZXJhdG9yOjplbWl0Tm9kZShLSlM6OlJlZ2lzdGVySUQqLCBLSlM6 Ok5vZGUqKSArIDMxMCAoQ29kZUdlbmVyYXRvci5oOjE3OCkKNiAgIGNvbS5hcHBsZS5KYXZhU2Ny aXB0Q29yZSAgICAgIAkweDAwMzUyOGQwIEtKUzo6Q29kZUdlbmVyYXRvcjo6ZW1pdE5vZGUoS0pT OjpOb2RlKikgKyAzMiAoQ29kZUdlbmVyYXRvci5oOjE4MykKNyAgIGNvbS5hcHBsZS5KYXZhU2Ny aXB0Q29yZSAgICAgIAkweDAwMmYwNmY4IEtKUzo6Q29uc3RTdGF0ZW1lbnROb2RlOjplbWl0Q29k ZShLSlM6OkNvZGVHZW5lcmF0b3ImLCBLSlM6OlJlZ2lzdGVySUQqKSArIDQ0IChub2Rlcy5jcHA6 MTAzNikKOCAgIGNvbS5hcHBsZS5KYXZhU2NyaXB0Q29yZSAgICAgIAkweDAwMzUyOGE4IEtKUzo6 Q29kZUdlbmVyYXRvcjo6ZW1pdE5vZGUoS0pTOjpSZWdpc3RlcklEKiwgS0pTOjpOb2RlKikgKyAz MTAgKENvZGVHZW5lcmF0b3IuaDoxNzgpCjkgICBjb20uYXBwbGUuSmF2YVNjcmlwdENvcmUgICAg ICAJMHgwMDJmMGY0YSBLSlM6OnN0YXRlbWVudExpc3RFbWl0Q29kZShXVEY6OlZlY3RvcjxXVEY6 OlJlZlB0cjxLSlM6OlN0YXRlbWVudE5vZGU+LCAwdWw+JiwgS0pTOjpDb2RlR2VuZXJhdG9yJiwg S0pTOjpSZWdpc3RlcklEKikgKyAxMzAgKG5vZGVzLmNwcDoxMDQzKQoxMCAgY29tLmFwcGxlLkph dmFTY3JpcHRDb3JlICAgICAgCTB4MDAzMTY5N2IgS0pTOjpFdmFsTm9kZTo6ZW1pdENvZGUoS0pT OjpDb2RlR2VuZXJhdG9yJiwgS0pTOjpSZWdpc3RlcklEKikgKyAxNTEgKG5vZGVzLmNwcDoxNjg3 KQoxMSAgY29tLmFwcGxlLkphdmFTY3JpcHRDb3JlICAgICAgCTB4MDAyZjQ5MGMgS0pTOjpDb2Rl R2VuZXJhdG9yOjpnZW5lcmF0ZSgpICsgMTE2IChDb2RlR2VuZXJhdG9yLmNwcDoxMzkpCjEyICBj b20uYXBwbGUuSmF2YVNjcmlwdENvcmUgICAgICAJMHgwMDJmZThkMCBLSlM6OkV2YWxOb2RlOjpn ZW5lcmF0ZUNvZGUoS0pTOjpTY29wZUNoYWluTm9kZSopICsgMzU4IChub2Rlcy5jcHA6MTcwMikK MTMgIGNvbS5hcHBsZS5KYXZhU2NyaXB0Q29yZSAgICAgIAkweDAwMzkzNmRiIEtKUzo6RXZhbE5v ZGU6OmJ5dGVDb2RlKEtKUzo6U2NvcGVDaGFpbk5vZGUqKSArIDQzIChub2Rlcy5oOjIyMDcpCjE0 ICBjb20uYXBwbGUuSmF2YVNjcmlwdENvcmUgICAgICAJMHgwMDM5MThmZCBLSlM6Ok1hY2hpbmU6 OmV4ZWN1dGUoS0pTOjpFdmFsTm9kZSosIEtKUzo6RXhlY1N0YXRlKiwgS0pTOjpKU09iamVjdCos IGludCwgS0pTOjpTY29wZUNoYWluTm9kZSosIEtKUzo6SlNWYWx1ZSoqKSArIDczIChNYWNoaW5l LmNwcDo4MTcpCjE1ICBjb20uYXBwbGUuSmF2YVNjcmlwdENvcmUgICAgICAJMHgwMDM5MWY5MyBL SlM6Ok1hY2hpbmU6OmNhbGxFdmFsKEtKUzo6RXhlY1N0YXRlKiwgS0pTOjpKU09iamVjdCosIEtK Uzo6U2NvcGVDaGFpbk5vZGUqLCBLSlM6OlJlZ2lzdGVyRmlsZSosIEtKUzo6UmVnaXN0ZXIqLCBp bnQsIGludCwgS0pTOjpKU1ZhbHVlKiYpICsgNjMxIChNYWNoaW5lLmNwcDo0NzEpCjE2ICBjb20u YXBwbGUuSmF2YVNjcmlwdENvcmUgICAgICAJMHgwMDM4ZmUwNSBLSlM6Ok1hY2hpbmU6OnByaXZh dGVFeGVjdXRlKEtKUzo6TWFjaGluZTo6RXhlY3V0aW9uRmxhZywgS0pTOjpFeGVjU3RhdGUqLCBL SlM6OlJlZ2lzdGVyRmlsZSosIEtKUzo6UmVnaXN0ZXIqLCBLSlM6OlNjb3BlQ2hhaW5Ob2RlKiwg S0pTOjpDb2RlQmxvY2sqLCBLSlM6OkpTVmFsdWUqKikgKyAyNzYzNyAoTWFjaGluZS5jcHA6MjI3 NikKMTcgIGNvbS5hcHBsZS5KYXZhU2NyaXB0Q29yZSAgICAgIAkweDAwMzkyNTg2IEtKUzo6TWFj aGluZTo6ZXhlY3V0ZShLSlM6OlByb2dyYW1Ob2RlKiwgS0pTOjpFeGVjU3RhdGUqLCBLSlM6OlNj b3BlQ2hhaW5Ob2RlKiwgS0pTOjpKU09iamVjdCosIEtKUzo6SlNWYWx1ZSoqKSArIDYxMiAoTWFj aGluZS5jcHA6NzM1KQoxOCAgY29tLmFwcGxlLkphdmFTY3JpcHRDb3JlICAgICAgCTB4MDAzMmMy N2IgS0pTOjpJbnRlcnByZXRlcjo6ZXZhbHVhdGUoS0pTOjpFeGVjU3RhdGUqLCBLSlM6OlNjb3Bl Q2hhaW4mLCBLSlM6OlVTdHJpbmcgY29uc3QmLCBpbnQsIFdURjo6UGFzc1JlZlB0cjxLSlM6OlNv dXJjZVByb3ZpZGVyPiwgS0pTOjpKU1ZhbHVlKikgKyA0MDkgKGludGVycHJldGVyLmNwcDo3OCkK MTkgIGNvbS5hcHBsZS5KYXZhU2NyaXB0Q29yZSAgICAgIAkweDAwMzJjM2JmIEtKUzo6SW50ZXJw cmV0ZXI6OmV2YWx1YXRlKEtKUzo6RXhlY1N0YXRlKiwgS0pTOjpTY29wZUNoYWluJiwgS0pTOjpV U3RyaW5nIGNvbnN0JiwgaW50LCBLSlM6OlVTdHJpbmcgY29uc3QmLCBLSlM6OkpTVmFsdWUqKSAr IDkzIChpbnRlcnByZXRlci5jcHA6NTkpCjIwICBqc2MgICAgICAgICAgICAgICAgICAgICAgICAg ICAJMHgwMDAwMmU1OSBydW5XaXRoU2NyaXB0cyhHbG9iYWxPYmplY3QqLCBXVEY6OlZlY3RvcjxL SlM6OlVTdHJpbmcsIDB1bD4gY29uc3QmLCBib29sLCBib29sKSArIDI4OQoyMSAganNjICAgICAg ICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDM2ZmUganNjbWFpbihpbnQsIGNoYXIqKiwgS0pT OjpKU0dsb2JhbERhdGEqKSArIDExMAoyMiAganNjICAgICAgICAgICAgICAgICAgICAgICAgICAg CTB4MDAwMDM3OTEgbWFpbiArIDc3IChTaGVsbC5jcHA6MzAzKQoyMyAganNjICAgICAgICAgICAg ICAgICAgICAgICAgICAgCTB4MDAwMDFlNGUgc3RhcnQgKyA1NAo= 22668 2008-08-05 17:29:53 -0700 2008-08-05 17:31:22 -0700 Proposed patch evalconst.diff text/plain 2940 zwarich SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM1NTgxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDgtMDUgIENhbWVyb24g WndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIwMjkzOiBDcmFzaCBpbiBKYXZhU2NyaXB0 IGNvZGVnZW4gZm9yIGV2YWwoImNvbnN0IGE7IikKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI5Mz4KKworICAgICAgICBDb3JyZWN0bHkgaGFuZGxl IGNvbnN0YW50IGRlY2xhcmF0aW9ucyBpbiBldmFsIGNvZGUgd2l0aCBubyBpbml0aWFsaXplci4K KworICAgICAgICAqIGtqcy9ub2Rlcy5jcHA6CisgICAgICAgIChLSlM6OkNvbnN0RGVjbE5vZGU6 OmVtaXRDb2RlU2luZ2xlKToKKwogMjAwOC0wOC0wNSAgQ2FtZXJvbiBad2FyaWNoICA8Y3d6d2Fy aWNoQHV3YXRlcmxvby5jYT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIuCkluZGV4OiBK YXZhU2NyaXB0Q29yZS9ranMvbm9kZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3Jl L2tqcy9ub2Rlcy5jcHAJKHJldmlzaW9uIDM1NTgwKQorKysgSmF2YVNjcmlwdENvcmUva2pzL25v ZGVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAxNSw3ICsxMDE1LDcgQEAgUmVnaXN0ZXJJRCog Q29uc3REZWNsTm9kZTo6ZW1pdENvZGVTaW5nbAogICAgIC8vIEZJWE1FOiBXaGlsZSB0aGlzIGNv ZGUgc2hvdWxkIG9ubHkgYmUgaGl0IGluIGV2YWwgY29kZSwgaXQgd2lsbCBwb3RlbnRpYWxseQog ICAgIC8vIGFzc2lnbiB0byB0aGUgd3JvbmcgYmFzZSBpZiBtX2lkZW50IGV4aXN0cyBpbiBhbiBp bnRlcnZlbmluZyBkeW5hbWljIHNjb3BlLgogICAgIFJlZlB0cjxSZWdpc3RlcklEPiBiYXNlID0g Z2VuZXJhdG9yLmVtaXRSZXNvbHZlQmFzZShnZW5lcmF0b3IubmV3VGVtcG9yYXJ5KCksIG1faWRl bnQpOwotICAgIFJlZ2lzdGVySUQqIHZhbHVlID0gZ2VuZXJhdG9yLmVtaXROb2RlKG1faW5pdC5n ZXQoKSk7CisgICAgUmVnaXN0ZXJJRCogdmFsdWUgPSBtX2luaXQgPyBnZW5lcmF0b3IuZW1pdE5v ZGUobV9pbml0LmdldCgpKSA6IGdlbmVyYXRvci5lbWl0TG9hZChnZW5lcmF0b3IubmV3VGVtcG9y YXJ5KCksIGpzVW5kZWZpbmVkKCkpOwogICAgIHJldHVybiBnZW5lcmF0b3IuZW1pdFB1dEJ5SWQo YmFzZS5nZXQoKSwgbV9pZGVudCwgdmFsdWUpOwogfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzNTU4 MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEz IEBACisyMDA4LTA4LTA1ICBDYW1lcm9uIFp3YXJpY2ggIDxjd3p3YXJpY2hAdXdhdGVybG9vLmNh PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Qg Zm9yIGJ1ZyAyMDI5MzogQ3Jhc2ggaW4gSmF2YVNjcmlwdCBjb2RlZ2VuIGZvciBldmFsKCJjb25z dCBhOyIpCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAyOTM+CisKKyAgICAgICAgKiBmYXN0L2pzL2NvbnN0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAg KiBmYXN0L2pzL3Jlc291cmNlcy9jb25zdC5qczoKKwogMjAwOC0wOC0wNSAgQ2FtZXJvbiBad2Fy aWNoICA8Y3d6d2FyaWNoQHV3YXRlcmxvby5jYT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2 ZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL2NvbnN0LWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL2NvbnN0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MzU1ODApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL2NvbnN0LWV4cGVjdGVkLnR4dAkod29ya2lu ZyBjb3B5KQpAQCAtNDcsNiArNDcsNyBAQCBQQVNTIG9iamVjdC5pbldpdGgxIGlzICdSSUdIVCcK IFBBU1MgaW5XaXRoMiBpcyAnUklHSFQnCiBQQVNTIChmdW5jdGlvbigpeyBvbmUgPSAyOyByZXR1 cm4gb25lOyB9KSgpIGlzIDEKIFBBU1MgZigpIGlzIGYKK1BBU1MgY29uc3QgYTsgaXMgdW5kZWZp bmVkCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL2NvbnN0LmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL2NvbnN0LmpzCShyZXZpc2lvbiAzNTU4MCkK KysrIExheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL2NvbnN0LmpzCSh3b3JraW5nIGNvcHkp CkBAIC0xMDcsNCArMTA3LDYgQEAgc2hvdWxkQmUoIihmdW5jdGlvbigpeyBvbmUgPSAyOyByZXR1 cm4gbwogdmFyIGYgPSBmdW5jdGlvbiBnKCkgeyBnPSJGQUlMIjsgcmV0dXJuIGc7IH07CiBzaG91 bGRCZSgiZigpIiwgImYiKTsKIAorc2hvdWxkQmUoImNvbnN0IGE7IiwgInVuZGVmaW5lZCIpOwor CiB2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK