202924 2019-10-14 05:15:57 -0700 [GTK][WPE] WebKitWebContext should identify web views by their WebPageProxy identifier 2019-10-15 02:11:45 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned aperez berto bugs-noreply ews-watchlist gustavo oldest_to_newest 1579608 0 cgarcia 2019-10-14 05:15:57 -0700 Instead of the WebPage identifier. 1579609 1 380877 cgarcia 2019-10-14 05:17:28 -0700 Created attachment 380877 Patch 1579610 2 ews-watchlist 2019-10-14 05:18:23 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1580014 3 380877 aperez 2019-10-15 00:38:47 -0700 Comment on attachment 380877 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380877&action=review I just have a comment suggesting a small improvement to the code that touches the “webViews” map, which could as well be a follow-up. Otherwise r=me :) > Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1807 > + context->priv->webViews.set(page.identifier().toUInt64(), webView); Instead of having the explicit .toUInt64() conversions where the “webViews” is used, the map could be declared as: HashMap<WebPageProxyIdentifier, WebKitWebView*> webViews; This would make explicit in the data type that the mapping is from page proxy identifiers to web views, and the compiler would help a little bit doing type checks. There will be still a couple of (unavoidable) casts when crossing the public API boundaries, but I think it would make the code a bit more robust. Could be a follow-up patch :) 1580042 4 cgarcia 2019-10-15 02:11:45 -0700 Committed r251127: <https://trac.webkit.org/changeset/251127> 380877 2019-10-14 05:17:28 -0700 2019-10-15 00:38:47 -0700 Patch wk2-page-ids.diff text/plain 1983 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNjFmODM3MjYzZDIuLjZkZjNiOTM2MjFkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDE5LTEwLTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIFdlYktpdFdlYkNvbnRleHQgc2hvdWxkIGlkZW50 aWZ5IHdlYiB2aWV3cyBieSB0aGVpciBXZWJQYWdlUHJveHkgaWRlbnRpZmllcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyOTI0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVhZCBvZiB0aGUgV2Vi UGFnZSBpZGVudGlmaWVyLCBzaW5jZSBpdCBtYXBzIFdlYlBhZ2VQcm94eSB0byBXZWJLaXRXZWJW aWV3LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3Bw OgorICAgICAgICAod2Via2l0V2ViQ29udGV4dENyZWF0ZVBhZ2VGb3JXZWJWaWV3KToKKyAgICAg ICAgKHdlYmtpdFdlYkNvbnRleHRXZWJWaWV3RGVzdHJveWVkKToKKyAgICAgICAgKHdlYmtpdFdl YkNvbnRleHRHZXRXZWJWaWV3Rm9yUGFnZSk6CisKIDIwMTktMTAtMTQgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gQWRkIHVz ZXIgbWVzc2FnZXMgQVBJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Z2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9n bGliL1dlYktpdFdlYkNvbnRleHQuY3BwCmluZGV4IDM2ZmJlZWFkZDg2Li44NGY3NzE2MzFiNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29u dGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2Vi Q29udGV4dC5jcHAKQEAgLTE4MDQsMTUgKzE4MDQsMTUgQEAgdm9pZCB3ZWJraXRXZWJDb250ZXh0 Q3JlYXRlUGFnZUZvcldlYlZpZXcoV2ViS2l0V2ViQ29udGV4dCogY29udGV4dCwgV2ViS2l0V2Vi VmkKICAgICAgICAgcGFnZS5zZXRVUkxTY2hlbWVIYW5kbGVyRm9yU2NoZW1lKFdURk1vdmUoaGFu ZGxlciksIGl0LmtleSk7CiAgICAgfQogCi0gICAgY29udGV4dC0+cHJpdi0+d2ViVmlld3Muc2V0 KHdlYmtpdF93ZWJfdmlld19nZXRfcGFnZV9pZCh3ZWJWaWV3KSwgd2ViVmlldyk7CisgICAgY29u dGV4dC0+cHJpdi0+d2ViVmlld3Muc2V0KHBhZ2UuaWRlbnRpZmllcigpLnRvVUludDY0KCksIHdl YlZpZXcpOwogfQogCiB2b2lkIHdlYmtpdFdlYkNvbnRleHRXZWJWaWV3RGVzdHJveWVkKFdlYktp dFdlYkNvbnRleHQqIGNvbnRleHQsIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiB7Ci0gICAgY29u dGV4dC0+cHJpdi0+d2ViVmlld3MucmVtb3ZlKHdlYmtpdF93ZWJfdmlld19nZXRfcGFnZV9pZCh3 ZWJWaWV3KSk7CisgICAgY29udGV4dC0+cHJpdi0+d2ViVmlld3MucmVtb3ZlKHdlYmtpdFdlYlZp ZXdHZXRQYWdlKHdlYlZpZXcpLmlkZW50aWZpZXIoKS50b1VJbnQ2NCgpKTsKIH0KIAogV2ViS2l0 V2ViVmlldyogd2Via2l0V2ViQ29udGV4dEdldFdlYlZpZXdGb3JQYWdlKFdlYktpdFdlYkNvbnRl eHQqIGNvbnRleHQsIFdlYlBhZ2VQcm94eSogcGFnZSkKIHsKLSAgICByZXR1cm4gcGFnZSA/IGNv bnRleHQtPnByaXYtPndlYlZpZXdzLmdldChwYWdlLT53ZWJQYWdlSUQoKS50b1VJbnQ2NCgpKSA6 IG51bGxwdHI7CisgICAgcmV0dXJuIHBhZ2UgPyBjb250ZXh0LT5wcml2LT53ZWJWaWV3cy5nZXQo cGFnZS0+aWRlbnRpZmllcigpLnRvVUludDY0KCkpIDogbnVsbHB0cjsKIH0K