202907 2019-10-13 14:26:25 -0700 Stop 'using namespace *Names' in files generated by make_names.pl 2019-10-15 15:13:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton cdumez commit-queue dbates esprehn+autocc ews-watchlist ggaren kangil.han lingcherd_ho sam simon.fraser webkit-bug-importer oldest_to_newest 1579522 0 thorton 2019-10-13 14:26:25 -0700 Stop 'using namespace *Names' in files generated by make_names.pl 1579524 1 380852 thorton 2019-10-13 14:27:06 -0700 Created attachment 380852 Patch 1579549 2 380852 ggaren 2019-10-13 20:57:29 -0700 Comment on attachment 380852 Patch r=me 1579551 3 380852 commit-queue 2019-10-13 22:04:36 -0700 Comment on attachment 380852 Patch Clearing flags on attachment: 380852 Committed r251064: <https://trac.webkit.org/changeset/251064> 1579552 4 commit-queue 2019-10-13 22:04:38 -0700 All reviewed patches have been landed. Closing bug. 1580304 5 lingcherd_ho 2019-10-15 15:13:43 -0700 <rdar://problem/56238114> 380852 2019-10-13 14:27:06 -0700 2019-10-13 22:04:36 -0700 Patch bug-202907-20191013142705.patch text/plain 3403 thorton SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MTA2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE5LTEwLTEzICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFN0b3AgJ3VzaW5nIG5h bWVzcGFjZSAqTmFtZXMnIGluIGZpbGVzIGdlbmVyYXRlZCBieSBtYWtlX25hbWVzLnBsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI5MDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9tYWtlX25h bWVzLnBsOgorICAgICAgICAocHJpbnRGdW5jdGlvblRhYmxlKToKKyAgICAgICAgKHByaW50RmFj dG9yeUNwcEZpbGUpOgorICAgICAgICAocHJpbnRXcmFwcGVyRmFjdG9yeUNwcEZpbGUpOgorICAg ICAgICBTdG9wICd1c2luZyBuYW1lc3BhY2UgU1ZHTmFtZXMnIGFuZCAndXNpbmcgbmFtZXBhY2Ug SFRNTE5hbWVzJyBpbgorICAgICAgICBmaWxlcyBnZW5lcmF0ZWQgYnkgbWFrZV9uYW1lcy5wbC4g SnVzdCB1c2UgZnVsbHktcXVhbGlmaWVkIG5hbWVzLgorCisgICAgICAgIFRoZXJlIGlzIHNvbWUg b3ZlcmxhcCBiZXR3ZWVuIHRoZSB0d28gbmFtZXNwYWNlcywgc28gdGhpcyBpcyBhCisgICAgICAg IHByZXJlcXVzaXRlIGZvciBkb2luZyBtb3JlIGFnZ3Jlc3NpdmUgdW5pZmllZCBzb3VyY2UgYnVu ZGxpbmcgaW4gYmluZGluZ3MuCisKIDIwMTktMTAtMTMgIEtvbnN0YW50aW4gVG9rYXJldiAgPGFu bnVsZW5AeWFuZGV4LnJ1PgogCiAgICAgICAgIEZpeCBjb21waWxhdGlvbiBvZiBDcnlwdG8uY3Bw IG9uIG1hY09TIHdpdGggIVdFQl9DUllQVE8KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9tYWtl X25hbWVzLnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBs CShyZXZpc2lvbiAyNTEwNjEpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbAko d29ya2luZyBjb3B5KQpAQCAtNTA0LDkgKzUwNCw5IEBAIHN1YiBwcmludEZ1bmN0aW9uVGFibGUK ICAgICAgICAgfQogCiAgICAgICAgIGlmICgkZW5hYmxlZFRhZ3N7JHRhZ05hbWV9e21hcFRvVGFn TmFtZX0pIHsKLSAgICAgICAgICAgIHByaW50IEYgIiAgICAgICAgeyAke3RhZ05hbWV9VGFnLCAk ZW5hYmxlZFRhZ3N7JHRhZ05hbWV9e21hcFRvVGFnTmFtZX1UbyR7dGFnTmFtZX1Db25zdHJ1Y3Rv ciB9LFxuIjsKKyAgICAgICAgICAgIHByaW50IEYgIiAgICAgICAgeyAkcGFyYW1ldGVyc3tuYW1l c3BhY2V9TmFtZXM6OiR7dGFnTmFtZX1UYWcsICRlbmFibGVkVGFnc3skdGFnTmFtZX17bWFwVG9U YWdOYW1lfVRvJHt0YWdOYW1lfUNvbnN0cnVjdG9yIH0sXG4iOwogICAgICAgICB9IGVsc2Ugewot ICAgICAgICAgICAgcHJpbnQgRiAiICAgICAgICB7ICR7dGFnTmFtZX1UYWcsICR0YWdDb25zdHJ1 Y3Rvck1hcHskdGFnTmFtZX1Db25zdHJ1Y3RvciB9LFxuIjsKKyAgICAgICAgICAgIHByaW50IEYg IiAgICAgICAgeyAkcGFyYW1ldGVyc3tuYW1lc3BhY2V9TmFtZXM6OiR7dGFnTmFtZX1UYWcsICR0 YWdDb25zdHJ1Y3Rvck1hcHskdGFnTmFtZX1Db25zdHJ1Y3RvciB9LFxuIjsKICAgICAgICAgfQog CiAgICAgICAgIGlmICgkY29uZGl0aW9uYWwpIHsKQEAgLTk2Nyw4ICs5NjcsNiBAQCBFTkQKIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCi11c2luZyBuYW1lc3BhY2UgJHBhcmFtZXRlcnN7bmFtZXNw YWNlfU5hbWVzOwotCiB0eXBlZGVmIFJlZjwkcGFyYW1ldGVyc3tuYW1lc3BhY2V9RWxlbWVudD4g KCokcGFyYW1ldGVyc3tuYW1lc3BhY2V9Q29uc3RydWN0b3JGdW5jdGlvbikoY29uc3QgUXVhbGlm aWVkTmFtZSYsIERvY3VtZW50JiRmb3JtRWxlbWVudEFyZ3VtZW50Rm9yRGVjbGFyYXRpb24sIGJv b2wgY3JlYXRlZEJ5UGFyc2VyKTsKIAogRU5ECkBAIC0xMDU5LDcgKzEwNTcsNyBAQCBSZWY8JHBh cmFtZXRlcnN7bmFtZXNwYWNlfUVsZW1lbnQ+ICRwYXJhCiAgICAgICAgIGNvbnN0IGF1dG8mIG5h bWUgPSAqZW50cnkucXVhbGlmaWVkTmFtZTsKICAgICAgICAgcmV0dXJuIGVudHJ5LmZ1bmN0aW9u KCRhcmd1bWVudExpc3QpOwogICAgIH0KLSAgICByZXR1cm4gJHBhcmFtZXRlcnN7ZmFsbGJhY2tJ bnRlcmZhY2VOYW1lfTo6Y3JlYXRlKFF1YWxpZmllZE5hbWUobnVsbEF0b20oKSwgbG9jYWxOYW1l LCAke2xvd2VyY2FzZU5hbWVzcGFjZVByZWZpeH1OYW1lc3BhY2VVUkkpLCBkb2N1bWVudCk7Cisg ICAgcmV0dXJuICRwYXJhbWV0ZXJze2ZhbGxiYWNrSW50ZXJmYWNlTmFtZX06OmNyZWF0ZShRdWFs aWZpZWROYW1lKG51bGxBdG9tKCksIGxvY2FsTmFtZSwgJHBhcmFtZXRlcnN7bmFtZXNwYWNlfU5h bWVzOjoke2xvd2VyY2FzZU5hbWVzcGFjZVByZWZpeH1OYW1lc3BhY2VVUkkpLCBkb2N1bWVudCk7 CiB9CiAKIFJlZjwkcGFyYW1ldGVyc3tuYW1lc3BhY2V9RWxlbWVudD4gJHBhcmFtZXRlcnN7bmFt ZXNwYWNlfUVsZW1lbnRGYWN0b3J5OjpjcmVhdGVFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUm IG5hbWUsIERvY3VtZW50JiBkb2N1bWVudCRmb3JtRWxlbWVudEFyZ3VtZW50Rm9yRGVmaW5pdGlv biwgYm9vbCBjcmVhdGVkQnlQYXJzZXIpCkBAIC0xMjQ5LDggKzEyNDcsNiBAQCB1c2luZyBuYW1l c3BhY2UgSlNDOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXVzaW5nIG5hbWVzcGFjZSAkcGFy YW1ldGVyc3tuYW1lc3BhY2V9TmFtZXM7Ci0KIHR5cGVkZWYgSlNET01PYmplY3QqICgqQ3JlYXRl JHBhcmFtZXRlcnN7bmFtZXNwYWNlfUVsZW1lbnRXcmFwcGVyRnVuY3Rpb24pKEpTRE9NR2xvYmFs T2JqZWN0KiwgUmVmPCRwYXJhbWV0ZXJze25hbWVzcGFjZX1FbGVtZW50PiYmKTsKIAogRU5ECkBA IC0xMjg4LDcgKzEyODQsNyBAQCBFTkQKICAgICAgICAgICAgICR1Y1RhZyA9ICRlbmFibGVkVGFn c3skdGFnfXtKU0ludGVyZmFjZU5hbWV9OwogICAgICAgICB9CiAKLSAgICAgICAgcHJpbnQgRiAi ICAgICAgICB7ICR7dGFnfVRhZywgY3JlYXRlJHt1Y1RhZ31XcmFwcGVyIH0sXG4iOworICAgICAg ICBwcmludCBGICIgICAgICAgIHsgJHBhcmFtZXRlcnN7bmFtZXNwYWNlfU5hbWVzOjoke3RhZ31U YWcsIGNyZWF0ZSR7dWNUYWd9V3JhcHBlciB9LFxuIjsKIAogICAgICAgICBpZiAoJGNvbmRpdGlv bmFsKSB7CiAgICAgICAgICAgICBwcmludCBGICIjZW5kaWZcbiI7Cg==