202904 2019-10-13 14:19:08 -0700 Chromium test-case asserts with ASSERTION FAILED: propertyMissingOrEqualToNone(style, CSSPropertyWebkitTextDecorationsInEffect) 2021-09-09 09:21:59 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 emilio fred.wang darin ews-watchlist fred.wang mifenton rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1579517 0 emilio 2019-10-13 14:19:08 -0700 On master (247b0314320d499ae788b6ea993aa1d98e2d607e / r250962), WebKitGTK build. Running this test-case locally: * https://cs.chromium.org/chromium/src/third_party/blink/web_tests/editing/execCommand/justify-right-in-effect-crash.html?rcl=753caf715d8f30f0c673f1b4b36dadfc75c3201f Asserts like: ASSERTION FAILED: propertyMissingOrEqualToNone(style, CSSPropertyWebkitTextDecorationsInEffect) ../../Source/WebCore/editing/markup.cpp(366) : void WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag(WTF::StringBuilder&, WebCore::StyleProperties*, WebCore::Document&, bool) 1 0x7fb15b8863d3 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x9) [0x7fb15b8863d3] 2 0x7fb16752f5f2 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3WTF15CrashOnOverflow10overflowedEv+0) [0x7fb16752f5f2] 3 0x7fb169b6d396 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore23StyledMarkupAccumulator22appendStyleNodeOpenTagERN3WTF13StringBuilderEPNS_15StylePropertiesERNS_8DocumentEb+0x62) [0x7fb169b6d396] 4 0x7fb169b6d783 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore23StyledMarkupAccumulator10appendTextERN3WTF13StringBuilderERKNS_4TextE+0x147) [0x7fb169b6d783] 5 0x7fb169b27241 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore17MarkupAccumulator20appendNonElementNodeERN3WTF13StringBuilderERKNS_4NodeEPNS1_7HashMapINS1_10AtomStringEPNS1_14AtomStringImplENS1_14AtomStringHashENS1_10HashTraitsIS8_EENSC_ISA_EEEE+0x9d) [0x7fb169b27241] 6 0x7fb169b25533 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore17MarkupAccumulator18startAppendingNodeERKNS_4NodeEPN3WTF7HashMapINS4_10AtomStringEPNS4_14AtomStringImplENS4_14AtomStringHashENS4_10HashTraitsIS6_EENSA_IS8_EEEE+0x7b) [0x7fb169b25533] 7 0x7fb169b6e7c2 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xcc1a7c2) [0x7fb169b6e7c2] 8 0x7fb169b6eae3 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore23StyledMarkupAccumulator29traverseNodesForSerializationEPNS_4NodeES2_NS0_17NodeTraversalModeE+0x275) [0x7fb169b6eae3] 9 0x7fb169b6e64e /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore23StyledMarkupAccumulator14serializeNodesERKNS_8PositionES3_+0x1ee) [0x7fb169b6e64e] 10 0x7fb169b6ff92 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xcc1bf92) [0x7fb169b6ff92] 11 0x7fb169b70631 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore35serializePreservingVisualAppearanceERKNS_5RangeEPN3WTF6VectorIPNS_4NodeELm0ENS3_15CrashOnOverflowELm16EEENS_22AnnotateForInterchangeENS_22ConvertBlocksToInlinesENS_11ResolveURLsE+0x80) [0x7fb169b70631] 12 0x7fb16b118a30 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore20CompositeEditCommand14moveParagraphsERKNS_15VisiblePositionES3_S3_bb+0x614) [0x7fb16b118a30] 13 0x7fb16b117232 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore20CompositeEditCommand42moveParagraphContentsToNewBlockIfNecessaryERKNS_8PositionE+0x4c6) [0x7fb16b117232] 14 0x7fb16b1086c3 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore17ApplyStyleCommand15applyBlockStyleERNS_12EditingStyleE+0x611) [0x7fb16b1086c3] 15 0x7fb16b1080ad /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore17ApplyStyleCommand7doApplyEv+0x157) [0x7fb16b1080ad] 16 0x7fb16b112cd3 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore20CompositeEditCommand5applyEv+0xf5) [0x7fb16b112cd3] 17 0x7fb169ae51f5 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore6Editor19applyParagraphStyleEPNS_15StylePropertiesENS_10EditActionE+0x235) [0x7fb169ae51f5] 18 0x7fb169af5250 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xcba1250) [0x7fb169af5250] 19 0x7fb169af7070 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xcba3070) [0x7fb169af7070] 20 0x7fb169afa62a /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNK7WebCore6Editor7Command7executeERKN3WTF6StringEPNS_5EventE+0xdc) [0x7fb169afa62a] 21 0x7fb1698e5268 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore8Document11execCommandERKN3WTF6StringEbS4_+0x56) [0x7fb1698e5268] 22 0x7fb1685f3694 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb69f694) [0x7fb1685f3694] 23 0x7fb16860d1b6 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb6b91b6) [0x7fb16860d1b6] 24 0x7fb1685f3702 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore38jsDocumentPrototypeFunctionExecCommandEPN3JSC14JSGlobalObjectEPNS0_9CallFrameE+0x23) [0x7fb1685f3702] 25 0x7fb105dfa16b [0x7fb105dfa16b] 1579922 1 webkit-bug-importer 2019-10-14 17:24:28 -0700 <rdar://problem/56271311> 1778409 2 433930 fred.wang 2021-07-21 07:03:03 -0700 Created attachment 433930 Patch Below is the backtrace I have. The assert expects -webkit-text-decorations-in-effect to be removed and the comment even says this should have happened during the wrappingStyleForSerialization call. However, this only happens if annotate is AnnotateForInterchange::YES: https://webkit-search.igalia.com/webkit/source/Source/WebCore/editing/EditingStyle.cpp#1197 As you can see in the backtrace, it's however set to AnnotateForInterchange::NO. Attached is a trivial patch that sets it to AnnotateForInterchange::YES instead, but not sure that's correct. It's however indeed fixing the ASSERT of the testcase. #0 WTFCrash() () at ../../Source/WTF/wtf/Assertions.cpp:319 #1 0x00007f895c246c3c in CRASH_WITH_INFO(...) () at WTF/Headers/wtf/Assertions.h:744 #2 0x00007f8962fd21cc in WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag(WTF::StringBuilder&, WebCore::StyleProperties*, WebCore::Document&, bool) (this=0x7ffcbe378cd0, out=..., style=0x60b0000de610, document=warning: RTTI symbol not found for class 'WebCore::HTMLDocument' ..., isBlock=false) at https://webkit-search.igalia.com/webkit/source/Source/WebCore/editing/markup.cpp#387 #3 0x00007f8962fd2ebc in WebCore::StyledMarkupAccumulator::appendText(WTF::StringBuilder&, WebCore::Text const&) (this=0x7ffcbe378cd0, out=..., text=...) at ../../Source/WebCore/editing/markup.cpp:438 #4 0x00007f8962ee71b0 in WebCore::MarkupAccumulator::appendNonElementNode(WTF::StringBuilder&, WebCore::Node const&, WTF::HashMap<WTF::AtomString, WTF::AtomStringImpl*, WTF::DefaultHash<WTF::AtomString>, WTF::HashTraits<WTF::AtomString>, WTF::HashTraits<WTF::AtomStringImpl*>, WTF::HashTableTraits>*) (this=0x7ffcbe378cd0, result=..., node=..., namespaces=0x0) at ../../Source/WebCore/editing/MarkupAccumulator.cpp:551 #5 0x00007f8962ee34fe in WebCore::MarkupAccumulator::startAppendingNode(WebCore::Node const&, WTF::HashMap<WTF::AtomString, WTF::AtomStringImpl*, WTF::DefaultHash<WTF::AtomString>, WTF::HashTraits<WTF::AtomString>, WTF::HashTraits<WTF::AtomStringImpl*>, WTF::HashTableTraits>*) (this=0x7ffcbe378cd0, node=..., namespaces=0x0) at ../../Source/WebCore/editing/MarkupAccumulator.cpp:254 #6 0x00007f8962fd51e1 in operator()(WebCore::Node&) const (__closure=0x7ffcbe378620, node=...) at ../../Source/WebCore/editing/markup.cpp:662 #7 0x00007f8962fd5b80 in WebCore::StyledMarkupAccumulator::traverseNodesForSerialization(WebCore::Node*, WebCore::Node*, WebCore::StyledMarkupAccumulator::NodeTraversalMode) --Type <RET> for more, q to quit, c to continue without paging--c cd0, startNode=0x60b0000dc670, pastEnd=0x60c0002a3e80, traversalMode=WebCore::StyledMarkupAccumulator::NodeTraversalMode::EmitString) at ../../Source/WebCore/editing/markup.cpp:708 #8 0x00007f8962fd4d5e in WebCore::StyledMarkupAccumulator::serializeNodes(WebCore::Position const&, WebCore::Position const&) (this=0x7ffcbe378cd0, start=..., end=...) at https://webkit-search.igalia.com/webkit/source/Source/WebCore/editing/markup.cpp#640 #9 0x00007f8962fd8573 in WebCore::serializePreservingVisualAppearanceInternal(WebCore::Position const&, WebCore::Position const&, WTF::Vector<WebCore::Node*, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>*, WebCore::ResolveURLs, WebCore::SerializeComposedTree, WebCore::AnnotateForInterchange, WebCore::ConvertBlocksToInlines, WebCore::StandardFontFamilySerializationMode, WebCore::MSOListMode) (start=..., end=..., nodes=0x0, resolveURLs=WebCore::ResolveURLs::No, serializeComposedTree=WebCore::SerializeComposedTree::No, annotate=WebCore::AnnotateForInterchange::No, convertBlocksToInlines=WebCore::ConvertBlocksToInlines::Yes, standardFontFamilySerializationMode=WebCore::StandardFontFamilySerializationMode::Keep, msoListMode=WebCore::MSOListMode::DoNotPreserve) at ../../Source/WebCore/editing/markup.cpp:918 #10 0x00007f8962fd91e1 in WebCore::serializePreservingVisualAppearance(WebCore::SimpleRange const&, WTF::Vector<WebCore::Node*, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>*, WebCore::AnnotateForInterchange, WebCore::ConvertBlocksToInlines, WebCore::ResolveURLs) (range=..., nodes=0x0, annotate=WebCore::AnnotateForInterchange::No, convertBlocksToInlines=WebCore::ConvertBlocksToInlines::Yes, resolveURLs=WebCore::ResolveURLs::No) at ../../Source/WebCore/editing/markup.cpp:980 #11 0x00007f8967146d6f in WebCore::CompositeEditCommand::moveParagraphs(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, bool, bool) (this=0x613000089640, startOfParagraphToMove=..., endOfParagraphToMove=..., destination=..., preserveSelection=false, preserveStyle=true) at https://webkit-search.igalia.com/webkit/source/Source/WebCore/editing/CompositeEditCommand.cpp#1470 1781580 3 434825 fred.wang 2021-08-03 04:48:57 -0700 Created attachment 434825 Patch Probably not ideal, but this just imports the change from Chromium (see https://codereview.chromium.org/1522063002). 1791492 4 434825 darin 2021-09-08 09:32:33 -0700 Comment on attachment 434825 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434825&action=review > Source/WebCore/editing/markup.cpp:387 > + // With AnnotateForInterchange::Yes, wrappingStyleForSerialization should have removed -webkit-text-decorations-in-effect > + ASSERT(!shouldAnnotate() || propertyMissingOrEqualToNone(style, CSSPropertyWebkitTextDecorationsInEffect)); Changing the assertion is OK, but I think this is sort of missing the big picture. Having a webpage specify "-webkit-text-decorations-in-effect" doesn’t really make logical sense. It’s a property intended for internal use in the engine. The key to this test case is that it specifies that property explicitly in a style sheet. Might be something to clean up here some day, but in the mean time loosening this assertion is a fine thing to do so we don’t block fuzz testing. Changing the assertion has no effect on WebKit behavior. 1791853 5 434825 fred.wang 2021-09-09 04:34:44 -0700 Comment on attachment 434825 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434825&action=review >> Source/WebCore/editing/markup.cpp:387 >> + ASSERT(!shouldAnnotate() || propertyMissingOrEqualToNone(style, CSSPropertyWebkitTextDecorationsInEffect)); > > Changing the assertion is OK, but I think this is sort of missing the big picture. Having a webpage specify "-webkit-text-decorations-in-effect" doesn’t really make logical sense. It’s a property intended for internal use in the engine. The key to this test case is that it specifies that property explicitly in a style sheet. > > Might be something to clean up here some day, but in the mean time loosening this assertion is a fine thing to do so we don’t block fuzz testing. Changing the assertion has no effect on WebKit behavior. Would it be possible to really make it an internal property, not web-exposed? IIUC, this is something that is now possible in WebKit. I guess the best thing to do is to open a separate bug for that. 1791855 6 ews-feeder 2021-09-09 04:39:12 -0700 Committed r282209 (?): <https://commits.webkit.org/r282209> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434825. 1791929 7 darin 2021-09-09 09:21:59 -0700 (In reply to Frédéric Wang (:fredw) from comment #5) > Would it be possible to really make it an internal property, not > web-exposed? IIUC, this is something that is now possible in WebKit. I guess > the best thing to do is to open a separate bug for that. That might be possible. I hope so! Compatibility with existing iOS and macOS apps that might rely on getting the value of the property might be an issue. 433930 2021-07-21 07:03:03 -0700 2021-09-08 01:27:42 -0700 Patch 202904.patch text/plain 1132 fred.wang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQu Y3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKaW5k ZXggM2ZkMDRjN2UzMS4uMWFmN2YyMzgyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKQEAgLTE0NjcsNyArMTQ2Nyw3IEBAIHZvaWQgQ29t cG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQYXJhZ3JhcGhzKGNvbnN0IFZpc2libGVQb3NpdGlvbiYg c3RhcnRPZlBhcmFncmFwCiAgICAgLy8gRklYTUU6IFNlcmlhbGl6aW5nIGFuZCByZS1wYXJzaW5n IGlzIGFuIGluZWZmaWNpZW50IHdheSB0byBwcmVzZXJ2ZSBzdHlsZS4KICAgICBSZWZQdHI8RG9j dW1lbnRGcmFnbWVudD4gZnJhZ21lbnQ7CiAgICAgaWYgKHN0YXJ0T2ZQYXJhZ3JhcGhUb01vdmUg IT0gZW5kT2ZQYXJhZ3JhcGhUb01vdmUpCi0gICAgICAgIGZyYWdtZW50ID0gY3JlYXRlRnJhZ21l bnRGcm9tTWFya3VwKGRvY3VtZW50KCksIHNlcmlhbGl6ZVByZXNlcnZpbmdWaXN1YWxBcHBlYXJh bmNlKCptYWtlU2ltcGxlUmFuZ2Uoc3RhcnQsIGVuZCksIG51bGxwdHIsIEFubm90YXRlRm9ySW50 ZXJjaGFuZ2U6Ok5vLCBDb252ZXJ0QmxvY2tzVG9JbmxpbmVzOjpZZXMpLCBlbXB0eVN0cmluZygp KTsKKyAgICAgICAgZnJhZ21lbnQgPSBjcmVhdGVGcmFnbWVudEZyb21NYXJrdXAoZG9jdW1lbnQo KSwgc2VyaWFsaXplUHJlc2VydmluZ1Zpc3VhbEFwcGVhcmFuY2UoKm1ha2VTaW1wbGVSYW5nZShz dGFydCwgZW5kKSwgbnVsbHB0ciwgQW5ub3RhdGVGb3JJbnRlcmNoYW5nZTo6WWVzLCBDb252ZXJ0 QmxvY2tzVG9JbmxpbmVzOjpZZXMpLCBlbXB0eVN0cmluZygpKTsKIAogICAgIC8vIEEgbm9uLWVt cHR5IHBhcmFncmFwaCdzIHN0eWxlIGlzIG1vdmVkIHdoZW4gd2UgY29weSBhbmQgbW92ZSBpdC4g IFdlIGRvbid0IG1vdmUgCiAgICAgLy8gYW55dGhpbmcgaWYgd2UncmUgZ2l2ZW4gYW4gZW1wdHkg cGFyYWdyYXBoLCBidXQgYW4gZW1wdHkgcGFyYWdyYXBoIGNhbiBoYXZlIHN0eWxlCg== 434825 2021-08-03 04:48:57 -0700 2021-09-09 04:39:13 -0700 Patch 0001-bug-202904.patch text/plain 5224 fred.wang RnJvbSBmOGE3Y2MxZWZiYzNkYmUxZjdmZDljNzE2YzA3MmI1YWMwNWU2NTk4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RnI9QzM9QTlkPUMzPUE5cmljPTIwV2FuZz89 IDxmd2FuZ0BpZ2FsaWEuY29tPgpEYXRlOiBUdWUsIDMgQXVnIDIwMjEgMTM6NDc6MDUgKzAyMDAK U3ViamVjdDogW1BBVENIXSBidWctMjAyOTA0CgotLS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysKIC4uLmp1c3RpZnktcmlnaHQt aW4tZWZmZWN0LWNyYXNoLWV4cGVjdGVkLnR4dCB8ICAxICsKIC4uLi9qdXN0aWZ5LXJpZ2h0LWlu LWVmZmVjdC1jcmFzaC5odG1sICAgICAgICB8IDI0ICsrKysrKysrKysrKysrKysrKysKIFNvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICB8IDIzICsrKysrKysrKysr KysrKysrKwogU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwICAgICAgICAgICAgIHwg IDQgKystLQogNSBmaWxlcyBjaGFuZ2VkLCA2MiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL2ltcG9ydGVkL2JsaW5rL2VkaXRpbmcv ZXhlY0NvbW1hbmQvanVzdGlmeS1yaWdodC1pbi1lZmZlY3QtY3Jhc2gtZXhwZWN0ZWQudHh0CiBj cmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvaW1wb3J0ZWQvYmxpbmsvZWRpdGluZy9leGVj Q29tbWFuZC9qdXN0aWZ5LXJpZ2h0LWluLWVmZmVjdC1jcmFzaC5odG1sCgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDYyYjFm OTZmMjkuLmFhMGVmNGZjYjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMS0wOC0wMyAgRnJl ZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+CisKKyAgICAgICAgQ2hyb21pdW0gdGVzdC1j YXNlIGFzc2VydHMgd2l0aCBBU1NFUlRJT04gRkFJTEVEOiBwcm9wZXJ0eU1pc3NpbmdPckVxdWFs VG9Ob25lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDI5MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bXBvcnQgcmVncmVzc2lvbiB0ZXN0IGZyb20gQmxpbmsuCisKKyAgICAgICAgKiBpbXBvcnRlZC9i bGluay9lZGl0aW5nL2V4ZWNDb21tYW5kL2p1c3RpZnktcmlnaHQtaW4tZWZmZWN0LWNyYXNoLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaW1wb3J0ZWQvYmxpbmsvZWRpdGluZy9leGVj Q29tbWFuZC9qdXN0aWZ5LXJpZ2h0LWluLWVmZmVjdC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAy MS0wOC0wMyAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIENoZWNrIHRo YXQgc2hhZG93IHJvb3QgaXMgY29ubmVjdGVkIGluIGludmFsaWRhdGVTdHlsZUFmdGVyU3R5bGVT aGVldENoYW5nZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvYmxpbmsvZWRpdGlu Zy9leGVjQ29tbWFuZC9qdXN0aWZ5LXJpZ2h0LWluLWVmZmVjdC1jcmFzaC1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC9ibGluay9lZGl0aW5nL2V4ZWNDb21tYW5kL2p1c3RpZnkt cmlnaHQtaW4tZWZmZWN0LWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwLi40OGFhY2NlNmJkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvYmxpbmsvZWRpdGluZy9leGVjQ29tbWFuZC9qdXN0aWZ5LXJpZ2h0LWluLWVm ZmVjdC1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorUEFTUyBpZiBCbGluayBkb2Vz bid0IGNyYXNoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvYmxpbmsvZWRpdGlu Zy9leGVjQ29tbWFuZC9qdXN0aWZ5LXJpZ2h0LWluLWVmZmVjdC1jcmFzaC5odG1sIGIvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvYmxpbmsvZWRpdGluZy9leGVjQ29tbWFuZC9qdXN0aWZ5LXJpZ2h0LWlu LWVmZmVjdC1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAu LjFhODdhNmRiMTEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC9ibGlu ay9lZGl0aW5nL2V4ZWNDb21tYW5kL2p1c3RpZnktcmlnaHQtaW4tZWZmZWN0LWNyYXNoLmh0bWwK QEAgLTAsMCArMSwyNCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlw dD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsK Kword2luZG93Lm9ubG9hZD0gZnVuY3Rpb24oKSB7CisgICAgZG9jdW1lbnQuZGVzaWduTW9kZSA9 ICJvbiI7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIlNlbGVjdEFsbCIpOworICAgIGRvY3Vt ZW50LmV4ZWNDb21tYW5kKCJKdXN0aWZ5UmlnaHQiKTsKKyAgICBkb2N1bWVudC5ib2R5LnRleHRD b250ZW50ID0gJ1BBU1MgaWYgQmxpbmsgZG9lc25cJ3QgY3Jhc2guJzsKK307Cis8L3NjcmlwdD4K KzxzdHlsZT4KKy5DTEFTUzMgeworICAgIC13ZWJraXQtdGV4dC1kZWNvcmF0aW9ucy1pbi1lZmZl Y3Q6dW5kZXJsaW5lOworfQorPC9zdHlsZT4KKzxib2R5IGNsYXNzPSJDTEFTUzMiPgorbmxzCis8 aHI+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODk0OTdmOGUyOS4uYzFmOTc0OTNh OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIxLTA4LTAzICBGcmVkZXJpYyBXYW5n ICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBDaHJvbWl1bSB0ZXN0LWNhc2UgYXNzZXJ0 cyB3aXRoIEFTU0VSVElPTiBGQUlMRUQ6IHByb3BlcnR5TWlzc2luZ09yRXF1YWxUb05vbmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjkwNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkNvcmU6OkNv bXBvc2l0ZUVkaXRDb21tYW5kOjptb3ZlUGFyYWdyYXBocyBjYWxscyBjcmVhdGVGcmFnbWVudEZy b21NYXJrdXAgd2l0aCBhIHBhcmFtZXRlcgorICAgICAgICBBbm5vdGF0ZUZvckludGVyY2hhbmdl IHNldCB0byBOby4gQXMgYSBjb25zZXF1ZW5jZSwgU3R5bGVkTWFya3VwQWNjdW11bGF0b3I6OnNl cmlhbGl6ZU5vZGVzCisgICAgICAgIHdpbGwgbm90IGNhbGwgRWRpdGluZ1N0eWxlOjp3cmFwcGlu Z1N0eWxlRm9yU2VyaWFsaXphdGlvbiAoaW4gb3JkZXIgdG8gcmVtb3ZlCisgICAgICAgIC13ZWJr aXQtdGV4dC1kZWNvcmF0aW9ucy1pbi1lZmZlY3QpIGNvbnRyYXJ5IHRvIHRoZSBhc3N1bXB0aW9u IG9mIHRoZSBBU1NFUlQgaW4KKyAgICAgICAgcHJvcGVydHlNaXNzaW5nT3JFcXVhbFRvTm9uZS4g VGhpcyBjYW4gbGVhZCB0byB0aGUgQVNTRVJUIGZhaWxpbmcgZS5nLiB3aXRoIHRoZSBKdXN0aWZ5 UmlnaHQKKyAgICAgICAgY29tbWFuZC4gVGhpcyBwYXRjaCBmaXhlcyB0aGF0IHdyb25nIGV4cGVj dGF0aW9uIGJ5IGltcG9ydGluZyB0aGUgY29ycmVzcG9uZGluZyBjaGFuZ2UgYW5kCisgICAgICAg IHRlc3QgZnJvbSBDaHJvbWl1bSBbMV0uCisKKyAgICAgICAgWzFdIGh0dHBzOi8vY29kZXJldmll dy5jaHJvbWl1bS5vcmcvMTUyMjA2MzAwMgorCisgICAgICAgIFRlc3Q6IGltcG9ydGVkL2JsaW5r L2VkaXRpbmcvZXhlY0NvbW1hbmQvanVzdGlmeS1yaWdodC1pbi1lZmZlY3QtY3Jhc2guaHRtbAor CisgICAgICAgICogZWRpdGluZy9tYXJrdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVk TWFya3VwQWNjdW11bGF0b3I6OmFwcGVuZFN0eWxlTm9kZU9wZW5UYWcpOiBTa2lwIHRoZSBhc3Nl cnQgaWYgd2Ugc2hvdWxkIG5vdAorICAgICAgICBhbm5vdGF0ZSBhbmQgdXBkYXRlIHRoZSBjb2Rl IGNvbW1lbnQgYWNjb3JkaW5nbHkuCisKIDIwMjEtMDgtMDMgIEtpbW1vIEtpbm51bmVuICA8a2tp bm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCBpbiB3ZWJnbC8xLjAueC9jb25mb3Jt YW5jZS90ZXh0dXJlcy9taXNjL3RleHR1cmUtd2l0aC1mbGlwLXktYW5kLXByZW11bHRpcGx5LWFs cGhhLmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcAppbmRleCA1ZWE4MWFhNDU4Li5mMmEx N2E4Mzg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwCkBAIC0zODMsOCArMzgzLDggQEAg dm9pZCBTdHlsZWRNYXJrdXBBY2N1bXVsYXRvcjo6d3JhcFdpdGhTdHlsZU5vZGUoU3R5bGVQcm9w ZXJ0aWVzKiBzdHlsZSwgRG9jdW1lbnQKIAogdm9pZCBTdHlsZWRNYXJrdXBBY2N1bXVsYXRvcjo6 YXBwZW5kU3R5bGVOb2RlT3BlblRhZyhTdHJpbmdCdWlsZGVyJiBvdXQsIFN0eWxlUHJvcGVydGll cyogc3R5bGUsIERvY3VtZW50JiBkb2N1bWVudCwgYm9vbCBpc0Jsb2NrKQogewotICAgIC8vIHdy YXBwaW5nU3R5bGVGb3JTZXJpYWxpemF0aW9uIHNob3VsZCBoYXZlIHJlbW92ZWQgLXdlYmtpdC10 ZXh0LWRlY29yYXRpb25zLWluLWVmZmVjdAotICAgIEFTU0VSVChwcm9wZXJ0eU1pc3NpbmdPckVx dWFsVG9Ob25lKHN0eWxlLCBDU1NQcm9wZXJ0eVdlYmtpdFRleHREZWNvcmF0aW9uc0luRWZmZWN0 KSk7CisgICAgLy8gV2l0aCBBbm5vdGF0ZUZvckludGVyY2hhbmdlOjpZZXMsIHdyYXBwaW5nU3R5 bGVGb3JTZXJpYWxpemF0aW9uIHNob3VsZCBoYXZlIHJlbW92ZWQgLXdlYmtpdC10ZXh0LWRlY29y YXRpb25zLWluLWVmZmVjdAorICAgIEFTU0VSVCghc2hvdWxkQW5ub3RhdGUoKSB8fCBwcm9wZXJ0 eU1pc3NpbmdPckVxdWFsVG9Ob25lKHN0eWxlLCBDU1NQcm9wZXJ0eVdlYmtpdFRleHREZWNvcmF0 aW9uc0luRWZmZWN0KSk7CiAgICAgaWYgKGlzQmxvY2spCiAgICAgICAgIG91dC5hcHBlbmQoIjxk aXYgc3R5bGU9XCIiKTsKICAgICBlbHNlCi0tIAoyLjI1LjEKCg==