202895 2019-10-13 09:15:33 -0700 Fix compilation of Crypto.cpp on macOS with !WEB_CRYPTO 2019-10-15 15:10:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annulen annulen ews-watchlist jiewen_tan lingcherd_ho webkit-bug-importer oldest_to_newest 1579494 0 annulen 2019-10-13 09:15:33 -0700 Crypto.cpp does not use getCommonCryptoDigestAlgorithm(), defined in CommonCryptoUtilities.h, but requires CommonCrypto includes which are coming with it. However, when WEB_CRYPTO is disabled necessary transitive includes are missing. 1579495 1 380847 annulen 2019-10-13 09:17:04 -0700 Created attachment 380847 Patch 1579505 2 380847 annulen 2019-10-13 12:25:50 -0700 Comment on attachment 380847 Patch Clearing flags on attachment: 380847 Committed r251061: <https://trac.webkit.org/changeset/251061> 1579506 3 annulen 2019-10-13 12:25:54 -0700 All reviewed patches have been landed. Closing bug. 1580300 4 lingcherd_ho 2019-10-15 15:10:50 -0700 <rdar://problem/56232550> 380847 2019-10-13 09:17:04 -0700 2019-10-13 12:25:50 -0700 Patch bug-202895-20191013191703.patch text/plain 1375 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmVjNmM1OGVhMjYzMTIx YzcwZjkxNGE3NDcyZjk5NjMwZTBjNjFjNy4uNWI1YmNhY2QwYzllNTgyNzRiNTgzZDc5MTkwZDIz NTMwNjg4NzJiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTEwLTEzICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBGaXggY29tcGls YXRpb24gb2YgQ3J5cHRvLmNwcCBvbiBtYWNPUyB3aXRoICFXRUJfQ1JZUFRPCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI4OTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDcnlwdG8uY3BwIGRvZXMgbm90 IHVzZSBnZXRDb21tb25DcnlwdG9EaWdlc3RBbGdvcml0aG0oKSwgZGVmaW5lZCBpbgorICAgICAg ICBDb21tb25DcnlwdG9VdGlsaXRpZXMuaCwgYnV0IHJlcXVpcmVzIENvbW1vbkNyeXB0byBpbmNs dWRlcyB3aGljaCBhcmUKKyAgICAgICAgY29taW5nIHdpdGggaXQuIEhvd2V2ZXIsIHdoZW4gV0VC X0NSWVBUTyBpcyBkaXNhYmxlZCBuZWNlc3NhcnkKKyAgICAgICAgdHJhbnNpdGl2ZSBpbmNsdWRl cyBhcmUgbWlzc2luZy4KKworICAgICAgICAqIHBhZ2UvQ3J5cHRvLmNwcDoKKwogMjAxOS0xMC0x MyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBDb252 ZXJ0IExpbmVCb3hDb250YWluIHRvIHVzZSBhbiBPcHRpb25TZXQ8PgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9DcnlwdG8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9DcnlwdG8u Y3BwCmluZGV4IDY5YzM2ZTk3MWI3M2MxYWNjZjBkNDBkMmQwYWQ1Y2UwYzQ0ZWU3YTQuLmI5OWZl MTM3MDA5OTcxNzNiMGQ5NGI5ZmJiZTY0M2ZjNjU3YjAzZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvQ3J5cHRvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NyeXB0by5j cHAKQEAgLTM3LDcgKzM3LDggQEAKICNpbmNsdWRlIDx3dGYvQ3J5cHRvZ3JhcGhpY2FsbHlSYW5k b21OdW1iZXIuaD4KIAogI2lmIE9TKERBUldJTikKLSNpbmNsdWRlICJDb21tb25DcnlwdG9VdGls aXRpZXMuaCIKKyNpbmNsdWRlIDxDb21tb25DcnlwdG8vQ29tbW9uQ3J5cHRvci5oPgorI2luY2x1 ZGUgPENvbW1vbkNyeXB0by9Db21tb25SYW5kb20uaD4KICNlbmRpZgogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7Cg==