<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>202893</bug_id>
          
          <creation_ts>2019-10-13 06:53:15 -0700</creation_ts>
          <short_desc>Wincairo build broken: EventLoop.h: No such file or directory</short_desc>
          <delta_ts>2019-10-15 15:11:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=202879</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Stephan Szabo">stephan.szabo</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>achristensen</cc>
    
    <cc>basuke</cc>
    
    <cc>commit-queue</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>galpeter</cc>
    
    <cc>lingcherd_ho</cc>
    
    <cc>stephan.szabo</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1579482</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-10-13 06:53:15 -0700</bug_when>
    <thetext>Wincairo build seems to be broken recently. There was a build fix in https://bugs.webkit.org/show_bug.cgi?id=202879, however, the build is now failing with another error:

&quot;..\..\Source\WebCore\platform\network\curl\SynchronousLoaderClientCurl.cpp(32): fatal error C1083: Cannot open include file: &apos;EventLoop.h&apos;: No such file or directory&quot;

e.g.: https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/11048</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1579496</commentid>
    <comment_count>1</comment_count>
      <attachid>380848</attachid>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2019-10-13 09:22:57 -0700</bug_when>
    <thetext>Created attachment 380848
Patch removing include of EventLoop.h

This built for me and things I tried in minibrowser seemed to work just without the include.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1579540</commentid>
    <comment_count>2</comment_count>
      <attachid>380848</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-10-13 16:49:09 -0700</bug_when>
    <thetext>Comment on attachment 380848
Patch removing include of EventLoop.h

Clearing flags on attachment: 380848

Committed r251062: &lt;https://trac.webkit.org/changeset/251062&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1579541</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-10-13 16:49:11 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1580302</commentid>
    <comment_count>4</comment_count>
    <who name="Ling Ho">lingcherd_ho</who>
    <bug_when>2019-10-15 15:11:37 -0700</bug_when>
    <thetext>&lt;rdar://problem/56234491&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>380848</attachid>
            <date>2019-10-13 09:22:57 -0700</date>
            <delta_ts>2019-10-13 16:49:09 -0700</delta_ts>
            <desc>Patch removing include of EventLoop.h</desc>
            <filename>202893-1.diff</filename>
            <type>text/plain</type>
            <size>1171</size>
            <attacher name="Stephan Szabo">stephan.szabo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA5ZWI4MTVmYzI4Ny4uMjk1M2M2MmQyNGUgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxOS0xMC0xMyAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29u
eS5jb20+CisKKyAgICAgICAgV2luY2Fpcm8gYnVpbGQgYnJva2VuOiBFdmVudExvb3AuaDogTm8g
c3VjaCBmaWxlIG9yIGRpcmVjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MjAyODkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgUmVtb3ZlIGluY2x1ZGUgb2YgRXZlbnRMb29wLmguCisKKyAgICAgICAg
KiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvU3luY2hyb25vdXNMb2FkZXJDbGllbnRDdXJsLmNwcDoK
KwogMjAxOS0xMC0xMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg
ICBbaU9TXSBDcmFzaCBpbiBXZWJDb3JlOjpET01XaW5kb3c6OmluY3JlbWVudFNjcm9sbEV2ZW50
TGlzdGVuZXJzQ291bnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv
cmsvY3VybC9TeW5jaHJvbm91c0xvYWRlckNsaWVudEN1cmwuY3BwIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vbmV0d29yay9jdXJsL1N5bmNocm9ub3VzTG9hZGVyQ2xpZW50Q3VybC5jcHAKaW5k
ZXggM2IzOTMwNzcxZTQuLjgxYWZmYWJiNzdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9uZXR3b3JrL2N1cmwvU3luY2hyb25vdXNMb2FkZXJDbGllbnRDdXJsLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvU3luY2hyb25vdXNMb2FkZXJD
bGllbnRDdXJsLmNwcApAQCAtMjksNyArMjksNiBAQAogI2luY2x1ZGUgIlN5bmNocm9ub3VzTG9h
ZGVyQ2xpZW50LmgiCiAKICNpbmNsdWRlICJBdXRoZW50aWNhdGlvbkNoYWxsZW5nZS5oIgotI2lu
Y2x1ZGUgIkV2ZW50TG9vcC5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVk
ZSAiUmVzb3VyY2VIYW5kbGVJbnRlcm5hbC5oIgogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>