<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>20289</bug_id>
          
          <creation_ts>2008-08-05 12:46:55 -0700</creation_ts>
          <short_desc>[qt] screenDepthPerComponent returns the wrong value</short_desc>
          <delta_ts>2010-11-07 07:26:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>EasyFix, Qt</keywords>
          <priority>P5</priority>
          <bug_severity>Minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Marco Barisione">marco.barisione</reporter>
          <assigned_to name="QtWebKit Unassigned">webkit-qt-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>pierre-luc.beaudoin</cc>
    
    <cc>vestbo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>87883</commentid>
    <comment_count>0</comment_count>
    <who name="Marco Barisione">marco.barisione</who>
    <bug_when>2008-08-05 12:46:55 -0700</bug_when>
    <thetext>Reading the code in other ports and from its name it seems that screenDepthPerComponent should return the number of pixels for each colour (for instance 8 if the screen depth is 24), but in the qt port it seems to just return the screen depth (24 in the example).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>197956</commentid>
    <comment_count>1</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2010-03-10 03:23:47 -0800</bug_when>
    <thetext>http://www.w3.org/TR/css3-mediaqueries/#color</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>305875</commentid>
    <comment_count>2</comment_count>
      <attachid>73194</attachid>
    <who name="Robert Hogan">robert</who>
    <bug_when>2010-11-07 05:34:00 -0800</bug_when>
    <thetext>Created attachment 73194
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>305876</commentid>
    <comment_count>3</comment_count>
      <attachid>73194</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-11-07 05:40:58 -0800</bug_when>
    <thetext>Comment on attachment 73194
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73194&amp;action=review

&gt; WebCore/ChangeLog:10
&gt; +        No layout tests possible for this I think.

On the contrary! :-)
http://www.w3.org/TR/css3-mediaqueries/#color</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>305882</commentid>
    <comment_count>4</comment_count>
      <attachid>73195</attachid>
    <who name="Robert Hogan">robert</who>
    <bug_when>2010-11-07 06:41:38 -0800</bug_when>
    <thetext>Created attachment 73195
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>305883</commentid>
    <comment_count>5</comment_count>
      <attachid>73195</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-11-07 07:04:56 -0800</bug_when>
    <thetext>Comment on attachment 73195
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73195&amp;action=review

LGTM.

&gt; WebCore/ChangeLog:14
&gt; +        Need a short description and bug URL (OOPS!)

Oops, indeed. Remove this when landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>305884</commentid>
    <comment_count>6</comment_count>
      <attachid>73196</attachid>
    <who name="Robert Hogan">robert</who>
    <bug_when>2010-11-07 07:10:01 -0800</bug_when>
    <thetext>Created attachment 73196
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>305885</commentid>
    <comment_count>7</comment_count>
      <attachid>73196</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-11-07 07:26:03 -0800</bug_when>
    <thetext>Comment on attachment 73196
Patch

Clearing flags on attachment: 73196

Committed r71483: &lt;http://trac.webkit.org/changeset/71483&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>305886</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-11-07 07:26:09 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>73194</attachid>
            <date>2010-11-07 05:34:00 -0800</date>
            <delta_ts>2010-11-07 06:41:32 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-20289-20101107133358.patch</filename>
            <type>text/plain</type>
            <size>2120</size>
            <attacher name="Robert Hogan">robert</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZThmMGU2OTFmMWM5YjhkZmEyNDhjMWMxZmVhYjU2OTJkNjA0MTEyOC4uMjFmNmFlZTRlZDZlMDQ4
OGE1NmI4YmI5ZWIxZTY2MDU2MTliOGFhOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMS0wNyAgUm9i
ZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgW3F0XSBzY3JlZW5EZXB0aFBlckNvbXBvbmVudCByZXR1
cm5zIHRoZSB3cm9uZyB2YWx1ZQorCisgICAgICAgIFJldHVybiBiZXN0IGVzdGltYXRlIG9mIHRo
ZSBudW1iZXIgb2YgYml0cyBwZXIgY29sb3IKKyAgICAgICAgcmF0aGVyIHRoYW4gc2NyZWVuIGRl
cHRoLgorCisgICAgICAgIE5vIGxheW91dCB0ZXN0cyBwb3NzaWJsZSBmb3IgdGhpcyBJIHRoaW5r
LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI4
OQorCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxhdGZvcm1TY3JlZW5RdC5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpzY3JlZW5EZXB0aFBlckNvbXBvbmVudCk6CisKIDIwMTAtMTEtMDcgIENoYW5n
IFNodSAgPGNoYW5nLnNodUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25p
byBHb21lcy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1TY3JlZW5R
dC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtU2NyZWVuUXQuY3BwCmluZGV4IDgy
MjE3NjA4ODU0MjljMTJiMjFlZjRlOTQzZGQwZTc4ZDMyMzc0ZjMuLmRiMzRlMjE2YTRlYWIxNzdm
NGE4Yjc4ODBkN2RkMGMxMmYzM2U0MWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQv
UGxhdGZvcm1TY3JlZW5RdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybVNj
cmVlblF0LmNwcApAQCAtNTgsMTYgKzU4LDMwIEBAIGludCBzY3JlZW5EZXB0aChXaWRnZXQqIHcp
CiAKIGludCBzY3JlZW5EZXB0aFBlckNvbXBvbmVudChXaWRnZXQqIHcpCiB7CisgICAgaW50IGRl
cHRoID0gUUFwcGxpY2F0aW9uOjpkZXNrdG9wKCktPnNjcmVlbigwKS0+ZGVwdGgoKTsKICAgICBp
ZiAodykgewogICAgICAgICBRV2ViUGFnZUNsaWVudCogY2xpZW50ID0gdy0+cm9vdCgpLT5ob3N0
V2luZG93KCktPnBsYXRmb3JtUGFnZUNsaWVudCgpOwogCiAgICAgICAgIGlmIChjbGllbnQpIHsK
ICAgICAgICAgICAgIFFXaWRnZXQqIHZpZXcgPSBjbGllbnQtPm93bmVyV2lkZ2V0KCk7CiAgICAg
ICAgICAgICBpZiAodmlldykKLSAgICAgICAgICAgICAgICByZXR1cm4gdmlldy0+ZGVwdGgoKTsK
KyAgICAgICAgICAgICAgICBkZXB0aCA9IHZpZXctPmRlcHRoKCk7CiAgICAgICAgIH0KICAgICB9
Ci0gICAgcmV0dXJuIFFBcHBsaWNhdGlvbjo6ZGVza3RvcCgpLT5zY3JlZW4oMCktPmRlcHRoKCk7
CisgICAgLy8gQW4gaW50ZXJmYWNlIHRvIGVzdGFibGlzaCB0aGUgYWN0dWFsIG51bWJlciBvZiBi
aXRzIHBlciBjb2xvcgorICAgIC8vIGRvZXNuJ3QgZXhpc3QgaW4gUXQsIG9yIHByb2JhYmx5IGF0
IGFsbCwgc28gdXNlIGNvbW1vbi1zZW5zZQorICAgIC8vIHZhbHVlcyBmb3IgZWFjaCBzY3JlZW4g
ZGVwdGggYW5kIGFzc3VtZSBSR0IvUkdCQSB3aGVyZSBhcHByb3ByaWF0ZS4KKyAgICAvLyBQZXIg
aHR0cDovL3d3dy53My5vcmcvVFIvY3NzMy1tZWRpYXF1ZXJpZXMvI2NvbG9yLCAnSWYgZGlmZmVy
ZW50IGNvbG9yCisgICAgLy8gY29tcG9uZW50cyBhcmUgcmVwcmVzZW50ZWQgYnkgZGlmZmVyZW50
IG51bWJlciBvZiBiaXRzLCB0aGUgc21hbGxlc3QKKyAgICAvLyBudW1iZXIgaXMgdXNlZC4nCisg
ICAgc3dpdGNoIChkZXB0aCkgeworICAgIGNhc2UgODoKKyAgICAgICAgcmV0dXJuIDI7CisgICAg
Y2FzZSAzMjoKKyAgICAgICAgcmV0dXJuIDg7CisgICAgZGVmYXVsdDoKKyAgICAgICAgcmV0dXJu
IHFSb3VuZChkZXB0aCAvIDMpOworICAgIH0KIH0KIAogYm9vbCBzY3JlZW5Jc01vbm9jaHJvbWUo
V2lkZ2V0KiB3KQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>73195</attachid>
            <date>2010-11-07 06:41:38 -0800</date>
            <delta_ts>2010-11-07 07:09:56 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-20289-20101107144136.patch</filename>
            <type>text/plain</type>
            <size>5393</size>
            <attacher name="Robert Hogan">robert</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBmODQ4YTY1ODkzODA5YWIxZDEyYzA4MTdiNDVhMzFjYjQzMmViY2E5Li5lZDAwODky
NDJhZWZiZWZhZTI5YTEyN2NmMTFmNTM4Y2U3NzEyOTMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK
KzIwMTAtMTEtMDcgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtxdF0gc2NyZWVuRGVwdGhQ
ZXJDb21wb25lbnQgcmV0dXJucyB0aGUgd3JvbmcgdmFsdWUKKworICAgICAgICBSZXR1cm4gYmVz
dCBlc3RpbWF0ZSBvZiB0aGUgbnVtYmVyIG9mIGJpdHMgcGVyIGNvbG9yCisgICAgICAgIHJhdGhl
ciB0aGFuIHNjcmVlbiBkZXB0aC4KKworICAgICAgICBBZGQgYSBsYXlvdXQgdGVzdCB0byBzYW5p
dHkgY2hlY2sgc2NyZWVuRGVwdGhQZXJDb21wb25lbnQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjg5CisKKyAgICAgICAgKiBmYXN0L2Nzcy9t
ZWRpYS1ydWxlLXNjcmVlbkRlcHRoUGVyQ29tcG9uZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisg
ICAgICAgICogZmFzdC9jc3MvbWVkaWEtcnVsZS1zY3JlZW5EZXB0aFBlckNvbXBvbmVudC5odG1s
OiBBZGRlZC4KKwogMjAxMC0xMS0wNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu
b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBRdCBzcGVjaWZpYyBleHBlY3RlZCBm
aWxlcyBhZnRlciByNzE0NjcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9tZWRp
YS1ydWxlLXNjcmVlbkRlcHRoUGVyQ29tcG9uZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz
L2Zhc3QvY3NzL21lZGlhLXJ1bGUtc2NyZWVuRGVwdGhQZXJDb21wb25lbnQtZXhwZWN0ZWQudHh0
Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAuLjUzMGNkMjQwN2EzNzlmZjBhMmRkZDVkODFkMzk5YTczOGY1ZDNmZjIKLS0t
IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9tZWRpYS1ydWxlLXNjcmVlbkRl
cHRoUGVyQ29tcG9uZW50LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK2h0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI4OQorCitTYW5pdHkgY2hlY2sgc2NyZWVu
RGVwdGhQZXJDb21wb25lbnQgdG8gZW5zdXJlIGl0IGlzIHJldHVybmluZyB0aGUgbnVtYmVyIG9m
IGJpdHMgcGVyIGNvbG9yIHJhdGhlciB0aGFuIHRoZSBzY3JlZW4gZGVwdGggKGUuZy4gMjQpLgor
U2hvdWxkIGJlIHJnYigwLCAwLCAwKTogcmdiKDAsIDAsIDApCitTaG91bGQgYmUgcmdiKDAsIDEy
OCwgMCk6IHJnYigwLCAxMjgsIDApCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9t
ZWRpYS1ydWxlLXNjcmVlbkRlcHRoUGVyQ29tcG9uZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0
L2Nzcy9tZWRpYS1ydWxlLXNjcmVlbkRlcHRoUGVyQ29tcG9uZW50Lmh0bWwKbmV3IGZpbGUgbW9k
ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u
NDFhMTMzOTBmYTlkMDI3YjFiM2E1NmY5ZWRhYWI2MzM2M2Q0MTFiMAotLS0gL2Rldi9udWxsCisr
KyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL21lZGlhLXJ1bGUtc2NyZWVuRGVwdGhQZXJDb21wb25l
bnQuaHRtbApAQCAtMCwwICsxLDI3IEBACis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHN0
eWxlIGlkPSJzdHlsZTEiPgorICAgICAgICAgICAgQG1lZGlhIGFsbCBhbmQgKG1pbi1jb2xvcjog
MjQpIHsgLmluc2FuZSB7IGNvbG9yOiBncmVlbjsgfSB9CisgICAgICAgICAgICBAbWVkaWEgYWxs
IGFuZCAobWluLWNvbG9yOiAyKSB7IC5zYW5lIHsgY29sb3I6IGdyZWVuOyB9IH0KKyAgICAgICAg
PC9zdHlsZT4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgICAgIGZ1bmN0aW9uIHJ1blRlc3Qo
KSB7CisgICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg
ICAgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisg
ICAgICAgICAgICAgICAgdHJ5IHsKKyAgICAgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxl
bWVudEJ5SWQoJ3Jlc3VsdCcpLmlubmVySFRNTCArPSB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShk
b2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0JykpLmdldFByb3BlcnR5VmFsdWUoImNvbG9y
Iik7CisgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQy
JykuaW5uZXJIVE1MICs9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1l
bnRCeUlkKCdyZXN1bHQyJykpLmdldFByb3BlcnR5VmFsdWUoImNvbG9yIik7CisgICAgICAgICAg
ICAgICAgfSBjYXRjaCAoZSkgeworICAgICAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVt
ZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MID0gJ0VYQ0VQVElPTic7CisgICAgICAgICAgICAg
ICAgfQorICAgICAgICAgICAgfQorICAgICAgICA8L3NjcmlwdD4KKyAgICA8L2hlYWQ+CisgICAg
PGJvZHkgb25sb2FkPSJydW5UZXN0KCk7Ij4KKyAgICAgICAgPHA+IGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI4OSA8L3A+CisgICAgICAgIFNhbml0eSBjaGVjayBz
Y3JlZW5EZXB0aFBlckNvbXBvbmVudCB0byBlbnN1cmUgaXQgaXMgcmV0dXJuaW5nIHRoZSBudW1i
ZXIgb2YgYml0cyBwZXIgY29sb3IgcmF0aGVyIHRoYW4gdGhlIHNjcmVlbiBkZXB0aCAoZS5nLiAy
NCkuCisgICAgICAgIDxkaXYgY2xhc3M9Imluc2FuZSIgaWQ9InJlc3VsdCI+U2hvdWxkIGJlIHJn
YigwLCAwLCAwKTogPC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9InNhbmUiIGlkPSJyZXN1bHQy
Ij5TaG91bGQgYmUgcmdiKDAsIDEyOCwgMCk6IDwvZGl2PgorICAgIDwvYm9keT4KKzwvaHRtbD4K
ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZThmMGU2OTFmMWM5YjhkZmEyNDhjMWMxZmVhYjU2OTJkNjA0MTEyOC4uOWYwNGU2MGQ2YWIzNDNj
MTRlZGY0MTY1OGQwMWYxZWVlZjk0OGY1NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0xMS0wNyAgUm9i
ZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgW3F0XSBzY3JlZW5EZXB0aFBlckNvbXBvbmVudCByZXR1
cm5zIHRoZSB3cm9uZyB2YWx1ZQorCisgICAgICAgIFJldHVybiBiZXN0IGVzdGltYXRlIG9mIHRo
ZSBudW1iZXIgb2YgYml0cyBwZXIgY29sb3IKKyAgICAgICAgcmF0aGVyIHRoYW4gc2NyZWVuIGRl
cHRoLgorCisgICAgICAgIEFkZCBhIGxheW91dCB0ZXN0IHRvIHNhbml0eSBjaGVjayBzY3JlZW5E
ZXB0aFBlckNvbXBvbmVudC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MjAyODkKKworICAgICAgICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5k
IGJ1ZyBVUkwgKE9PUFMhKQorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL21lZGlhLXJ1bGUtc2Ny
ZWVuRGVwdGhQZXJDb21wb25lbnQuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxhdGZv
cm1TY3JlZW5RdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5EZXB0aFBlckNvbXBvbmVu
dCk6CisKIDIwMTAtMTEtMDcgIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5jb20+CiAKICAg
ICAgICAgUmV2aWV3ZWQgYnkgQW50b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh
dGZvcm0vcXQvUGxhdGZvcm1TY3JlZW5RdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRm
b3JtU2NyZWVuUXQuY3BwCmluZGV4IDgyMjE3NjA4ODU0MjljMTJiMjFlZjRlOTQzZGQwZTc4ZDMy
Mzc0ZjMuLmRiMzRlMjE2YTRlYWIxNzdmNGE4Yjc4ODBkN2RkMGMxMmYzM2U0MWYgMTAwNjQ0Ci0t
LSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1TY3JlZW5RdC5jcHAKKysrIGIvV2ViQ29y
ZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybVNjcmVlblF0LmNwcApAQCAtNTgsMTYgKzU4LDMwIEBAIGlu
dCBzY3JlZW5EZXB0aChXaWRnZXQqIHcpCiAKIGludCBzY3JlZW5EZXB0aFBlckNvbXBvbmVudChX
aWRnZXQqIHcpCiB7CisgICAgaW50IGRlcHRoID0gUUFwcGxpY2F0aW9uOjpkZXNrdG9wKCktPnNj
cmVlbigwKS0+ZGVwdGgoKTsKICAgICBpZiAodykgewogICAgICAgICBRV2ViUGFnZUNsaWVudCog
Y2xpZW50ID0gdy0+cm9vdCgpLT5ob3N0V2luZG93KCktPnBsYXRmb3JtUGFnZUNsaWVudCgpOwog
CiAgICAgICAgIGlmIChjbGllbnQpIHsKICAgICAgICAgICAgIFFXaWRnZXQqIHZpZXcgPSBjbGll
bnQtPm93bmVyV2lkZ2V0KCk7CiAgICAgICAgICAgICBpZiAodmlldykKLSAgICAgICAgICAgICAg
ICByZXR1cm4gdmlldy0+ZGVwdGgoKTsKKyAgICAgICAgICAgICAgICBkZXB0aCA9IHZpZXctPmRl
cHRoKCk7CiAgICAgICAgIH0KICAgICB9Ci0gICAgcmV0dXJuIFFBcHBsaWNhdGlvbjo6ZGVza3Rv
cCgpLT5zY3JlZW4oMCktPmRlcHRoKCk7CisgICAgLy8gQW4gaW50ZXJmYWNlIHRvIGVzdGFibGlz
aCB0aGUgYWN0dWFsIG51bWJlciBvZiBiaXRzIHBlciBjb2xvcgorICAgIC8vIGRvZXNuJ3QgZXhp
c3QgaW4gUXQsIG9yIHByb2JhYmx5IGF0IGFsbCwgc28gdXNlIGNvbW1vbi1zZW5zZQorICAgIC8v
IHZhbHVlcyBmb3IgZWFjaCBzY3JlZW4gZGVwdGggYW5kIGFzc3VtZSBSR0IvUkdCQSB3aGVyZSBh
cHByb3ByaWF0ZS4KKyAgICAvLyBQZXIgaHR0cDovL3d3dy53My5vcmcvVFIvY3NzMy1tZWRpYXF1
ZXJpZXMvI2NvbG9yLCAnSWYgZGlmZmVyZW50IGNvbG9yCisgICAgLy8gY29tcG9uZW50cyBhcmUg
cmVwcmVzZW50ZWQgYnkgZGlmZmVyZW50IG51bWJlciBvZiBiaXRzLCB0aGUgc21hbGxlc3QKKyAg
ICAvLyBudW1iZXIgaXMgdXNlZC4nCisgICAgc3dpdGNoIChkZXB0aCkgeworICAgIGNhc2UgODoK
KyAgICAgICAgcmV0dXJuIDI7CisgICAgY2FzZSAzMjoKKyAgICAgICAgcmV0dXJuIDg7CisgICAg
ZGVmYXVsdDoKKyAgICAgICAgcmV0dXJuIHFSb3VuZChkZXB0aCAvIDMpOworICAgIH0KIH0KIAog
Ym9vbCBzY3JlZW5Jc01vbm9jaHJvbWUoV2lkZ2V0KiB3KQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>73196</attachid>
            <date>2010-11-07 07:10:01 -0800</date>
            <delta_ts>2010-11-07 07:26:03 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-20289-20101107151000.patch</filename>
            <type>text/plain</type>
            <size>5335</size>
            <attacher name="Robert Hogan">robert</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBmODQ4YTY1ODkzODA5YWIxZDEyYzA4MTdiNDVhMzFjYjQzMmViY2E5Li4wY2ZlM2U1
ZmQxNjUyZWM4YmQ3NDYzMjhiNTZjODA4Y2UyNmIwMDkyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK
KzIwMTAtMTEtMDcgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg
IFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCisKKyAgICAgICAgW3F0XSBzY3JlZW5EZXB0aFBl
ckNvbXBvbmVudCByZXR1cm5zIHRoZSB3cm9uZyB2YWx1ZQorCisgICAgICAgIFJldHVybiBiZXN0
IGVzdGltYXRlIG9mIHRoZSBudW1iZXIgb2YgYml0cyBwZXIgY29sb3IKKyAgICAgICAgcmF0aGVy
IHRoYW4gc2NyZWVuIGRlcHRoLgorCisgICAgICAgIEFkZCBhIGxheW91dCB0ZXN0IHRvIHNhbml0
eSBjaGVjayBzY3JlZW5EZXB0aFBlckNvbXBvbmVudC4KKworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyODkKKworICAgICAgICAqIGZhc3QvY3NzL21l
ZGlhLXJ1bGUtc2NyZWVuRGVwdGhQZXJDb21wb25lbnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg
ICAgICAgKiBmYXN0L2Nzcy9tZWRpYS1ydWxlLXNjcmVlbkRlcHRoUGVyQ29tcG9uZW50Lmh0bWw6
IEFkZGVkLgorCiAyMDEwLTExLTA2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5v
cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIFF0IHNwZWNpZmljIGV4cGVjdGVkIGZp
bGVzIGFmdGVyIHI3MTQ2Ny4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL21lZGlh
LXJ1bGUtc2NyZWVuRGVwdGhQZXJDb21wb25lbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv
ZmFzdC9jc3MvbWVkaWEtcnVsZS1zY3JlZW5EZXB0aFBlckNvbXBvbmVudC1leHBlY3RlZC50eHQK
bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMC4uNTMwY2QyNDA3YTM3OWZmMGEyZGRkNWQ4MWQzOTlhNzM4ZjVkM2ZmMgotLS0g
L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL21lZGlhLXJ1bGUtc2NyZWVuRGVw
dGhQZXJDb21wb25lbnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAoraHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjg5CisKK1Nhbml0eSBjaGVjayBzY3JlZW5E
ZXB0aFBlckNvbXBvbmVudCB0byBlbnN1cmUgaXQgaXMgcmV0dXJuaW5nIHRoZSBudW1iZXIgb2Yg
Yml0cyBwZXIgY29sb3IgcmF0aGVyIHRoYW4gdGhlIHNjcmVlbiBkZXB0aCAoZS5nLiAyNCkuCitT
aG91bGQgYmUgcmdiKDAsIDAsIDApOiByZ2IoMCwgMCwgMCkKK1Nob3VsZCBiZSByZ2IoMCwgMTI4
LCAwKTogcmdiKDAsIDEyOCwgMCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL21l
ZGlhLXJ1bGUtc2NyZWVuRGVwdGhQZXJDb21wb25lbnQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv
Y3NzL21lZGlhLXJ1bGUtc2NyZWVuRGVwdGhQZXJDb21wb25lbnQuaHRtbApuZXcgZmlsZSBtb2Rl
IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40
MWExMzM5MGZhOWQwMjdiMWIzYTU2ZjllZGFhYjYzMzYzZDQxMWIwCi0tLSAvZGV2L251bGwKKysr
IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbWVkaWEtcnVsZS1zY3JlZW5EZXB0aFBlckNvbXBvbmVu
dC5odG1sCkBAIC0wLDAgKzEsMjcgQEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8c3R5
bGUgaWQ9InN0eWxlMSI+CisgICAgICAgICAgICBAbWVkaWEgYWxsIGFuZCAobWluLWNvbG9yOiAy
NCkgeyAuaW5zYW5lIHsgY29sb3I6IGdyZWVuOyB9IH0KKyAgICAgICAgICAgIEBtZWRpYSBhbGwg
YW5kIChtaW4tY29sb3I6IDIpIHsgLnNhbmUgeyBjb2xvcjogZ3JlZW47IH0gfQorICAgICAgICA8
L3N0eWxlPgorICAgICAgICA8c2NyaXB0PgorICAgICAgICAgICAgZnVuY3Rpb24gcnVuVGVzdCgp
IHsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg
ICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAg
ICAgICAgICAgICAgICB0cnkgeworICAgICAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVt
ZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MICs9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRv
Y3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKSkuZ2V0UHJvcGVydHlWYWx1ZSgiY29sb3Ii
KTsKKyAgICAgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jlc3VsdDIn
KS5pbm5lckhUTUwgKz0gd2luZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVu
dEJ5SWQoJ3Jlc3VsdDInKSkuZ2V0UHJvcGVydHlWYWx1ZSgiY29sb3IiKTsKKyAgICAgICAgICAg
ICAgICB9IGNhdGNoIChlKSB7CisgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1l
bnRCeUlkKCdyZXN1bHQnKS5pbm5lckhUTUwgPSAnRVhDRVBUSU9OJzsKKyAgICAgICAgICAgICAg
ICB9CisgICAgICAgICAgICB9CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8
Ym9keSBvbmxvYWQ9InJ1blRlc3QoKTsiPgorICAgICAgICA8cD4gaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjg5IDwvcD4KKyAgICAgICAgU2FuaXR5IGNoZWNrIHNj
cmVlbkRlcHRoUGVyQ29tcG9uZW50IHRvIGVuc3VyZSBpdCBpcyByZXR1cm5pbmcgdGhlIG51bWJl
ciBvZiBiaXRzIHBlciBjb2xvciByYXRoZXIgdGhhbiB0aGUgc2NyZWVuIGRlcHRoIChlLmcuIDI0
KS4KKyAgICAgICAgPGRpdiBjbGFzcz0iaW5zYW5lIiBpZD0icmVzdWx0Ij5TaG91bGQgYmUgcmdi
KDAsIDAsIDApOiA8L2Rpdj4KKyAgICAgICAgPGRpdiBjbGFzcz0ic2FuZSIgaWQ9InJlc3VsdDIi
PlNob3VsZCBiZSByZ2IoMCwgMTI4LCAwKTogPC9kaXY+CisgICAgPC9ib2R5PgorPC9odG1sPgpk
aWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBl
OGYwZTY5MWYxYzliOGRmYTI0OGMxYzFmZWFiNTY5MmQ2MDQxMTI4Li40ODkxMzkwODVhNDI2ZjVi
YThiODY3NTliMmJhYTk0YjZlZDI2NGJmIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZwor
KysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEwLTExLTA3ICBSb2Jl
cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBBbmRy
ZWFzIEtsaW5nLgorCisgICAgICAgIFtxdF0gc2NyZWVuRGVwdGhQZXJDb21wb25lbnQgcmV0dXJu
cyB0aGUgd3JvbmcgdmFsdWUKKworICAgICAgICBSZXR1cm4gYmVzdCBlc3RpbWF0ZSBvZiB0aGUg
bnVtYmVyIG9mIGJpdHMgcGVyIGNvbG9yCisgICAgICAgIHJhdGhlciB0aGFuIHNjcmVlbiBkZXB0
aC4KKworICAgICAgICBBZGQgYSBsYXlvdXQgdGVzdCB0byBzYW5pdHkgY2hlY2sgc2NyZWVuRGVw
dGhQZXJDb21wb25lbnQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMjg5CisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvbWVkaWEtcnVsZS1zY3Jl
ZW5EZXB0aFBlckNvbXBvbmVudC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9QbGF0Zm9y
bVNjcmVlblF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNjcmVlbkRlcHRoUGVyQ29tcG9uZW50
KToKKwogMjAxMC0xMS0wNyAgQ2hhbmcgU2h1ICA8Y2hhbmcuc2h1QG5va2lhLmNvbT4KIAogICAg
ICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0
Zm9ybS9xdC9QbGF0Zm9ybVNjcmVlblF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZv
cm1TY3JlZW5RdC5jcHAKaW5kZXggODIyMTc2MDg4NTQyOWMxMmIyMWVmNGU5NDNkZDBlNzhkMzIz
NzRmMy4uZGIzNGUyMTZhNGVhYjE3N2Y0YThiNzg4MGQ3ZGQwYzEyZjMzZTQxZiAxMDA2NDQKLS0t
IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybVNjcmVlblF0LmNwcAorKysgYi9XZWJDb3Jl
L3BsYXRmb3JtL3F0L1BsYXRmb3JtU2NyZWVuUXQuY3BwCkBAIC01OCwxNiArNTgsMzAgQEAgaW50
IHNjcmVlbkRlcHRoKFdpZGdldCogdykKIAogaW50IHNjcmVlbkRlcHRoUGVyQ29tcG9uZW50KFdp
ZGdldCogdykKIHsKKyAgICBpbnQgZGVwdGggPSBRQXBwbGljYXRpb246OmRlc2t0b3AoKS0+c2Ny
ZWVuKDApLT5kZXB0aCgpOwogICAgIGlmICh3KSB7CiAgICAgICAgIFFXZWJQYWdlQ2xpZW50KiBj
bGllbnQgPSB3LT5yb290KCktPmhvc3RXaW5kb3coKS0+cGxhdGZvcm1QYWdlQ2xpZW50KCk7CiAK
ICAgICAgICAgaWYgKGNsaWVudCkgewogICAgICAgICAgICAgUVdpZGdldCogdmlldyA9IGNsaWVu
dC0+b3duZXJXaWRnZXQoKTsKICAgICAgICAgICAgIGlmICh2aWV3KQotICAgICAgICAgICAgICAg
IHJldHVybiB2aWV3LT5kZXB0aCgpOworICAgICAgICAgICAgICAgIGRlcHRoID0gdmlldy0+ZGVw
dGgoKTsKICAgICAgICAgfQogICAgIH0KLSAgICByZXR1cm4gUUFwcGxpY2F0aW9uOjpkZXNrdG9w
KCktPnNjcmVlbigwKS0+ZGVwdGgoKTsKKyAgICAvLyBBbiBpbnRlcmZhY2UgdG8gZXN0YWJsaXNo
IHRoZSBhY3R1YWwgbnVtYmVyIG9mIGJpdHMgcGVyIGNvbG9yCisgICAgLy8gZG9lc24ndCBleGlz
dCBpbiBRdCwgb3IgcHJvYmFibHkgYXQgYWxsLCBzbyB1c2UgY29tbW9uLXNlbnNlCisgICAgLy8g
dmFsdWVzIGZvciBlYWNoIHNjcmVlbiBkZXB0aCBhbmQgYXNzdW1lIFJHQi9SR0JBIHdoZXJlIGFw
cHJvcHJpYXRlLgorICAgIC8vIFBlciBodHRwOi8vd3d3LnczLm9yZy9UUi9jc3MzLW1lZGlhcXVl
cmllcy8jY29sb3IsICdJZiBkaWZmZXJlbnQgY29sb3IKKyAgICAvLyBjb21wb25lbnRzIGFyZSBy
ZXByZXNlbnRlZCBieSBkaWZmZXJlbnQgbnVtYmVyIG9mIGJpdHMsIHRoZSBzbWFsbGVzdAorICAg
IC8vIG51bWJlciBpcyB1c2VkLicKKyAgICBzd2l0Y2ggKGRlcHRoKSB7CisgICAgY2FzZSA4Ogor
ICAgICAgICByZXR1cm4gMjsKKyAgICBjYXNlIDMyOgorICAgICAgICByZXR1cm4gODsKKyAgICBk
ZWZhdWx0OgorICAgICAgICByZXR1cm4gcVJvdW5kKGRlcHRoIC8gMyk7CisgICAgfQogfQogCiBi
b29sIHNjcmVlbklzTW9ub2Nocm9tZShXaWRnZXQqIHcpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>