202879 2019-10-11 23:36:14 -0700 Regression (251018): Wincairo build broken: unresolved external symbol 2019-10-15 15:02:24 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=202780 https://bugs.webkit.org/show_bug.cgi?id=202893 InRadar P2 Normal --- 1 aakash_jain achristensen aakash_jain achristensen annulen commit-queue dino ews-watchlist fujii graouts gyuyoung.kim kbr kondapallykalyan lingcherd_ho rakuco ryuan.choi sergio stephan.szabo webkit-bug-importer oldest_to_newest 1579401 0 aakash_jain 2019-10-11 23:36:14 -0700 Wincairo build seems to be broken. EWS and build.webkit.org seems to be failing with below build error, e.g.: https://ews-build.webkit.org/#/builders/12/builds/7400/steps/9/logs/stdio, https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/11035/steps/compile-webkit/logs/stdio [1854/5075] Linking CXX shared library bin64\libGLESv2.dll FAILED: bin64/libGLESv2.dll lib64/libGLESv2.lib cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E vs_link_dll --intdir=Source\ThirdParty\ANGLE\CMakeFiles\GLESv2.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\mt.exe" ... ... ... winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:bin64\libGLESv2.dll.manifest" failed (exit code 1120) with the following output: Creating library lib64\libGLESv2.lib and object lib64\libGLESv2.exp LINK : warning LNK4217: symbol 'ANGLEGetDisplayPlatform' defined in 'ANGLE.lib(Platform.cpp.obj)' is imported by 'proc_table_egl_autogen.cpp.obj' in function ... LINK : warning LNK4217: symbol 'ANGLEResetDisplayPlatform' defined in 'ANGLE.lib(Platform.cpp.obj)' is imported by 'proc_table_egl_autogen.cpp.obj' in function ... ANGLE.lib(Renderer11.cpp.obj) : error LNK2019: unresolved external symbol CreateDXGIFactory1 referenced in function ... bin64\libGLESv2.dll : fatal error LNK1120: 1 unresolved externals [1858/5075] Building CXX object Source\WebCore\PAL\pal\CMakeFiles\PAL.dir\FileSizeFormatter.cpp.obj ninja: build stopped: subcommand failed. 1579402 1 aakash_jain 2019-10-11 23:37:36 -0700 Failed in r251019 (https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/11011) Passed in r251017 (https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/11010) 1579403 2 aakash_jain 2019-10-11 23:38:42 -0700 Seems to be broken by https://trac.webkit.org/changeset/251018/webkit 1579434 3 380831 stephan.szabo 2019-10-12 11:09:25 -0700 Created attachment 380831 Patch It seems like the function that was being complained about is in dxgi, and adding that to where dxguid is defined seems to work. I'm uncertain if the same issue will apply to FTW as well as the library line there seems similar to the one in PlatformWin. 1579435 4 ews-watchlist 2019-10-12 11:09:58 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1579436 5 stephan.szabo 2019-10-12 11:22:28 -0700 I'd gotten a second unrelated error locally after fixing this, but am not sure whether I should be trying to fix that in this or a separate ticket. 1579478 6 380831 commit-queue 2019-10-12 22:35:34 -0700 Comment on attachment 380831 Patch Clearing flags on attachment: 380831 Committed r251056: <https://trac.webkit.org/changeset/251056> 1579479 7 commit-queue 2019-10-12 22:35:36 -0700 All reviewed patches have been landed. Closing bug. 1579483 8 aakash_jain 2019-10-13 06:53:27 -0700 It seems like another fix is needed. The build is still failing at a later stage with the error: ..\..\Source\WebCore\platform\network\curl\SynchronousLoaderClientCurl.cpp(32): fatal error C1083: Cannot open include file: 'EventLoop.h': No such file or directory Filed https://bugs.webkit.org/show_bug.cgi?id=202893 1579683 9 kbr 2019-10-14 10:30:52 -0700 Sorry about the breakage and thanks for fixing this build issue! 1580290 10 lingcherd_ho 2019-10-15 15:02:24 -0700 <rdar://problem/56225894> 380831 2019-10-12 11:09:25 -0700 2019-10-12 22:35:34 -0700 Patch 202879-1.diff text/plain 1175 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwppbmRleCAyZjA5ZDg0MTExNy4uN2Y1MmNiMmIzYWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxOS0xMC0x MiAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CisKKyAgICAgICAgUmVn cmVzc2lvbiAoMjUxMDE4KTogV2luY2Fpcm8gYnVpbGQgYnJva2VuOiB1bnJlc29sdmVkIGV4dGVy bmFsIHN5bWJvbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjAyODc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBQbGF0Zm9ybVdpbi5jbWFrZTogQWRkIGR4Z2kgbGlicmFyeSBmb3IgQ3JlYXRlRFhHSUZh Y3RvcnkxCisKIDIwMTktMTAtMTEgIEtlbm5ldGggUnVzc2VsbCAgPGtickBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgVVNFX0FOR0xFPTEgYnVpbGQgYnJva2VuIHdpdGggbGFzdCBBTkdMRSByb2xs CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9QbGF0Zm9ybVdpbi5jbWFrZSBi L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL1BsYXRmb3JtV2luLmNtYWtlCmluZGV4IDY1ZGJiYzcz ODEyLi43MTg3NTM0ZmJjOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvUGxh dGZvcm1XaW4uY21ha2UKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvUGxhdGZvcm1XaW4u Y21ha2UKQEAgLTIzLDcgKzIzLDcgQEAgaWYgKFVTRV9BTkdMRV9FR0wpCiAgICAgICAgIEFOR0xF X0VOQUJMRV9EM0QxMQogICAgICkKIAotICAgIGxpc3QoQVBQRU5EIEFOR0xFR0xFU3YyX0xJQlJB UklFUyBkeGd1aWQpCisgICAgbGlzdChBUFBFTkQgQU5HTEVHTEVTdjJfTElCUkFSSUVTIGR4Z3Vp ZCBkeGdpKQogCiAgICAgIyBEaXJlY3RYIDkgc3VwcG9ydCBzaG91bGQgYmUgb3B0aW9uYWwgYnV0 IEFOR0xFIHdpbGwgbm90IGNvbXBpbGUgd2l0aG91dCBpdAogICAgIGxpc3QoQVBQRU5EIEFOR0xF X1NPVVJDRVMgJHtsaWJhbmdsZV9kM2Q5X3NvdXJjZXN9KQo=