202873 2019-10-11 17:11:42 -0700 results.webkit.org: Make recent=False more usable 2019-10-15 15:23:54 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue lingcherd_ho webkit-bug-importer zhifei_fang oldest_to_newest 1579325 0 jbedard 2019-10-11 17:11:42 -0700 Queries with recent=False will fail unless some configuration value is specified. We have a decently sane alternative, which would be to assume that the current platforms are not stale, even if the configurations might be. This isn't a perfect strategy, but in most cases, it will give engineers what they're looking for. 1579333 1 380804 jbedard 2019-10-11 17:22:24 -0700 Created attachment 380804 Patch 1579335 2 jbedard 2019-10-11 17:27:26 -0700 Effect is hard to notice on the current instance, we don't have any stale configurations. 1579392 3 aakash_jain 2019-10-11 22:44:47 -0700 rs=me 1579628 4 380883 jbedard 2019-10-14 07:36:17 -0700 Created attachment 380883 Patch for landing 1579630 5 380883 commit-queue 2019-10-14 08:21:18 -0700 Comment on attachment 380883 Patch for landing Clearing flags on attachment: 380883 Committed r251072: <https://trac.webkit.org/changeset/251072> 1579631 6 commit-queue 2019-10-14 08:21:19 -0700 All reviewed patches have been landed. Closing bug. 1580321 7 lingcherd_ho 2019-10-15 15:23:54 -0700 <rdar://problem/56249800> 380804 2019-10-11 17:22:24 -0700 2019-10-14 07:36:13 -0700 Patch bug-202873-20191011172223.patch text/plain 3784 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTAzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTEwLTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IE1ha2UgcmVjZW50PUZhbHNlIG1vcmUg dXNhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDI4NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2NvbmZpZ3VyYXRpb25fY29udGV4dC5weToK KyAgICAgICAgKENvbmZpZ3VyYXRpb25Db250ZXh0LnNlYXJjaF9mb3JfY29uZmlndXJhdGlvbik6 IElmIG5vIGNvbmZpZ3VyYXRpb24gaXMgc3BlY2lmaWVkLAorICAgICAgICB1c2UgYSBzZXQgb2Yg Y29uZmlndXJhdGlvbnMgZGVmaW5lZCBieSByZWNlbnQgcGxhdGZvcm0uCisgICAgICAgICogcmVz dWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvY29uZmlndXJhdGlvbl9jb250ZXh0X3VuaXR0ZXN0 LnB5OgorICAgICAgICAoQ29uZmlndXJhdGlvbkNvbnRleHRUZXN0LnRlc3RfZXhwaXJlZF9jb25m aWd1cmF0aW9ucyk6IFRlc3QgdGhhdCByZWNlbnQ9RmFsc2Ugd29ya3MuCisKIDIwMTktMTAtMTEg IEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBi dWlsZC53ZWJraXQub3JnIGJhc2VkaXIKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNk YnB5L21vZGVsL2NvbmZpZ3VyYXRpb25fY29udGV4dC5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9y ZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9jb25maWd1cmF0aW9uX2NvbnRleHQucHkJKHJl dmlzaW9uIDI1MTAyNykKKysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2Nv bmZpZ3VyYXRpb25fY29udGV4dC5weQkod29ya2luZyBjb3B5KQpAQCAtMTg5LDcgKzE4OSw3IEBA IGNsYXNzIENvbmZpZ3VyYXRpb25Db250ZXh0KG9iamVjdCk6CiAKICAgICAgICAgc2VsZi5fcmVn aXN0ZXJfaW5fcmVkaXMoY29uZmlndXJhdGlvbiwgYnJhbmNoLCB0aW1lc3RhbXApCiAKLSAgICBk ZWYgc2VhcmNoX2Zvcl9jb25maWd1cmF0aW9uKHNlbGYsIGNvbmZpZ3VyYXRpb24sIGJyYW5jaD1O b25lKToKKyAgICBkZWYgc2VhcmNoX2Zvcl9jb25maWd1cmF0aW9uKHNlbGYsIGNvbmZpZ3VyYXRp b249Q29uZmlndXJhdGlvbigpLCBicmFuY2g9Tm9uZSk6CiAgICAgICAgIGlmIG5vdCBpc2luc3Rh bmNlKGNvbmZpZ3VyYXRpb24sIENvbmZpZ3VyYXRpb24pOgogICAgICAgICAgICAgcmFpc2UgVHlw ZUVycm9yKGYnRXhwZWN0ZWQgdHlwZSB7Q29uZmlndXJhdGlvbn0sIGdvdCB7dHlwZShjb25maWd1 cmF0aW9uKX0nKQogCkBAIC0yMDcsNyArMjA3LDE2IEBAIGNsYXNzIENvbmZpZ3VyYXRpb25Db250 ZXh0KG9iamVjdCk6CiAgICAgICAgIGVsaWYgJ21vZGVsJyBpbiBrd2FyZ3M6CiAgICAgICAgICAg ICB0YWJsZSA9IHNlbGYuQnlNb2RlbAogICAgICAgICBlbHNlOgotICAgICAgICAgICAgcmFpc2Ug VHlwZUVycm9yKGYne2NvbmZpZ3VyYXRpb259IGlzIG5vdCBzcGVjaWZpYyBlbm91Z2ggdG8gYmUg c2VhcmNoZWQgYnknKQorICAgICAgICAgICAgIyBQbGF0Zm9ybXMgcmFyZWx5IGV4cGlyZSwgc28g d2UgY2FuIGRvIGEgZGVjZW50IGpvYiBvZiB3aWxkY2FyZCBtYXRjaGluZyBleHBpcmVkIGNvbmZp Z3VyYXRpb25zCisgICAgICAgICAgICAjIGlmIHdlIHRyeSBhbGwgcGxhdGZvcm1zIGluIHRoZSBj YWNoZS4KKyAgICAgICAgICAgIHBsYXRmb3JtcyA9IHNldChbY29uZmlnLnBsYXRmb3JtIGZvciBj b25maWcgaW4gc2VsZi5zZWFyY2hfZm9yX3JlY2VudF9jb25maWd1cmF0aW9uKGJyYW5jaD1icmFu Y2gpXSkKKyAgICAgICAgICAgIHdpdGggc2VsZjoKKyAgICAgICAgICAgICAgICByZXN1bHQgPSBb XQorICAgICAgICAgICAgICAgIGZvciBwbGF0Zm9ybSBpbiBwbGF0Zm9ybXM6CisgICAgICAgICAg ICAgICAgICAgIGNvbmZpZ3VyYXRpb24ucGxhdGZvcm0gPSBwbGF0Zm9ybQorICAgICAgICAgICAg ICAgICAgICByZXN1bHQuZXh0ZW5kKHNlbGYuc2VhcmNoX2Zvcl9jb25maWd1cmF0aW9uKGNvbmZp Z3VyYXRpb24sIGJyYW5jaCkpCisgICAgICAgICAgICAgICAgY29uZmlndXJhdGlvbi5wbGF0Zm9y bSA9IE5vbmUKKyAgICAgICAgICAgICAgICByZXR1cm4gcmVzdWx0CiAKICAgICAgICAgd2l0aCBz ZWxmOgogICAgICAgICAgICAgcmV0dXJuIFttb2RlbC50b19jb25maWd1cmF0aW9uKCkgZm9yIG1v ZGVsIGluIHNlbGYuY2Fzc2FuZHJhLnNlbGVjdF9mcm9tX3RhYmxlKHRhYmxlLl9fdGFibGVfbmFt ZV9fLCAqKmt3YXJncyldCkluZGV4OiBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2Rl bC9jb25maWd1cmF0aW9uX2NvbnRleHRfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv cmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvY29uZmlndXJhdGlvbl9jb250ZXh0X3VuaXR0 ZXN0LnB5CShyZXZpc2lvbiAyNTEwMjcpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJw eS9tb2RlbC9jb25maWd1cmF0aW9uX2NvbnRleHRfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkK QEAgLTE2MCw2ICsxNjAsMTQgQEAgY2xhc3MgQ29uZmlndXJhdGlvbkNvbnRleHRUZXN0KFdhaXRG b3JEbwogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKDEyLCBsZW4ocmVjZW50X2NvbmZpZ3VyYXRp b25zKSkKIAogICAgIEBXYWl0Rm9yRG9ja2VyVGVzdENhc2UubW9ja19pZl9ub19kb2NrZXIobW9j a19yZWRpcz1GYWtlU3RyaWN0UmVkaXMsIG1vY2tfY2Fzc2FuZHJhPU1vY2tDYXNzYW5kcmFDb250 ZXh0KQorICAgIGRlZiB0ZXN0X2V4cGlyZWRfY29uZmlndXJhdGlvbnMoc2VsZiwgcmVkaXM9U3Ry aWN0UmVkaXMsIGNhc3NhbmRyYT1DYXNzYW5kcmFDb250ZXh0KToKKyAgICAgICAgc2VsZi5pbml0 X2RhdGFiYXNlKHJlZGlzPXJlZGlzLCBjYXNzYW5kcmE9Y2Fzc2FuZHJhKQorICAgICAgICBzZWxm LnJlZ2lzdGVyX2NvbmZpZ3VyYXRpb25zKCkKKworICAgICAgICByZWNlbnRfY29uZmlndXJhdGlv bnMgPSBzZWxmLmRhdGFiYXNlLnNlYXJjaF9mb3JfY29uZmlndXJhdGlvbigpCisgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWwoMjQsIGxlbihyZWNlbnRfY29uZmlndXJhdGlvbnMpKQorCisgICAgQFdh aXRGb3JEb2NrZXJUZXN0Q2FzZS5tb2NrX2lmX25vX2RvY2tlcihtb2NrX3JlZGlzPUZha2VTdHJp Y3RSZWRpcywgbW9ja19jYXNzYW5kcmE9TW9ja0Nhc3NhbmRyYUNvbnRleHQpCiAgICAgZGVmIHRl c3RfcmVjZW50X2NvbmZpZ3VyYXRpb25zX2NvbnN0cmFpbmVkKHNlbGYsIHJlZGlzPVN0cmljdFJl ZGlzLCBjYXNzYW5kcmE9Q2Fzc2FuZHJhQ29udGV4dCk6CiAgICAgICAgIHNlbGYuaW5pdF9kYXRh YmFzZShyZWRpcz1yZWRpcywgY2Fzc2FuZHJhPWNhc3NhbmRyYSkKICAgICAgICAgc2VsZi5yZWdp c3Rlcl9jb25maWd1cmF0aW9ucygpCg== 380883 2019-10-14 07:36:17 -0700 2019-10-14 08:21:18 -0700 Patch for landing bug-202873-20191014073616.patch text/plain 3820 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTA3MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTEwLTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IE1ha2UgcmVjZW50PUZhbHNlIG1vcmUg dXNhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDI4NzMKKworICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBBYWthc2ggSmFpbi4KKworICAgICAg ICAqIHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2NvbmZpZ3VyYXRpb25fY29udGV4dC5w eToKKyAgICAgICAgKENvbmZpZ3VyYXRpb25Db250ZXh0LnNlYXJjaF9mb3JfY29uZmlndXJhdGlv bik6IElmIG5vIGNvbmZpZ3VyYXRpb24gaXMgc3BlY2lmaWVkLAorICAgICAgICB1c2UgYSBzZXQg b2YgY29uZmlndXJhdGlvbnMgZGVmaW5lZCBieSByZWNlbnQgcGxhdGZvcm0uCisgICAgICAgICog cmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvY29uZmlndXJhdGlvbl9jb250ZXh0X3VuaXR0 ZXN0LnB5OgorICAgICAgICAoQ29uZmlndXJhdGlvbkNvbnRleHRUZXN0LnRlc3RfZXhwaXJlZF9j b25maWd1cmF0aW9ucyk6IFRlc3QgdGhhdCByZWNlbnQ9RmFsc2Ugd29ya3MuCisKIDIwMTktMTAt MTQgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCBzZXQgQWRyaWFuIFBlcmV6IGRlIENhc3RybyBhcyBXZWJLaXQgUmV2aWV3 ZXIKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2NvbmZpZ3VyYXRp b25fY29udGV4dC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJw eS9tb2RlbC9jb25maWd1cmF0aW9uX2NvbnRleHQucHkJKHJldmlzaW9uIDI1MTA3MSkKKysrIFRv b2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL2NvbmZpZ3VyYXRpb25fY29udGV4dC5w eQkod29ya2luZyBjb3B5KQpAQCAtMTg5LDcgKzE4OSw3IEBAIGNsYXNzIENvbmZpZ3VyYXRpb25D b250ZXh0KG9iamVjdCk6CiAKICAgICAgICAgc2VsZi5fcmVnaXN0ZXJfaW5fcmVkaXMoY29uZmln dXJhdGlvbiwgYnJhbmNoLCB0aW1lc3RhbXApCiAKLSAgICBkZWYgc2VhcmNoX2Zvcl9jb25maWd1 cmF0aW9uKHNlbGYsIGNvbmZpZ3VyYXRpb24sIGJyYW5jaD1Ob25lKToKKyAgICBkZWYgc2VhcmNo X2Zvcl9jb25maWd1cmF0aW9uKHNlbGYsIGNvbmZpZ3VyYXRpb249Q29uZmlndXJhdGlvbigpLCBi cmFuY2g9Tm9uZSk6CiAgICAgICAgIGlmIG5vdCBpc2luc3RhbmNlKGNvbmZpZ3VyYXRpb24sIENv bmZpZ3VyYXRpb24pOgogICAgICAgICAgICAgcmFpc2UgVHlwZUVycm9yKGYnRXhwZWN0ZWQgdHlw ZSB7Q29uZmlndXJhdGlvbn0sIGdvdCB7dHlwZShjb25maWd1cmF0aW9uKX0nKQogCkBAIC0yMDcs NyArMjA3LDE2IEBAIGNsYXNzIENvbmZpZ3VyYXRpb25Db250ZXh0KG9iamVjdCk6CiAgICAgICAg IGVsaWYgJ21vZGVsJyBpbiBrd2FyZ3M6CiAgICAgICAgICAgICB0YWJsZSA9IHNlbGYuQnlNb2Rl bAogICAgICAgICBlbHNlOgotICAgICAgICAgICAgcmFpc2UgVHlwZUVycm9yKGYne2NvbmZpZ3Vy YXRpb259IGlzIG5vdCBzcGVjaWZpYyBlbm91Z2ggdG8gYmUgc2VhcmNoZWQgYnknKQorICAgICAg ICAgICAgIyBQbGF0Zm9ybXMgcmFyZWx5IGV4cGlyZSwgc28gd2UgY2FuIGRvIGEgZGVjZW50IGpv YiBvZiB3aWxkY2FyZCBtYXRjaGluZyBleHBpcmVkIGNvbmZpZ3VyYXRpb25zCisgICAgICAgICAg ICAjIGlmIHdlIHRyeSBhbGwgcGxhdGZvcm1zIGluIHRoZSBjYWNoZS4KKyAgICAgICAgICAgIHBs YXRmb3JtcyA9IHNldChbY29uZmlnLnBsYXRmb3JtIGZvciBjb25maWcgaW4gc2VsZi5zZWFyY2hf Zm9yX3JlY2VudF9jb25maWd1cmF0aW9uKGJyYW5jaD1icmFuY2gpXSkKKyAgICAgICAgICAgIHdp dGggc2VsZjoKKyAgICAgICAgICAgICAgICByZXN1bHQgPSBbXQorICAgICAgICAgICAgICAgIGZv ciBwbGF0Zm9ybSBpbiBwbGF0Zm9ybXM6CisgICAgICAgICAgICAgICAgICAgIGNvbmZpZ3VyYXRp b24ucGxhdGZvcm0gPSBwbGF0Zm9ybQorICAgICAgICAgICAgICAgICAgICByZXN1bHQuZXh0ZW5k KHNlbGYuc2VhcmNoX2Zvcl9jb25maWd1cmF0aW9uKGNvbmZpZ3VyYXRpb24sIGJyYW5jaCkpCisg ICAgICAgICAgICAgICAgY29uZmlndXJhdGlvbi5wbGF0Zm9ybSA9IE5vbmUKKyAgICAgICAgICAg ICAgICByZXR1cm4gcmVzdWx0CiAKICAgICAgICAgd2l0aCBzZWxmOgogICAgICAgICAgICAgcmV0 dXJuIFttb2RlbC50b19jb25maWd1cmF0aW9uKCkgZm9yIG1vZGVsIGluIHNlbGYuY2Fzc2FuZHJh LnNlbGVjdF9mcm9tX3RhYmxlKHRhYmxlLl9fdGFibGVfbmFtZV9fLCAqKmt3YXJncyldCkluZGV4 OiBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9jb25maWd1cmF0aW9uX2NvbnRl eHRfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2Ri cHkvbW9kZWwvY29uZmlndXJhdGlvbl9jb250ZXh0X3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNTEw NzEpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC9jb25maWd1cmF0aW9u X2NvbnRleHRfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTE2MCw2ICsxNjAsMTQgQEAg Y2xhc3MgQ29uZmlndXJhdGlvbkNvbnRleHRUZXN0KFdhaXRGb3JEbwogICAgICAgICBzZWxmLmFz c2VydEVxdWFsKDEyLCBsZW4ocmVjZW50X2NvbmZpZ3VyYXRpb25zKSkKIAogICAgIEBXYWl0Rm9y RG9ja2VyVGVzdENhc2UubW9ja19pZl9ub19kb2NrZXIobW9ja19yZWRpcz1GYWtlU3RyaWN0UmVk aXMsIG1vY2tfY2Fzc2FuZHJhPU1vY2tDYXNzYW5kcmFDb250ZXh0KQorICAgIGRlZiB0ZXN0X2V4 cGlyZWRfY29uZmlndXJhdGlvbnMoc2VsZiwgcmVkaXM9U3RyaWN0UmVkaXMsIGNhc3NhbmRyYT1D YXNzYW5kcmFDb250ZXh0KToKKyAgICAgICAgc2VsZi5pbml0X2RhdGFiYXNlKHJlZGlzPXJlZGlz LCBjYXNzYW5kcmE9Y2Fzc2FuZHJhKQorICAgICAgICBzZWxmLnJlZ2lzdGVyX2NvbmZpZ3VyYXRp b25zKCkKKworICAgICAgICByZWNlbnRfY29uZmlndXJhdGlvbnMgPSBzZWxmLmRhdGFiYXNlLnNl YXJjaF9mb3JfY29uZmlndXJhdGlvbigpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoMjQsIGxl bihyZWNlbnRfY29uZmlndXJhdGlvbnMpKQorCisgICAgQFdhaXRGb3JEb2NrZXJUZXN0Q2FzZS5t b2NrX2lmX25vX2RvY2tlcihtb2NrX3JlZGlzPUZha2VTdHJpY3RSZWRpcywgbW9ja19jYXNzYW5k cmE9TW9ja0Nhc3NhbmRyYUNvbnRleHQpCiAgICAgZGVmIHRlc3RfcmVjZW50X2NvbmZpZ3VyYXRp b25zX2NvbnN0cmFpbmVkKHNlbGYsIHJlZGlzPVN0cmljdFJlZGlzLCBjYXNzYW5kcmE9Q2Fzc2Fu ZHJhQ29udGV4dCk6CiAgICAgICAgIHNlbGYuaW5pdF9kYXRhYmFzZShyZWRpcz1yZWRpcywgY2Fz c2FuZHJhPWNhc3NhbmRyYSkKICAgICAgICAgc2VsZi5yZWdpc3Rlcl9jb25maWd1cmF0aW9ucygp Cg==