202864 2019-10-11 13:42:07 -0700 [ews] Services EWS should also run build.webkit.org unit tests 2019-10-12 08:22:31 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199994 InRadar P2 Normal --- 0 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1579226 0 aakash_jain 2019-10-11 13:42:07 -0700 Services EWS should also run build.webkit.org unit tests. 1579233 1 380782 aakash_jain 2019-10-11 13:52:45 -0700 Created attachment 380782 Patch 1579234 2 aakash_jain 2019-10-11 13:53:18 -0700 tested locally. 1579240 3 380782 jbedard 2019-10-11 14:09:48 -0700 Comment on attachment 380782 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380782&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:607 > +class RunBuildWebKitUnitTests(shell.ShellCommand): Maybe should be RunBuildWebKitOrgUnitTests since we actually have a build-webkit script. 1579242 4 aakash_jain 2019-10-11 14:25:47 -0700 > Maybe should be RunBuildWebKitOrgUnitTests since we actually have a build-webkit script. Sure, will change it to RunBuildWebKitOrgUnitTests. 1579243 5 aakash_jain 2019-10-11 14:26:50 -0700 Committed r251025: <https://trac.webkit.org/changeset/251025> 1579426 6 webkit-bug-importer 2019-10-12 08:21:43 -0700 <rdar://problem/56219593> 380782 2019-10-11 13:52:45 -0700 2019-10-11 14:09:48 -0700 Patch bug-202864-20191011165244.patch text/plain 6868 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTAyNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE5LTEwLTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBTZXJ2aWNlcyBFV1Mgc2hvdWxkIGFsc28gcnVuIGJ1aWxkLndl YmtpdC5vcmcgdW5pdCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAyODY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5Ogor ICAgICAgICAoU2VydmljZXNGYWN0b3J5Ll9faW5pdF9fKTogQWRkZWQgbmV3IFJ1bkJ1aWxkV2Vi S2l0VW5pdFRlc3RzIHN0ZXAuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L3N0ZXBzLnB5OgorICAgICAgICAoQ2hlY2tQYXRjaFJlbGV2YW5jZSk6IEFkZGVkIHBhdGhzIGZv ciBidWlsZC53ZWJraXQub3JnIGNvZGUuCisgICAgICAgIChSdW5CdWlsZFdlYktpdFVuaXRUZXN0 cyk6IEJ1aWxkIHN0ZXAgdG8gcnVuIGJ1aWxkLndlYmtpdC5vcmcgdW5pdCB0ZXN0cy4KKyAgICAg ICAgKFJ1bkJ1aWxkV2ViS2l0VW5pdFRlc3RzLl9faW5pdF9fKTogU2V0IHdvcmtkaXIsIHRpbWVv dXQgYW5kIGxvZ0Vudmlyb24uCisgICAgICAgIChSdW5CdWlsZFdlYktpdFVuaXRUZXN0cy5nZXRS ZXN1bHRTdW1tYXJ5KTogQ3VzdG9taXplIEJ1aWxkYm90IG1lc3NhZ2VzIGZvciB0aGlzIGJ1aWxk IHN0ZXAuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0 ZXN0LnB5OiBBZGRlZCB1bml0LXRlc3RzLgorCiAyMDE5LTEwLTExICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBTdXNwZW5kZWRQYWdlIGxvZ2ljIGZyb20g V2ViUHJvY2Vzc1Bvb2wgdG8gbmV3IFdlYkJhY2tGb3J3YXJkQ2FjaGUgY2xhc3MKSW5kZXg6IFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQkocmV2aXNp b24gMjUxMDI0KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmll cy5weQkod29ya2luZyBjb3B5KQpAQCAtMjcsNyArMjcsNyBAQCBmcm9tIGJ1aWxkYm90LnN0ZXBz IGltcG9ydCB0cmlnZ2VyCiBmcm9tIHN0ZXBzIGltcG9ydCAoQXBwbHlQYXRjaCwgQXBwbHlXYXRj aExpc3QsIENoZWNrT3V0U291cmNlLCBDaGVja091dFNwZWNpZmljUmV2aXNpb24sIENoZWNrUGF0 Y2hSZWxldmFuY2UsCiAgICAgICAgICAgICAgICAgICAgQ2hlY2tTdHlsZSwgQ29tcGlsZUpTQywg Q29tcGlsZVdlYktpdCwgQ29uZmlndXJlQnVpbGQsCiAgICAgICAgICAgICAgICAgICAgRG93bmxv YWRCdWlsdFByb2R1Y3QsIEV4dHJhY3RCdWlsdFByb2R1Y3QsIEluc3RhbGxHdGtEZXBlbmRlbmNp ZXMsIEluc3RhbGxXcGVEZXBlbmRlbmNpZXMsIEtpbGxPbGRQcm9jZXNzZXMsCi0gICAgICAgICAg ICAgICAgICAgUHJpbnRDb25maWd1cmF0aW9uLCBSdW5BUElUZXN0cywgUnVuQmluZGluZ3NUZXN0 cywgUnVuRVdTQnVpbGRib3RDaGVja0NvbmZpZywgUnVuRVdTVW5pdFRlc3RzLAorICAgICAgICAg ICAgICAgICAgIFByaW50Q29uZmlndXJhdGlvbiwgUnVuQVBJVGVzdHMsIFJ1bkJpbmRpbmdzVGVz dHMsIFJ1bkJ1aWxkV2ViS2l0VW5pdFRlc3RzLCBSdW5FV1NCdWlsZGJvdENoZWNrQ29uZmlnLCBS dW5FV1NVbml0VGVzdHMsCiAgICAgICAgICAgICAgICAgICAgUnVuSmF2YVNjcmlwdENvcmVUZXN0 cywgUnVuV2ViS2l0MVRlc3RzLCBSdW5XZWJLaXRQZXJsVGVzdHMsCiAgICAgICAgICAgICAgICAg ICAgUnVuV2ViS2l0UHlUZXN0cywgUnVuV2ViS2l0VGVzdHMsIFVwZGF0ZVdvcmtpbmdEaXJlY3Rv cnksIFZhbGlkYXRlUGF0Y2gpCiAKQEAgLTE4MywzICsxODMsNCBAQCBjbGFzcyBTZXJ2aWNlc0Zh Y3RvcnkoRmFjdG9yeSk6CiAgICAgICAgIEZhY3RvcnkuX19pbml0X18oc2VsZiwgcGxhdGZvcm0s IGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNlLCBhZGRpdGlvbmFsQXJndW1lbnRz LCBjaGVja1JlbGV2YW5jZT1UcnVlKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuRVdTVW5pdFRl c3RzKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5FV1NCdWlsZGJvdENoZWNrQ29uZmlnKCkp CisgICAgICAgIHNlbGYuYWRkU3RlcChSdW5CdWlsZFdlYktpdFVuaXRUZXN0cygpKQpJbmRleDog VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjUx MDI0KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC0yMjUsNyArMjI1LDkgQEAgY2xhc3MgQ2hlY2tQYXRjaFJlbGV2YW5jZShi dWlsZHN0ZXAuQnVpbAogICAgIF0KIAogICAgIHNlcnZpY2VzX3BhdGhzID0gWworICAgICAgICAn VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcnLAogICAgICAg ICAnVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkJywKKyAgICAgICAgJ1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L1NoYXJlZCcsCiAgICAgXQogCiAgICAganNjX3BhdGhzID0gWwpAQCAt NjAyLDYgKzYwNCwyMCBAQCBjbGFzcyBSdW5XZWJLaXRQZXJsVGVzdHMoc2hlbGwuU2hlbGxDb21t CiAgICAgICAgIHN1cGVyKFJ1bldlYktpdFBlcmxUZXN0cywgc2VsZikuX19pbml0X18odGltZW91 dD0yICogNjAsIGxvZ0Vudmlyb249RmFsc2UsICoqa3dhcmdzKQogCiAKK2NsYXNzIFJ1bkJ1aWxk V2ViS2l0VW5pdFRlc3RzKHNoZWxsLlNoZWxsQ29tbWFuZCk6CisgICAgbmFtZSA9ICdidWlsZC13 ZWJraXQtdW5pdC10ZXN0cycKKyAgICBkZXNjcmlwdGlvbiA9IFsnYnVpbGQtd2Via2l0LXVuaXQt dGVzdHMgcnVubmluZyddCisgICAgY29tbWFuZCA9IFsncHl0aG9uJywgJ3N0ZXBzX3VuaXR0ZXN0 LnB5J10KKworICAgIGRlZiBfX2luaXRfXyhzZWxmLCAqKmt3YXJncyk6CisgICAgICAgIHNoZWxs LlNoZWxsQ29tbWFuZC5fX2luaXRfXyhzZWxmLCB3b3JrZGlyPSdidWlsZC9Ub29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZycsIHRpbWVvdXQ9MiAqIDYwLCBsb2dF bnZpcm9uPUZhbHNlLCAqKmt3YXJncykKKworICAgIGRlZiBnZXRSZXN1bHRTdW1tYXJ5KHNlbGYp OgorICAgICAgICBpZiBzZWxmLnJlc3VsdHMgPT0gU1VDQ0VTUzoKKyAgICAgICAgICAgIHJldHVy biB7dSdzdGVwJzogdSdQYXNzZWQgYnVpbGQud2Via2l0Lm9yZyB1bml0IHRlc3RzJ30KKyAgICAg ICAgcmV0dXJuIHt1J3N0ZXAnOiB1J0ZhaWxlZCBidWlsZC53ZWJraXQub3JnIHVuaXQgdGVzdHMn fQorCisKIGNsYXNzIFJ1bkVXU1VuaXRUZXN0cyhzaGVsbC5TaGVsbENvbW1hbmQpOgogICAgIG5h bWUgPSAnZXdzLXVuaXQtdGVzdHMnCiAgICAgZGVzY3JpcHRpb24gPSBbJ2V3cy11bml0LXRlc3Rz IHJ1bm5pbmcnXQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjUxMDI0KQorKysgVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBA IC0zOSw3ICszOSw3IEBAIGZyb20gc3RlcHMgaW1wb3J0IChBbmFseXplQVBJVGVzdHNSZXN1bHQK ICAgICAgICAgICAgICAgICAgICBDb21waWxlSlNDLCBDb21waWxlSlNDVG9ULCBDb21waWxlV2Vi S2l0LCBDb21waWxlV2ViS2l0VG9ULCBDb25maWd1cmVCdWlsZCwKICAgICAgICAgICAgICAgICAg ICBEb3dubG9hZEJ1aWx0UHJvZHVjdCwgRXh0cmFjdEJ1aWx0UHJvZHVjdCwgRXh0cmFjdFRlc3RS ZXN1bHRzLCBJbnN0YWxsR3RrRGVwZW5kZW5jaWVzLCBJbnN0YWxsV3BlRGVwZW5kZW5jaWVzLCBL aWxsT2xkUHJvY2Vzc2VzLAogICAgICAgICAgICAgICAgICAgIFByaW50Q29uZmlndXJhdGlvbiwg UmVSdW5BUElUZXN0cywgUmVSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLCBSZVJ1bldlYktpdFRlc3Rz LCBSdW5BUElUZXN0cywgUnVuQVBJVGVzdHNXaXRob3V0UGF0Y2gsCi0gICAgICAgICAgICAgICAg ICAgUnVuQmluZGluZ3NUZXN0cywgUnVuRVdTQnVpbGRib3RDaGVja0NvbmZpZywgUnVuRVdTVW5p dFRlc3RzLCBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLCBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzVG9U LCBSdW5XZWJLaXQxVGVzdHMsCisgICAgICAgICAgICAgICAgICAgUnVuQmluZGluZ3NUZXN0cywg UnVuQnVpbGRXZWJLaXRVbml0VGVzdHMsIFJ1bkVXU0J1aWxkYm90Q2hlY2tDb25maWcsIFJ1bkVX U1VuaXRUZXN0cywgUnVuSmF2YVNjcmlwdENvcmVUZXN0cywgUnVuSmF2YVNjcmlwdENvcmVUZXN0 c1RvVCwgUnVuV2ViS2l0MVRlc3RzLAogICAgICAgICAgICAgICAgICAgIFJ1bldlYktpdFBlcmxU ZXN0cywgUnVuV2ViS2l0UHlUZXN0cywgUnVuV2ViS2l0VGVzdHMsIFRlc3RXaXRoRmFpbHVyZUNv dW50LCBUcmlnZ2VyLCBUcmFuc2ZlclRvUzMsIFVuQXBwbHlQYXRjaElmUmVxdWlyZWQsCiAgICAg ICAgICAgICAgICAgICAgVXBkYXRlV29ya2luZ0RpcmVjdG9yeSwgVXBsb2FkQnVpbHRQcm9kdWN0 LCBVcGxvYWRUZXN0UmVzdWx0cywgVmFsaWRhdGVQYXRjaCkKIApAQCAtNTIzLDYgKzUyMyw0MiBA QCBjbGFzcyBUZXN0UnVuRVdTVW5pdFRlc3RzKEJ1aWxkU3RlcE1peGluCiAgICAgICAgIHJldHVy biBzZWxmLnJ1blN0ZXAoKQogCiAKK2NsYXNzIFRlc3RSdW5CdWlsZFdlYktpdFVuaXRUZXN0cyhC dWlsZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgorICAgIGRlZiBzZXRV cChzZWxmKToKKyAgICAgICAgc2VsZi5sb25nTWVzc2FnZSA9IFRydWUKKyAgICAgICAgcmV0dXJu IHNlbGYuc2V0VXBCdWlsZFN0ZXAoKQorCisgICAgZGVmIHRlYXJEb3duKHNlbGYpOgorICAgICAg ICByZXR1cm4gc2VsZi50ZWFyRG93bkJ1aWxkU3RlcCgpCisKKyAgICBkZWYgdGVzdF9zdWNjZXNz KHNlbGYpOgorICAgICAgICBzZWxmLnNldHVwU3RlcChSdW5CdWlsZFdlYktpdFVuaXRUZXN0cygp KQorICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAorICAgICAgICAgICAgRXhwZWN0 U2hlbGwod29ya2Rpcj0nYnVpbGQvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcnLAorICAgICAgICAgICAgICAgICAgICAgICAgdGltZW91dD0xMjAsCisgICAg ICAgICAgICAgICAgICAgICAgICBsb2dFbnZpcm9uPUZhbHNlLAorICAgICAgICAgICAgICAgICAg ICAgICAgY29tbWFuZD1bJ3B5dGhvbicsICdzdGVwc191bml0dGVzdC5weSddLAorICAgICAgICAg ICAgICAgICAgICAgICAgKQorICAgICAgICAgICAgKyAwLAorICAgICAgICApCisgICAgICAgIHNl bGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdQYXNzZWQgYnVp bGQud2Via2l0Lm9yZyB1bml0IHRlc3RzJykKKyAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgp CisKKyAgICBkZWYgdGVzdF9mYWlsdXJlKHNlbGYpOgorICAgICAgICBzZWxmLnNldHVwU3RlcChS dW5CdWlsZFdlYktpdFVuaXRUZXN0cygpKQorICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1h bmRzKAorICAgICAgICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nYnVpbGQvVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcnLAorICAgICAgICAgICAgICAgICAg ICAgICAgdGltZW91dD0xMjAsCisgICAgICAgICAgICAgICAgICAgICAgICBsb2dFbnZpcm9uPUZh bHNlLAorICAgICAgICAgICAgICAgICAgICAgICAgY29tbWFuZD1bJ3B5dGhvbicsICdzdGVwc191 bml0dGVzdC5weSddLAorICAgICAgICAgICAgICAgICAgICAgICAgKQorICAgICAgICAgICAgKyBF eHBlY3RTaGVsbC5sb2coJ3N0ZGlvJywgc3Rkb3V0PSdVbmhhbmRsZWQgRXJyb3IuIFRyYWNlYmFj ayAobW9zdCByZWNlbnQgY2FsbCBsYXN0KTogS2V5cyBpbiBjbWQgbWlzc2luZyBmcm9tIGV4cGVj dGF0aW9uOiBbbG9nZmlsZXMuanNvbl0nKQorICAgICAgICAgICAgKyAyLAorICAgICAgICApCisg ICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5nPSdG YWlsZWQgYnVpbGQud2Via2l0Lm9yZyB1bml0IHRlc3RzJykKKyAgICAgICAgcmV0dXJuIHNlbGYu cnVuU3RlcCgpCisKKwogY2xhc3MgVGVzdEtpbGxPbGRQcm9jZXNzZXMoQnVpbGRTdGVwTWl4aW5B ZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYgc2V0VXAoc2VsZik6CiAgICAg ICAgIHNlbGYubG9uZ01lc3NhZ2UgPSBUcnVlCg==