202853 2019-10-11 10:47:24 -0700 Remove some dead code in webkitpy's mac.py 2019-10-15 16:49:11 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg ap bburg commit-queue ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1579149 0 bburg 2019-10-11 10:47:24 -0700 . 1579151 1 380764 bburg 2019-10-11 10:50:28 -0700 Created attachment 380764 Patch 1579153 2 380764 jbedard 2019-10-11 10:56:00 -0700 Comment on attachment 380764 Patch Looks good to me, but let's let EWS do it's thing, since if you were going to break something horribly, EWS would likely make it clear. 1579197 3 380764 ap 2019-10-11 12:36:33 -0700 Comment on attachment 380764 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380764&action=review > Tools/Scripts/webkitpy/port/mac.py:-272 > - # FIXME: Remove this after <rdar://problem/15605007> is fixed. > - logging_patterns.append((re.compile('(AVF|GVA) info:.*\n'), '')) Seeing other instances of similar logging from same sources below, I wonder if we should treat stripping that as a permanent feature. 1579216 4 380764 commit-queue 2019-10-11 13:35:12 -0700 Comment on attachment 380764 Patch Clearing flags on attachment: 380764 Committed r251020: <https://trac.webkit.org/changeset/251020> 1579217 5 commit-queue 2019-10-11 13:35:13 -0700 All reviewed patches have been landed. Closing bug. 1580377 6 webkit-bug-importer 2019-10-15 16:49:11 -0700 <rdar://problem/56313774> 380764 2019-10-11 10:50:28 -0700 2019-10-11 13:35:12 -0700 Patch bug-202853-20191011105027.patch text/plain 4828 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTM0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDZjZGVhYTZhNDg3NzUyMmI3YzhjNGQzMTNhZDQ2ZjM0 ZDcwMzE1MC4uZTkwNTQ1NDAxZjhiZWI4MjI5YmUzYWRmNDIyZGMyMTlkYzMxMTRmMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDE5LTEwLTExICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAg IFJlbW92ZSBzb21lIGRlYWQgY29kZSBpbiB3ZWJraXRweSdzIG1hYy5weQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyODUzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBSZW1vdmUgX2J1aWxkX2phdmFf dGVzdF9zdXBwb3J0IGFzIGl0IG5vIGxvbmdlciBkb2VzIGFueXRoaW5nLgorICAgICAgICAtIFJl bW92ZSBfY2hlY2tfcG9ydF9idWlsZCBhcyBpdCdzIG9ubHkgdXNlZCB0byBidWlsZCBKYXZhIHRl c3Qgc3VwcG9ydC4KKyAgICAgICAgLSBSZW1vdmUgdW51c2VkIGlzX21hdmVyaWNrcygpIGZ1bmN0 aW9uLgorICAgICAgICAtIFJlbW92ZSBhIGxvZyBzdHJpcHBpbmcgcGF0dGVybiB0aGF0IHdhcyBm aXhlZCBzZXZlcmFsIHJlbGVhc2VzIGFnby4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv cG9ydC9iYXNlLnB5OgorICAgICAgICAoUG9ydC5jaGVja19idWlsZCk6CisgICAgICAgIChQb3J0 LmNoZWNrX2FwaV90ZXN0X2J1aWxkKToKKyAgICAgICAgKFBvcnQuX2NoZWNrX2RyaXZlcik6Cisg ICAgICAgIChQb3J0Ll9jaGVja19wb3J0X2J1aWxkKTogRGVsZXRlZC4KKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5OgorICAgICAgICAoTWFjUG9ydC5vcGVyYXRpbmdfc3lz dGVtKToKKyAgICAgICAgKE1hY1BvcnQuZGVmYXVsdF9jaGlsZF9wcm9jZXNzZXMpOgorICAgICAg ICAoTWFjUG9ydC5sb2dnaW5nX3BhdHRlcm5zX3RvX3N0cmlwKToKKyAgICAgICAgKE1hY1BvcnQu aXNfbWF2ZXJpY2tzKTogRGVsZXRlZC4KKyAgICAgICAgKE1hY1BvcnQuX2J1aWxkX2phdmFfdGVz dF9zdXBwb3J0KTogRGVsZXRlZC4KKyAgICAgICAgKE1hY1BvcnQuX2NoZWNrX3BvcnRfYnVpbGQp OiBEZWxldGVkLgorCiAyMDE5LTEwLTA5ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgQ29tcGFjdFBvaW50ZXJUdXBsZTwuLi4sIE9w dGlvblNldDwuLi4+PgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jh c2UucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQppbmRleCAwYzhiNmIx YWFiMDU3MzhiZjI4MWFhOGExNWRhYjg1MDkxOWJlNjlhLi5lMjUxY2I4NTAzMTdjY2UzODg5YjMy MzBiNWJkYWIxZTRjNTc0NjY3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvYmFzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQpAQCAt MjQwLDggKzI0MCw2IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKICAgICAgICAgICAgIHJldHVybiBG YWxzZQogICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oJ2luc3RhbGwnKSBhbmQgbm90IHNlbGYu X2NoZWNrX2RyaXZlcigpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCi0gICAgICAgIGlmIHNl bGYuZ2V0X29wdGlvbignaW5zdGFsbCcpIGFuZCBub3Qgc2VsZi5fY2hlY2tfcG9ydF9idWlsZCgp OgotICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAgIGlmIG5vdCBzZWxmLmNoZWNrX2lt YWdlX2RpZmYoKToKICAgICAgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignYnVpbGQnKToKICAg ICAgICAgICAgICAgICByZXR1cm4gc2VsZi5fYnVpbGRfaW1hZ2VfZGlmZigpCkBAIC0yNTQsOCAr MjUyLDYgQEAgY2xhc3MgUG9ydChvYmplY3QpOgogICAgICAgICAgICAgY2Fub25pY2FsaXplZF9i aW5hcmllcyA9IHNlbGYucGF0aF90b19hcGlfdGVzdF9iaW5hcmllcygpLmtleXMoKQogICAgICAg ICBpZiBub3Qgc2VsZi5fcm9vdF93YXNfc2V0IGFuZCBzZWxmLmdldF9vcHRpb24oJ2J1aWxkJykg YW5kIG5vdCBzZWxmLl9idWlsZF9hcGlfdGVzdHMod3RmX29ubHk9KGNhbm9uaWNhbGl6ZWRfYmlu YXJpZXMgPT0gWydUZXN0V1RGJ10pKToKICAgICAgICAgICAgIHJldHVybiBGYWxzZQotICAgICAg ICBpZiBzZWxmLmdldF9vcHRpb24oJ2luc3RhbGwnKSBhbmQgbm90IHNlbGYuX2NoZWNrX3BvcnRf YnVpbGQoKToKLSAgICAgICAgICAgIHJldHVybiBGYWxzZQogCiAgICAgICAgIGZvciBiaW5hcnks IHBhdGggaW4gc2VsZi5wYXRoX3RvX2FwaV90ZXN0X2JpbmFyaWVzKCkuaXRlcml0ZW1zKCk6CiAg ICAgICAgICAgICBpZiBiaW5hcnkgbm90IGluIGNhbm9uaWNhbGl6ZWRfYmluYXJpZXM6CkBAIC0y ODAsMTAgKzI3Niw2IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKICAgICAgICAgICAgIHJldHVybiBG YWxzZQogICAgICAgICByZXR1cm4gVHJ1ZQogCi0gICAgZGVmIF9jaGVja19wb3J0X2J1aWxkKHNl bGYpOgotICAgICAgICAjIFBvcnRzIGNhbiBvdmVycmlkZSB0aGlzIG1ldGhvZCB0byBkbyBhZGRp dGlvbmFsIGNoZWNrcy4KLSAgICAgICAgcmV0dXJuIFRydWUKLQogICAgIGRlZiBjaGVja19zeXNf ZGVwcyhzZWxmKToKICAgICAgICAgIiIiSWYgdGhlIHBvcnQgbmVlZHMgdG8gZG8gc29tZSBydW50 aW1lIGNoZWNrcyB0byBlbnN1cmUgdGhhdCB0aGUKICAgICAgICAgdGVzdHMgY2FuIGJlIHJ1biBz dWNjZXNzZnVsbHksIGl0IHNob3VsZCBvdmVycmlkZSB0aGlzIHJvdXRpbmUuCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L21hYy5weQppbmRleCAyNTZmNzE3YzYzMzFjMDc5ZWI0NTE2MTg0ZDVlZjIzMGI5 MGFhYzdiLi4xOWQ5NWM3ODQ0OTcxZWZhNjZjMjkzNDMyNWE5MGQwNWQ3NGQ4MzcwIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9tYWMucHkKQEAgLTE4MywxMCArMTgzLDYgQEAgY2xhc3MgTWFjUG9y dChEYXJ3aW5Qb3J0KToKICAgICBkZWYgb3BlcmF0aW5nX3N5c3RlbShzZWxmKToKICAgICAgICAg cmV0dXJuICdtYWMnCiAKLSAgICAjIEJlbG9uZ3Mgb24gYSBQbGF0Zm9ybSBvYmplY3QuCi0gICAg ZGVmIGlzX21hdmVyaWNrcyhzZWxmKToKLSAgICAgICAgcmV0dXJuIHNlbGYuX3ZlcnNpb24gPT0g J21hdmVyaWNrcycKLQogICAgIGRlZiBkZWZhdWx0X2NoaWxkX3Byb2Nlc3NlcyhzZWxmLCAqKmt3 YXJncyk6CiAgICAgICAgIGRlZmF1bHRfY291bnQgPSBzdXBlcihNYWNQb3J0LCBzZWxmKS5kZWZh dWx0X2NoaWxkX3Byb2Nlc3NlcygpCiAKQEAgLTIxNiwxOCArMjEyLDYgQEAgY2xhc3MgTWFjUG9y dChEYXJ3aW5Qb3J0KToKICAgICAgICAgICAgIHN1cHBvcnRhYmxlX2luc3RhbmNlcyA9IGRlZmF1 bHRfY291bnQKICAgICAgICAgcmV0dXJuIG1pbihzdXBwb3J0YWJsZV9pbnN0YW5jZXMsIGRlZmF1 bHRfY291bnQpCiAKLSAgICBkZWYgX2J1aWxkX2phdmFfdGVzdF9zdXBwb3J0KHNlbGYpOgotICAg ICAgICAjIEZJWE1FOiBUaGlzIGlzIHVudXNlZC4gUmVtb3ZlLgotICAgICAgICBqYXZhX3Rlc3Rz X3BhdGggPSBzZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5sYXlvdXRfdGVzdHNfZGlyKCksICJq YXZhIikKLSAgICAgICAgYnVpbGRfamF2YSA9IFtzZWxmLm1ha2VfY29tbWFuZCgpLCAiLUMiLCBq YXZhX3Rlc3RzX3BhdGhdCi0gICAgICAgIGlmIHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChi dWlsZF9qYXZhLCByZXR1cm5fZXhpdF9jb2RlPVRydWUpOiAgIyBQYXRocyBhcmUgYWJzb2x1dGUs IHNvIHdlIGRvbid0IG5lZWQgdG8gc2V0IGEgY3dkLgotICAgICAgICAgICAgX2xvZy5lcnJvcigi RmFpbGVkIHRvIGJ1aWxkIEphdmEgc3VwcG9ydCBmaWxlczogJXMiICUgYnVpbGRfamF2YSkKLSAg ICAgICAgICAgIHJldHVybiBGYWxzZQotICAgICAgICByZXR1cm4gVHJ1ZQotCi0gICAgZGVmIF9j aGVja19wb3J0X2J1aWxkKHNlbGYpOgotICAgICAgICByZXR1cm4gbm90IHNlbGYuZ2V0X29wdGlv bignamF2YScpIG9yIHNlbGYuX2J1aWxkX2phdmFfdGVzdF9zdXBwb3J0KCkKLQogICAgIGRlZiBz dGFydF9oZWxwZXIoc2VsZiwgcGl4ZWxfdGVzdHM9RmFsc2UpOgogICAgICAgICBoZWxwZXJfcGF0 aCA9IHNlbGYuX3BhdGhfdG9faGVscGVyKCkKICAgICAgICAgaWYgbm90IGhlbHBlcl9wYXRoOgpA QCAtMjY4LDkgKzI1Miw2IEBAIGNsYXNzIE1hY1BvcnQoRGFyd2luUG9ydCk6CiAgICAgZGVmIGxv Z2dpbmdfcGF0dGVybnNfdG9fc3RyaXAoc2VsZik6CiAgICAgICAgIGxvZ2dpbmdfcGF0dGVybnMg PSBbXQogCi0gICAgICAgICMgRklYTUU6IFJlbW92ZSB0aGlzIGFmdGVyIDxyZGFyOi8vcHJvYmxl bS8xNTYwNTAwNz4gaXMgZml4ZWQuCi0gICAgICAgIGxvZ2dpbmdfcGF0dGVybnMuYXBwZW5kKChy ZS5jb21waWxlKCcoQVZGfEdWQSkgaW5mbzouKlxuJyksICcnKSkKLQogICAgICAgICAjIEZJWE1F OiBSZW1vdmUgdGhpcyBhZnRlciA8cmRhcjovL3Byb2JsZW0vMzU5NTQ0NTk+IGlzIGZpeGVkLgog ICAgICAgICBsb2dnaW5nX3BhdHRlcm5zLmFwcGVuZCgoJ0FWRENyZWF0ZUdQVUFjY2VsZXJhdG9y OiBFcnJvciBsb2FkaW5nIEdQVSByZW5kZXJlclxuJywgJycpKQogCg==