202837 2019-10-10 18:22:46 -0700 results.webkit.org: Sort out certificates on Catalina 2020-04-30 14:15:25 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204513 https://bugs.webkit.org/show_bug.cgi?id=211226 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain achristensen ap commit-queue ews-watchlist glenn webkit-bug-importer oldest_to_newest 1578944 0 jbedard 2019-10-10 18:22:46 -0700 For some reason, our Catalina bots can't verify the results.webkit.org certificate when posting via requests. 1578945 1 jbedard 2019-10-10 18:26:37 -0700 As a temporary measure, I'm going to disable verification for results.webkit.org until we get our certificates sorted out 1578948 2 jbedard 2019-10-10 18:30:32 -0700 Committed r250997: <https://trac.webkit.org/changeset/250997> 1578949 3 webkit-bug-importer 2019-10-10 18:31:14 -0700 <rdar://problem/56177210> 1578950 4 jbedard 2019-10-10 18:31:47 -0700 WebKit patch closed the bug. To be clear, the issue is not resolved, the landed change just works around it temporarily. 1595232 5 384763 jbedard 2019-12-03 15:42:16 -0800 Created attachment 384763 Patch for landing 1595237 6 jbedard 2019-12-03 15:47:27 -0800 We've figured out the issue server-side, removing the insecure work-around. 1595241 7 384763 commit-queue 2019-12-03 15:59:27 -0800 Comment on attachment 384763 Patch for landing Clearing flags on attachment: 384763 Committed r253069: <https://trac.webkit.org/changeset/253069> 1595242 8 commit-queue 2019-12-03 15:59:28 -0800 All reviewed patches have been landed. Closing bug. 1595537 9 jbedard 2019-12-04 11:02:40 -0800 Reverted r253069 for reason: requests not handling certificate chain correctly in Catalina Committed r253117: <https://trac.webkit.org/changeset/253117> 1595538 10 jbedard 2019-12-04 11:04:01 -0800 I though I had this fixed, but apparently I didn't test enough. I think there is something wrong with our Python SSL libraries on Catalina. Curl is happy using the same ca file that requests is relying on, so I think our issue is no longer server-side. 1647476 11 jbedard 2020-04-30 12:04:39 -0700 Thanks to Philippe Normand for pointing out our problem, we had an incomplete certificate chain server-side. Now that this is resolved, we should be able to remove verify=False. 1647482 12 398076 jbedard 2020-04-30 12:13:21 -0700 Created attachment 398076 Patch 1647510 13 aakash_jain 2020-04-30 12:59:14 -0700 rs=me 1647537 14 ews-feeder 2020-04-30 14:15:25 -0700 Committed r260965: <https://trac.webkit.org/changeset/260965> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398076. 384763 2019-12-03 15:42:16 -0800 2020-04-30 12:13:19 -0700 Patch for landing bug-202837-20191203154215.patch text/plain 1651 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MzA2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTEyLTAzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IFNvcnQgb3V0IGNlcnRpZmljYXRlcyBv biBDYXRhbGluYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjAyODM3CisKKyAgICAgICAgVW5yZXZpZXdlZCBpbmZyYXN0cnVjdHVyZSByZXBhaXIuCisK KyAgICAgICAgUmV2ZXJ0aW5nIHRoZSBhY3RpdmUgcGFydHMgb2YgcjI1MDk5NyBub3cgdGhhdCB0 aGUgY2VydGlmaWNhdGVzIGFyZSBzb3J0ZWQgb3V0LgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9yZXN1bHRzL3VwbG9hZC5weToKKyAgICAgICAgKFVwbG9hZC51cGxvYWQpOgorICAgICAg ICAoVXBsb2FkLnVwbG9hZF9hcmNoaXZlKToKKwogMjAxOS0xMi0wMyAgSm9uYXRoYW4gQmVkYXJk ICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgcmVzdWx0cy53ZWJraXQub3JnOiBEZWNy ZWFzZSB0dGwgZm9yIGFyY2hpdmVzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Jlc3Vs dHMvdXBsb2FkLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcmVzdWx0 cy91cGxvYWQucHkJKHJldmlzaW9uIDI1MzA2NikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv cmVzdWx0cy91cGxvYWQucHkJKHdvcmtpbmcgY29weSkKQEAgLTE4NCw3ICsxODQsNiBAQCBjbGFz cyBVcGxvYWQob2JqZWN0KToKICAgICAgICAgICAgICAgICAne317fScuZm9ybWF0KGhvc3RuYW1l LCBzZWxmLlVQTE9BRF9FTkRQT0lOVCksCiAgICAgICAgICAgICAgICAgaGVhZGVycz17J0NvbnRl bnQtdHlwZSc6ICdhcHBsaWNhdGlvbi9qc29uJ30sCiAgICAgICAgICAgICAgICAgZGF0YT1qc29u LmR1bXBzKGRhdGEpLAotICAgICAgICAgICAgICAgIHZlcmlmeT1GYWxzZSwKICAgICAgICAgICAg ICkKICAgICAgICAgZXhjZXB0IHJlcXVlc3RzLmV4Y2VwdGlvbnMuQ29ubmVjdGlvbkVycm9yOgog ICAgICAgICAgICAgbG9nX2xpbmVfZnVuYygnICcgKiA0ICsgJ0ZhaWxlZCB0byB1cGxvYWQgdG8g e30sIHJlc3VsdHMgc2VydmVyIG5vdCBvbmxpbmUnLmZvcm1hdChob3N0bmFtZSkpCkBAIC0yMjIs NyArMjIxLDYgQEAgY2xhc3MgVXBsb2FkKG9iamVjdCk6CiAgICAgICAgICAgICAgICAgJ3t9e30n LmZvcm1hdChob3N0bmFtZSwgc2VsZi5BUkNISVZFX1VQTE9BRF9FTkRQT0lOVCksCiAgICAgICAg ICAgICAgICAgZGF0YT1tZXRhX2RhdGEsCiAgICAgICAgICAgICAgICAgZmlsZXM9ZGljdChmaWxl PWFyY2hpdmUpLAotICAgICAgICAgICAgICAgIHZlcmlmeT1GYWxzZSwKICAgICAgICAgICAgICkK IAogICAgICAgICBleGNlcHQgcmVxdWVzdHMuZXhjZXB0aW9ucy5Db25uZWN0aW9uRXJyb3I6Cg== 398076 2020-04-30 12:13:21 -0700 2020-04-30 14:15:25 -0700 Patch bug-202837-20200430121320.patch text/plain 2599 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MDk1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTA0LTMwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IFNvcnQgb3V0IGNlcnRpZmljYXRlcyBv biBDYXRhbGluYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjAyODM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NjE3NzIxMD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFz Y3JpcHRjb3JlLXRlc3RzOgorICAgICAgICAodXBsb2FkUmVzdWx0cyk6IERvIG5vdCBhbGxvdyBp bnNlY3VyZSByZXF1ZXN0cy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Jlc3VsdHMvdXBs b2FkLnB5OgorICAgICAgICAoVXBsb2FkLnVwbG9hZCk6IFZlcmlmeSBzc2wgY2VydGlmaWNhdGVz LgorICAgICAgICAoVXBsb2FkLnVwbG9hZF9hcmNoaXZlKTogRGl0dG8uCisKIDIwMjAtMDQtMzAg IERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O IChyMjQ3NDkwKTogTGVhayBvZiBNaW5pQnJvd3Nlck5TVGV4dEZpbmRlci5faGlkZUludGVyZmFj ZUNhbGxiYWNrCkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkocmV2 aXNpb24gMjYwOTU1KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMJ KHdvcmtpbmcgY29weSkKQEAgLTkzOCwxMiArOTM4LDcgQEAgc3ViIHVwbG9hZFJlc3VsdHMKICAg ICB9CiAKICAgICBwcmludCAiVXBsb2FkaW5nIHJlc3VsdHMgdG8gJHJlcG9ydFxuIjsKLQotICAg IG15ICRzc2xPcHRpb25zID0gJyc7Ci0gICAgaWYgKCFpc0FwcGxlTWFjV2ViS2l0KCkpIHsKLSAg ICAgICAgJHNzbE9wdGlvbnMgPSAnLS1pbnNlY3VyZSc7Ci0gICAgfQotICAgIG9wZW4oSEFORExF LCAifC0iLCAiY3VybCAtWCBQT1NUICRyZXBvcnQvYXBpL3VwbG9hZCAtSCAnQ29udGVudC1UeXBl OiBhcHBsaWNhdGlvbi9qc29uJyAkc3NsT3B0aW9ucyAtZiAtZCAnXEAtJyIpIG9yIGRpZSAiRmFp bGVkIHRvIG9wZW4gY3VybCI7CisgICAgb3BlbihIQU5ETEUsICJ8LSIsICJjdXJsIC1YIFBPU1Qg JHJlcG9ydC9hcGkvdXBsb2FkIC1IICdDb250ZW50LVR5cGU6IGFwcGxpY2F0aW9uL2pzb24nIC1m IC1kICdcQC0nIikgb3IgZGllICJGYWlsZWQgdG8gb3BlbiBjdXJsIjsKIAogICAgICMgSnNvbiBj b25mb3JtaW5nIHRvIGh0dHBzOi8vcmVzdWx0cy53ZWJraXQub3JnL2RvY3VtZW50YXRpb24jQVBJ LVVwbG9hZHMuCiAgICAgbXkgJGVuY29kZWRVcGxvYWQgPSBlbmNvZGVfanNvbihcJXVwbG9hZCk7 CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Jlc3VsdHMvdXBsb2FkLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcmVzdWx0cy91cGxvYWQucHkJKHJldmlzaW9u IDI2MDk1NSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcmVzdWx0cy91cGxvYWQucHkJKHdv cmtpbmcgY29weSkKQEAgLTE4NCw3ICsxODQsNiBAQCBjbGFzcyBVcGxvYWQob2JqZWN0KToKICAg ICAgICAgICAgICAgICAne317fScuZm9ybWF0KGhvc3RuYW1lLCBzZWxmLlVQTE9BRF9FTkRQT0lO VCksCiAgICAgICAgICAgICAgICAgaGVhZGVycz17J0NvbnRlbnQtdHlwZSc6ICdhcHBsaWNhdGlv bi9qc29uJ30sCiAgICAgICAgICAgICAgICAgZGF0YT1qc29uLmR1bXBzKGRhdGEpLAotICAgICAg ICAgICAgICAgIHZlcmlmeT1GYWxzZSwKICAgICAgICAgICAgICkKICAgICAgICAgZXhjZXB0IHJl cXVlc3RzLmV4Y2VwdGlvbnMuQ29ubmVjdGlvbkVycm9yOgogICAgICAgICAgICAgbG9nX2xpbmVf ZnVuYygnICcgKiA0ICsgJ0ZhaWxlZCB0byB1cGxvYWQgdG8ge30sIHJlc3VsdHMgc2VydmVyIG5v dCBvbmxpbmUnLmZvcm1hdChob3N0bmFtZSkpCkBAIC0yMjIsNyArMjIxLDYgQEAgY2xhc3MgVXBs b2FkKG9iamVjdCk6CiAgICAgICAgICAgICAgICAgJ3t9e30nLmZvcm1hdChob3N0bmFtZSwgc2Vs Zi5BUkNISVZFX1VQTE9BRF9FTkRQT0lOVCksCiAgICAgICAgICAgICAgICAgZGF0YT1tZXRhX2Rh dGEsCiAgICAgICAgICAgICAgICAgZmlsZXM9ZGljdChmaWxlPWFyY2hpdmUpLAotICAgICAgICAg ICAgICAgIHZlcmlmeT1GYWxzZSwKICAgICAgICAgICAgICkKIAogICAgICAgICBleGNlcHQgcmVx dWVzdHMuZXhjZXB0aW9ucy5Db25uZWN0aW9uRXJyb3I6Cg==