202833 2019-10-10 17:24:33 -0700 GenerateAndAllocateRegisters can trivially elide self moves at end of liveness 2019-10-16 12:27:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ews-watchlist mark.lam msaboff saam tsavell tzagallo webkit-bug-importer oldest_to_newest 1578919 0 keith_miller 2019-10-10 17:24:33 -0700 GenerateAndAllocateRegisters can trivially elide self moves at end of liveness 1578923 1 380708 keith_miller 2019-10-10 17:27:53 -0700 Created attachment 380708 Patch 1578940 2 380708 saam 2019-10-10 18:07:24 -0700 Comment on attachment 380708 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380708&action=review > Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:54 > + if (!reg) > + return; should we assert here that nothing in m_currentAllocation points to tmp? 1578951 3 380708 keith_miller 2019-10-10 18:35:23 -0700 Comment on attachment 380708 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380708&action=review >> Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:54 >> + return; > > should we assert here that nothing in m_currentAllocation points to tmp? My intention was that would be handled in the lower loop. I suppose the lower loop could say a disallowed register is allocated to tmp. But that seems very unlikely and probably wouldn’t break anything anyway. Maybe I’m missing something though? 1578952 4 keith_miller 2019-10-10 18:38:50 -0700 Mac debug builder just seems to be down... 1578953 5 380708 saam 2019-10-10 18:39:42 -0700 Comment on attachment 380708 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380708&action=review >>> Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:54 >>> + return; >> >> should we assert here that nothing in m_currentAllocation points to tmp? > > My intention was that would be handled in the lower loop. I suppose the lower loop could say a disallowed register is allocated to tmp. But that seems very unlikely and probably wouldn’t break anything anyway. Maybe I’m missing something though? nope, it's handled. Ignore me. 1578964 6 380708 commit-queue 2019-10-10 19:23:44 -0700 Comment on attachment 380708 Patch Clearing flags on attachment: 380708 Committed r250999: <https://trac.webkit.org/changeset/250999> 1578965 7 commit-queue 2019-10-10 19:23:45 -0700 All reviewed patches have been landed. Closing bug. 1578966 8 webkit-bug-importer 2019-10-10 19:24:16 -0700 <rdar://problem/56178257> 1580176 9 tsavell 2019-10-15 11:03:15 -0700 It looks like the changes in https://trac.webkit.org/changeset/250999/webkit has caused 3 tests to time out on Mac Debug: wasm/iframe-parent-postmessage.html wasm/iframe-postmessage.html wasm/window-postmessage.html Not these tests are taking 25 seconds to pass, or they time out. before they were taking only a few seconds to pass. I was able to reproduce this locally by running the three tests in iterations. 1580628 10 keith_miller 2019-10-16 12:27:52 -0700 (In reply to Truitt Savell from comment #9) > It looks like the changes in https://trac.webkit.org/changeset/250999/webkit > > has caused 3 tests to time out on Mac Debug: > wasm/iframe-parent-postmessage.html > wasm/iframe-postmessage.html > wasm/window-postmessage.html > > Not these tests are taking 25 seconds to pass, or they time out. before they > were taking only a few seconds to pass. I was able to reproduce this locally > by running the three tests in iterations. Opened https://bugs.webkit.org/show_bug.cgi?id=203050 with a fix. 380708 2019-10-10 17:27:53 -0700 2019-10-10 19:23:44 -0700 Patch bug-202833-20191010172751.patch text/plain 5343 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YmZmNzUwNTEyNzBmNjY2MzdiNWRlNTQxZjkyM2MxNzI0NTQwOTkwLi5jMzRlNDQ0YmRmZmUyMDI4 ZjA4NTRjYTQ4YjJhNGFhMmUxNTFkMjc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxOS0xMC0xMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBHZW5lcmF0ZUFuZEFsbG9jYXRlUmVnaXN0ZXJzIGNhbiB0cml2aWFs bHkgZWxpZGUgc2VsZiBtb3ZlcyBhdCBlbmQgb2YgbGl2ZW5lc3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjgzMworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYWxzbyBmaXhlcyBhIGJ1ZyB3aGVy ZSBpZiBhIHRtcCBpcyBtb3ZlZCB0byBpdHNlbGYgYXQgdGhlIGVuZCBvZiBpdHMgbGlmZXRpbWUK KyAgICAgICAgd2Ugd291bGQgbWVzcyB1cCB0aGUgYWNjb3VudGluZyBmb3IgdGhlIHRtcC4KKwor ICAgICAgICBJbiBvcmRlciB0byBjYXRjaCB0aGVzZSBidWdzIGVhcmxpZXIgZHVyaW5nIGdlbmVy YXRpb24gSSBhZGRlZCBhCisgICAgICAgIGNoZWNrQ29uc2lzdGVuY3kgZnVuY3Rpb24gdGhhdCBp ZiBhIHRtcCBpcyBpbiBhIHJlZyB0aGF0IHJlZyBpcworICAgICAgICBub3QgYXZhaWxhYmxlIGFu ZCB0aGF0IHJlZyB0aGlua3MgdGhlIHRtcCBpcyBhbHNvIGFsbG9jYXRlZCBpbiBpdC4KKworICAg ICAgICAqIGIzL0IzQmFuay5oOgorICAgICAgICAoSlNDOjpCMzo6YmFua0ZvclJlZyk6CisgICAg ICAgICogYjMvYWlyL0FpckFsbG9jYXRlUmVnaXN0ZXJzQW5kU3RhY2tBbmRHZW5lcmF0ZUNvZGUu Y3BwOgorICAgICAgICAoSlNDOjpCMzo6QWlyOjpHZW5lcmF0ZUFuZEFsbG9jYXRlUmVnaXN0ZXJz OjpjaGVja0NvbnNpc3RlbmN5KToKKyAgICAgICAgKEpTQzo6QjM6OkFpcjo6R2VuZXJhdGVBbmRB bGxvY2F0ZVJlZ2lzdGVyczo6Z2VuZXJhdGUpOgorICAgICAgICAqIGIzL2Fpci9BaXJBbGxvY2F0 ZVJlZ2lzdGVyc0FuZFN0YWNrQW5kR2VuZXJhdGVDb2RlLmg6CisKIDIwMTktMTAtMTAgIEJhc3Vr ZSBTdXp1a2kgIDxCYXN1a2UuU3V6dWtpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb10g TW92ZSByZW1vdGUgY29tbXVuaWNhdGlvbiBoYW5kbGluZyBmcm9tIFJlbW90ZUluc3BlY3RvclNl cnZlciB0byBSZW1vdGVJbnNwZWN0b3IuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvQjNCYW5rLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNCYW5rLmgKaW5kZXgg MWU5M2JhZDdmMjdmYmI1NmE3YTBiMDJlZjQ4ZjM0ZDc5N2IwODVlZS4uNWJlYmYyNmFjNGM3Njk1 YzY3NzNmNzIzZDI0ZWYzMTJjZWNmMmQ0YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2IzL0IzQmFuay5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM0JhbmsuaApA QCAtMjgsNiArMjgsNyBAQAogI2lmIEVOQUJMRShCM19KSVQpCiAKICNpbmNsdWRlICJCM1R5cGUu aCIKKyNpbmNsdWRlICJSZWcuaCIKIAogbmFtZXNwYWNlIEpTQyB7IG5hbWVzcGFjZSBCMyB7CiAK QEAgLTYzLDYgKzY0LDExIEBAIGlubGluZSBCYW5rIGJhbmtGb3JUeXBlKFR5cGUgdHlwZSkKICAg ICByZXR1cm4gR1A7CiB9CiAKK2lubGluZSBCYW5rIGJhbmtGb3JSZWcoUmVnIHJlZykKK3sKKyAg ICByZXR1cm4gcmVnLmlzR1BSKCkgPyBHUCA6IEZQOworfQorCiB9IH0gLy8gbmFtZXNwYWNlIEpT Qzo6QjMKIAogbmFtZXNwYWNlIFdURiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvYWlyL0FpckFsbG9jYXRlUmVnaXN0ZXJzQW5kU3RhY2tBbmRHZW5lcmF0ZUNvZGUuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJBbGxvY2F0ZVJlZ2lzdGVyc0FuZFN0 YWNrQW5kR2VuZXJhdGVDb2RlLmNwcAppbmRleCAzZjljNzljYjhjNzBkN2ZjMzBiNzJkN2I3MDZi ZGY1ZmQzMjdhMDU2Li5lYTJjN2NjYjMxYjE4MTJhZTZkZDllYTY4NmE3ZGIzNDdmZDg1NDg0IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0FpckFsbG9jYXRlUmVnaXN0 ZXJzQW5kU3RhY2tBbmRHZW5lcmF0ZUNvZGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy9haXIvQWlyQWxsb2NhdGVSZWdpc3RlcnNBbmRTdGFja0FuZEdlbmVyYXRlQ29kZS5jcHAK QEAgLTQ1LDYgKzQ1LDM0IEBAIEdlbmVyYXRlQW5kQWxsb2NhdGVSZWdpc3RlcnM6OkdlbmVyYXRl QW5kQWxsb2NhdGVSZWdpc3RlcnMoQ29kZSYgY29kZSkKICAgICAsIG1fbWFwKGNvZGUpCiB7IH0K IAorQUxXQVlTX0lOTElORSB2b2lkIEdlbmVyYXRlQW5kQWxsb2NhdGVSZWdpc3RlcnM6OmNoZWNr Q29uc2lzdGVuY3koKQoreworI2lmICFBU1NFUlRfRElTQUJMRUQKKyAgICBtX2NvZGUuZm9yRWFj aFRtcChbJl0gKFRtcCB0bXApIHsKKyAgICAgICAgUmVnIHJlZyA9IG1fbWFwW3RtcF0ucmVnOwor ICAgICAgICBpZiAoIXJlZykKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBBU1NFUlQo IW1fYXZhaWxhYmxlUmVnc1t0bXAuYmFuaygpXS5jb250YWlucyhyZWcpKTsKKyAgICAgICAgQVNT RVJUKG1fY3VycmVudEFsbG9jYXRpb24tPmF0KHJlZykgPT0gdG1wKTsKKyAgICB9KTsKKworICAg IGZvciAoUmVnIHJlZyA6IFJlZ2lzdGVyU2V0OjphbGxSZWdpc3RlcnMoKSkgeworICAgICAgICBp ZiAoaXNEaXNhbGxvd2VkUmVnaXN0ZXIocmVnKSkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCisg ICAgICAgIFRtcCB0bXAgPSBtX2N1cnJlbnRBbGxvY2F0aW9uLT5hdChyZWcpOworICAgICAgICBp ZiAoIXRtcCkgeworICAgICAgICAgICAgQVNTRVJUKG1fYXZhaWxhYmxlUmVnc1tiYW5rRm9yUmVn KHJlZyldLmNvbnRhaW5zKHJlZykpOworICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIH0K KworICAgICAgICBBU1NFUlQoIW1fYXZhaWxhYmxlUmVnc1t0bXAuYmFuaygpXS5jb250YWlucyhy ZWcpKTsKKyAgICAgICAgQVNTRVJUKG1fbWFwW3RtcF0ucmVnID09IHJlZyk7CisgICAgfQorI2Vu ZGlmCit9CisKIHZvaWQgR2VuZXJhdGVBbmRBbGxvY2F0ZVJlZ2lzdGVyczo6YnVpbGRMaXZlUmFu Z2VzKFVuaWZpZWRUbXBMaXZlbmVzcyYgbGl2ZW5lc3MpCiB7CiAgICAgbV9saXZlUmFuZ2VFbmQg PSBUbXBNYXA8c2l6ZV90PihtX2NvZGUsIDApOwpAQCAtNDE2LDYgKzQ0NCw4IEBAIHZvaWQgR2Vu ZXJhdGVBbmRBbGxvY2F0ZVJlZ2lzdGVyczo6Z2VuZXJhdGUoQ0NhbGxIZWxwZXJzJiBqaXQpCiAK ICAgICAgICAgYm9vbCBpc1JlcGxheWluZ1NhbWVJbnN0ID0gZmFsc2U7CiAgICAgICAgIGZvciAo c2l6ZV90IGluc3RJbmRleCA9IDA7IGluc3RJbmRleCA8IGJsb2NrLT5zaXplKCk7ICsraW5zdElu ZGV4KSB7CisgICAgICAgICAgICBjaGVja0NvbnNpc3RlbmN5KCk7CisKICAgICAgICAgICAgIGlm IChpbnN0SW5kZXggJiYgIWlzUmVwbGF5aW5nU2FtZUluc3QpCiAgICAgICAgICAgICAgICAgc3Rh cnRMYWJlbCA9IG1faml0LT5sYWJlbElnbm9yaW5nV2F0Y2hwb2ludHMoKTsKIApAQCAtNDQ0LDYg KzQ3NCwxMCBAQCB2b2lkIEdlbmVyYXRlQW5kQWxsb2NhdGVSZWdpc3RlcnM6OmdlbmVyYXRlKEND YWxsSGVscGVycyYgaml0KQogICAgICAgICAgICAgICAgIGlmIChzb3VyY2UuaXNSZWcoKSB8fCBt X2xpdmVSYW5nZUVuZFtzb3VyY2UudG1wKCldICE9IG1fZ2xvYmFsSW5zdEluZGV4KQogICAgICAg ICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKIAorICAgICAgICAgICAgICAgIC8vIElmIHdlIGFy ZSBkb2luZyBhIHNlbGYgbW92ZSBhdCB0aGUgZW5kIG9mIHRoZSB0ZW1wcyBsaXZlbmVzcyB3ZSBj YW4gdHJpdmlhbGx5IGVsaWRlIHRoZSBtb3ZlLgorICAgICAgICAgICAgICAgIGlmIChzb3VyY2Ug PT0gZGVzdCkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgICAgICAg ICAgICAgUmVnIHNvdXJjZVJlZyA9IG1fbWFwW3NvdXJjZS50bXAoKV0ucmVnOwogICAgICAgICAg ICAgICAgIC8vIElmIHRoZSB2YWx1ZSBpcyBub3QgYWxyZWFkeSBtYXRlcmlhbGl6ZWQgaW50byBh IHJlZ2lzdGVyIHdlIG1heSBzdGlsbCBtb3ZlIGl0IGludG8gb25lIHNvIGxldCB0aGUgbm9ybWFs IGdlbmVyYXRpb24gY29kZSBydW4uCiAgICAgICAgICAgICAgICAgaWYgKCFzb3VyY2VSZWcpCkBA IC00NjIsNiArNDk2LDcgQEAgdm9pZCBHZW5lcmF0ZUFuZEFsbG9jYXRlUmVnaXN0ZXJzOjpnZW5l cmF0ZShDQ2FsbEhlbHBlcnMmIGppdCkKICAgICAgICAgICAgICAgICBtX21hcFtzb3VyY2UudG1w KCldLnJlZyA9IFJlZygpOwogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAg ICAgIH0pKCk7CisgICAgICAgICAgICBjaGVja0NvbnNpc3RlbmN5KCk7CiAKICAgICAgICAgICAg IGluc3QuZm9yRWFjaEFyZyhbJl0gKEFyZyYgYXJnLCBBcmc6OlJvbGUgcm9sZSwgQmFuaywgV2lk dGgpIHsKICAgICAgICAgICAgICAgICBpZiAoIWFyZy5pc1RtcCgpKQpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJBbGxvY2F0ZVJlZ2lzdGVyc0FuZFN0YWNrQW5k R2VuZXJhdGVDb2RlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0FpckFsbG9jYXRl UmVnaXN0ZXJzQW5kU3RhY2tBbmRHZW5lcmF0ZUNvZGUuaAppbmRleCBkZjdhM2ZmZjk5MGM1MWFk ZDIxODgyM2NjODk5NTdlYzhhODU0YjY3Li5hYzNjZWJmMjg1MTkyZGM0NmFhNTk1MGI3MjdkZmZk MjRiYzBlZjg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0FpckFs bG9jYXRlUmVnaXN0ZXJzQW5kU3RhY2tBbmRHZW5lcmF0ZUNvZGUuaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYjMvYWlyL0FpckFsbG9jYXRlUmVnaXN0ZXJzQW5kU3RhY2tBbmRHZW5lcmF0 ZUNvZGUuaApAQCAtNjQsNiArNjQsOCBAQCBwcml2YXRlOgogICAgIHZvaWQgYnVpbGRMaXZlUmFu Z2VzKFVuaWZpZWRUbXBMaXZlbmVzcyYpOwogICAgIGJvb2wgaXNEaXNhbGxvd2VkUmVnaXN0ZXIo UmVnKTsKIAorICAgIHZvaWQgY2hlY2tDb25zaXN0ZW5jeSgpOworCiAgICAgQ29kZSYgbV9jb2Rl OwogICAgIENDYWxsSGVscGVycyogbV9qaXQgeyBudWxscHRyIH07CiAK