202831 2019-10-10 17:08:42 -0700 [cmake] Use HINTS instead of PATHS when searching in paths from pkg-config 2019-10-11 02:04:21 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen aperez cgarcia commit-queue ews-watchlist gyuyoung.kim mcatanzaro rakuco ryuan.choi sergio oldest_to_newest 1578908 0 annulen 2019-10-10 17:08:42 -0700 HINTS and PATHS sections are similar, however HINTS is processed before default system locations, while PATHS - after. If target file can be found in the system, pkg-config results are ignored in case of PATHS, making it impossible to override system version of library with PKG_CONFIG_PATH. Note that CMake documentation recommends using PATHS for hard-coded guesses. 1578917 1 380705 annulen 2019-10-10 17:21:22 -0700 Created attachment 380705 Patch 1579036 2 380705 commit-queue 2019-10-11 02:04:19 -0700 Comment on attachment 380705 Patch Clearing flags on attachment: 380705 Committed r251005: <https://trac.webkit.org/changeset/251005> 1579037 3 commit-queue 2019-10-11 02:04:21 -0700 All reviewed patches have been landed. Closing bug. 380705 2019-10-10 17:21:22 -0700 2019-10-11 02:04:19 -0700 Patch bug-202831-20191011032121.patch text/plain 4953 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZEVuY2hhbnQuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZEVuY2hhbnQuY21ha2UKaW5kZXggNTNi OWEwZWQzZmFjMWRhZDY1MjcyM2IyNmEzNjgwMzEyZTBmNDljNi4uOWNkOTc1ODMwMmEwZTNlZjEz YzM0YjNkZDU5NjUzNWFiYzJjYWEzYiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRFbmNo YW50LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kRW5jaGFudC5jbWFrZQpAQCAtMzcsMTMg KzM3LDEzIEBAIGZvcmVhY2ggKEVOQ0hBTlRfTkFNRSBlbmNoYW50LTIgZW5jaGFudCkKIAogICAg IGZpbmRfcGF0aChFTkNIQU5UX0lOQ0xVREVfRElSUwogICAgICAgICBOQU1FUyBlbmNoYW50LmgK LSAgICAgICAgUEFUSFMgJHtQQ19FTkNIQU5UX0lOQ0xVREVESVJ9CisgICAgICAgIEhJTlRTICR7 UENfRU5DSEFOVF9JTkNMVURFRElSfQogICAgICAgICAgICAgICAke1BDX0VOQ0hBTlRfSU5DTFVE RV9ESVJTfQogICAgICkKIAogICAgIGZpbmRfbGlicmFyeShFTkNIQU5UX0xJQlJBUklFUwogICAg ICAgICBOQU1FUyAke0VOQ0hBTlRfTkFNRX0KLSAgICAgICAgUEFUSFMgJHtQQ19FTkNIQU5UX0xJ QkRJUn0KKyAgICAgICAgSElOVFMgJHtQQ19FTkNIQU5UX0xJQkRJUn0KICAgICAgICAgICAgICAg JHtQQ19FTkNIQU5UX0xJQlJBUllfRElSU30KICAgICApCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9j bWFrZS9GaW5kRm9udGNvbmZpZy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kRm9udGNvbmZpZy5j bWFrZQppbmRleCAyZWQ2MDVkNzM5ZDRmMTk2Nzc2MTY4YjA1ZmJiNDdiMDFlNjRkN2ViLi4yZjNh Y2FmZmVhYTNiMjljYThmYzg4YjI4MDdlYTQ4ZWNiNTJiMzZmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv Y21ha2UvRmluZEZvbnRjb25maWcuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRGb250Y29u ZmlnLmNtYWtlCkBAIC00OSwxNiArNDksMTIgQEAgZWxzZSAoRk9OVENPTkZJR19MSUJSQVJJRVMg QU5EIEZPTlRDT05GSUdfSU5DTFVERV9ESVIpCiAgICAgZW5kaWYgKE5PVCBXSU4zMikKIAogICAg IGZpbmRfcGF0aChGT05UQ09ORklHX0lOQ0xVREVfRElSIGZvbnRjb25maWcvZm9udGNvbmZpZy5o Ci0gICAgICAgIFBBVEhTCi0gICAgICAgICR7UENfRk9OVENPTkZJR19JTkNMVURFRElSfQotICAg ICAgICAke1BDX0ZPTlRDT05GSUdfSU5DTFVERV9ESVJTfQotICAgICAgICAvdXNyL1gxMS9pbmNs dWRlCisgICAgICAgIEhJTlRTICR7UENfRk9OVENPTkZJR19JTkNMVURFRElSfSAke1BDX0ZPTlRD T05GSUdfSU5DTFVERV9ESVJTfQorICAgICAgICBQQVRIUyAvdXNyL1gxMS9pbmNsdWRlCiAgICAg KQogCiAgICAgZmluZF9saWJyYXJ5KEZPTlRDT05GSUdfTElCUkFSSUVTIE5BTUVTIGZvbnRjb25m aWcKLSAgICAgICAgUEFUSFMKLSAgICAgICAgJHtQQ19GT05UQ09ORklHX0xJQkRJUn0KLSAgICAg ICAgJHtQQ19GT05UQ09ORklHX0xJQlJBUllfRElSU30KKyAgICAgICAgSElOVFMgJHtQQ19GT05U Q09ORklHX0xJQkRJUn0gJHtQQ19GT05UQ09ORklHX0xJQlJBUllfRElSU30KICAgICApCiAKICAg ICBpbmNsdWRlKEZpbmRQYWNrYWdlSGFuZGxlU3RhbmRhcmRBcmdzKQpkaWZmIC0tZ2l0IGEvU291 cmNlL2NtYWtlL0ZpbmRMaWJFcG94eS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kTGliRXBveHku Y21ha2UKaW5kZXggZTU4OTdiNWVmMTllNWNiZGI4NjBjMGVjYzJkM2Q3ZWIwZmIyOTdkMS4uZTlh N2ExMWEzYTEzMzlkMTc2YjYyMmE0ZDAzNDAzZDBjMWVmMjRhYyAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL0ZpbmRMaWJFcG94eS5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvRmluZExpYkVwb3h5 LmNtYWtlCkBAIC0zNiwxMiArMzYsMTIgQEAgZW5kaWYgKCkKIAogZmluZF9wYXRoKExJQkVQT1hZ X0lOQ0xVREVfRElSUwogICAgIE5BTUVTIGVwb3h5L2dsLmgKLSAgICBQQVRIUyAke1BDX0xJQkVQ T1hZX0lOQ0xVREVESVJ9ICR7UENfTElCRVBPWFlfSU5DTFVERV9ESVJTfQorICAgIEhJTlRTICR7 UENfTElCRVBPWFlfSU5DTFVERURJUn0gJHtQQ19MSUJFUE9YWV9JTkNMVURFX0RJUlN9CiApCiAK IGZpbmRfbGlicmFyeShMSUJFUE9YWV9MSUJSQVJJRVMKICAgICBOQU1FUyBlcG94eQotICAgIFBB VEhTICR7UENfTElCRVBPWFlfTElCRElSfSAke1BDX0xJQkVQT1hZX0xJQlJBUllfRElSU30KKyAg ICBISU5UUyAke1BDX0xJQkVQT1hZX0xJQkRJUn0gJHtQQ19MSUJFUE9YWV9MSUJSQVJZX0RJUlN9 CiApCiAKIG1hcmtfYXNfYWR2YW5jZWQoTElCRVBPWFlfSU5DTFVERV9ESVJTIExJQkVQT1hZX0xJ QlJBUklFUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kTGlidGFzbjEuY21ha2UgYi9T b3VyY2UvY21ha2UvRmluZExpYnRhc24xLmNtYWtlCmluZGV4IDEyZTM2Y2JjYTUxNjgyZWRhMTFm YjQ3NTg1Y2UyNTY3YzZhMWUzZmMuLjE0NzU2NjllYzQ3MzE5NTk1MGFkZWVlMDE2NGM4YTcyOWZi MzI0NzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5kTGlidGFzbjEuY21ha2UKKysrIGIv U291cmNlL2NtYWtlL0ZpbmRMaWJ0YXNuMS5jbWFrZQpAQCAtMzMsMTIgKzMzLDEyIEBAIHBrZ19j aGVja19tb2R1bGVzKFBDX0xJQlRBU04xIGxpYnRhc24xKQogCiBmaW5kX3BhdGgoTElCVEFTTjFf SU5DTFVERV9ESVJTCiAgICAgTkFNRVMgbGlidGFzbjEuaAotICAgIFBBVEhTICR7UENfTElCVEFT TjFfSU5DTFVERURJUn0gJHtQQ19MSUJUQVNOMV9JTkNMVURFX0RJUlN9CisgICAgSElOVFMgJHtQ Q19MSUJUQVNOMV9JTkNMVURFRElSfSAke1BDX0xJQlRBU04xX0lOQ0xVREVfRElSU30KICkKIAog ZmluZF9saWJyYXJ5KExJQlRBU04xX0xJQlJBUklFUwogICAgIE5BTUVTIHRhc24xCi0gICAgUEFU SFMgJHtQQ19MSUJUQVNOMV9MSUJESVJ9ICR7UENfTElCVEFTTjFfTElCUkFSWV9ESVJTfQorICAg IEhJTlRTICR7UENfTElCVEFTTjFfTElCRElSfSAke1BDX0xJQlRBU04xX0xJQlJBUllfRElSU30K ICkKIAogaW5jbHVkZShGaW5kUGFja2FnZUhhbmRsZVN0YW5kYXJkQXJncykKZGlmZiAtLWdpdCBh L1NvdXJjZS9jbWFrZS9GaW5kU3FsaXRlLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRTcWxpdGUu Y21ha2UKaW5kZXggNDdjYWEzNjBjYzRiMjdjZDY0MTZiY2Q3ZjVmMGZhNjQyYmZiYjY0OS4uMTBm YzY1MDhiZjk0YWIxZTYxNWFmNjA2YTEwMWY4NTY4ZjJmZDAxMCAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL0ZpbmRTcWxpdGUuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRTcWxpdGUuY21h a2UKQEAgLTQ3LDE1ICs0NywxMSBAQCBpZiAoTk9UIFdJTjMyKQogZW5kaWYgKE5PVCBXSU4zMikK IAogZmluZF9wYXRoKFNRTElURV9JTkNMVURFX0RJUiBOQU1FUyBzcWxpdGUzLmgKLSAgICBQQVRI UwotICAgICR7UENfU1FMSVRFX0lOQ0xVREVESVJ9Ci0gICAgJHtQQ19TUUxJVEVfSU5DTFVERV9E SVJTfQorICAgIEhJTlRTICR7UENfU1FMSVRFX0lOQ0xVREVESVJ9ICR7UENfU1FMSVRFX0lOQ0xV REVfRElSU30KICkKIAogZmluZF9saWJyYXJ5KFNRTElURV9MSUJSQVJJRVMgTkFNRVMgc3FsaXRl MwotICAgIFBBVEhTCi0gICAgJHtQQ19TUUxJVEVfTElCRElSfQotICAgICR7UENfU1FMSVRFX0xJ QlJBUllfRElSU30KKyAgICBISU5UUyAke1BDX1NRTElURV9MSUJESVJ9ICR7UENfU1FMSVRFX0xJ QlJBUllfRElSU30KICkKIAogaW5jbHVkZShGaW5kUGFja2FnZUhhbmRsZVN0YW5kYXJkQXJncykK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA0OGYzODM3ODQ5Y2U3M2Nl N2EyMGY5OWI3MTgwOTdkMGMwOGU4Y2JhLi40OGQwMTVlNDlmNjQzZjEyZTJkN2Y3NjZlYzM3Yzhl MTU3MmM1M2IwIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjMgQEAKKzIwMTktMTAtMTAgIEtvbnN0YW50aW4gVG9rYXJldiAgPGFubnVsZW5AeWFuZGV4 LnJ1PgorCisgICAgICAgIFtjbWFrZV0gVXNlIEhJTlRTIGluc3RlYWQgb2YgUEFUSFMgd2hlbiBz ZWFyY2hpbmcgaW4gcGF0aHMgZnJvbSBwa2ctY29uZmlnCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI4MzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBISU5UUyBhbmQgUEFUSFMgc2VjdGlvbnMgYXJlIHNp bWlsYXIsIGhvd2V2ZXIgSElOVFMgaXMgcHJvY2Vzc2VkIGJlZm9yZQorICAgICAgICBkZWZhdWx0 IHN5c3RlbSBsb2NhdGlvbnMsIHdoaWxlIFBBVEhTIC0gYWZ0ZXIuIElmIHRhcmdldCBmaWxlIGNh biBiZSBmb3VuZAorICAgICAgICBpbiB0aGUgc3lzdGVtLCBwa2ctY29uZmlnIHJlc3VsdHMgYXJl IGlnbm9yZWQgaW4gY2FzZSBvZiBQQVRIUywgbWFraW5nIGl0CisgICAgICAgIGltcG9zc2libGUg dG8gb3ZlcnJpZGUgc3lzdGVtIHZlcnNpb24gb2YgbGlicmFyeSB3aXRoIFBLR19DT05GSUdfUEFU SC4KKworICAgICAgICBOb3RlIHRoYXQgQ01ha2UgZG9jdW1lbnRhdGlvbiByZWNvbW1lbmRzIHVz aW5nIFBBVEhTIGZvciBoYXJkLWNvZGVkIGd1ZXNzZXMuCisKKyAgICAgICAgKiBTb3VyY2UvY21h a2UvRmluZEVuY2hhbnQuY21ha2U6CisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRGb250Y29u ZmlnLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kTGliRXBveHkuY21ha2U6Cisg ICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRMaWJ0YXNuMS5jbWFrZToKKyAgICAgICAgKiBTb3Vy Y2UvY21ha2UvRmluZFNxbGl0ZS5jbWFrZToKKwogMjAxOS0xMC0wOCAgQWRyaWFuIFBlcmV6IGRl IENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0 ZSBPcHRpb25zV1BFLmNtYWtlIGFuZCBORVdTIGZvciB0aGUgMi4yNy4xIHJlbGVhc2UK