202828 2019-10-10 15:06:58 -0700 Modify JSTests/stress/string-overflow-createError-*.js tests to allow an OOME result. 2019-10-10 16:45:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam webkit-bug-importer ysuzuki oldest_to_newest 1578881 0 mark.lam 2019-10-10 15:06:58 -0700 The tests intentionally allocate a very large string. Hence, for some memory limited configurations, it is perfectly reasonable for the test to throw an Out Of Memory error. 1578882 1 380692 mark.lam 2019-10-10 15:13:48 -0700 Created attachment 380692 propose patch. 1578883 2 380692 ysuzuki 2019-10-10 15:22:24 -0700 Comment on attachment 380692 propose patch. r=me 1578901 3 mark.lam 2019-10-10 16:44:38 -0700 Thanks for the review. Landed in r250995: <http://trac.webkit.org/r250995>. 1578902 4 webkit-bug-importer 2019-10-10 16:45:18 -0700 <rdar://problem/56174573> 380692 2019-10-10 15:13:48 -0700 2019-10-10 15:22:24 -0700 propose patch. bug-202828.patch text/plain 2057 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTA5OTMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDE5LTEwLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBNb2RpZnkgSlNUZXN0cy9zdHJlc3Mvc3RyaW5nLW92ZXJmbG93LWNyZWF0 ZUVycm9yLSouanMgdGVzdHMgdG8gYWxsb3cgYW4gT09NRSByZXN1bHQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI4MjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdHMgaW50ZW50aW9uYWxs eSBhbGxvY2F0ZSBhIHZlcnkgbGFyZ2Ugc3RyaW5nLiAgSGVuY2UsIGZvciBzb21lIG1lbW9yeQor ICAgICAgICBsaW1pdGVkIGNvbmZpZ3VyYXRpb25zLCBpdCBpcyBwZXJmZWN0bHkgcmVhc29uYWJs ZSBmb3IgdGhlIHRlc3QgdG8gdGhyb3cgYW4gT3V0CisgICAgICAgIE9mIE1lbW9yeSBlcnJvci4K KworICAgICAgICAqIHN0cmVzcy9zdHJpbmctb3ZlcmZsb3ctY3JlYXRlRXJyb3ItYnVpbGRlci5q czoKKyAgICAgICAgKiBzdHJlc3Mvc3RyaW5nLW92ZXJmbG93LWNyZWF0ZUVycm9yLWZpdC5qczoK KwogMjAxOS0xMC0wOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGwgb3V0IHIyNTA4NzgKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3N0 cmluZy1vdmVyZmxvdy1jcmVhdGVFcnJvci1idWlsZGVyLmpzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVz dHMvc3RyZXNzL3N0cmluZy1vdmVyZmxvdy1jcmVhdGVFcnJvci1idWlsZGVyLmpzCShyZXZpc2lv biAyNTA5OTIpCisrKyBKU1Rlc3RzL3N0cmVzcy9zdHJpbmctb3ZlcmZsb3ctY3JlYXRlRXJyb3It YnVpbGRlci5qcwkod29ya2luZyBjb3B5KQpAQCAtMTEsNSArMTEsNiBAQCB0cnkgewogCiAvLyB3 aGVuIHRoZSBTdHJpbmdCdWlsZGVyIGZvciB0aGUgZXJyb3IgbWVzc2FnZSBvdmVyZmxvd3MsCiAv LyAib2JqZWN0IGlzIG5vdCBhIGZ1bmN0aW9uIiBpcyB1c2VkIGFzIG1lc3NhZ2UgZm9yIHRoZSBU eXBlRXJyb3IuCi1pZiAoZXhjZXB0aW9uLm1lc3NhZ2UgIT0gIm9iamVjdCBpcyBub3QgYSBmdW5j dGlvbi4iKQoraWYgKGV4Y2VwdGlvbi5tZXNzYWdlICE9ICJvYmplY3QgaXMgbm90IGEgZnVuY3Rp b24uIgorICAgICYmIGV4Y2VwdGlvbiAhPSAiRXJyb3I6IE91dCBvZiBtZW1vcnkiKQogICAgIHRo cm93ICJGQUlMRUQiOwpJbmRleDogSlNUZXN0cy9zdHJlc3Mvc3RyaW5nLW92ZXJmbG93LWNyZWF0 ZUVycm9yLWZpdC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9zdHJpbmctb3ZlcmZs b3ctY3JlYXRlRXJyb3ItZml0LmpzCShyZXZpc2lvbiAyNTA5OTIpCisrKyBKU1Rlc3RzL3N0cmVz cy9zdHJpbmctb3ZlcmZsb3ctY3JlYXRlRXJyb3ItZml0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0x Miw1ICsxMiw2IEBAIHRyeSB7CiAvLyBBbHRob3VnaCB0aGUgbWVzc2FnZSBvZiB0aGUgVHlwZUVy cm9yIGlzIHF1aXRlIGxvbmcsCiAvLyBpdCBzdGlsbCBmaXRzIGludG8gU3RyaW5nOjpNYXhMZW5n dGguIENoZWNrIHRoZSBzdGFydAogLy8gb2YgdGhlIGVycm9yIG1lc3NhZ2UuCi1pZiAoIWV4Y2Vw dGlvbi5tZXNzYWdlLnN0YXJ0c1dpdGgoImZvbyBpcyBub3QgYSBmdW5jdGlvbiIpKQoraWYgKCFl eGNlcHRpb24ubWVzc2FnZS5zdGFydHNXaXRoKCJmb28gaXMgbm90IGEgZnVuY3Rpb24iKQorICAg ICYmIGV4Y2VwdGlvbiAhPSAiRXJyb3I6IE91dCBvZiBtZW1vcnkiKQogICAgIHRocm93ICJGQUlM RUQiOwo=