202806 2019-10-10 10:43:38 -0700 W3C test importer breaks svg files. 2019-11-13 06:56:58 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=137968 InRadar P2 Normal --- 1 clopez clopez cdumez clopez ews-watchlist glenn jbedard webkit-bug-importer youennf oldest_to_newest 1578718 0 clopez 2019-10-10 10:43:38 -0700 The WebKit W3C importer tries to rewrite the xml/html/css files when importing them to rewrite paths and such. The issue is that to decide if rewrite the file or not uses the mimetype and the current code just checks for something like if "xml" in str(mimetype[0]) but svg files have mimetype image/svg+xml so the above becomes true and it tries to rewrite a svg file breaking it. 1578726 1 380658 clopez 2019-10-10 10:52:37 -0700 Created attachment 380658 Patch 1578778 2 380658 jbedard 2019-10-10 12:18:09 -0700 Comment on attachment 380658 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380658&action=review > Tools/Scripts/webkitpy/w3c/test_importer.py:514 > + _log.info("Rewriting: %s" % new_filepath) Can we use .format strings? % encoding doesn't work in Python 3 1578801 3 clopez 2019-10-10 12:56:03 -0700 (In reply to Jonathan Bedard from comment #2) > Comment on attachment 380658 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380658&action=review > > > Tools/Scripts/webkitpy/w3c/test_importer.py:514 > > + _log.info("Rewriting: %s" % new_filepath) > > Can we use .format strings? % encoding doesn't work in Python 3 I think it does work in python3 without issue. $ python3 -c 'var="world"; print("Hello %s" % var)' Hello world 1578805 4 jbedard 2019-10-10 13:01:16 -0700 (In reply to Carlos Alberto Lopez Perez from comment #3) > (In reply to Jonathan Bedard from comment #2) > > Comment on attachment 380658 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=380658&action=review > > > > > Tools/Scripts/webkitpy/w3c/test_importer.py:514 > > > + _log.info("Rewriting: %s" % new_filepath) > > > > Can we use .format strings? % encoding doesn't work in Python 3 > > I think it does work in python3 without issue. > > $ python3 -c 'var="world"; print("Hello %s" % var)' > Hello world You're totally right...not sure why I thought that didn't work in Python3. 1578875 5 380658 clopez 2019-10-10 14:58:02 -0700 Comment on attachment 380658 Patch Clearing flags on attachment: 380658 Committed r250992: <https://trac.webkit.org/changeset/250992> 1578876 6 clopez 2019-10-10 14:58:06 -0700 All reviewed patches have been landed. Closing bug. 1578877 7 webkit-bug-importer 2019-10-10 14:59:17 -0700 <rdar://problem/56170891> 380658 2019-10-10 10:52:37 -0700 2019-10-10 14:58:02 -0700 Patch bug-202806-20191010195232.patch text/plain 2713 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTc2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDUyMGM1ZDI2M2VjMDI4MWVkMDUyMzMxYjRiYzIwZWUw NjU4ZmUxNy4uYjEwYmZiZWJmZDE3ZWVlNTM3ZTY1YzA0NTlmYmQ4OGE4NDUzMjRlMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5 IEBACisyMDE5LTEwLTEwICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFczQyB0ZXN0IGltcG9ydGVyIGJyZWFrcyBzdmcgZmlsZXMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI4MDYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgV2ViS2l0 IFczQyBpbXBvcnRlciB0cmllcyB0byByZXdyaXRlIHRoZSB4bWwvaHRtbC9jc3MgZmlsZXMKKyAg ICAgICAgd2hlbiBpbXBvcnRpbmcgdGhlIHRlc3RzIHRvIHJld3JpdGUgcGF0aHMgYW5kIHN1Y2gu CisKKyAgICAgICAgVGhlIGlzc3VlIGlzIHRoYXQgdG8gZGVjaWRlIGlmIHJld3JpdGUgdGhlIGZp bGUgb3Igbm90IHVzZXMgdGhlCisgICAgICAgIG1pbWV0eXBlIGFuZCB0aGUgY3VycmVudCBjb2Rl IHdhcyBjb21wYXJpbmcgZm9yIHNvbWV0aGluZyBsaWtlCisgICAgICAgIGlmICJ4bWwiIGluIHN0 cihtaW1ldHlwZVswXSkKKworICAgICAgICBCdXQgc3ZnIGZpbGVzIGhhdmUgbWltZXR5cGUgImlt YWdlL3N2Zyt4bWwiIHNvIHRoZSBwcmV2aW91cyBjb2RlCisgICAgICAgIHdhcyB0cnlpbmcgdG8g cmV3cml0ZSBzdmcgZmlsZXMsIGJyZWFraW5nIHRoZW0uCisKKyAgICAgICAgVGhpcyBwYXRjaGVz IGNoYW5nZXMgdGhhdCBjb2RlIHRvIG9ubHkgcmV3cml0ZSBpZiB0aGUgbWltZXR5cGUKKyAgICAg ICAgYWxzbyBjb250YWlucyB0aGUgImFwcGxpY2F0aW9uLyIgb3IgInRleHQvIiBzdHJpbmcuCisK KyAgICAgICAgSXQgYWxzbyBhZGRzIGFuIGluZm8gbG9nIChwcmludGVkIHdoZW4gdmVyYm9zZSBl bmFibGVkKSB0byB0ZWxsCisgICAgICAgIHRoYXQgYSBmaWxlIGhhcyBiZWVuIHJld3JpdHRlbi4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHk6CisgICAg ICAgIChUZXN0SW1wb3J0ZXIuaW1wb3J0X3Rlc3RzKToKKwogMjAxOS0xMC0xMCAgU2lodWkgTGl1 ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSB1bml0IHRlc3QgZm9yIFN0 b3JhZ2VRdW90YU1hbmFnZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNj L3Rlc3RfaW1wb3J0ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2ltcG9y dGVyLnB5CmluZGV4IGNmMTZmM2Q2YTdkZjZmMjdkMjE5OTUwZjViYTJiMzM4NDI0MzVhZjYuLjA1 MWIxYmM3YjEyMDMwZTc5YWU4ZTliMDUzOWFmZTFmMTY0NjQzNWUgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS93M2MvdGVzdF9pbXBvcnRlci5weQpAQCAtNTA5LDcgKzUwOSw5IEBAIGNsYXNz IFRlc3RJbXBvcnRlcihvYmplY3QpOgogICAgICAgICAgICAgICAgICMgT25seSBodG1sLCB4bWws IG9yIGNzcyBzaG91bGQgYmUgY29udmVydGVkCiAgICAgICAgICAgICAgICAgIyBGSVhNRTogRXZl bnR1YWxseSwgc28gc2hvdWxkIGpzIHdoZW4gc3VwcG9ydCBpcyBhZGRlZCBmb3IgdGhpcyB0eXBl IG9mIGNvbnZlcnNpb24KICAgICAgICAgICAgICAgICBtaW1ldHlwZSA9IG1pbWV0eXBlcy5ndWVz c190eXBlKG9yaWdfZmlsZXBhdGgpCi0gICAgICAgICAgICAgICAgaWYgc2hvdWxkX3Jld3JpdGVf ZmlsZXMgYW5kICgnaHRtbCcgaW4gc3RyKG1pbWV0eXBlWzBdKSBvciAneG1sJyBpbiBzdHIobWlt ZXR5cGVbMF0pICBvciAnY3NzJyBpbiBzdHIobWltZXR5cGVbMF0pKToKKyAgICAgICAgICAgICAg ICBpZiBzaG91bGRfcmV3cml0ZV9maWxlcyBhbmQgKCd0ZXh0LycgaW4gc3RyKG1pbWV0eXBlWzBd KSBvciAnYXBwbGljYXRpb24vJyBpbiBzdHIobWltZXR5cGVbMF0pKSBcCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgYW5kICgnaHRtbCcgaW4gc3RyKG1pbWV0eXBlWzBd KSBvciAneG1sJyBpbiBzdHIobWltZXR5cGVbMF0pICBvciAnY3NzJyBpbiBzdHIobWltZXR5cGVb MF0pKToKKyAgICAgICAgICAgICAgICAgICAgX2xvZy5pbmZvKCJSZXdyaXRpbmc6ICVzIiAlIG5l d19maWxlcGF0aCkKICAgICAgICAgICAgICAgICAgICAgdHJ5OgogICAgICAgICAgICAgICAgICAg ICAgICAgY29udmVydGVkX2ZpbGUgPSBjb252ZXJ0X2Zvcl93ZWJraXQobmV3X3BhdGgsIGZpbGVu YW1lPW9yaWdfZmlsZXBhdGgsIHJlZmVyZW5jZV9zdXBwb3J0X2luZm89cmVmZXJlbmNlX3N1cHBv cnRfaW5mbywgaG9zdD1zZWxmLmhvc3QsIGNvbnZlcnRfdGVzdF9oYXJuZXNzX2xpbmtzPXNlbGYu c2hvdWxkX2NvbnZlcnRfdGVzdF9oYXJuZXNzX2xpbmtzKHN1YnBhdGgpLCB3ZWJraXRfdGVzdF9y dW5uZXJfb3B0aW9ucz1zZWxmLl93ZWJraXRfdGVzdF9ydW5uZXJfb3B0aW9ucyhuZXdfZmlsZXBh dGgpKQogICAgICAgICAgICAgICAgICAgICBleGNlcHQ6Cg==