20280 2008-08-04 17:03:06 -0700 REGRESSION: initial selection is not the name or value when double clicking a CSS property 2008-08-05 09:50:11 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy aroben oldest_to_newest 87810 0 timothy 2008-08-04 17:03:06 -0700 THe selection should be the name or value that was doubled clicked to start editing. This regressed when we switched to focus/blur events, since a focus on a content editable region changes the selection. 87811 1 22644 timothy 2008-08-04 17:10:41 -0700 Created attachment 22644 Proposed patch 87817 2 22644 mitz 2008-08-04 17:45:26 -0700 Comment on attachment 22644 Proposed patch r=me 87874 3 timothy 2008-08-05 09:50:11 -0700 Landed in r35563. 22644 2008-08-04 17:10:41 -0700 2008-08-04 17:45:26 -0700 Proposed patch 0002-Makes-the-selection-surround-just-the-name-o.patch text/plain 3072 timothy RnJvbSBjYTcxMDQ4ZmE1ODZjYjQ0YWY3Zjk5ZmYzNTdlMDE0NWNhMDlmOTY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBNb24sIDQgQXVnIDIwMDggMTc6MDk6MzggLTA3MDAKU3ViamVjdDogW1BBVENIXSAgICAg ICAgIE1ha2VzIHRoZSBzZWxlY3Rpb24gc3Vycm91bmQganVzdCB0aGUgbmFtZSBvciB2YWx1ZSB0 aGF0IHdhcwogICAgICAgICBkb3VibGUgY2xpY2tlZCB3aGVuIGVkaXRpbmcgQ1NTIHByb3BlcnRp ZXMuIFRoaXMgcmVncmVzc2VkIHdoZW4KICAgICAgICAgdGhlIEluc3BlY3RvciBzdGFydGVkIHVz aW5nIGZvY3VzL2JsdXIgZXZlbnRzLCBzaW5jZSBhIGZvY3VzIG9uCiAgICAgICAgIGEgY29udGVu dCBlZGl0YWJsZSByZWdpb24gY2hhbmdlcyB0aGUgc2VsZWN0aW9uLgoKICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyODAKCiAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICogcGFnZS9pbnNwZWN0b3IvU3R5bGVzU2lkZWJh clBhbmUuanM6CiAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQu cHJvdG90eXBlLnN0YXJ0RWRpdGluZyk6CiAgICAgICAgQ2hhbmdlIHRoZSBzZWxlY3Rpb24gYWZ0 ZXIgY2FsbGluZyBXZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nLAogICAgICAgIHNpbmNlIFdlYklu c3BlY3Rvci5zdGFydEVkaXRpbmcgd2lsbCBzZXQgYW4gaW5pdGlhbCBzZWxlY3Rpb24KICAgICAg ICBkdWUgdG8gYSBmb2N1cyBldmVudC4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNyArKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wYWdlL2lu c3BlY3Rvci9TdHlsZXNTaWRlYmFyUGFuZS5qcyB8ICAgIDYgKysrKy0tCiAyIGZpbGVzIGNoYW5n ZWQsIDIxIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkYjI2ZTNhLi5kYmUxNWEwIDEw MDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSw1ICsxLDIyIEBACiAyMDA4LTA4LTA0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxl LmNvbT4KIAorICAgICAgICBNYWtlcyB0aGUgc2VsZWN0aW9uIHN1cnJvdW5kIGp1c3QgdGhlIG5h bWUgb3IgdmFsdWUgdGhhdCB3YXMKKyAgICAgICAgZG91YmxlIGNsaWNrZWQgd2hlbiBlZGl0aW5n IENTUyBwcm9wZXJ0aWVzLiBUaGlzIHJlZ3Jlc3NlZCB3aGVuCisgICAgICAgIHRoZSBJbnNwZWN0 b3Igc3RhcnRlZCB1c2luZyBmb2N1cy9ibHVyIGV2ZW50cywgc2luY2UgYSBmb2N1cyBvbgorICAg ICAgICBhIGNvbnRlbnQgZWRpdGFibGUgcmVnaW9uIGNoYW5nZXMgdGhlIHNlbGVjdGlvbi4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyODAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvaW5z cGVjdG9yL1N0eWxlc1NpZGViYXJQYW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxl UHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUuc3RhcnRFZGl0aW5nKToKKyAgICAgICAgQ2hh bmdlIHRoZSBzZWxlY3Rpb24gYWZ0ZXIgY2FsbGluZyBXZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5n LAorICAgICAgICBzaW5jZSBXZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nIHdpbGwgc2V0IGFuIGlu aXRpYWwgc2VsZWN0aW9uCisgICAgICAgIGR1ZSB0byBhIGZvY3VzIGV2ZW50LgorCisyMDA4LTA4 LTA0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKwogICAgICAgICBDaGFu Z2VzIHRoZSBlZGl0aW5nIGJlaGF2aW9yIGluIHRoZSBJbnNwZWN0b3IgdG8gY29tbWl0IGNoYW5n ZXMKICAgICAgICAgd2hlbiBmb2N1cyBpcyBsb3N0LCBpbnN0ZWFkIG9mIHJldmVydGluZyB0aGUg Y2hhbmdlcy4KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9TdHlsZXNTaWRl YmFyUGFuZS5qcyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvU3R5bGVzU2lkZWJhclBhbmUuanMK aW5kZXggZGFmMWM4Zi4uMGM1NDNiZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rv ci9TdHlsZXNTaWRlYmFyUGFuZS5qcworKysgYi9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL1N0eWxl c1NpZGViYXJQYW5lLmpzCkBAIC02ODcsMTEgKzY4NywxMyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQ cm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKCFzZWxlY3RFbGVt ZW50KQogICAgICAgICAgICAgc2VsZWN0RWxlbWVudCA9IHRoaXMubGlzdEl0ZW1FbGVtZW50Owog Ci0gICAgICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50KHNlbGVjdEVs ZW1lbnQsIDAsIHNlbGVjdEVsZW1lbnQsIDEpOwotCiAgICAgICAgIHRoaXMubGlzdEl0ZW1FbGVt ZW50LmhhbmRsZUtleUV2ZW50ID0gdGhpcy5lZGl0aW5nS2V5RG93bi5iaW5kKHRoaXMpOwogCiAg ICAgICAgIFdlYkluc3BlY3Rvci5zdGFydEVkaXRpbmcodGhpcy5saXN0SXRlbUVsZW1lbnQsIHRo aXMuZWRpdGluZ0NvbW1pdHRlZC5iaW5kKHRoaXMpLCB0aGlzLmVkaXRpbmdDYW5jZWxsZWQuYmlu ZCh0aGlzKSwgY29udGV4dCk7CisKKyAgICAgICAgLy8gQ2hhbmdlIHRoZSBzZWxlY3Rpb24gYWZ0 ZXIgY2FsbGluZyBXZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nLCBzaW5jZSBXZWJJbnNwZWN0b3Iu c3RhcnRFZGl0aW5nCisgICAgICAgIC8vIHdpbGwgc2V0IGFuIGluaXRpYWwgc2VsZWN0aW9uIGR1 ZSB0byBhIGZvY3VzIGV2ZW50LgorICAgICAgICB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuc2V0QmFz ZUFuZEV4dGVudChzZWxlY3RFbGVtZW50LCAwLCBzZWxlY3RFbGVtZW50LCAxKTsKICAgICB9LAog CiAgICAgZWRpdGluZ0tleURvd246IGZ1bmN0aW9uKGV2ZW50KQotLSAKMS41LjQuNAoK