202795 2019-10-10 06:22:20 -0700 SpeculativeLoad should use CompletionHandler 2019-10-10 09:38:15 -0700 1 1 1 Unclassified WebKit Page Loading Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis beidson cdumez cgarcia commit-queue ews-watchlist webkit-bug-importer oldest_to_newest 1578617 0 rbuis 2019-10-10 06:22:20 -0700 SpeculativeLoad should use CompletionHandler, as remarked in https://bugs.webkit.org/show_bug.cgi?id=201461 review. 1578619 1 380638 rbuis 2019-10-10 06:25:06 -0700 Created attachment 380638 Patch 1578658 2 380638 cdumez 2019-10-10 08:25:25 -0700 Comment on attachment 380638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380638&action=review > Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:45 > +SpeculativeLoad::SpeculativeLoad(Cache& cache, const GlobalFrameID& globalFrameID, const ResourceRequest& request, std::unique_ptr<NetworkCache::Entry> cacheEntryForValidation, WTF::CompletionHandler<void(std::unique_ptr<NetworkCache::Entry>)>&& completionHandler) No WTF:: please. Same comment applies everywhere below. > Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:-46 > - typedef Function<void (std::unique_ptr<NetworkCache::Entry>)> RevalidationCompletionHandler; Why did you drop the typedef? I would have kept it and simply used a CompletionHandler instead of a Function. 1578673 3 380648 rbuis 2019-10-10 08:53:29 -0700 Created attachment 380648 Patch 1578675 4 380638 rbuis 2019-10-10 08:54:58 -0700 Comment on attachment 380638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380638&action=review >> Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:45 >> +SpeculativeLoad::SpeculativeLoad(Cache& cache, const GlobalFrameID& globalFrameID, const ResourceRequest& request, std::unique_ptr<NetworkCache::Entry> cacheEntryForValidation, WTF::CompletionHandler<void(std::unique_ptr<NetworkCache::Entry>)>&& completionHandler) > > No WTF:: please. Same comment applies everywhere below. Fixed. >> Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:-46 >> - typedef Function<void (std::unique_ptr<NetworkCache::Entry>)> RevalidationCompletionHandler; > > Why did you drop the typedef? I would have kept it and simply used a CompletionHandler instead of a Function. I saw another such usage of CompletionHandler and assumed that was the way to go. 1578696 5 380648 commit-queue 2019-10-10 09:37:20 -0700 Comment on attachment 380648 Patch Clearing flags on attachment: 380648 Committed r250974: <https://trac.webkit.org/changeset/250974> 1578697 6 commit-queue 2019-10-10 09:37:22 -0700 All reviewed patches have been landed. Closing bug. 1578698 7 webkit-bug-importer 2019-10-10 09:38:15 -0700 <rdar://problem/56157710> 380638 2019-10-10 06:25:06 -0700 2019-10-10 08:53:26 -0700 Patch bug-202795-20191010152505.patch text/plain 3483 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5NzJhYzNjYzk4ZWNhOWY4 NDMyNTUwYjdkODQ3OTFmN2FjNmE4MWYuLjJiOWExNGFkMTg0MDRlMzJiOGNhYzk0MGViNWUzMzE0 NGQ2MTMwYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMTAtMTAgIFJvYiBCdWlz ICA8cmJ1aXNAaWdhbGlhLmNvbT4KKworICAgICAgICBTcGVjdWxhdGl2ZUxvYWQgc2hvdWxkIHVz ZSBDb21wbGV0aW9uSGFuZGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAyNzk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU3BlY3VsYXRpdmVMb2FkIHNob3VsZCB1c2UgQ29tcGxldGlvbkhhbmRsZXIs IGFzIHJlbWFya2VkIGluCisgICAgICAgIEJ1ZyAyMDE2NDEgcmV2aWV3LgorCisgICAgICAgICog TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpTcGVjdWxhdGl2ZUxvYWQ6OlNwZWN1bGF0aXZl TG9hZCk6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3Vs YXRpdmVMb2FkLmg6CisKIDIwMTktMTAtMDggIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVy ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtHVEtdIEJ1aWxkIGZhaWxzIHdpdGggRU5B QkxFX1dFQkRSSVZFUj1PRkYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcCBiL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcAppbmRl eCA2YzcyZmFiZTcyZTM1OTQ0OGE3YzFiMjkxY2Q5MGU5NTBlNWJiZTU0Li5iNGU1MGY2ZDQ1ZmQ5 NzEzYTk4NTg1NGJhMjYwZGJlYmU0M2YzZTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZC5jcHAKKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2 ZUxvYWQuY3BwCkBAIC00Miw3ICs0Miw3IEBAIG5hbWVzcGFjZSBOZXR3b3JrQ2FjaGUgewogCiB1 c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAotU3BlY3VsYXRpdmVMb2FkOjpTcGVjdWxhdGl2ZUxv YWQoQ2FjaGUmIGNhY2hlLCBjb25zdCBHbG9iYWxGcmFtZUlEJiBnbG9iYWxGcmFtZUlELCBjb25z dCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIHN0ZDo6dW5pcXVlX3B0cjxOZXR3b3JrQ2FjaGU6 OkVudHJ5PiBjYWNoZUVudHJ5Rm9yVmFsaWRhdGlvbiwgUmV2YWxpZGF0aW9uQ29tcGxldGlvbkhh bmRsZXImJiBjb21wbGV0aW9uSGFuZGxlcikKK1NwZWN1bGF0aXZlTG9hZDo6U3BlY3VsYXRpdmVM b2FkKENhY2hlJiBjYWNoZSwgY29uc3QgR2xvYmFsRnJhbWVJRCYgZ2xvYmFsRnJhbWVJRCwgY29u c3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBzdGQ6OnVuaXF1ZV9wdHI8TmV0d29ya0NhY2hl OjpFbnRyeT4gY2FjaGVFbnRyeUZvclZhbGlkYXRpb24sIFdURjo6Q29tcGxldGlvbkhhbmRsZXI8 dm9pZChzdGQ6OnVuaXF1ZV9wdHI8TmV0d29ya0NhY2hlOjpFbnRyeT4pPiYmIGNvbXBsZXRpb25I YW5kbGVyKQogICAgIDogbV9jYWNoZShjYWNoZSkKICAgICAsIG1fZ2xvYmFsRnJhbWVJRChnbG9i YWxGcmFtZUlEKQogICAgICwgbV9jb21wbGV0aW9uSGFuZGxlcihXVEZNb3ZlKGNvbXBsZXRpb25I YW5kbGVyKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUv TmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmggYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZC5oCmluZGV4IDZjZTc3Zjk5ZWEw MDM0NzNjNjk4MDdmZjg1OTBiMjIxYzJlMmQ0MGMuLmQwOTI1OWFmZjQyOWUzODUwYTQ3NDRjNmJm MWI3YmIwNTVmNDhlMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Y2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmgKKysrIGIvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWQuaApAQCAtMzMs NiArMzMsNyBAQAogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VSZXF1ZXN0Lmg+CiAjaW5jbHVk ZSA8V2ViQ29yZS9SZXNvdXJjZVJlc3BvbnNlLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9TaGFyZWRC dWZmZXIuaD4KKyNpbmNsdWRlIDx3dGYvQ29tcGxldGlvbkhhbmRsZXIuaD4KIAogbmFtZXNwYWNl IFdlYktpdCB7CiAKQEAgLTQzLDggKzQ0LDcgQEAgbmFtZXNwYWNlIE5ldHdvcmtDYWNoZSB7CiBj bGFzcyBTcGVjdWxhdGl2ZUxvYWQgZmluYWwgOiBwdWJsaWMgTmV0d29ya0xvYWRDbGllbnQgewog ICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgotICAgIHR5cGVkZWYgRnVuY3Rp b248dm9pZCAoc3RkOjp1bmlxdWVfcHRyPE5ldHdvcmtDYWNoZTo6RW50cnk+KT4gUmV2YWxpZGF0 aW9uQ29tcGxldGlvbkhhbmRsZXI7Ci0gICAgU3BlY3VsYXRpdmVMb2FkKENhY2hlJiwgY29uc3Qg R2xvYmFsRnJhbWVJRCYsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYsIHN0ZDo6dW5p cXVlX3B0cjxOZXR3b3JrQ2FjaGU6OkVudHJ5PiwgUmV2YWxpZGF0aW9uQ29tcGxldGlvbkhhbmRs ZXImJik7CisgICAgU3BlY3VsYXRpdmVMb2FkKENhY2hlJiwgY29uc3QgR2xvYmFsRnJhbWVJRCYs IGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYsIHN0ZDo6dW5pcXVlX3B0cjxOZXR3b3Jr Q2FjaGU6OkVudHJ5PiwgV1RGOjpDb21wbGV0aW9uSGFuZGxlcjx2b2lkKHN0ZDo6dW5pcXVlX3B0 cjxOZXR3b3JrQ2FjaGU6OkVudHJ5Pik+JiYpOwogCiAgICAgdmlydHVhbCB+U3BlY3VsYXRpdmVM b2FkKCk7CiAKQEAgLTY1LDcgKzY1LDcgQEAgcHJpdmF0ZToKIAogICAgIFJlZjxDYWNoZT4gbV9j YWNoZTsKICAgICBHbG9iYWxGcmFtZUlEIG1fZ2xvYmFsRnJhbWVJRDsKLSAgICBSZXZhbGlkYXRp b25Db21wbGV0aW9uSGFuZGxlciBtX2NvbXBsZXRpb25IYW5kbGVyOworICAgIFdURjo6Q29tcGxl dGlvbkhhbmRsZXI8dm9pZChzdGQ6OnVuaXF1ZV9wdHI8TmV0d29ya0NhY2hlOjpFbnRyeT4pPiBt X2NvbXBsZXRpb25IYW5kbGVyOwogICAgIFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCBtX29yaWdp bmFsUmVxdWVzdDsKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxOZXR3b3JrTG9hZD4gbV9uZXR3b3Jr TG9hZDsK 380648 2019-10-10 08:53:29 -0700 2019-10-10 09:37:20 -0700 Patch bug-202795-20191010175328.patch text/plain 1823 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk1ZjBjYzkwYzYwNGU3ZWY4 Y2ZkZmMwOTY4ODM0ZTc5ODcyYmY5NzUuLmE4NmUyYzY0OWEwMTJiMTg1ZTk2NzQ4NDNmODkwZTQ4 MjA3NGZjMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTAtMTAgIFJvYiBCdWlz ICA8cmJ1aXNAaWdhbGlhLmNvbT4KKworICAgICAgICBTcGVjdWxhdGl2ZUxvYWQgc2hvdWxkIHVz ZSBDb21wbGV0aW9uSGFuZGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAyNzk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU3BlY3VsYXRpdmVMb2FkIHNob3VsZCB1c2UgQ29tcGxldGlvbkhhbmRsZXIs IGFzIHJlbWFya2VkIGluCisgICAgICAgIEJ1ZyAyMDE2NDEgcmV2aWV3LgorCisgICAgICAgICog TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmg6CisKIDIw MTktMTAtMTAgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFJl bW92ZSB1bmlmaWVkIHBsYW4gcnVudGltZSBmbGFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZC5oIGIvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxv YWQuaAppbmRleCA2Y2U3N2Y5OWVhMDAzNDczYzY5ODA3ZmY4NTkwYjIyMWMyZTJkNDBjLi41NDA2 ZDlmODIxOGIzODA1YjQ2OGI2ODljOWJlMmNmOGY2MzgwMDRmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZC5o CisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3Bl Y3VsYXRpdmVMb2FkLmgKQEAgLTMzLDYgKzMzLDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291 cmNlUmVxdWVzdC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VSZXNwb25zZS5oPgogI2lu Y2x1ZGUgPFdlYkNvcmUvU2hhcmVkQnVmZmVyLmg+CisjaW5jbHVkZSA8d3RmL0NvbXBsZXRpb25I YW5kbGVyLmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCkBAIC00Myw3ICs0NCw3IEBAIG5hbWVz cGFjZSBOZXR3b3JrQ2FjaGUgewogY2xhc3MgU3BlY3VsYXRpdmVMb2FkIGZpbmFsIDogcHVibGlj IE5ldHdvcmtMb2FkQ2xpZW50IHsKICAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1Ymxp YzoKLSAgICB0eXBlZGVmIEZ1bmN0aW9uPHZvaWQgKHN0ZDo6dW5pcXVlX3B0cjxOZXR3b3JrQ2Fj aGU6OkVudHJ5Pik+IFJldmFsaWRhdGlvbkNvbXBsZXRpb25IYW5kbGVyOworICAgIHVzaW5nIFJl dmFsaWRhdGlvbkNvbXBsZXRpb25IYW5kbGVyID0gQ29tcGxldGlvbkhhbmRsZXI8dm9pZChzdGQ6 OnVuaXF1ZV9wdHI8TmV0d29ya0NhY2hlOjpFbnRyeT4pPjsKICAgICBTcGVjdWxhdGl2ZUxvYWQo Q2FjaGUmLCBjb25zdCBHbG9iYWxGcmFtZUlEJiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1 ZXN0Jiwgc3RkOjp1bmlxdWVfcHRyPE5ldHdvcmtDYWNoZTo6RW50cnk+LCBSZXZhbGlkYXRpb25D b21wbGV0aW9uSGFuZGxlciYmKTsKIAogICAgIHZpcnR1YWwgflNwZWN1bGF0aXZlTG9hZCgpOwo=