202791 2019-10-10 03:19:44 -0700 SMIL animations of href / xlink:href of <image> have no visual effect 2026-04-29 11:46:08 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/animate-elem-39-t.html BrowserCompat, InRadar P2 Normal --- 1 zimmermann ahmad.saleem792 ahmad.saleem792 bfulgham rwlbuis sabouhallawa webkit-bug-importer zimmermann oldest_to_newest 1578585 0 zimmermann 2019-10-10 03:19:44 -0700 LayoutTests/svg/W3C-SVG-1.1/animate-elem-39-t.svg shows that SMIL animations of the <image> element href / xlink:href have no effect. A quick investigation shows that imageSourceURL() is the culprit, since it simply returns getAttribute(SVGNames::hrefAttr, XLinkNames::hrefAttr) -- which is equal to the serialized baseVal of the underlying SVGAnimatedString, never reflecting the animVal. SVGURIReference::href() returns the right value, and also correctly handles href vs. xlink:href, since the baseVal is either reflecting href, or if xlink:href (if any of them is set). The only issue is that imageSourceURL() returns a reference to a const AtomString, and thus we cannot simply return href(). A quick hack to fix SMIL animations on the aforementioned testcase is: const AtomString& SVGImageElement::imageSourceURL() const { static NeverDestroyed<AtomString> tempAtom("tempAtom", AtomString::ConstructFromLiteral); AtomString& mutableAtom = tempAtom; mutableAtom = href(); return tempAtom; } We either have to give up the "const AtomString&" return value, or add a new AtomString m_imageSourceURL member to SVGImageElement. And obviously we need more test coverage! 1880182 1 webkit-bug-importer 2022-07-01 15:10:35 -0700 <rdar://problem/96316808> 1964567 2 ahmad.saleem792 2023-06-30 14:13:55 -0700 Fixed in Blink by giving up on AtomString& and just returning ("href()"). https://src.chromium.org/viewvc/blink?view=revision&revision=157025 2058811 3 ahmad.saleem792 2024-09-09 18:11:30 -0700 (In reply to Ahmad Saleem from comment #2) > Fixed in Blink by giving up on AtomString& and just returning ("href()"). > > https://src.chromium.org/viewvc/blink?view=revision&revision=157025 SVG link is gone - https://source.chromium.org/chromium/chromium/src/+/93976b6624f40024070bea7dde68e81a3d366173 2192300 4 ahmad.saleem792 2026-03-20 21:44:08 -0700 Pull request: https://github.com/WebKit/WebKit/pull/61066 2195192 5 ews-feeder 2026-03-30 09:30:31 -0700 Committed 310236@main (4a210d1278f1): <https://commits.webkit.org/310236@main> Reviewed commits have been landed. Closing PR #61066 and removing active labels. 2205826 6 bfulgham 2026-04-29 10:09:18 -0700 This change is present in Safari Technology Preview 242. Please install that revision or newer to confirm the fix. Release notes: https://webkit.org/blog/17934/release-notes-for-safari-technology-preview-242/ 2205898 7 bfulgham 2026-04-29 11:46:08 -0700 This change is present in Safari Technology Preview 241. Please install that revision or newer to confirm the fix. Release notes: https://webkit.org/blog/17917/release-notes-for-safari-technology-preview-241/