202784 2019-10-10 02:42:09 -0700 [GTK][WPE] Lots of media related tests crashing or flaky after r250918 - [ Mac WK2 ] Layout Test fast/mediastream/MediaStreamTrack-getSettings.html is a flaky failure 2019-10-11 11:26:48 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez eric.carlson bugs-noreply clopez commit-queue eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw oldest_to_newest 1578570 0 magomez 2019-10-10 02:42:09 -0700 There are lots of tests in both bots crashing with this backtrace: Program terminated with signal SIGFPE, Arithmetic exception. #0 0x00007f80c9d9884f in WebCore::WrappedMockRealtimeAudioSource::render(WTF::Seconds) () from /home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib/libWPEWebKit-1.0.so.3 #1 0x00007f80cac16fdd in WTF::RunLoop::performWork() () from /home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib/libWPEWebKit-1.0.so.3 #2 0x00007f80cac7ac79 in WTF::RunLoop::RunLoop()::{lambda(void*)#1}::_FUN(void*) () from /home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib/libWPEWebKit-1.0.so.3 #3 0x00007f80c23e06b8 in g_main_dispatch (context=0x7f80080572e0) at ../../Source/glib-2.58.1/glib/gmain.c:3182 #4 g_main_context_dispatch (context=context@entry=0x7f80080572e0) at ../../Source/glib-2.58.1/glib/gmain.c:3847 #5 0x00007f80c23e0a78 in g_main_context_iterate (context=0x7f80080572e0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../Source/glib-2.58.1/glib/gmain.c:3920 #6 0x00007f80c23e0d62 in g_main_loop_run (loop=0x7f800818f5c0) at ../../Source/glib-2.58.1/glib/gmain.c:4116 #7 0x00007f80cac7b760 in WTF::RunLoop::run() () from /home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib/libWPEWebKit-1.0.so.3 #8 0x00007f80cac185db in WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) () from /home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib/libWPEWebKit-1.0.so.3 #9 0x00007f80cac7c169 in WTF::wtfThreadEntryPoint(void*) () from /home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib/libWPEWebKit-1.0.so.3 #10 0x00007f80c2bfcfa3 in start_thread (arg=<optimized out>) at pthread_create.c:486 #11 0x00007f80c1d864cf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 The failing tests in the WPE bot are (at least at r250954, there will be more probably) fast/mediastream/MediaDevices-addEventListener.html [ Crash Pass ] fast/mediastream/MediaDevices-getUserMedia.html [ Crash Pass ] fast/mediastream/MediaStream-video-element-remove-track.html [ Crash Pass ] fast/mediastream/MediaStream-video-element.html [ Crash Pass ] fast/mediastream/MediaStreamTrack-getSettings.html [ Crash Pass ] fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html [ Crash Pass ] fast/mediastream/RTCPeerConnection-stable.html [ Crash Pass ] fast/mediastream/apply-constraints-advanced.html [ Crash Pass ] fast/mediastream/constraint-intrinsic-size.html [ Crash Pass ] fast/mediastream/get-user-media-device-id.html [ Crash Failure ] fast/mediastream/getUserMedia-default.html [ Crash Pass ] fast/mediastream/getUserMedia-deny-persistency4.html [ Crash Pass ] fast/mediastream/getUserMedia-grant-persistency2.html [ Crash Pass ] fast/mediastream/getUserMedia-webaudio.html [ Crash Pass Timeout ] fast/mediastream/media-stream-page-muted.html [ Crash Timeout ] fast/mediastream/media-stream-track-muted.html [ Crash Pass ] fast/mediastream/mock-media-source-webaudio.html [ Crash Pass Timeout ] imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys.https.html [ Crash Pass ] imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerwidth.html [ Crash Failure ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-preload-none.https.html [ Crash Pass ] webrtc/filtering-ice-candidate-after-reload.html [ Crash Pass Timeout ] webrtc/negotiatedneeded-event-addStream.html [ Crash Pass ] webrtc/rtcpeerconnection-error-messages.html [ Crash Pass ] webrtc/video-update-often.html [ Crash Pass ] And the tests failing on the GTK bot: fast/mediastream/MediaDevices-getUserMedia.html [ Crash Pass ] fast/mediastream/MediaStream-add-ended-tracks.html [ Crash Timeout ] fast/mediastream/MediaStream-page-muted.html [ Crash Pass Timeout ] fast/mediastream/MediaStream-video-element-remove-track.html [ Crash Failure ] fast/mediastream/MediaStreamTrack-clone.html [ Crash Pass ] fast/mediastream/RTCPeerConnection-onnegotiationneeded.html [ Crash Pass ] fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html [ Crash Pass ] fast/mediastream/apply-constraints-advanced.html [ Crash Pass ] fast/mediastream/apply-constraints-video.html [ Crash Pass ] fast/mediastream/constraint-intrinsic-size.html [ Crash Pass ] fast/mediastream/device-change-event-2.html [ Crash Failure ] fast/mediastream/enumerate-devices-change-event.html [ Crash Pass ] fast/mediastream/getUserMedia-default.html [ Crash Pass ] fast/mediastream/getUserMedia-deny-persistency4.html [ Crash Pass ] fast/mediastream/getUserMedia-grant-persistency2.html [ Crash Pass ] fast/mediastream/getUserMedia-webaudio.html [ Crash Pass Timeout ] fast/mediastream/media-device-info.html [ Crash Pass ] fast/mediastream/media-stream-page-muted.html [ Crash Timeout ] fast/mediastream/mock-media-source-webaudio.html [ Crash Pass Timeout ] http/tests/media/media-stream/device-change-event-in-iframe.html [ Crash Pass ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-preload-none.https.html [ Crash Pass Failure ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https.html [ Crash Pass ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-end-manual.https.html [ Crash Pass ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-init.https.html [ Crash Pass ] webrtc/addICECandidate-closed.html [ Crash Pass ] webrtc/audio-muted-stats.html [ Crash Pass ] webrtc/clone-audio-track.html [ Crash Pass Failure ] webrtc/ephemeral-certificates-and-cnames.html [ Crash Pass ] webrtc/h264-packetization-mode.html [ Crash Pass ] webrtc/ice-candidate-sdpMLineIndex.html [ Crash Pass ] webrtc/peer-connection-audio-mute2.html [ Crash Pass ] 1578609 1 eric.carlson 2019-10-10 05:55:17 -0700 Strange - why was this not caught by the EWS bots? 1578610 2 eric.carlson 2019-10-10 05:55:35 -0700 I'll have a patch with a fix up shortly. 1578611 3 380636 eric.carlson 2019-10-10 06:07:55 -0700 Created attachment 380636 Patch 1578620 4 magomez 2019-10-10 06:27:48 -0700 (In reply to Eric Carlson from comment #3) > Created attachment 380636 [details] > Patch I've checked that it fixes the issue. Thanks Eric!! :) 1578662 5 380636 commit-queue 2019-10-10 08:31:28 -0700 Comment on attachment 380636 Patch Clearing flags on attachment: 380636 Committed r250971: <https://trac.webkit.org/changeset/250971> 1578663 6 commit-queue 2019-10-10 08:31:30 -0700 All reviewed patches have been landed. Closing bug. 1579167 7 clopez 2019-10-11 11:26:48 -0700 (In reply to Eric Carlson from comment #1) > Strange - why was this not caught by the EWS bots? The GTK and WPE EWS bots don't run layout tests. We tried once for GTK but it didn't work well, our tree (regarding layout tests results) is usually close to green but never green. 380636 2019-10-10 06:07:55 -0700 2019-10-10 08:31:28 -0700 Patch bug-202784-20191010060754.patch text/plain 4322 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDc0ZmVmYjcxM2JmNmJj ZjRjNzQxNTdkY2MyYmQ1MTg3NjljMDkzOS4uZjFhMWUzM2M0N2E5ZTgzMTY1NDhjYjMxZDE2YmVk ZmU1NGM2MGUyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEwLTEwICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0g TG90cyBvZiBtZWRpYSByZWxhdGVkIHRlc3RzIGNyYXNoaW5nIG9yIGZsYWt5IGFmdGVyIHIyNTA5 MTggLSBbIE1hYyBXSzIgXSBMYXlvdXQgVGVzdCBmYXN0L21lZGlhc3RyZWFtL01lZGlhU3RyZWFt VHJhY2stZ2V0U2V0dGluZ3MuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjc4NAorCisgICAgICAgIFVucmV2 aWV3ZWQsIGZpeCBHVEsgYW5kIFdQRSB0ZXN0IGNyYXNoZXMuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvTW9ja0dTdHJlYW1lckF1ZGlvQ2FwdHVyZVNvdXJjZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpXcmFwcGVkTW9ja1JlYWx0aW1lQXVkaW9Tb3VyY2U6OnJl bmRlcik6IFJlY29uZmlndXJlIGlmIG5lY2Vzc2FyeS4KKyAgICAgICAgKFdlYkNvcmU6OldyYXBw ZWRNb2NrUmVhbHRpbWVBdWRpb1NvdXJjZTo6cmVjb25maWd1cmUpOiBOZXcsIHNldHVwIGZvciBy ZW5kZXJpbmcuCisgICAgICAgIChXZWJDb3JlOjpXcmFwcGVkTW9ja1JlYWx0aW1lQXVkaW9Tb3Vy Y2U6OnNldHRpbmdzRGlkQ2hhbmdlKTogQ2FsbCByZWNvbmZpZ3VyZS4KKwogMjAxOS0xMC0xMCAg eW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGFzc2VydHMg dG8gTWVkaWFTdHJlYW1Qcml2YXRlIG9ic2VydmVyIHJvdXRpbmVzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvTW9ja0dTdHJlYW1lckF1 ZGlvQ2FwdHVyZVNvdXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9nc3RyZWFtZXIvTW9ja0dTdHJlYW1lckF1ZGlvQ2FwdHVyZVNvdXJjZS5jcHAKaW5kZXggNDJj YjljNmU5ZDdlMjhjYTMwYzNhZDU4Njg0YWI0NGM1NDQ0YWEwOS4uZDhiOTI5Zjk1ZGM5Nzc0MDA3 NDU2ODA0OGYyMDI5NmVlZjZlNDhjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL01vY2tHU3RyZWFtZXJBdWRpb0NhcHR1cmVTb3VyY2Uu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9N b2NrR1N0cmVhbWVyQXVkaW9DYXB0dXJlU291cmNlLmNwcApAQCAtNzMsNiArNzMsOSBAQCBwdWJs aWM6CiAgICAgewogICAgICAgICBBU1NFUlQobV9zcmMpOwogCisgICAgICAgIGlmICghbV9iaXBC b3BCdWZmZXIuc2l6ZSgpKQorICAgICAgICAgICAgcmVjb25maWd1cmUoKTsKKwogICAgICAgICB1 aW50MzJfdCB0b3RhbEZyYW1lQ291bnQgPSBHU1RfUk9VTkRfVVBfMTYoc3RhdGljX2Nhc3Q8c2l6 ZV90PihkZWx0YS5zZWNvbmRzKCkgKiBzYW1wbGVSYXRlKCkpKTsKICAgICAgICAgdWludDMyX3Qg ZnJhbWVDb3VudCA9IHN0ZDo6bWluKHRvdGFsRnJhbWVDb3VudCwgbV9tYXhpbWl1bUZyYW1lQ291 bnQpOwogICAgICAgICB3aGlsZSAoZnJhbWVDb3VudCkgewpAQCAtOTgsMzAgKzEwMSwzNCBAQCBw dWJsaWM6CiAgICAgICAgIH0KICAgICB9CiAKLSAgICB2b2lkIHNldHRpbmdzRGlkQ2hhbmdlKE9w dGlvblNldDxSZWFsdGltZU1lZGlhU291cmNlU2V0dGluZ3M6OkZsYWc+IHNldHRpbmdzKQorICAg IHZvaWQgcmVjb25maWd1cmUoKQogICAgIHsKLSAgICAgICAgaWYgKHNldHRpbmdzLmNvbnRhaW5z KFJlYWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5nczo6RmxhZzo6U2FtcGxlUmF0ZSkpIHsKLSAgICAg ICAgICAgIEdzdEF1ZGlvSW5mbyBpbmZvOwotICAgICAgICAgICAgYXV0byByYXRlID0gc2FtcGxl UmF0ZSgpOwotICAgICAgICAgICAgc2l6ZV90IHNhbXBsZUNvdW50ID0gMiAqIHJhdGU7CisgICAg ICAgIEdzdEF1ZGlvSW5mbyBpbmZvOworICAgICAgICBhdXRvIHJhdGUgPSBzYW1wbGVSYXRlKCk7 CisgICAgICAgIHNpemVfdCBzYW1wbGVDb3VudCA9IDIgKiByYXRlOwogCi0gICAgICAgICAgICBt X21heGltaXVtRnJhbWVDb3VudCA9IFdURjo6cm91bmRVcFRvUG93ZXJPZlR3byhyZW5kZXJJbnRl cnZhbCgpLnNlY29uZHMoKSAqIHNhbXBsZVJhdGUoKSk7Ci0gICAgICAgICAgICBnc3RfYXVkaW9f aW5mb19zZXRfZm9ybWF0KCZpbmZvLCBHU1RfQVVESU9fRk9STUFUX0YzMkxFLCByYXRlLCAxLCBu dWxscHRyKTsKLSAgICAgICAgICAgIG1fc3RyZWFtRm9ybWF0ID0gR1N0cmVhbWVyQXVkaW9TdHJl YW1EZXNjcmlwdGlvbihpbmZvKTsKKyAgICAgICAgbV9tYXhpbWl1bUZyYW1lQ291bnQgPSBXVEY6 OnJvdW5kVXBUb1Bvd2VyT2ZUd28ocmVuZGVySW50ZXJ2YWwoKS5zZWNvbmRzKCkgKiBzYW1wbGVS YXRlKCkpOworICAgICAgICBnc3RfYXVkaW9faW5mb19zZXRfZm9ybWF0KCZpbmZvLCBHU1RfQVVE SU9fRk9STUFUX0YzMkxFLCByYXRlLCAxLCBudWxscHRyKTsKKyAgICAgICAgbV9zdHJlYW1Gb3Jt YXQgPSBHU3RyZWFtZXJBdWRpb1N0cmVhbURlc2NyaXB0aW9uKGluZm8pOwogCi0gICAgICAgICAg ICBpZiAobV9zcmMpCi0gICAgICAgICAgICAgICAgZ3N0X2FwcF9zcmNfc2V0X2NhcHMoR1NUX0FQ UF9TUkMobV9zcmMuZ2V0KCkpLCBtX3N0cmVhbUZvcm1hdC0+Y2FwcygpKTsKKyAgICAgICAgaWYg KG1fc3JjKQorICAgICAgICAgICAgZ3N0X2FwcF9zcmNfc2V0X2NhcHMoR1NUX0FQUF9TUkMobV9z cmMuZ2V0KCkpLCBtX3N0cmVhbUZvcm1hdC0+Y2FwcygpKTsKIAotICAgICAgICAgICAgbV9iaXBC b3BCdWZmZXIuZ3JvdyhzYW1wbGVDb3VudCk7Ci0gICAgICAgICAgICBtX2JpcEJvcEJ1ZmZlci5m aWxsKDApOworICAgICAgICBtX2JpcEJvcEJ1ZmZlci5yZXNpemUoc2FtcGxlQ291bnQpOworICAg ICAgICBtX2JpcEJvcEJ1ZmZlci5maWxsKDApOwogCi0gICAgICAgICAgICBzaXplX3QgYmlwQm9w U2FtcGxlQ291bnQgPSBjZWlsKHNfQmlwQm9wRHVyYXRpb24gKiByYXRlKTsKLSAgICAgICAgICAg IHNpemVfdCBiaXBTdGFydCA9IDA7Ci0gICAgICAgICAgICBzaXplX3QgYm9wU3RhcnQgPSByYXRl OworICAgICAgICBzaXplX3QgYmlwQm9wU2FtcGxlQ291bnQgPSBjZWlsKHNfQmlwQm9wRHVyYXRp b24gKiByYXRlKTsKKyAgICAgICAgc2l6ZV90IGJpcFN0YXJ0ID0gMDsKKyAgICAgICAgc2l6ZV90 IGJvcFN0YXJ0ID0gcmF0ZTsKIAotICAgICAgICAgICAgYWRkSHVtKHNfQmlwQm9wVm9sdW1lLCBz X0JpcEZyZXF1ZW5jeSwgcmF0ZSwgMCwgc3RhdGljX2Nhc3Q8ZmxvYXQqPihtX2JpcEJvcEJ1ZmZl ci5kYXRhKCkgKyBiaXBTdGFydCksIGJpcEJvcFNhbXBsZUNvdW50KTsKLSAgICAgICAgICAgIGFk ZEh1bShzX0JpcEJvcFZvbHVtZSwgc19Cb3BGcmVxdWVuY3ksIHJhdGUsIDAsIHN0YXRpY19jYXN0 PGZsb2F0Kj4obV9iaXBCb3BCdWZmZXIuZGF0YSgpICsgYm9wU3RhcnQpLCBiaXBCb3BTYW1wbGVD b3VudCk7Ci0gICAgICAgIH0KKyAgICAgICAgYWRkSHVtKHNfQmlwQm9wVm9sdW1lLCBzX0JpcEZy ZXF1ZW5jeSwgcmF0ZSwgMCwgc3RhdGljX2Nhc3Q8ZmxvYXQqPihtX2JpcEJvcEJ1ZmZlci5kYXRh KCkgKyBiaXBTdGFydCksIGJpcEJvcFNhbXBsZUNvdW50KTsKKyAgICAgICAgYWRkSHVtKHNfQmlw Qm9wVm9sdW1lLCBzX0JvcEZyZXF1ZW5jeSwgcmF0ZSwgMCwgc3RhdGljX2Nhc3Q8ZmxvYXQqPiht X2JpcEJvcEJ1ZmZlci5kYXRhKCkgKyBib3BTdGFydCksIGJpcEJvcFNhbXBsZUNvdW50KTsKKyAg ICB9CisKKyAgICB2b2lkIHNldHRpbmdzRGlkQ2hhbmdlKE9wdGlvblNldDxSZWFsdGltZU1lZGlh U291cmNlU2V0dGluZ3M6OkZsYWc+IHNldHRpbmdzKQorICAgIHsKKyAgICAgICAgaWYgKHNldHRp bmdzLmNvbnRhaW5zKFJlYWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5nczo6RmxhZzo6U2FtcGxlUmF0 ZSkpCisgICAgICAgICAgICByZWNvbmZpZ3VyZSgpOwogCiAgICAgICAgIE1vY2tSZWFsdGltZUF1 ZGlvU291cmNlOjpzZXR0aW5nc0RpZENoYW5nZShzZXR0aW5ncyk7CiAgICAgfQo=