202778 2019-10-09 18:53:51 -0700 [Cocoa] font-family:system-ui on Chinese systems don't get Chinese quote marks 2019-10-14 14:00:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue darin dino jonlee simon.fraser thorton webkit-bug-importer oldest_to_newest 1578492 0 mmaxfield 2019-10-09 18:53:51 -0700 [Cocoa] font-family:system-ui on Chinese systems don't get Chinese quote marks 1578493 1 380600 mmaxfield 2019-10-09 18:54:58 -0700 Created attachment 380600 Patch 1578494 2 mmaxfield 2019-10-09 18:55:00 -0700 <rdar://problem/52594556> 1578830 3 380600 simon.fraser 2019-10-10 13:51:30 -0700 Comment on attachment 380600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380600&action=review > Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:53 > + if (locale && !CFStringGetLength(locale)) > + locale = nullptr; Should we detect an empty locale in the calling chain? 1578832 4 380600 mmaxfield 2019-10-10 13:56:57 -0700 Comment on attachment 380600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380600&action=review >> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:53 >> + locale = nullptr; > > Should we detect an empty locale in the calling chain? I actually don't think so, since WebKit is robust enough to handle it. We're just trying to work around a quirk of a platform API. 1578864 5 380600 commit-queue 2019-10-10 14:39:02 -0700 Comment on attachment 380600 Patch Clearing flags on attachment: 380600 Committed r250989: <https://trac.webkit.org/changeset/250989> 1578865 6 commit-queue 2019-10-10 14:39:04 -0700 All reviewed patches have been landed. Closing bug. 1578925 7 380600 darin 2019-10-10 17:33:13 -0700 Comment on attachment 380600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380600&action=review >>> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:53 >>> + locale = nullptr; >> >> Should we detect an empty locale in the calling chain? > > I actually don't think so, since WebKit is robust enough to handle it. We're just trying to work around a quirk of a platform API. Seems like this needs a "why" comment. I would not have understood that this is working around a quirk of a platform API. 1579804 8 mmaxfield 2019-10-14 14:00:48 -0700 Committed r251093: <https://trac.webkit.org/changeset/251093> 380600 2019-10-09 18:54:58 -0700 2019-10-10 14:39:02 -0700 Patch bug-202778-20191009185457.patch text/plain 3633 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTI4MmRmYWFhZTM4ZmY0 YWViMTFlNDY5ODU1MmQ1N2RmNzFmMGZhMS4uZjI1ZDMwODQxMGI5YTMyNjBlNTUyMGU4MjU5YjE3 NmIxZjZkNWIyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTEwLTA5ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBm b250LWZhbWlseTpzeXN0ZW0tdWkgb24gQ2hpbmVzZSBzeXN0ZW1zIGRvbid0IGdldCBDaGluZXNl IHF1b3RlIG1hcmtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDI3NzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUyNTk0NTU2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgd2FzIGNhdWdodCBi eSBmYXN0L3RleHQvaW50ZXJuYXRpb25hbC9zeXN0ZW0tbGFuZ3VhZ2UvaGFuLXF1b3Rlcy5odG1s LAorICAgICAgICBidXQgd2UgZGlkbid0IGhhdmUgdGltZSB0byBmaXggaXQgdW50aWwgbm93Lgor CisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC9pbnRlcm5hdGlvbmFsL3N5c3RlbS1sYW5ndWFnZS9o YW4tcXVvdGVzLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1N5c3Rl bUZvbnREYXRhYmFzZUNvcmVUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN5c3RlbUZvbnRE YXRhYmFzZUNvcmVUZXh0OjpjcmVhdGVTeXN0ZW1VSUZvbnQpOgorCiAyMDE5LTEwLTA5ICBSdXNz ZWxsIEVwc3RlaW4gIDxyZXBzdGVpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjI1MDkzMC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NvY29hL1N5c3RlbUZvbnREYXRhYmFzZUNvcmVUZXh0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1N5c3RlbUZvbnREYXRhYmFzZUNvcmVUZXh0 LmNwcAppbmRleCBhYzBlMzRiOWRlNzc2ZGE3NzQxMDk0NWNkNjA3MTQ5NmQ2ZjZjNWIyLi5lNDli YTFhODkyYmFhNDQ4OGVkODg3OWQyNGIwOGZjYjJlMjdjNmY1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9TeXN0ZW1Gb250RGF0YWJhc2VDb3JlVGV4 dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvU3lzdGVt Rm9udERhdGFiYXNlQ29yZVRleHQuY3BwCkBAIC00OSw2ICs0OSw4IEBAIFN5c3RlbUZvbnREYXRh YmFzZUNvcmVUZXh0OjpTeXN0ZW1Gb250RGF0YWJhc2VDb3JlVGV4dCgpCiAKIFJldGFpblB0cjxD VEZvbnRSZWY+IFN5c3RlbUZvbnREYXRhYmFzZUNvcmVUZXh0OjpjcmVhdGVTeXN0ZW1VSUZvbnQo Y29uc3QgQ2FzY2FkZUxpc3RQYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzLCBDRlN0cmluZ1JlZiBsb2Nh bGUpCiB7CisgICAgaWYgKGxvY2FsZSAmJiAhQ0ZTdHJpbmdHZXRMZW5ndGgobG9jYWxlKSkKKyAg ICAgICAgbG9jYWxlID0gbnVsbHB0cjsKICAgICBhdXRvIHJlc3VsdCA9IGFkb3B0Q0YoQ1RGb250 Q3JlYXRlVUlGb250Rm9yTGFuZ3VhZ2Uoa0NURm9udFVJRm9udFN5c3RlbSwgcGFyYW1ldGVycy5z aXplLCBsb2NhbGUpKTsKICAgICBBU1NFUlQocmVzdWx0KTsKICAgICByZXR1cm4gY3JlYXRlRm9u dEJ5QXBwbHlpbmdXZWlnaHRJdGFsaWNzQW5kRmFsbGJhY2tCZWhhdmlvcihyZXN1bHQuZ2V0KCks IHBhcmFtZXRlcnMud2VpZ2h0LCBwYXJhbWV0ZXJzLml0YWxpYywgcGFyYW1ldGVycy5zaXplLCBw YXJhbWV0ZXJzLmFsbG93VXNlckluc3RhbGxlZEZvbnRzKTsKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzYTc5M2E1Y2VlMGQ0 YWViZjIzM2IxYzI4YjM3ZmExNmI2NWIyYjgyLi4yYzFlOThlMWYwMmE0NWIzYTJlYTJkMmFkODY4 ODQ3ZTRjZjExNGQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMTAtMDkgIE15bGVzIEMu IE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIGZvbnQt ZmFtaWx5OnN5c3RlbS11aSBvbiBDaGluZXNlIHN5c3RlbXMgZG9uJ3QgZ2V0IENoaW5lc2UgcXVv dGUgbWFya3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwMjc3OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTI1OTQ1NTY+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGVzdEV4 cGVjdGF0aW9uczoKKwogMjAxOS0xMC0wOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtpT1NdIExheW91dFRlc3QgZmFzdC9ldmVudHMvdG91Y2gvaW9zL2RvdWJs ZS10YXAtZm9yLWRvdWJsZS1jbGljazIuaHRtbCBpcyB0aW1pbmcgb3V0CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDM0MWIyYWE1Y2MyNjI2NGM4YjZlNTNj NjQ3Mjg0YzgyNmExZWFjNDIuLmY3MGQzMGYxNTdiZTk2MjY1NzhmYjA3NWM4ZjRhMGU0MzkxYWQ4 M2UgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xOTc4 LDkgKzE5NzgsNiBAQCB3ZWJraXQub3JnL2IvMTk1NjM1IHNjcm9sbGluZ2Nvb3JkaW5hdG9yL21h Yy9tdWx0aXBsZS1maXhlZC5odG1sIFsgUGFzcyBUaW1lb3V0CiAKIHdlYmtpdC5vcmcvYi8yMDAy NTggWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2FzbS9qc2FwaS9p bnRlcmZhY2UuYW55Lndvcmtlci5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAotIyByZGFyOi8vNTI1 OTQ1NTYgKExheW91dCB0ZXN0IGZhc3QvdGV4dC9pbnRlcm5hdGlvbmFsL3N5c3RlbS1sYW5ndWFn ZS9oYW4tcXVvdGVzLmh0bWwgaXMgZmFpbGluZykKLVsgQ2F0YWxpbmErIF0gZmFzdC90ZXh0L2lu dGVybmF0aW9uYWwvc3lzdGVtLWxhbmd1YWdlL2hhbi1xdW90ZXMuaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMjAwMTI4IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90aGUtdmlkZW8tZWxlbWVudC92 aWRlb190aW1ldXBkYXRlX29uX3NlZWsuaHRtbCBbIFRpbWVvdXQgUGFzcyBdCiAKICMgcmRhcjov LzUyNTU3OTE2IChSRUdSRVNTSU9OOiBmYXN0L2Nzcy9wYWludC1vcmRlci5odG1sIGFuZCBmYXN0 L2Nzcy9wYWludC1vcmRlci1zaGFkb3cuaHRtbCBhcmUgZmFpbGluZykK