20276 2008-08-04 12:10:48 -0700 [GTK] Makefile rules for the enum GTypes files depend on Makefile instead of GNUmakefile 2008-08-06 05:41:27 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED Gtk P2 Minor --- 1 marco.barisione marco.barisione jmalonzo oldest_to_newest 87781 0 marco.barisione 2008-08-04 12:10:48 -0700 The patch committed in revision 34649 added the code needed to generate GTypes for enums but the makefile rules for stamp-webkitenumtypes.h and webkitenumtypes.cpp depend on Makefile instead of GNUmakefile. 87783 1 22636 marco.barisione 2008-08-04 12:15:05 -0700 Created attachment 22636 Depend on GNUmakefile instead of Makefile 87852 2 jmalonzo 2008-08-05 03:56:17 -0700 Good catch. Looks good. 87925 3 22636 eric 2008-08-06 01:27:15 -0700 Comment on attachment 22636 Depend on GNUmakefile instead of Makefile Ok. I'll believe you. 87949 4 jmalonzo 2008-08-06 05:41:17 -0700 landed in r35600 22636 2008-08-04 12:15:05 -0700 2008-08-06 01:27:15 -0700 Depend on GNUmakefile instead of Makefile enum-dependency.patch text/plain 1608 marco.barisione ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5NzRkMDBlLi41ZTk0OTZl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMDgtMDgtMDQgIE1hcmNvIEJhcmlzaW9uZSAgPG1hcmNvLmJhcmlzaW9uZUBjb2xsYWJvcmEu Y28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNzYKKyAgICAgICAgW0dU S10gTWFrZWZpbGUgcnVsZXMgZm9yIHRoZSBlbnVtIEdUeXBlcyBmaWxlcyBkZXBlbmQgb24gTWFr ZWZpbGUKKyAgICAgICAgaW5zdGVhZCBvZiBHTlVtYWtlZmlsZQorCisgICAgICAgIFRoZSBwYXRj aCBjb21taXR0ZWQgaW4gcmV2aXNpb24gMzQ2NDkgYWRkZWQgdGhlIGNvZGUgbmVlZGVkIHRvCisg ICAgICAgIGdlbmVyYXRlIEdUeXBlcyBmb3IgZW51bXMgYnV0IHRoZSBtYWtlZmlsZSBydWxlcyBm b3IKKyAgICAgICAgc3RhbXAtd2Via2l0ZW51bXR5cGVzLmggYW5kIHdlYmtpdGVudW10eXBlcy5j cHAgd2VyZSBkZXBlbmRpbmcgb24KKyAgICAgICAgTWFrZWZpbGUgKHVzZWQgYnkgb3RoZXIgcG9y dHMpIGluc3RlYWQgb2YgR05VbWFrZWZpbGUuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTog RGVwZW5kIG9uIEdOVW1ha2VmaWxlIGluc3RlYWQgb2YgTWFrZWZpbGUuCisKIDIwMDgtMDctMzAg IE1hcmNvIEJhcmlzaW9uZSAgPG1hcmNvLmJhcmlzaW9uZUBjb2xsYWJvcmEuY28udWs+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyLgpkaWZmIC0tZ2l0IGEvR05VbWFrZWZpbGUuYW0gYi9H TlVtYWtlZmlsZS5hbQppbmRleCA5YjJmMDZmLi4yNjI4MmE3IDEwMDY0NAotLS0gYS9HTlVtYWtl ZmlsZS5hbQorKysgYi9HTlVtYWtlZmlsZS5hbQpAQCAtNDAzLDcgKzQwMyw3IEBAIHN0YW1wLXdl YmtpdG1hcnNoYWwuaDogJChXRUJLSVRfTUFSU0hBTF9MSVNUKQogCiBXZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXRlbnVtdHlwZXMuaDogc3RhbXAtd2Via2l0ZW51bXR5cGVzLmgKIAlAdHJ1ZQotc3Rh bXAtd2Via2l0ZW51bXR5cGVzLmg6ICQod2Via2l0Z3RrX2hfYXBpKSBNYWtlZmlsZQorc3RhbXAt d2Via2l0ZW51bXR5cGVzLmg6ICQod2Via2l0Z3RrX2hfYXBpKSBHTlVtYWtlZmlsZQogCShjZCAk KHNyY2RpcikgXAogCSYmIGdsaWItbWtlbnVtcyBcCiAJCQktLWZoZWFkICIjaWZuZGVmIFdFQktJ VF9FTlVNX1RZUEVTX0hcbiIgXApAQCAtNDI1LDcgKzQyNSw3IEBAIHN0YW1wLXdlYmtpdGVudW10 eXBlcy5oOiAkKHdlYmtpdGd0a19oX2FwaSkgTWFrZWZpbGUKIAkmJiBybSAtZiB4Z2VuLWd0aCBc CiAJJiYgZWNobyB0aW1lc3RhbXAgPiAkKEBGKQogCi1EZXJpdmVkU291cmNlcy93ZWJraXRlbnVt dHlwZXMuY3BwOiAkKHdlYmtpdGd0a19oX2FwaSkgTWFrZWZpbGUKK0Rlcml2ZWRTb3VyY2VzL3dl YmtpdGVudW10eXBlcy5jcHA6ICQod2Via2l0Z3RrX2hfYXBpKSBHTlVtYWtlZmlsZQogCShjZCAk KHNyY2RpcikgXAogCSYmIGdsaWItbWtlbnVtcyBcCiAJCQktLWZoZWFkICIjaW5jbHVkZSA8Y29u ZmlnLmg+XG4iIFwK