<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>202748</bug_id>
          
          <creation_ts>2019-10-09 06:30:00 -0700</creation_ts>
          <short_desc>JSC does not compile on 32bits in Debug mode</short_desc>
          <delta_ts>2019-10-14 08:38:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Regression</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paulo Matos">pmatos</reporter>
          <assigned_to name="Paulo Matos">pmatos</assigned_to>
          <cc>saam</cc>
    
    <cc>xan.lopez</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1578210</commentid>
    <comment_count>0</comment_count>
    <who name="Paulo Matos">pmatos</who>
    <bug_when>2019-10-09 06:30:00 -0700</bug_when>
    <thetext>Since bug 202509 got fixed, we cannot build JSC 32bits in Debug mode.

It fails with:
FAILED: DerivedSources/JavaScriptCore/LLIntAssembly.h 
cd /home/pmatos/Projects/igalia/WebKit/WebKitBuild/Debug/DerivedSources/JavaScriptCore &amp;&amp; /usr/bin/ruby /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb -I/home/pmatos/Projects/igalia/WebKit/WebKitBuild/Debug/DerivedSources/JavaScriptCore/ /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm /home/pmatos/Projects/igalia/WebKit/WebKitBuild/Debug/bin/LLIntOffsetsExtractor /home/pmatos/Projects/igalia/WebKit/WebKitBuild/Debug/DerivedSources/JavaScriptCore/LLIntAssembly.h &amp;&amp; /usr/bin/cmake -E touch_nocreate /home/pmatos/Projects/igalia/WebKit/WebKitBuild/Debug/DerivedSources/JavaScriptCore/LLIntAssembly.h
/home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:621:in `validate&apos;: Unresolved temp at /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:782 (RuntimeError)
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:627:in `block in validateChildren&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:625:in `each&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:625:in `validateChildren&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:689:in `validate&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:627:in `block in validateChildren&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:625:in `each&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:625:in `validateChildren&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:634:in `validate&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:403:in `block (3 levels) in &lt;main&gt;&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/settings.rb:107:in `forSettings&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:390:in `block (2 levels) in &lt;main&gt;&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:386:in `each&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:386:in `block in &lt;main&gt;&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:376:in `open&apos;
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:376:in `&lt;main&gt;&apos;

In Release mode, JSC builds successfully but a ton of tests fail with a segmentation fault. I am left wondering why the `validate` seems to be happy in Release and raises an error in Debug mode. I am investigating this issue at the moment, but I am happy to discuss possible issues, if anyone has an idea of what is going wrong.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1578211</commentid>
    <comment_count>1</comment_count>
    <who name="Paulo Matos">pmatos</who>
    <bug_when>2019-10-09 06:31:12 -0700</bug_when>
    <thetext>Apologies - I meant since but 202569 :  [JSC] Change signature of HostFunction to (JSGlobalObject*, CallFrame*)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1579299</commentid>
    <comment_count>2</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-10-11 16:33:34 -0700</bug_when>
    <thetext>This is non-CLoop 32bit issue (32bit JIT enabled JSC) and fixed in r250982.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1579638</commentid>
    <comment_count>3</comment_count>
    <who name="Paulo Matos">pmatos</who>
    <bug_when>2019-10-14 08:38:22 -0700</bug_when>
    <thetext>(In reply to Yusuke Suzuki from comment #2)
&gt; This is non-CLoop 32bit issue (32bit JIT enabled JSC) and fixed in r250982.

Thanks - I confirm. Closing.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>