202742 2019-10-09 05:10:43 -0700 Remove explicit opt-ins to modern media controls from tests 2025-01-20 23:28:29 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts annevk ahmad.saleem792 annevk dino eric.carlson ews-watchlist glenn jer.noble jonlee philipj sergio webkit-bug-importer oldest_to_newest 1578191 0 graouts 2019-10-09 05:10:43 -0700 Remove explicit opt-ins to modern media controls 1578192 1 380529 graouts 2019-10-09 05:11:23 -0700 Created attachment 380529 Patch 1908374 2 ahmad.saleem792 2022-10-26 03:50:33 -0700 We still have these: https://github.com/WebKit/WebKit/blob/main/LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering.html https://github.com/WebKit/WebKit/blob/main/LayoutTests/media/ios/viewport-change-with-video.html https://github.com/WebKit/WebKit/blob/main/LayoutTests/media/modern-media-controls/media-documents/insert-style-should-not-crash.html and it seems this r+ patch didn't landed while checking using BugID on Webkit GitHub. Do we still need to land this? Thanks! 2088502 3 annevk 2025-01-20 05:40:42 -0800 Pull request: https://github.com/WebKit/WebKit/pull/39292 2088629 4 ews-feeder 2025-01-20 23:21:30 -0800 Committed 289171@main (7829051d4c24): <https://commits.webkit.org/289171@main> Reviewed commits have been landed. Closing PR #39292 and removing active labels. 2088634 5 webkit-bug-importer 2025-01-20 23:26:59 -0800 <rdar://problem/143299579> 380529 2019-10-09 05:11:23 -0700 2019-10-09 08:44:38 -0700 Patch bug-202742-20191009141122.patch text/plain 2875 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwODk4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODU0ZmEwOTM0NzVhNTU2NTVlOTE0 ZDgwYmMwMGE1NTNiODE2Mjg3Zi4uMzlmZWZjZWViMTk4NDBjM2MxY2ExNzdmNjQ3MzYxMjBkNDNh MDZjMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEwLTA5ICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGV4cGxpY2l0IG9wdC1pbnMgdG8g bW9kZXJuIG1lZGlhIGNvbnRyb2xzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDI3NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIGlzIHRoZSBkZWZhdWx0IHNldHRpbmcuIAorCisgICAgICAgICog bWVkaWEvaW9zL3ZpZXdwb3J0LWNoYW5nZS13aXRoLXZpZGVvLmh0bWw6CisgICAgICAgICogbWVk aWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWRvY3VtZW50cy9iYWNrZ3JvdW5kLWNvbG9y LWFuZC1jZW50ZXJpbmcuaHRtbDoKKyAgICAgICAgKiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJv bHMvbWVkaWEtZG9jdW1lbnRzL2luc2VydC1zdHlsZS1zaG91bGQtbm90LWNyYXNoLmh0bWw6CisK IDIwMTktMTAtMDggIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBQYXJ0aWFsbHkgdW5kbyByMjUwODExCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9p b3Mvdmlld3BvcnQtY2hhbmdlLXdpdGgtdmlkZW8uaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL2lv cy92aWV3cG9ydC1jaGFuZ2Utd2l0aC12aWRlby5odG1sCmluZGV4IGE2Y2JlMWRiMzJmNTUwNWFk YmJhMzJkYjI1ZWVjZjUzNmM2NGMwYWQuLjY3ZjI3YWU2YmI1Y2E3ZGI5YjAxMDE1MTQyODBhNmM5 ODExZTUxZWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL2lvcy92aWV3cG9ydC1jaGFu Z2Utd2l0aC12aWRlby5odG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlhL2lvcy92aWV3cG9ydC1j aGFuZ2Utd2l0aC12aWRlby5odG1sCkBAIC0xLDQgKzEsNCBAQAotPCFET0NUWVBFIGh0bWw+PCEt LSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBtb2Rlcm5NZWRpYUNvbnRyb2xzPXRydWUgdXNlRmxleGli bGVWaWV3cG9ydD10cnVlIF0gLS0+Cis8IURPQ1RZUEUgaHRtbD48IS0tIHdlYmtpdC10ZXN0LXJ1 bm5lciBbIHVzZUZsZXhpYmxlVmlld3BvcnQ9dHJ1ZSBdIC0tPgogPGh0bWw+CiA8Ym9keT4KIDxw PlRoaXMgdGVzdHMgY2hhbmdpbmcgdGhlIHZpZXdwb3J0IGFmdGVyIGEgdmlkZW8gZWxlbWVudC4g V2ViS2l0IHNob3VsZCBub3QgY3Jhc2guPC9wPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk aWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWRvY3VtZW50cy9iYWNrZ3JvdW5kLWNvbG9y LWFuZC1jZW50ZXJpbmcuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250 cm9scy9tZWRpYS1kb2N1bWVudHMvYmFja2dyb3VuZC1jb2xvci1hbmQtY2VudGVyaW5nLmh0bWwK aW5kZXggYzY4NTM4NDI0MjMzNzdlYTQ2MzIzMzcyNzE1MTkxOTdhMjg1MGI1OS4uMmY4NDMxOGUw YWMyNjNmOGVmMjFlM2FlZTNkODM0ZDU2NDUzYTIwZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv bWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWRvY3VtZW50cy9iYWNrZ3JvdW5kLWNv bG9yLWFuZC1jZW50ZXJpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVk aWEtY29udHJvbHMvbWVkaWEtZG9jdW1lbnRzL2JhY2tncm91bmQtY29sb3ItYW5kLWNlbnRlcmlu Zy5odG1sCkBAIC0xLDIgKzEsMiBAQAotPCFET0NUWVBFIGh0bWw+PCEtLSB3ZWJraXQtdGVzdC1y dW5uZXIgWyBtb2Rlcm5NZWRpYUNvbnRyb2xzPXRydWUgXSAtLT4KKzwhRE9DVFlQRSBodG1sPgog PGlmcmFtZSBzcmM9Ii4uLy4uL2NvbnRlbnQvdGVzdC5tcDQiIHN0eWxlPSJ3aWR0aDogMzYwcHg7 IGhlaWdodDogNDAwcHg7IGJvcmRlcjogbm9uZTsgLXdlYmtpdC1jbGlwLXBhdGg6IHBvbHlnb24o MHB4IDBweCwgMjBweCAwcHgsIDIwcHggMjBweCwgMHB4IDIwcHgpOyI+PC9pZnJhbWU+CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtZG9j dW1lbnRzL2luc2VydC1zdHlsZS1zaG91bGQtbm90LWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9t ZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtZG9jdW1lbnRzL2luc2VydC1zdHlsZS1z aG91bGQtbm90LWNyYXNoLmh0bWwKaW5kZXggOGE0OWJkZTBlMTEwODEyMDNhYzQ3YjQ1MDEzNmE0 NjA5ODcyMWJmYi4uMjE4MTVkMjViYWY3YjRmMzQ2ZmJiYjU3MmExNTU4OTc3NGVmOTc1OSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWRv Y3VtZW50cy9pbnNlcnQtc3R5bGUtc2hvdWxkLW5vdC1jcmFzaC5odG1sCisrKyBiL0xheW91dFRl c3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS1kb2N1bWVudHMvaW5zZXJ0LXN0 eWxlLXNob3VsZC1ub3QtY3Jhc2guaHRtbApAQCAtMSw0ICsxLDQgQEAKLTwhRE9DVFlQRSBodG1s PjwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgbW9kZXJuTWVkaWFDb250cm9scz10cnVlIF0gLS0+ Cis8IURPQ1RZUEUgaHRtbD4KIDxzY3JpcHQ+CiBpZiAod2luZG93LnRlc3RSdW5uZXIpCiAgICAg dGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cg==