202735 2019-10-09 02:15:23 -0700 MediaTime pretty printer can print if time is invalid 2019-10-11 01:22:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 calvaris calvaris benjamin cdumez cmarcelo commit-queue dbates eric.carlson ews-watchlist glenn iamluispureevil jer.noble philipj philn sergio webkit-bug-importer oldest_to_newest 1578159 0 calvaris 2019-10-09 02:15:23 -0700 MediaTime pretty printer can print if time is invalid 1578160 1 380522 calvaris 2019-10-09 02:16:50 -0700 Created attachment 380522 Patch 1578239 2 380522 eric.carlson 2019-10-09 08:41:53 -0700 Comment on attachment 380522 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380522&action=review > Source/WTF/wtf/MediaTime.cpp:598 > + if (isInvalid()) > + builder.appendLiteral(", invalid"); It would be nice to fix MediaTime::toJSONObject as well. Something like: if (isInvalid()) object->setBoolean("invalid"_s, true); 1578603 3 380634 calvaris 2019-10-10 05:06:07 -0700 Created attachment 380634 Patch 1578604 4 380635 calvaris 2019-10-10 05:07:23 -0700 Created attachment 380635 Patch for landing 1578626 5 380635 calvaris 2019-10-10 06:58:21 -0700 Comment on attachment 380635 Patch for landing I'll land this tomorrow in the morning. 1579023 6 380635 commit-queue 2019-10-11 01:21:09 -0700 Comment on attachment 380635 Patch for landing Clearing flags on attachment: 380635 Committed r251003: <https://trac.webkit.org/changeset/251003> 1579024 7 commit-queue 2019-10-11 01:21:11 -0700 All reviewed patches have been landed. Closing bug. 1579025 8 webkit-bug-importer 2019-10-11 01:22:19 -0700 <rdar://problem/56184195> 380522 2019-10-09 02:16:50 -0700 2019-10-10 05:06:04 -0700 Patch bug-202735-20191009111649.patch text/plain 1239 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDFmMGY1YmYxZWU3Nzc5YjA5MmZhMDJj YjA5N2ZlNmQzN2ZmZWJkOWIuLmNjZGUxMDk3NjE5MmJkOTQxMTBkNmI5MDZkNDlkMWY0MjFkZTc2 ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMTAtMDkgIFhhYmllciBSb2RyaWd1ZXogQ2Fs dmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KKworICAgICAgICBNZWRpYVRpbWUgcHJldHR5IHBy aW50ZXIgY2FuIHByaW50IGlmIHRpbWUgaXMgaW52YWxpZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvTWVkaWFUaW1lLmNwcDoKKyAgICAgICAg KFdURjo6TWVkaWFUaW1lOjp0b1N0cmluZyBjb25zdCk6IEFwcGVuZCAiLCBpbnZhbGlkIiBpZiBp c0ludmFsaWQoKS4KKwogMjAxOS0xMC0wNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KIAogICAgICAgICBCdWlsZCBmYWlsdXJlIGluIFdlYkhUTUxWaWV3Lm1tIHdpdGggdGhl IHB1YmxpYyBTREsgKFhjb2RlIDExIGFuZCBNb2phdmUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L3d0Zi9NZWRpYVRpbWUuY3BwIGIvU291cmNlL1dURi93dGYvTWVkaWFUaW1lLmNwcAppbmRleCBi NzJjZWM3ZjJlNGUzZDJmYWZjNWYwNGQ4ODA3MTU5MjAyYjUzYmU2Li5mNGY1OWUzMTBjNjU3MmEw MzNhNjdkNjFiMjZlYmUzYzI5Y2YxN2IyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9NZWRp YVRpbWUuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5jcHAKQEAgLTU5NCw2ICs1 OTQsOCBAQCBTdHJpbmcgTWVkaWFUaW1lOjp0b1N0cmluZygpIGNvbnN0CiAgICAgICAgIGJ1aWxk ZXIuYXBwZW5kTGl0ZXJhbCgiID0gIik7CiAgICAgfQogICAgIGJ1aWxkZXIuYXBwZW5kRml4ZWRQ cmVjaXNpb25OdW1iZXIodG9Eb3VibGUoKSk7CisgICAgaWYgKGlzSW52YWxpZCgpKQorICAgICAg ICBidWlsZGVyLmFwcGVuZExpdGVyYWwoIiwgaW52YWxpZCIpOwogICAgIGJ1aWxkZXIuYXBwZW5k KCd9Jyk7CiAgICAgcmV0dXJuIGJ1aWxkZXIudG9TdHJpbmcoKTsKIH0K 380634 2019-10-10 05:06:07 -0700 2019-10-10 05:07:19 -0700 Patch bug-202735-20191010140606.patch text/plain 1683 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDkzMDc4YTE5YTU5YTRjMDY1MmFlODhj MmViMjViNDFkY2IzMzQwMDkuLjBjY2ZjNmEwZWY1NzRmZTQ5NzEyZTEzOWY1OWEwZjhkMTRlOTlh OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTAtMTAgIFhhYmllciBSb2RyaWd1ZXogQ2Fs dmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KKworICAgICAgICBNZWRpYVRpbWUgcHJldHR5IHBy aW50ZXIgY2FuIHByaW50IGlmIHRpbWUgaXMgaW52YWxpZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvTWVkaWFUaW1lLmNwcDoKKyAgICAgICAg KFdURjo6TWVkaWFUaW1lOjp0b1N0cmluZyBjb25zdCk6IEFwcGVuZCAiLCBpbnZhbGlkIiBpZiBp c0ludmFsaWQoKS4KKyAgICAgICAgKFdURjo6TWVkaWFUaW1lOjp0b0pTT05PYmplY3QgY29uc3Qp OiBTZXQgYm9vbGVhbiBpbnZhbGlkIHRvIHRydWUKKyAgICAgICAgd2hlbiBpbnZhbGlkLgorCiAy MDE5LTEwLTA5ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZW1vdmUgc29tZSBzdXBwb3J0IGZvciA8IGlPUyAxMwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvTWVkaWFUaW1lLmNwcCBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5jcHAKaW5kZXggYjcy Y2VjN2YyZTRlM2QyZmFmYzVmMDRkODgwNzE1OTIwMmI1M2JlNi4uNDE0YTliNGZkZWQ1ZGFmZjc4 ZjE0ZDAzNDhkMmU5YzQwYzM2ZjMxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWVkaWFU aW1lLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuY3BwCkBAIC01OTQsNiArNTk0 LDggQEAgU3RyaW5nIE1lZGlhVGltZTo6dG9TdHJpbmcoKSBjb25zdAogICAgICAgICBidWlsZGVy LmFwcGVuZExpdGVyYWwoIiA9ICIpOwogICAgIH0KICAgICBidWlsZGVyLmFwcGVuZEZpeGVkUHJl Y2lzaW9uTnVtYmVyKHRvRG91YmxlKCkpOworICAgIGlmIChpc0ludmFsaWQoKSkKKyAgICAgICAg YnVpbGRlci5hcHBlbmRMaXRlcmFsKCIsIGludmFsaWQiKTsKICAgICBidWlsZGVyLmFwcGVuZCgn fScpOwogICAgIHJldHVybiBidWlsZGVyLnRvU3RyaW5nKCk7CiB9CkBAIC02MDcsNyArNjA5LDkg QEAgUmVmPEpTT046Ok9iamVjdD4gTWVkaWFUaW1lOjp0b0pTT05PYmplY3QoKSBjb25zdAogICAg ICAgICByZXR1cm4gb2JqZWN0OwogICAgIH0KIAotICAgIGlmIChpc0ludmFsaWQoKSB8fCBpc0lu ZGVmaW5pdGUoKSkKKyAgICBpZiAoaXNJbnZhbGlkKCkpCisgICAgICAgIG9iamVjdC0+c2V0Qm9v bGVhbigiaW52YWxpZCJfcywgdHJ1ZSk7CisgICAgZWxzZSBpZiAoaXNJbmRlZmluaXRlKCkpCiAg ICAgICAgIG9iamVjdC0+c2V0U3RyaW5nKCJ2YWx1ZSJfcywgIk5hTiJfcyk7CiAgICAgZWxzZSBp ZiAoaXNQb3NpdGl2ZUluZmluaXRlKCkpCiAgICAgICAgIG9iamVjdC0+c2V0U3RyaW5nKCJ2YWx1 ZSJfcywgIlBPU0lUSVZFX0lORklOSVRZIl9zKTsK 380635 2019-10-10 05:07:23 -0700 2019-10-11 01:21:09 -0700 Patch for landing bug-202735-20191010140722.patch text/plain 1681 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDkzMDc4YTE5YTU5YTRjMDY1MmFlODhj MmViMjViNDFkY2IzMzQwMDkuLjgwNmQzNTNlMTUwZmY0YjI2YjNjNGZhMjQ3MjdkMGY0ZWUyNjk1 NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTAtMTAgIFhhYmllciBSb2RyaWd1ZXogQ2Fs dmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KKworICAgICAgICBNZWRpYVRpbWUgcHJldHR5IHBy aW50ZXIgY2FuIHByaW50IGlmIHRpbWUgaXMgaW52YWxpZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg RXJpYyBDYXJsc29uLgorCisgICAgICAgICogd3RmL01lZGlhVGltZS5jcHA6CisgICAgICAgIChX VEY6Ok1lZGlhVGltZTo6dG9TdHJpbmcgY29uc3QpOiBBcHBlbmQgIiwgaW52YWxpZCIgaWYgaXNJ bnZhbGlkKCkuCisgICAgICAgIChXVEY6Ok1lZGlhVGltZTo6dG9KU09OT2JqZWN0IGNvbnN0KTog U2V0IGJvb2xlYW4gaW52YWxpZCB0byB0cnVlCisgICAgICAgIHdoZW4gaW52YWxpZC4KKwogMjAx OS0xMC0wOSAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVt b3ZlIHNvbWUgc3VwcG9ydCBmb3IgPCBpT1MgMTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3Rm L01lZGlhVGltZS5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuY3BwCmluZGV4IGI3MmNl YzdmMmU0ZTNkMmZhZmM1ZjA0ZDg4MDcxNTkyMDJiNTNiZTYuLjQxNGE5YjRmZGVkNWRhZmY3OGYx NGQwMzQ4ZDJlOWM0MGMzNmYzMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01lZGlhVGlt ZS5jcHAKKysrIGIvU291cmNlL1dURi93dGYvTWVkaWFUaW1lLmNwcApAQCAtNTk0LDYgKzU5NCw4 IEBAIFN0cmluZyBNZWRpYVRpbWU6OnRvU3RyaW5nKCkgY29uc3QKICAgICAgICAgYnVpbGRlci5h cHBlbmRMaXRlcmFsKCIgPSAiKTsKICAgICB9CiAgICAgYnVpbGRlci5hcHBlbmRGaXhlZFByZWNp c2lvbk51bWJlcih0b0RvdWJsZSgpKTsKKyAgICBpZiAoaXNJbnZhbGlkKCkpCisgICAgICAgIGJ1 aWxkZXIuYXBwZW5kTGl0ZXJhbCgiLCBpbnZhbGlkIik7CiAgICAgYnVpbGRlci5hcHBlbmQoJ30n KTsKICAgICByZXR1cm4gYnVpbGRlci50b1N0cmluZygpOwogfQpAQCAtNjA3LDcgKzYwOSw5IEBA IFJlZjxKU09OOjpPYmplY3Q+IE1lZGlhVGltZTo6dG9KU09OT2JqZWN0KCkgY29uc3QKICAgICAg ICAgcmV0dXJuIG9iamVjdDsKICAgICB9CiAKLSAgICBpZiAoaXNJbnZhbGlkKCkgfHwgaXNJbmRl ZmluaXRlKCkpCisgICAgaWYgKGlzSW52YWxpZCgpKQorICAgICAgICBvYmplY3QtPnNldEJvb2xl YW4oImludmFsaWQiX3MsIHRydWUpOworICAgIGVsc2UgaWYgKGlzSW5kZWZpbml0ZSgpKQogICAg ICAgICBvYmplY3QtPnNldFN0cmluZygidmFsdWUiX3MsICJOYU4iX3MpOwogICAgIGVsc2UgaWYg KGlzUG9zaXRpdmVJbmZpbml0ZSgpKQogICAgICAgICBvYmplY3QtPnNldFN0cmluZygidmFsdWUi X3MsICJQT1NJVElWRV9JTkZJTklUWSJfcyk7Cg==