202719 2019-10-08 23:38:36 -0700 [CSS Shadow Parts] Allow exporting single part with multiple names using exportparts attribute 2019-10-09 01:26:18 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 149443 1 koivisto webkit-unassigned allan.jensen cdumez commit-queue dbates esprehn+autocc ews-watchlist glenn gyuyoung.kim kangil.han macpherson menard rniwa webkit-bug-importer oldest_to_newest 1578082 0 koivisto 2019-10-08 23:38:36 -0700 exportparts="part:export1, part:export2" should work. 1578086 1 380502 koivisto 2019-10-08 23:45:10 -0700 Created attachment 380502 patch 1578098 2 380502 rniwa 2019-10-09 00:28:01 -0700 Comment on attachment 380502 patch View in context: https://bugs.webkit.org/attachment.cgi?id=380502&action=review > Source/WebCore/css/SelectorChecker.cpp:1181 > + for (unsigned i = 0; i < element.partNames().size(); ++i) We can’t use range loop? > Source/WebCore/dom/ShadowRoot.h:99 > + using PartMappings = HashMap<AtomString, Vector<AtomString, 1>>; Should we typedef Vector? 1578104 3 koivisto 2019-10-09 00:38:07 -0700 > We can’t use range loop? Not at the moment, SpaceSplitString doesn't have iterator interface. > Should we typedef Vector? Seems like overkill. Aliases make the code more opaque so I prefer only using them when types get pretty complicated. 1578127 4 380502 commit-queue 2019-10-09 01:25:41 -0700 Comment on attachment 380502 patch Clearing flags on attachment: 380502 Committed r250902: <https://trac.webkit.org/changeset/250902> 1578128 5 commit-queue 2019-10-09 01:25:43 -0700 All reviewed patches have been landed. Closing bug. 1578129 6 webkit-bug-importer 2019-10-09 01:26:18 -0700 <rdar://problem/56108565> 380502 2019-10-08 23:45:10 -0700 2019-10-09 01:25:41 -0700 patch css-shadow-parts-multiple-exports.patch text/plain 6847 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4NTRmYTA5MzQ3NS4uNDQzN2UyMDRkYTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxOS0xMC0wOCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CisKKyAgICAgICAg W0NTUyBTaGFkb3cgUGFydHNdIEFsbG93IGV4cG9ydGluZyBzaW5nbGUgcGFydCB3aXRoIG11bHRp cGxlIG5hbWVzIHVzaW5nIGV4cG9ydHBhcnRzIGF0dHJpYnV0ZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNzE5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9zaGFkb3ctcGFydHMvZXhw b3J0cGFydHMtc3ludGF4LWV4cGVjdGVkLnR4dDoKKwogMjAxOS0xMC0wOCAgSmlld2VuIFRhbiAg PGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFBhcnRpYWxseSB1bmRvIHIyNTA4MTEK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3NoYWRvdy1wYXJ0cy9leHBvcnRwYXJ0 cy1zeW50YXgtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvc2hhZG93LXBhcnRz L2V4cG9ydHBhcnRzLXN5bnRheC1leHBlY3RlZC50eHQKaW5kZXggMTY5YmMxOGI2MjUuLjZhYzIy NmE3MzcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9zaGFkb3ctcGFydHMvZXhw b3J0cGFydHMtc3ludGF4LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9z aGFkb3ctcGFydHMvZXhwb3J0cGFydHMtc3ludGF4LWV4cGVjdGVkLnR4dApAQCAtNCw1ICs0LDUg QEAgUEFTUyBTaG9ydGN1dCBub3RhdGlvbgogUEFTUyBGdWxsIG5vdGF0aW9uIAogUEFTUyBTa2lw IGJhZCBlbnRyaWVzIAogUEFTUyBNYXBwaW5nIG11bHRpcGxlIHBhcnRzIHRvIGEgc2luZ2xlIGV4 cG9ydCAKLUZBSUwgTXVsdGlwbGUgZXhwb3J0cyBmb3IgYSBzaW5nbGUgcGFydCBhc3NlcnRfZXF1 YWxzOiBleHBlY3RlZCAicmdiKDAsIDEyOCwgMCkiIGJ1dCBnb3QgInJnYigwLCAwLCAyNTUpIgor UEFTUyBNdWx0aXBsZSBleHBvcnRzIGZvciBhIHNpbmdsZSBwYXJ0IAogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzA5YjE4MmQ5OWQuLmRmMDVhM2Q5MjdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIw MTktMTAtMDggIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFtD U1MgU2hhZG93IFBhcnRzXSBBbGxvdyBleHBvcnRpbmcgc2luZ2xlIHBhcnQgd2l0aCBtdWx0aXBs ZSBuYW1lcyB1c2luZyBleHBvcnRwYXJ0cyBhdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjcxOQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhc2VzIGxpa2UgZXhwb3J0cGFydHM9InBhcnQ6 ZXhwb3J0MSwgcGFydDpleHBvcnQyIiBzaG91bGQgd29yay4KKworICAgICAgICAqIGNzcy9TZWxl Y3RvckNoZWNrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0b3JDaGVja2VyOjpjaGVj a09uZSBjb25zdCk6CisKKyAgICAgICAgQWxsb3cgb25lIHBhcnQgbmFtZSB0byBleHBhbmQgaW50 byBtdWx0aXBsZSBuYW1lcyBmb3IgbWF0Y2hpbmcuCisKKyAgICAgICAgKiBkb20vU2hhZG93Um9v dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwYXJzZVBhcnRNYXBwaW5nc0xpc3QpOgorCisgICAg ICAgIEFsbG93IG11bHRpcGxlIG5hbWVzIHBlciBtYXBwaW5nLgorCisgICAgICAgIChXZWJDb3Jl OjpTaGFkb3dSb290OjpwYXJ0TWFwcGluZ3MgY29uc3QpOgorICAgICAgICAqIGRvbS9TaGFkb3dS b290Lmg6CisKIDIwMTktMTAtMDggIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4K IAogICAgICAgICBQYXJ0aWFsbHkgdW5kbyByMjUwODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3Rv ckNoZWNrZXIuY3BwCmluZGV4IGExZTYzMmEyZDhjLi5jZWViZjdkYzk3OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKQEAgLTExNjAsMjMgKzExNjAsMjYgQEAgYm9vbCBT ZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lKENoZWNraW5nQ29udGV4dCYgY2hlY2tpbmdDb250ZXh0 LCBjb25zdCBMb2NhbENvbnQKIAogICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9FbGVt ZW50UGFydDogewogICAgICAgICAgICAgYXV0byB0cmFuc2xhdGVQYXJ0TmFtZVRvUnVsZVNjb3Bl ID0gWyZdKEF0b21TdHJpbmcgcGFydE5hbWUpIHsKKyAgICAgICAgICAgICAgICBWZWN0b3I8QXRv bVN0cmluZywgMT4gbWFwcGVkTmFtZXMgeyBwYXJ0TmFtZSB9OwogICAgICAgICAgICAgICAgIGZv ciAoYXV0byogc2hhZG93Um9vdCA9IGVsZW1lbnQuY29udGFpbmluZ1NoYWRvd1Jvb3QoKTsgc2hh ZG93Um9vdDsgc2hhZG93Um9vdCA9IHNoYWRvd1Jvb3QtPmhvc3QoKS0+Y29udGFpbmluZ1NoYWRv d1Jvb3QoKSkgewogICAgICAgICAgICAgICAgICAgICAvLyBBcHBseSBtYXBwaW5ncyB1cCB0byB0 aGUgc2NvcGUgdGhlIHJ1bGVzIGFyZSBjb21pbmcgZnJvbS4KICAgICAgICAgICAgICAgICAgICAg aWYgKHNoYWRvd1Jvb3QtPmhvc3QoKSA9PSBjaGVja2luZ0NvbnRleHQuc2hhZG93SG9zdEluUGFy dFJ1bGVTY29wZSkKICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAg ICAgICAgICBwYXJ0TmFtZSA9IHNoYWRvd1Jvb3QtPnBhcnRNYXBwaW5ncygpLmdldChwYXJ0TmFt ZSk7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChwYXJ0TmFtZS5pc0VtcHR5KCkpCi0gICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gQXRvbVN0cmluZygpOworICAgICAgICAgICAgICAgICAg ICAKKyAgICAgICAgICAgICAgICAgICAgVmVjdG9yPEF0b21TdHJpbmcsIDE+IG5ld01hcHBlZE5h bWVzOworICAgICAgICAgICAgICAgICAgICBmb3IgKGF1dG8mIG5hbWUgOiBtYXBwZWROYW1lcykK KyAgICAgICAgICAgICAgICAgICAgICAgIG5ld01hcHBlZE5hbWVzLmFwcGVuZFZlY3RvcihzaGFk b3dSb290LT5wYXJ0TWFwcGluZ3MoKS5nZXQobmFtZSkpOworICAgICAgICAgICAgICAgICAgICBt YXBwZWROYW1lcyA9IG5ld01hcHBlZE5hbWVzOworCisgICAgICAgICAgICAgICAgICAgIGlmICht YXBwZWROYW1lcy5pc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAgcmV0dXJuIHBhcnROYW1lOworICAgICAg ICAgICAgICAgIHJldHVybiBtYXBwZWROYW1lczsKICAgICAgICAgICAgIH07CiAKICAgICAgICAg ICAgIFZlY3RvcjxBdG9tU3RyaW5nLCA0PiB0cmFuc2xhdGVkUGFydE5hbWVzOwotICAgICAgICAg ICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGVsZW1lbnQucGFydE5hbWVzKCkuc2l6ZSgpOyAr K2kpIHsKLSAgICAgICAgICAgICAgICBhdXRvIHRyYW5zbGF0ZWRQYXJ0TmFtZSA9IHRyYW5zbGF0 ZVBhcnROYW1lVG9SdWxlU2NvcGUoZWxlbWVudC5wYXJ0TmFtZXMoKVtpXSk7Ci0gICAgICAgICAg ICAgICAgaWYgKCF0cmFuc2xhdGVkUGFydE5hbWUuaXNFbXB0eSgpKQotICAgICAgICAgICAgICAg ICAgICB0cmFuc2xhdGVkUGFydE5hbWVzLmFwcGVuZCh0cmFuc2xhdGVkUGFydE5hbWUpOwotICAg ICAgICAgICAgfQorICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGVsZW1lbnQu cGFydE5hbWVzKCkuc2l6ZSgpOyArK2kpCisgICAgICAgICAgICAgICAgdHJhbnNsYXRlZFBhcnRO YW1lcy5hcHBlbmRWZWN0b3IodHJhbnNsYXRlUGFydE5hbWVUb1J1bGVTY29wZShlbGVtZW50LnBh cnROYW1lcygpW2ldKSk7CiAKICAgICAgICAgICAgIGZvciAoYXV0byYgcGFydCA6ICpzZWxlY3Rv ci5hcmd1bWVudExpc3QoKSkgewogICAgICAgICAgICAgICAgIGlmICghdHJhbnNsYXRlZFBhcnRO YW1lcy5jb250YWlucyhwYXJ0KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFk b3dSb290LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmNwcAppbmRleCA2Y2Rm NmFkNmM2Yi4uYzNjODE1OTg1NGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFk b3dSb290LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAKQEAgLTMw MSw3ICszMDEsNyBAQCBzdGF0aWMgT3B0aW9uYWw8c3RkOjpwYWlyPEF0b21TdHJpbmcsIEF0b21T dHJpbmc+PiBwYXJzZVBhcnRNYXBwaW5nKFN0cmluZ1ZpZXcgbQogICAgIHJldHVybiBzdGQ6Om1h a2VfcGFpcihmaXJzdFBhcnQsIHNlY29uZFBhcnQpOwogfQogCi1zdGF0aWMgdm9pZCBwYXJzZVBh cnRNYXBwaW5nc0xpc3QoSGFzaE1hcDxBdG9tU3RyaW5nLCBBdG9tU3RyaW5nPiYgbWFwcGluZ3Ms IFN0cmluZ1ZpZXcgbWFwcGluZ3NMaXN0U3RyaW5nKQorc3RhdGljIHZvaWQgcGFyc2VQYXJ0TWFw cGluZ3NMaXN0KFNoYWRvd1Jvb3Q6OlBhcnRNYXBwaW5ncyYgbWFwcGluZ3MsIFN0cmluZ1ZpZXcg bWFwcGluZ3NMaXN0U3RyaW5nKQogewogICAgIGNvbnN0IGF1dG8gZW5kID0gbWFwcGluZ3NMaXN0 U3RyaW5nLmxlbmd0aCgpOwogCkBAIC0zMTMsNyArMzEzLDcgQEAgc3RhdGljIHZvaWQgcGFyc2VQ YXJ0TWFwcGluZ3NMaXN0KEhhc2hNYXA8QXRvbVN0cmluZywgQXRvbVN0cmluZz4mIG1hcHBpbmdz LCBTdHIKIAogICAgICAgICBhdXRvIHJlc3VsdCA9IHBhcnNlUGFydE1hcHBpbmcobWFwcGluZ3NM aXN0U3RyaW5nLnN1YnN0cmluZyhiZWdpbiwgbWFwcGluZ0VuZCAtIGJlZ2luKSk7CiAgICAgICAg IGlmIChyZXN1bHQpCi0gICAgICAgICAgICBtYXBwaW5ncy5hZGQocmVzdWx0LT5maXJzdCwgcmVz dWx0LT5zZWNvbmQpOworICAgICAgICAgICAgbWFwcGluZ3MuYWRkKHJlc3VsdC0+Zmlyc3QsIFZl Y3RvcjxBdG9tU3RyaW5nLCAxPigpKS5pdGVyYXRvci0+dmFsdWUuYXBwZW5kKHJlc3VsdC0+c2Vj b25kKTsKIAogICAgICAgICBpZiAobWFwcGluZ0VuZCA9PSBlbmQpCiAgICAgICAgICAgICBicmVh azsKQEAgLTMyMiwxMCArMzIyLDEwIEBAIHN0YXRpYyB2b2lkIHBhcnNlUGFydE1hcHBpbmdzTGlz dChIYXNoTWFwPEF0b21TdHJpbmcsIEF0b21TdHJpbmc+JiBtYXBwaW5ncywgU3RyCiAgICAgfQog fQogCi1jb25zdCBIYXNoTWFwPEF0b21TdHJpbmcsIEF0b21TdHJpbmc+JiBTaGFkb3dSb290Ojpw YXJ0TWFwcGluZ3MoKSBjb25zdAorY29uc3QgU2hhZG93Um9vdDo6UGFydE1hcHBpbmdzJiBTaGFk b3dSb290OjpwYXJ0TWFwcGluZ3MoKSBjb25zdAogewogICAgIGlmICghbV9wYXJ0TWFwcGluZ3Mp IHsKLSAgICAgICAgbV9wYXJ0TWFwcGluZ3MgPSBIYXNoTWFwPEF0b21TdHJpbmcsIEF0b21TdHJp bmc+KCk7CisgICAgICAgIG1fcGFydE1hcHBpbmdzID0gUGFydE1hcHBpbmdzKCk7CiAKICAgICAg ICAgYXV0byBleHBvcnRwYXJ0c1ZhbHVlID0gaG9zdCgpLT5hdHRyaWJ1dGVXaXRob3V0U3luY2hy b25pemF0aW9uKEhUTUxOYW1lczo6ZXhwb3J0cGFydHNBdHRyKTsKICAgICAgICAgaWYgKCFleHBv cnRwYXJ0c1ZhbHVlLmlzRW1wdHkoKSAmJiBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRG ZWF0dXJlcygpLmNzc1NoYWRvd1BhcnRzRW5hYmxlZCgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL1NoYWRvd1Jvb3QuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmgK aW5kZXggZjIwYzFiODQ4NjIuLjc2NTc4NTg5OTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9kb20vU2hhZG93Um9vdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmgK QEAgLTk2LDcgKzk2LDggQEAgcHVibGljOgogICAgIHZvaWQgbW92ZVNoYWRvd1Jvb3RUb05ld1Bh cmVudFNjb3BlKFRyZWVTY29wZSYsIERvY3VtZW50Jik7CiAgICAgdm9pZCBtb3ZlU2hhZG93Um9v dFRvTmV3RG9jdW1lbnQoRG9jdW1lbnQmKTsKIAotICAgIGNvbnN0IEhhc2hNYXA8QXRvbVN0cmlu ZywgQXRvbVN0cmluZz4mIHBhcnRNYXBwaW5ncygpIGNvbnN0OworICAgIHVzaW5nIFBhcnRNYXBw aW5ncyA9IEhhc2hNYXA8QXRvbVN0cmluZywgVmVjdG9yPEF0b21TdHJpbmcsIDE+PjsKKyAgICBj b25zdCBQYXJ0TWFwcGluZ3MmIHBhcnRNYXBwaW5ncygpIGNvbnN0OwogICAgIHZvaWQgaW52YWxp ZGF0ZVBhcnRNYXBwaW5ncygpOwogCiBwcm90ZWN0ZWQ6CkBAIC0xMjQsNyArMTI1LDcgQEAgcHJp dmF0ZToKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxTdHlsZTo6U2NvcGU+IG1fc3R5bGVTY29wZTsK ICAgICBzdGQ6OnVuaXF1ZV9wdHI8U2xvdEFzc2lnbm1lbnQ+IG1fc2xvdEFzc2lnbm1lbnQ7Ci0g ICAgbXV0YWJsZSBPcHRpb25hbDxIYXNoTWFwPEF0b21TdHJpbmcsIEF0b21TdHJpbmc+PiBtX3Bh cnRNYXBwaW5nczsKKyAgICBtdXRhYmxlIE9wdGlvbmFsPFBhcnRNYXBwaW5ncz4gbV9wYXJ0TWFw cGluZ3M7CiB9OwogCiBpbmxpbmUgRWxlbWVudCogU2hhZG93Um9vdDo6YWN0aXZlRWxlbWVudCgp IGNvbnN0Cg==