202717 2019-10-08 21:04:47 -0700 [iOS] Remove redundant uses of USE(UIKIT_EDITING) 2019-10-09 09:30:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes andersca commit-queue thorton webkit-bug-importer oldest_to_newest 1578075 0 aestes 2019-10-08 21:04:47 -0700 [iOS] Remove redundant uses of USE(UIKIT_EDITING) 1578076 1 380500 aestes 2019-10-08 21:05:17 -0700 Created attachment 380500 Patch 1578259 2 380500 commit-queue 2019-10-09 09:29:20 -0700 Comment on attachment 380500 Patch Clearing flags on attachment: 380500 Committed r250913: <https://trac.webkit.org/changeset/250913> 1578260 3 commit-queue 2019-10-09 09:29:21 -0700 All reviewed patches have been landed. Closing bug. 1578261 4 webkit-bug-importer 2019-10-09 09:30:21 -0700 <rdar://problem/56117989> 380500 2019-10-08 21:05:17 -0700 2019-10-09 09:29:20 -0700 Patch bug-202717-20191008210516.patch text/plain 5976 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDdiNTBlOWJlZTAyOGQ1 YjQ5OGY3ZmZkOGMwZjAzNjZiOGE5NzgxNi4uMDYxNmNjNmQ1M2NmNDFkN2M1NjI1NTZhZTkyMmFk Mjg2NzVlMmQwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTEwLTA4ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBSZW1vdmUgcmVkdW5k YW50IHVzZXMgb2YgVVNFKFVJS0lUX0VESVRJTkcpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI3MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvaW9zL0ZyYW1lSU9TLm1tOgorICAgICAgICAo V2ViQ29yZTo6RnJhbWU6OnF1YWxpZnlpbmdOb2RlQXRWaWV3cG9ydExvY2F0aW9uKToKKyAgICAg ICAgKFdlYkNvcmU6OkZyYW1lOjphcHByb3hpbWF0ZU5vZGVBdFZpZXdwb3J0TG9jYXRpb25MZWdh Y3kpOgorCiAyMDE5LTEwLTA4ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBDYW52YXM6IG1vZGlmaWNhdGlvbnMgdG8gc2hhZGVyIG1v ZHVsZXMgY2FuIGJlIHNoYXJlZCBiZXR3ZWVuIHZlcnRleC9mcmFnbWVudCBzaGFkZXJzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L2lvcy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 TGVnYWN5L2lvcy9DaGFuZ2VMb2cKaW5kZXggYzcwZDQwN2IwMjdmOWU4ODFhNGMyMTg0MDJhNmY1 YTJiOWUyM2JiNS4uZDI1YWY0NzMwOTc0Y2E3OTVjYmE0ZjNhYWJjNTcwY2JhNWEzMjY0NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9pb3MvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXRMZWdhY3kvaW9zL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTEwLTA4ICBB bmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBSZW1vdmUgcmVk dW5kYW50IHVzZXMgb2YgVVNFKFVJS0lUX0VESVRJTkcpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI3MTcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYlZpc2libGVQb3Np dGlvbi5tbToKKyAgICAgICAgKC1bRE9NTm9kZSBzdGFydFBvc2l0aW9uXSk6CisgICAgICAgICgt W0RPTU5vZGUgZW5kUG9zaXRpb25dKToKKwogMjAxOS0wOC0yMyAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtnZW9sb2NhdGlvbl0gUmVuYW1lIGludGVyZmFjZXMg YW5kIHJlbW92ZSBbTm9JbnRlcmZhY2VPYmplY3RdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL2lvcy9GcmFtZUlPUy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0ZyYW1lSU9T Lm1tCmluZGV4IDViZjJiNmNlMDhkNDg3N2NmZGY2NzllNThhZGRiMzNhNmQ2OWQ0YmUuLjgzYzYw NTc1NTMyMThjYjcwMWNjZTBhZGNlZTdmMTRhM2IyY2VlNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvaW9zL0ZyYW1lSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9z L0ZyYW1lSU9TLm1tCkBAIC0yNjgsMTAgKzI2OCw2IEBAIGJvb2wgRnJhbWU6OmhpdFRlc3RSZXN1 bHRBdFZpZXdwb3J0TG9jYXRpb24oY29uc3QgRmxvYXRQb2ludCYgdmlld3BvcnRMb2NhdGlvbiwK IAogTm9kZSogRnJhbWU6OnF1YWxpZnlpbmdOb2RlQXRWaWV3cG9ydExvY2F0aW9uKGNvbnN0IEZs b2F0UG9pbnQmIHZpZXdwb3J0TG9jYXRpb24sIEZsb2F0UG9pbnQmIGFkanVzdGVkVmlld3BvcnRM b2NhdGlvbiwgY29uc3QgTm9kZVF1YWxpZmllciYgbm9kZVF1YWxpZmllckZ1bmN0aW9uLCBTaG91 bGRBcHByb3hpbWF0ZSBzaG91bGRBcHByb3hpbWF0ZSwgU2hvdWxkRmluZFJvb3RFZGl0YWJsZUVs ZW1lbnQgc2hvdWxkRmluZFJvb3RFZGl0YWJsZUVsZW1lbnQpCiB7Ci0jaWYgIVVTRShVSUtJVF9F RElUSU5HKQotICAgIFVOVVNFRF9QQVJBTShzaG91bGRGaW5kUm9vdEVkaXRhYmxlRWxlbWVudCk7 Ci0jZW5kaWYKLQogICAgIGFkanVzdGVkVmlld3BvcnRMb2NhdGlvbiA9IHZpZXdwb3J0TG9jYXRp b247CiAKICAgICBJbnRQb2ludCB0ZXN0Q2VudGVyOwpAQCAtMjg1LDcgKzI4MSw2IEBAIE5vZGUq IEZyYW1lOjpxdWFsaWZ5aW5nTm9kZUF0Vmlld3BvcnRMb2NhdGlvbihjb25zdCBGbG9hdFBvaW50 JiB2aWV3cG9ydExvY2F0aW9uCiAgICAgLy8gdGhlIHF1YWxpZmllciBmdW5jdGlvbiwgd2hpY2gg dHlwaWNhbGx5IGNoZWNrcyBpZiB0aGUgbm9kZSByZXNwb25kcyB0byBhIHBhcnRpY3VsYXIgZXZl bnQgdHlwZS4KICAgICBOb2RlKiBhcHByb3hpbWF0ZU5vZGUgPSBub2RlUXVhbGlmaWVyRnVuY3Rp b24oY2FuZGlkYXRlSW5mbywgMCwgMCk7CiAKLSNpZiBVU0UoVUlLSVRfRURJVElORykKICAgICBp ZiAoc2hvdWxkRmluZFJvb3RFZGl0YWJsZUVsZW1lbnQgPT0gU2hvdWxkRmluZFJvb3RFZGl0YWJs ZUVsZW1lbnQ6OlllcyAmJiBhcHByb3hpbWF0ZU5vZGUgJiYgYXBwcm94aW1hdGVOb2RlLT5pc0Nv bnRlbnRFZGl0YWJsZSgpKSB7CiAgICAgICAgIC8vIElmIHdlIGFyZSBpbiBlZGl0YWJsZSBjb250 ZW50LCB3ZSBsb29rIGZvciB0aGUgcm9vdCBlZGl0YWJsZSBlbGVtZW50LgogICAgICAgICBhcHBy b3hpbWF0ZU5vZGUgPSBhcHByb3hpbWF0ZU5vZGUtPnJvb3RFZGl0YWJsZUVsZW1lbnQoKTsKQEAg LTI5Myw4ICsyODgsNiBAQCBOb2RlKiBGcmFtZTo6cXVhbGlmeWluZ05vZGVBdFZpZXdwb3J0TG9j YXRpb24oY29uc3QgRmxvYXRQb2ludCYgdmlld3BvcnRMb2NhdGlvbgogICAgICAgICBpZiAoYXBw cm94aW1hdGVOb2RlKQogICAgICAgICAgICAgc2hvdWxkQXBwcm94aW1hdGUgPSBTaG91bGRBcHBy b3hpbWF0ZTo6Tm87CiAgICAgfQotI2VuZGlmCi0KIAogICAgIGZsb2F0IHNjYWxlID0gcGFnZSgp ID8gcGFnZSgpLT5wYWdlU2NhbGVGYWN0b3IoKSA6IDE7CiAgICAgZmxvYXQgcHBpRmFjdG9yID0g c2NyZWVuUFBJRmFjdG9yKCk7CkBAIC0zNzAsMTMgKzM2MywxMSBAQCBOb2RlKiBGcmFtZTo6cXVh bGlmeWluZ05vZGVBdFZpZXdwb3J0TG9jYXRpb24oY29uc3QgRmxvYXRQb2ludCYgdmlld3BvcnRM b2NhdGlvbgogICAgIGlmIChhcHByb3hpbWF0ZU5vZGUpIHsKICAgICAgICAgSW50UG9pbnQgcCA9 IG1fdmlldy0+Y29udGVudHNUb1dpbmRvdyhiZXN0UG9pbnQpOwogICAgICAgICBhZGp1c3RlZFZp ZXdwb3J0TG9jYXRpb24gPSBwOwotI2lmIFVTRShVSUtJVF9FRElUSU5HKQogICAgICAgICBpZiAo c2hvdWxkRmluZFJvb3RFZGl0YWJsZUVsZW1lbnQgPT0gU2hvdWxkRmluZFJvb3RFZGl0YWJsZUVs ZW1lbnQ6OlllcyAmJiBhcHByb3hpbWF0ZU5vZGUtPmlzQ29udGVudEVkaXRhYmxlKCkpIHsKICAg ICAgICAgICAgIC8vIFdoZW4gaW4gZWRpdGFibGUgY29udGVudCwgbG9vayBmb3IgdGhlIHJvb3Qg ZWRpdGFibGUgbm9kZSBhZ2FpbiwKICAgICAgICAgICAgIC8vIHNpbmNlIHRoaXMgY291bGQgYmUg dGhlIG5vZGUgZm91bmQgd2l0aCB0aGUgYXBwcm94aW1hdGlvbi4KICAgICAgICAgICAgIGFwcHJv eGltYXRlTm9kZSA9IGFwcHJveGltYXRlTm9kZS0+cm9vdEVkaXRhYmxlRWxlbWVudCgpOwogICAg ICAgICB9Ci0jZW5kaWYKICAgICB9CiAKICAgICByZXR1cm4gYXBwcm94aW1hdGVOb2RlOwpAQCAt NDEwLDExICs0MDEsOSBAQCBOb2RlKiBGcmFtZTo6YXBwcm94aW1hdGVOb2RlQXRWaWV3cG9ydExv Y2F0aW9uTGVnYWN5KGNvbnN0IEZsb2F0UG9pbnQmIHZpZXdwb3J0TAogICAgICAgICBmb3IgKDsg bm9kZSAmJiBub2RlICE9IHRlcm1pbmF0aW9uTm9kZTsgbm9kZSA9IG5vZGUtPnBhcmVudEluQ29t cG9zZWRUcmVlKCkpIHsKICAgICAgICAgICAgIC8vIFdlIG9ubHkgYWNjZXB0IHBvaW50ZXIgbm9k ZXMgYmVmb3JlIHJlYWNoaW5nIHRoZSBib2R5IHRhZy4KICAgICAgICAgICAgIGlmIChub2RlLT5o YXNUYWdOYW1lKEhUTUxOYW1lczo6Ym9keVRhZykpIHsKLSNpZiBVU0UoVUlLSVRfRURJVElORykK ICAgICAgICAgICAgICAgICAvLyBNYWtlIHN1cmUgd2UgY292ZXIgdGhlIGNhc2Ugb2YgYW4gZW1w dHkgZWRpdGFibGUgYm9keS4KICAgICAgICAgICAgICAgICBpZiAoIXBvaW50ZXJDdXJzb3JOb2Rl ICYmIG5vZGUtPmlzQ29udGVudEVkaXRhYmxlKCkpCiAgICAgICAgICAgICAgICAgICAgIHBvaW50 ZXJDdXJzb3JOb2RlID0gbm9kZTsKLSNlbmRpZgogICAgICAgICAgICAgICAgIGJvZHlIYXNCZWVu UmVhY2hlZCA9IHRydWU7CiAgICAgICAgICAgICAgICAgcG9pbnRlckN1cnNvclN0aWxsVmFsaWQg PSBmYWxzZTsKICAgICAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kv aW9zL1dlYkNvcmVTdXBwb3J0L1dlYlZpc2libGVQb3NpdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXRM ZWdhY3kvaW9zL1dlYkNvcmVTdXBwb3J0L1dlYlZpc2libGVQb3NpdGlvbi5tbQppbmRleCA4NTkx MTc3YTljZjJhZTkyNjBjN2EwY2ZhZjJmMzJhMTM2MWY2Njg2Li42ODI4YWE2N2YxYjAwMTk5NjYz NTdiZTYzOTU4NjcwYThkZTJlNGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L2lv cy9XZWJDb3JlU3VwcG9ydC9XZWJWaXNpYmxlUG9zaXRpb24ubW0KKysrIGIvU291cmNlL1dlYktp dExlZ2FjeS9pb3MvV2ViQ29yZVN1cHBvcnQvV2ViVmlzaWJsZVBvc2l0aW9uLm1tCkBAIC01NDAs NyArNTQwLDYgQEAgLSAoRE9NUmFuZ2UgKilyYW5nZU9mQ29udGVudHMKIAogLSAoV2ViVmlzaWJs ZVBvc2l0aW9uICopc3RhcnRQb3NpdGlvbgogewotI2lmIFVTRShVSUtJVF9FRElUSU5HKQogICAg IC8vIFdoZW4gaW4gZWRpdGFibGUgY29udGVudCwgd2UgbmVlZCB0byBjYWxjdWxhdGUgdGhlIHN0 YXJ0UG9zaXRpb24gZnJvbSB0aGUgYmVnaW5uaW5nIG9mIHRoZQogICAgIC8vIGVkaXRhYmxlIGFy ZWEuCiAgICAgTm9kZSogbm9kZSA9IGNvcmUoc2VsZik7CkBAIC01NDgsMTMgKzU0NywxMSBAQCAt IChXZWJWaXNpYmxlUG9zaXRpb24gKilzdGFydFBvc2l0aW9uCiAgICAgICAgIFZpc2libGVQb3Np dGlvbiB2cChjcmVhdGVMZWdhY3lFZGl0aW5nUG9zaXRpb24obm9kZSwgMCksIFZQX0RFRkFVTFRf QUZGSU5JVFkpOwogICAgICAgICByZXR1cm4gW1dlYlZpc2libGVQb3NpdGlvbiBfd3JhcFZpc2li bGVQb3NpdGlvbjpzdGFydE9mRWRpdGFibGVDb250ZW50KHZwKV07CiAgICAgfQotI2VuZGlmCiAg ICAgcmV0dXJuIFtbc2VsZiByYW5nZU9mQ29udGVudHNdIHN0YXJ0UG9zaXRpb25dOwogfQogCiAt IChXZWJWaXNpYmxlUG9zaXRpb24gKillbmRQb3NpdGlvbgogewotI2lmIFVTRShVSUtJVF9FRElU SU5HKQogICAgIC8vIFdoZW4gaW4gZWRpdGFibGUgY29udGVudCwgd2UgbmVlZCB0byBjYWxjdWxh dGUgdGhlIGVuZFBvc2l0aW9uIGZyb20gdGhlIGVuZCBvZiB0aGUKICAgICAvLyBlZGl0YWJsZSBh cmVhLgogICAgIE5vZGUqIG5vZGUgPSBjb3JlKHNlbGYpOwpAQCAtNTYyLDcgKzU1OSw2IEBAIC0g KFdlYlZpc2libGVQb3NpdGlvbiAqKWVuZFBvc2l0aW9uCiAgICAgICAgIFZpc2libGVQb3NpdGlv biB2cChjcmVhdGVMZWdhY3lFZGl0aW5nUG9zaXRpb24obm9kZSwgMCksIFZQX0RFRkFVTFRfQUZG SU5JVFkpOwogICAgICAgICByZXR1cm4gW1dlYlZpc2libGVQb3NpdGlvbiBfd3JhcFZpc2libGVQ b3NpdGlvbjplbmRPZkVkaXRhYmxlQ29udGVudCh2cCldOwogICAgIH0KLSNlbmRpZgogICAgIHJl dHVybiBbW3NlbGYgcmFuZ2VPZkNvbnRlbnRzXSBlbmRQb3NpdGlvbl07CiB9CiAK