202712 2019-10-08 16:59:23 -0700 [iOS] REGRESSION (r250398) Layout Test fast/history/page-cache-element-state-focused.html is failing 2019-10-09 10:27:35 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue darin dino esprehn+autocc ews-watchlist ggaren glenn gyuyoung.kim koivisto macpherson menard timothy webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1578020 0 cdumez 2019-10-08 16:59:23 -0700 fast/history/page-cache-element-state-focused.html is failing on internal bots. 1578021 1 cdumez 2019-10-08 16:59:40 -0700 <rdar://problem/56082428> 1578022 2 380481 cdumez 2019-10-08 17:01:24 -0700 Created attachment 380481 WIP Patch Needs change log. 1578040 3 380490 cdumez 2019-10-08 18:30:35 -0700 Created attachment 380490 Patch 1578222 4 380490 commit-queue 2019-10-09 07:38:52 -0700 Comment on attachment 380490 Patch Clearing flags on attachment: 380490 Committed r250912: <https://trac.webkit.org/changeset/250912> 1578223 5 commit-queue 2019-10-09 07:38:54 -0700 All reviewed patches have been landed. Closing bug. 1578267 6 380490 darin 2019-10-09 09:45:21 -0700 Comment on attachment 380490 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380490&action=review > Source/WebCore/css/CSSDefaultStyleSheets.cpp:96 > +static const char* simpleUserAgentStyleSheet = "html,body,div{display:block}" CSS_DARK_MODE_ADDITION "head{display:none}body{margin:8px}div:focus,span:focus,a:focus{outline:auto " DEFAULT_OUTLINE_WIDTH " -webkit-focus-ring-color}a:any-link{color:-webkit-link;text-decoration:underline}a:any-link:active{color:-webkit-activelink}"; Tiny nitpick: There’s not enough const here. This declares a constant string, and a non-constant global variable that starts out pointing to it; but we don’t need to change the value of that global variable. We should add another const or constexpr so the pointer itself is constant too, not just the string contents. Or could use a constant array instead of a pointer to a string; I think that is a little smaller. 1578287 7 cdumez 2019-10-09 10:27:35 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 380490 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380490&action=review > > > Source/WebCore/css/CSSDefaultStyleSheets.cpp:96 > > +static const char* simpleUserAgentStyleSheet = "html,body,div{display:block}" CSS_DARK_MODE_ADDITION "head{display:none}body{margin:8px}div:focus,span:focus,a:focus{outline:auto " DEFAULT_OUTLINE_WIDTH " -webkit-focus-ring-color}a:any-link{color:-webkit-link;text-decoration:underline}a:any-link:active{color:-webkit-activelink}"; > > Tiny nitpick: There’s not enough const here. This declares a constant > string, and a non-constant global variable that starts out pointing to it; > but we don’t need to change the value of that global variable. We should add > another const or constexpr so the pointer itself is constant too, not just > the string contents. Or could use a constant array instead of a pointer to a > string; I think that is a little smaller. Landed a follow-up fix in <https://trac.webkit.org/changeset/250916> thanks. I opted for "static const char simpleUserAgentStyleSheet[]". 380481 2019-10-08 17:01:24 -0700 2019-10-08 18:30:34 -0700 WIP Patch 202712_wip.patch text/plain 2049 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NEZWZhdWx0U3R5bGVTaGVldHMuY3Bw IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0RlZmF1bHRTdHlsZVNoZWV0cy5jcHAKaW5kZXggZTVh ZThiNzdhNTEuLjM0MGZkOWQ0YjI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT RGVmYXVsdFN0eWxlU2hlZXRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRGVmYXVs dFN0eWxlU2hlZXRzLmNwcApAQCAtODAsMTQgKzgwLDIxIEBAIFN0eWxlU2hlZXRDb250ZW50cyog Q1NTRGVmYXVsdFN0eWxlU2hlZXRzOjpkYXRhTGlzdFN0eWxlU2hlZXQ7CiBTdHlsZVNoZWV0Q29u dGVudHMqIENTU0RlZmF1bHRTdHlsZVNoZWV0czo6Y29sb3JJbnB1dFN0eWxlU2hlZXQ7CiAjZW5k aWYKIAotLy8gRklYTUU6IEl0IHdvdWxkIGJlIG5pY2UgdG8gdXNlIHNvbWUgbWVjaGFuaXNtIHRo YXQgZ3VhcmFudGVlcyB0aGlzIGlzIGluIHN5bmMgd2l0aCB0aGUgcmVhbCBVQSBzdHlsZXNoZWV0 LgorI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCisjZGVmaW5lIERFRkFVTFRfT1VUTElORV9XSURU SCAiM3B4IgorI2Vsc2UKKyNkZWZpbmUgREVGQVVMVF9PVVRMSU5FX1dJRFRIICI1cHgiCisjZW5k aWYKKwogI2lmIEhBVkUoT1NfREFSS19NT0RFX1NVUFBPUlQpCi0vLyBUaGUgb25seSBkaWZmZXJl bmNlIGluIHRoZSBzaW1wbGUgc3R5bGUgc2hlZXQgZm9yIGRhcmsgbW9kZSBpcyB0aGUgYWRkaXRp b24gb2YgaHRtbHtjb2xvcjp0ZXh0fS4KLXN0YXRpYyBjb25zdCBjaGFyKiBzaW1wbGVVc2VyQWdl bnRTdHlsZVNoZWV0ID0gImh0bWwsYm9keSxkaXZ7ZGlzcGxheTpibG9ja31odG1se2NvbG9yOnRl eHR9aGVhZHtkaXNwbGF5Om5vbmV9Ym9keXttYXJnaW46OHB4fWRpdjpmb2N1cyxzcGFuOmZvY3Vz LGE6Zm9jdXN7b3V0bGluZTphdXRvIDVweCAtd2Via2l0LWZvY3VzLXJpbmctY29sb3J9YTphbnkt bGlua3tjb2xvcjotd2Via2l0LWxpbms7dGV4dC1kZWNvcmF0aW9uOnVuZGVybGluZX1hOmFueS1s aW5rOmFjdGl2ZXtjb2xvcjotd2Via2l0LWFjdGl2ZWxpbmt9IjsKKyNkZWZpbmUgQ1NTX0RBUktf TU9ERV9BRERJVElPTiAiaHRtbHtjb2xvcjp0ZXh0fSIKICNlbHNlCi1zdGF0aWMgY29uc3QgY2hh ciogc2ltcGxlVXNlckFnZW50U3R5bGVTaGVldCA9ICJodG1sLGJvZHksZGl2e2Rpc3BsYXk6Ymxv Y2t9aGVhZHtkaXNwbGF5Om5vbmV9Ym9keXttYXJnaW46OHB4fWRpdjpmb2N1cyxzcGFuOmZvY3Vz LGE6Zm9jdXN7b3V0bGluZTphdXRvIDVweCAtd2Via2l0LWZvY3VzLXJpbmctY29sb3J9YTphbnkt bGlua3tjb2xvcjotd2Via2l0LWxpbms7dGV4dC1kZWNvcmF0aW9uOnVuZGVybGluZX1hOmFueS1s aW5rOmFjdGl2ZXtjb2xvcjotd2Via2l0LWFjdGl2ZWxpbmt9IjsKKyNkZWZpbmUgQ1NTX0RBUktf TU9ERV9BRERJVElPTiAiIgogI2VuZGlmCiAKKy8vIEZJWE1FOiBJdCB3b3VsZCBiZSBuaWNlIHRv IHVzZSBzb21lIG1lY2hhbmlzbSB0aGF0IGd1YXJhbnRlZXMgdGhpcyBpcyBpbiBzeW5jIHdpdGgg dGhlIHJlYWwgVUEgc3R5bGVzaGVldC4KK3N0YXRpYyBjb25zdCBjaGFyKiBzaW1wbGVVc2VyQWdl bnRTdHlsZVNoZWV0ID0gImh0bWwsYm9keSxkaXZ7ZGlzcGxheTpibG9ja30iIENTU19EQVJLX01P REVfQURESVRJT04gImhlYWR7ZGlzcGxheTpub25lfWJvZHl7bWFyZ2luOjhweH1kaXY6Zm9jdXMs c3Bhbjpmb2N1cyxhOmZvY3Vze291dGxpbmU6YXV0byAiIERFRkFVTFRfT1VUTElORV9XSURUSCAi IC13ZWJraXQtZm9jdXMtcmluZy1jb2xvcn1hOmFueS1saW5re2NvbG9yOi13ZWJraXQtbGluazt0 ZXh0LWRlY29yYXRpb246dW5kZXJsaW5lfWE6YW55LWxpbms6YWN0aXZle2NvbG9yOi13ZWJraXQt YWN0aXZlbGlua30iOworCiBzdGF0aWMgaW5saW5lIGJvb2wgZWxlbWVudENhblVzZVNpbXBsZURl ZmF1bHRTdHlsZShjb25zdCBFbGVtZW50JiBlbGVtZW50KQogewogICAgIHJldHVybiBpczxIVE1M SHRtbEVsZW1lbnQ+KGVsZW1lbnQpIHx8IGlzPEhUTUxIZWFkRWxlbWVudD4oZWxlbWVudCkK 380490 2019-10-08 18:30:35 -0700 2019-10-09 07:38:52 -0700 Patch bug-202712-20191008183034.patch text/plain 3484 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDdiNTBlOWJlZTAyOGQ1 YjQ5OGY3ZmZkOGMwZjAzNjZiOGE5NzgxNi4uNjRkNWI0OTM2NGJlMWNhZTQ5NWY3YWRjMmQ2YWYy ODU0NzFjN2Q1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTEwLTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUkVHUkVTU0lPTiAo cjI1MDM5OCkgTGF5b3V0IFRlc3QgZmFzdC9oaXN0b3J5L3BhZ2UtY2FjaGUtZWxlbWVudC1zdGF0 ZS1mb2N1c2VkLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNzEyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NjA4MjQy OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg dGVzdCB3YXMgZmFpbGluZyBkZXBlbmRpbmcgb24gdGhlIG9yZGVyIGluIHdoaWNoIHRoZSB0ZXN0 cyB3ZXJlIGV4ZWN1dGVkLiBUaGUgcmVhc29uIGlzIHRoYXQKKyAgICAgICAgZWxlbWVudHMgd291 bGQgZWl0aGVyIHVzZSB0aGUgZnVsbCBVQSBzdHlsZXNoZWV0IChodG1sLmNzcykgb3IgdGhlIHNp bXBsZSBvbmUgaW4gQ1NTRGVmYXVsdFN0eWxlU2hlZXRzLmNwcC4KKyAgICAgICAgVW5mb3J0dW5h dGVseSwgdGhlIG91dGxpbmUtd2lkdGggd2FzIGRpZmZlcmVudCBvbiBpT1MgYmV0d2VlbiB0aGUg c2ltcGxlIHN0eWxlc2hlZXQgYW5kIHRoZSBmdWxsIG9uZSwgY2F1c2luZworICAgICAgICB0aGUg dGVzdCBvdXRwdXQgdG8gbG9vayBkaWZmZXJlbnQgZGVwZW5kaW5nIG9uIHdoaWNoIHN0eWxlc2hl ZXQgd2FzIHVzZWQuCisKKyAgICAgICAgQWRkcmVzcyB0aGUgaXNzdWUgYnkgbWFraW5nIHN1cmUg dGhhdCB0aGUgb3V0bGluZS13aWR0aCBpcyAzcHggb24gSU9TX0ZBTUlMWSBpbiB0aGUgc2ltcGxl IHN0eWxlc2hlZXQsIHRvCisgICAgICAgIGJlIGNvbnNpc3RlbnQgd2l0aCB0aGUgdmFsdWUgaW4g dGhlIGZ1bGwgc3R5bGVzaGVldCAoaHRtbC5jc3MpLgorCisgICAgICAgICogY3NzL0NTU0RlZmF1 bHRTdHlsZVNoZWV0cy5jcHA6CisKIDIwMTktMTAtMDggIERldmluIFJvdXNzbyAgPGRyb3Vzc29A YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENhbnZhczogbW9kaWZpY2F0aW9u cyB0byBzaGFkZXIgbW9kdWxlcyBjYW4gYmUgc2hhcmVkIGJldHdlZW4gdmVydGV4L2ZyYWdtZW50 IHNoYWRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NEZWZhdWx0U3R5bGVT aGVldHMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0RlZmF1bHRTdHlsZVNoZWV0cy5jcHAK aW5kZXggZTVhZThiNzdhNTE0ZjA5YzNiNDk0NDFiNTYyZjVjMmExZWM3NTE2Zi4uMzQwZmQ5ZDRi MjUxNjgzYWQ3OGIxYjY2NGUzYjVkZDliNDNiYzFlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU0RlZmF1bHRTdHlsZVNoZWV0cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU0RlZmF1bHRTdHlsZVNoZWV0cy5jcHAKQEAgLTgwLDE0ICs4MCwyMSBAQCBTdHlsZVNoZWV0 Q29udGVudHMqIENTU0RlZmF1bHRTdHlsZVNoZWV0czo6ZGF0YUxpc3RTdHlsZVNoZWV0OwogU3R5 bGVTaGVldENvbnRlbnRzKiBDU1NEZWZhdWx0U3R5bGVTaGVldHM6OmNvbG9ySW5wdXRTdHlsZVNo ZWV0OwogI2VuZGlmCiAKLS8vIEZJWE1FOiBJdCB3b3VsZCBiZSBuaWNlIHRvIHVzZSBzb21lIG1l Y2hhbmlzbSB0aGF0IGd1YXJhbnRlZXMgdGhpcyBpcyBpbiBzeW5jIHdpdGggdGhlIHJlYWwgVUEg c3R5bGVzaGVldC4KKyNpZiBQTEFURk9STShJT1NfRkFNSUxZKQorI2RlZmluZSBERUZBVUxUX09V VExJTkVfV0lEVEggIjNweCIKKyNlbHNlCisjZGVmaW5lIERFRkFVTFRfT1VUTElORV9XSURUSCAi NXB4IgorI2VuZGlmCisKICNpZiBIQVZFKE9TX0RBUktfTU9ERV9TVVBQT1JUKQotLy8gVGhlIG9u bHkgZGlmZmVyZW5jZSBpbiB0aGUgc2ltcGxlIHN0eWxlIHNoZWV0IGZvciBkYXJrIG1vZGUgaXMg dGhlIGFkZGl0aW9uIG9mIGh0bWx7Y29sb3I6dGV4dH0uCi1zdGF0aWMgY29uc3QgY2hhciogc2lt cGxlVXNlckFnZW50U3R5bGVTaGVldCA9ICJodG1sLGJvZHksZGl2e2Rpc3BsYXk6YmxvY2t9aHRt bHtjb2xvcjp0ZXh0fWhlYWR7ZGlzcGxheTpub25lfWJvZHl7bWFyZ2luOjhweH1kaXY6Zm9jdXMs c3Bhbjpmb2N1cyxhOmZvY3Vze291dGxpbmU6YXV0byA1cHggLXdlYmtpdC1mb2N1cy1yaW5nLWNv bG9yfWE6YW55LWxpbmt7Y29sb3I6LXdlYmtpdC1saW5rO3RleHQtZGVjb3JhdGlvbjp1bmRlcmxp bmV9YTphbnktbGluazphY3RpdmV7Y29sb3I6LXdlYmtpdC1hY3RpdmVsaW5rfSI7CisjZGVmaW5l IENTU19EQVJLX01PREVfQURESVRJT04gImh0bWx7Y29sb3I6dGV4dH0iCiAjZWxzZQotc3RhdGlj IGNvbnN0IGNoYXIqIHNpbXBsZVVzZXJBZ2VudFN0eWxlU2hlZXQgPSAiaHRtbCxib2R5LGRpdntk aXNwbGF5OmJsb2NrfWhlYWR7ZGlzcGxheTpub25lfWJvZHl7bWFyZ2luOjhweH1kaXY6Zm9jdXMs c3Bhbjpmb2N1cyxhOmZvY3Vze291dGxpbmU6YXV0byA1cHggLXdlYmtpdC1mb2N1cy1yaW5nLWNv bG9yfWE6YW55LWxpbmt7Y29sb3I6LXdlYmtpdC1saW5rO3RleHQtZGVjb3JhdGlvbjp1bmRlcmxp bmV9YTphbnktbGluazphY3RpdmV7Y29sb3I6LXdlYmtpdC1hY3RpdmVsaW5rfSI7CisjZGVmaW5l IENTU19EQVJLX01PREVfQURESVRJT04gIiIKICNlbmRpZgogCisvLyBGSVhNRTogSXQgd291bGQg YmUgbmljZSB0byB1c2Ugc29tZSBtZWNoYW5pc20gdGhhdCBndWFyYW50ZWVzIHRoaXMgaXMgaW4g c3luYyB3aXRoIHRoZSByZWFsIFVBIHN0eWxlc2hlZXQuCitzdGF0aWMgY29uc3QgY2hhciogc2lt cGxlVXNlckFnZW50U3R5bGVTaGVldCA9ICJodG1sLGJvZHksZGl2e2Rpc3BsYXk6YmxvY2t9IiBD U1NfREFSS19NT0RFX0FERElUSU9OICJoZWFke2Rpc3BsYXk6bm9uZX1ib2R5e21hcmdpbjo4cHh9 ZGl2OmZvY3VzLHNwYW46Zm9jdXMsYTpmb2N1c3tvdXRsaW5lOmF1dG8gIiBERUZBVUxUX09VVExJ TkVfV0lEVEggIiAtd2Via2l0LWZvY3VzLXJpbmctY29sb3J9YTphbnktbGlua3tjb2xvcjotd2Vi a2l0LWxpbms7dGV4dC1kZWNvcmF0aW9uOnVuZGVybGluZX1hOmFueS1saW5rOmFjdGl2ZXtjb2xv cjotd2Via2l0LWFjdGl2ZWxpbmt9IjsKKwogc3RhdGljIGlubGluZSBib29sIGVsZW1lbnRDYW5V c2VTaW1wbGVEZWZhdWx0U3R5bGUoY29uc3QgRWxlbWVudCYgZWxlbWVudCkKIHsKICAgICByZXR1 cm4gaXM8SFRNTEh0bWxFbGVtZW50PihlbGVtZW50KSB8fCBpczxIVE1MSGVhZEVsZW1lbnQ+KGVs ZW1lbnQpCg==