202703 2019-10-08 13:19:11 -0700 dataLogIf should be ALWAYS_INLINE 2019-10-08 15:17:26 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset benjamin cdumez cmarcelo commit-queue dbates ews-watchlist saam webkit-bug-importer oldest_to_newest 1577910 0 rmorisset 2019-10-08 13:19:11 -0700 We often have the following pattern: ``` static constexpr bool verbose = false; ... dataLogLnIf(verbose, "Something is happening"); ``` To make sure that these are always properly eliminated I'd like to make dataLogIf/dataLogLnIf ALWAYS_INLINE. We may as well mark the branch as UNLIKELY too, for the cases where the condition comes from Options::verboseSomething. 1577911 1 380457 rmorisset 2019-10-08 13:21:35 -0700 Created attachment 380457 Patch 1577974 2 380457 commit-queue 2019-10-08 15:16:11 -0700 Comment on attachment 380457 Patch Clearing flags on attachment: 380457 Committed r250867: <https://trac.webkit.org/changeset/250867> 1577975 3 commit-queue 2019-10-08 15:16:13 -0700 All reviewed patches have been landed. Closing bug. 1577976 4 webkit-bug-importer 2019-10-08 15:17:26 -0700 <rdar://problem/56094719> 380457 2019-10-08 13:21:35 -0700 2019-10-08 15:16:11 -0700 Patch patchTrivialDataLogIf text/plain 1776 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMWYwZjViZjFlZTcuLmRmNjY5ZDAyZWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5 LTEwLTA4ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAgICAgICAg ZGF0YUxvZ0lmIHNob3VsZCBiZSBBTFdBWVNfSU5MSU5FCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI3MDMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBvZnRlbiBoYXZlIHRoZSBmb2xsb3dpbmcgcGF0 dGVybjoKKyAgICAgICAgYGBgCisgICAgICAgIHN0YXRpYyBjb25zdGV4cHIgYm9vbCB2ZXJib3Nl ID0gZmFsc2U7CisgICAgICAgIC4uLgorICAgICAgICBkYXRhTG9nTG5JZih2ZXJib3NlLCAiU29t ZXRoaW5nIGlzIGhhcHBlbmluZyIpOworICAgICAgICBgYGAKKyAgICAgICAgVG8gbWFrZSBzdXJl IHRoYXQgdGhlc2UgYXJlIGFsd2F5cyBwcm9wZXJseSBlbGltaW5hdGVkIEknZCBsaWtlIHRvIG1h a2UgZGF0YUxvZ0lmL2RhdGFMb2dMbklmIEFMV0FZU19JTkxJTkUuCisgICAgICAgIAorICAgICAg ICBXZSBtYXkgYXMgd2VsbCBtYXJrIHRoZSBicmFuY2ggYXMgVU5MSUtFTFkgdG9vLCBmb3IgdGhl IGNhc2VzIHdoZXJlIHRoZSBjb25kaXRpb24gY29tZXMgZnJvbSBPcHRpb25zOjp2ZXJib3NlU29t ZXRoaW5nKCkgYW5kIGlzIG9ubHkga25vd24gYXQgcnVudGltZS4KKworICAgICAgICAqIHd0Zi9E YXRhTG9nLmg6CisgICAgICAgIChXVEY6OmRhdGFMb2dJZik6CisgICAgICAgIChXVEY6OmRhdGFM b2dMbklmKToKKwogMjAxOS0xMC0wNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNv bT4KIAogICAgICAgICBCdWlsZCBmYWlsdXJlIGluIFdlYkhUTUxWaWV3Lm1tIHdpdGggdGhlIHB1 YmxpYyBTREsgKFhjb2RlIDExIGFuZCBNb2phdmUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi9EYXRhTG9nLmggYi9Tb3VyY2UvV1RGL3d0Zi9EYXRhTG9nLmgKaW5kZXggNzBmMDYzMDJmYjku LjBiODQ0YjUyMzU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9EYXRhTG9nLmgKKysrIGIv U291cmNlL1dURi93dGYvRGF0YUxvZy5oCkBAIC01MiwxNiArNTIsMTYgQEAgdm9pZCBkYXRhTG9n TG4oY29uc3QgVHlwZXMmLi4uIHZhbHVlcykKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUuLi4gVHlw ZXM+Ci12b2lkIGRhdGFMb2dJZihib29sIHNob3VsZExvZywgY29uc3QgVHlwZXMmLi4uIHZhbHVl cykKK0FMV0FZU19JTkxJTkUgdm9pZCBkYXRhTG9nSWYoYm9vbCBzaG91bGRMb2csIGNvbnN0IFR5 cGVzJi4uLiB2YWx1ZXMpCiB7Ci0gICAgaWYgKHNob3VsZExvZykKKyAgICBpZiAoVU5MSUtFTFko c2hvdWxkTG9nKSkKICAgICAgICAgZGF0YUxvZyh2YWx1ZXMuLi4pOwogfQogCiB0ZW1wbGF0ZTx0 eXBlbmFtZS4uLiBUeXBlcz4KLXZvaWQgZGF0YUxvZ0xuSWYoYm9vbCBzaG91bGRMb2csIGNvbnN0 IFR5cGVzJi4uLiB2YWx1ZXMpCitBTFdBWVNfSU5MSU5FIHZvaWQgZGF0YUxvZ0xuSWYoYm9vbCBz aG91bGRMb2csIGNvbnN0IFR5cGVzJi4uLiB2YWx1ZXMpCiB7Ci0gICAgaWYgKHNob3VsZExvZykK KyAgICBpZiAoVU5MSUtFTFkoc2hvdWxkTG9nKSkKICAgICAgICAgZGF0YUxvZ0xuKHZhbHVlcy4u Lik7CiB9CiAK