202698 2019-10-08 10:48:46 -0700 [ews-build] Do not print worker environment variables in each build step [part 3] 2019-10-08 12:04:30 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197319 https://bugs.webkit.org/show_bug.cgi?id=199405 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1577829 0 aakash_jain 2019-10-08 10:48:46 -0700 By default Buildbot prints worker's environment variables in each build step. This is unnecessary and makes the logs hard to read. We should disable printing environment variable in most of the build steps. This is part 3 of https://bugs.webkit.org/show_bug.cgi?id=197319 1577830 1 380443 aakash_jain 2019-10-08 10:50:33 -0700 Created attachment 380443 Patch 1577835 2 aakash_jain 2019-10-08 10:54:59 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/17/builds/4506/steps/8/logs/stdio 1577865 3 380443 commit-queue 2019-10-08 11:59:43 -0700 Comment on attachment 380443 Patch Clearing flags on attachment: 380443 Committed r250847: <https://trac.webkit.org/changeset/250847> 1577866 4 commit-queue 2019-10-08 11:59:45 -0700 All reviewed patches have been landed. Closing bug. 1577870 5 webkit-bug-importer 2019-10-08 12:04:30 -0700 <rdar://problem/56082939> 380443 2019-10-08 10:50:33 -0700 2019-10-08 11:59:43 -0700 Patch bug-202698-20191008135032.patch text/plain 5401 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MDgzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTEwLTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBEbyBub3QgcHJpbnQgd29ya2VyIGVudmlyb25tZW50 IHZhcmlhYmxlcyBpbiBlYWNoIGJ1aWxkIHN0ZXAgW3BhcnQgM10KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjY5OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzLnB5OgorICAgICAgICAoUnVuSmF2YVNjcmlwdENvcmVUZXN0cy5fX2luaXRfXyk6 IERpc2FibGVkIGxvZ2dpbmcgb2YgZW52aXJvbm1lbnQgdmFyaWFibGVzLgorICAgICAgICAoRXh0 cmFjdFRlc3RSZXN1bHRzLl9faW5pdF9fKTogRGl0dG8uCisgICAgICAgICogQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBVcGRhdGVkIHVuaXQtdGVzdHMuCisK IDIwMTktMTAtMDcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg QWRkIElETCBmb3IgcmVxdWVzdElkbGVDYWxsYmFjawpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjUwODM4KQorKysgVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC04NDQs NiArODQ0LDkgQEAgY2xhc3MgUnVuSmF2YVNjcmlwdENvcmVUZXN0cyhzaGVsbC5UZXN0KQogICAg IGxvZ2ZpbGVzID0geydqc29uJzoganNvbkZpbGVOYW1lfQogICAgIGNvbW1hbmQgPSBbJ3Blcmwn LCAnVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMnLCAnLS1uby1idWlsZCcs ICctLW5vLWZhaWwtZmFzdCcsICctLWpzb24tb3V0cHV0PXswfScuZm9ybWF0KGpzb25GaWxlTmFt ZSksIFdpdGhQcm9wZXJ0aWVzKCctLSUoY29uZmlndXJhdGlvbilzJyldCiAKKyAgICBkZWYgX19p bml0X18oc2VsZiwgKiprd2FyZ3MpOgorICAgICAgICBzaGVsbC5UZXN0Ll9faW5pdF9fKHNlbGYs IGxvZ0Vudmlyb249RmFsc2UsICoqa3dhcmdzKQorCiAgICAgZGVmIHN0YXJ0KHNlbGYpOgogICAg ICAgICBhcHBlbmRDdXN0b21CdWlsZEZsYWdzKHNlbGYsIHNlbGYuZ2V0UHJvcGVydHkoJ3BsYXRm b3JtJyksIHNlbGYuZ2V0UHJvcGVydHkoJ2Z1bGxQbGF0Zm9ybScpKQogICAgICAgICByZXR1cm4g c2hlbGwuVGVzdC5zdGFydChzZWxmKQpAQCAtMTUwOCw3ICsxNTExLDcgQEAgY2xhc3MgRXh0cmFj dFRlc3RSZXN1bHRzKG1hc3Rlci5NYXN0ZXJTaAogICAgICAgICBzZWxmLnJlc3VsdERpcmVjdG9y eSA9IEludGVycG9sYXRlKCdwdWJsaWNfaHRtbC9yZXN1bHRzLyUocHJvcDpidWlsZGVybmFtZSlz L3IlKHByb3A6cGF0Y2hfaWQpcy0lKHByb3A6YnVpbGRudW1iZXIpc3t9Jy5mb3JtYXQoaWRlbnRp ZmllcikpCiAgICAgICAgIHNlbGYuY29tbWFuZCA9IFsndW56aXAnLCBzZWxmLnppcEZpbGUsICct ZCcsIHNlbGYucmVzdWx0RGlyZWN0b3J5XQogCi0gICAgICAgIHN1cGVyKEV4dHJhY3RUZXN0UmVz dWx0cywgc2VsZikuX19pbml0X18oc2VsZi5jb21tYW5kKQorICAgICAgICBtYXN0ZXIuTWFzdGVy U2hlbGxDb21tYW5kLl9faW5pdF9fKHNlbGYsIGNvbW1hbmQ9c2VsZi5jb21tYW5kLCBsb2dFbnZp cm9uPUZhbHNlKQogCiAgICAgZGVmIHJlc3VsdERpcmVjdG9yeVVSTChzZWxmKToKICAgICAgICAg cmV0dXJuIHNlbGYucmVzdWx0RGlyZWN0b3J5LnJlcGxhY2UoJ3B1YmxpY19odG1sLycsICcvJykg KyAnLycKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0 dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI1MDgzOCkKKysrIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtOTY2 LDYgKzk2Niw3IEBAIGNsYXNzIFRlc3RSdW5KYXZhU2NyaXB0Q29yZVRlc3RzKEJ1aWxkU3QKICAg ICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicsICdyZWxlYXNlJykKICAgICAg ICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKICAgICAgICAgICAgIEV4cGVjdFNoZWxsKHdv cmtkaXI9J3drZGlyJywKKyAgICAgICAgICAgICAgICAgICAgICAgIGxvZ0Vudmlyb249RmFsc2Us CiAgICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsncGVybCcsICdUb29scy9TY3JpcHRz L3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cycsICctLW5vLWJ1aWxkJywgJy0tbm8tZmFpbC1mYXN0 JywgJy0tanNvbi1vdXRwdXQ9ezB9Jy5mb3JtYXQoc2VsZi5qc29uRmlsZU5hbWUpLCAnLS1yZWxl YXNlJ10sCiAgICAgICAgICAgICAgICAgICAgICAgICBsb2dmaWxlcz17J2pzb24nOiBzZWxmLmpz b25GaWxlTmFtZX0sCiAgICAgICAgICAgICAgICAgICAgICAgICApCkBAIC05ODAsNiArOTgxLDcg QEAgY2xhc3MgVGVzdFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMoQnVpbGRTdAogICAgICAgICBzZWxm LnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ2RlYnVnJykKICAgICAgICAgc2VsZi5leHBl Y3RSZW1vdGVDb21tYW5kcygKICAgICAgICAgICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGly JywKKyAgICAgICAgICAgICAgICAgICAgICAgIGxvZ0Vudmlyb249RmFsc2UsCiAgICAgICAgICAg ICAgICAgICAgICAgICBjb21tYW5kPVsncGVybCcsICdUb29scy9TY3JpcHRzL3J1bi1qYXZhc2Ny aXB0Y29yZS10ZXN0cycsICctLW5vLWJ1aWxkJywgJy0tbm8tZmFpbC1mYXN0JywgJy0tanNvbi1v dXRwdXQ9ezB9Jy5mb3JtYXQoc2VsZi5qc29uRmlsZU5hbWUpLCAnLS1kZWJ1ZyddLAogICAgICAg ICAgICAgICAgICAgICAgICAgbG9nZmlsZXM9eydqc29uJzogc2VsZi5qc29uRmlsZU5hbWV9LAog ICAgICAgICAgICAgICAgICAgICAgICAgKQpAQCAtMTAwNSw2ICsxMDA3LDcgQEAgY2xhc3MgVGVz dFJlUnVuSmF2YVNjcmlwdENvcmVUZXN0cyhCdWlsZAogICAgICAgICBzZWxmLnNldFByb3BlcnR5 KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2UnKQogICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNv bW1hbmRzKAogICAgICAgICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAorICAgICAg ICAgICAgICAgICAgICAgICAgbG9nRW52aXJvbj1GYWxzZSwKICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbW1hbmQ9WydwZXJsJywgJ1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRl c3RzJywgJy0tbm8tYnVpbGQnLCAnLS1uby1mYWlsLWZhc3QnLCAnLS1qc29uLW91dHB1dD17MH0n LmZvcm1hdChzZWxmLmpzb25GaWxlTmFtZSksICctLXJlbGVhc2UnXSwKICAgICAgICAgICAgICAg ICAgICAgICAgIGxvZ2ZpbGVzPXsnanNvbic6IHNlbGYuanNvbkZpbGVOYW1lfSwKICAgICAgICAg ICAgICAgICAgICAgICAgICkKQEAgLTEwMTksNiArMTAyMiw3IEBAIGNsYXNzIFRlc3RSZVJ1bkph dmFTY3JpcHRDb3JlVGVzdHMoQnVpbGQKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmln dXJhdGlvbicsICdkZWJ1ZycpCiAgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCiAg ICAgICAgICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCisgICAgICAgICAgICAgICAg ICAgICAgICBsb2dFbnZpcm9uPUZhbHNlLAogICAgICAgICAgICAgICAgICAgICAgICAgY29tbWFu ZD1bJ3BlcmwnLCAnVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMnLCAnLS1u by1idWlsZCcsICctLW5vLWZhaWwtZmFzdCcsICctLWpzb24tb3V0cHV0PXswfScuZm9ybWF0KHNl bGYuanNvbkZpbGVOYW1lKSwgJy0tZGVidWcnXSwKICAgICAgICAgICAgICAgICAgICAgICAgIGxv Z2ZpbGVzPXsnanNvbic6IHNlbGYuanNvbkZpbGVOYW1lfSwKICAgICAgICAgICAgICAgICAgICAg ICAgICkKQEAgLTEwNDQsNiArMTA0OCw3IEBAIGNsYXNzIFRlc3RSdW5KYXZhU2NyaXB0Q29yZVRl c3RzVG9UKEJ1aWwKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicsICdy ZWxlYXNlJykKICAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKICAgICAgICAgICAg IEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKKyAgICAgICAgICAgICAgICAgICAgICAgIGxv Z0Vudmlyb249RmFsc2UsCiAgICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsncGVybCcs ICdUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cycsICctLW5vLWJ1aWxkJywg Jy0tbm8tZmFpbC1mYXN0JywgJy0tanNvbi1vdXRwdXQ9ezB9Jy5mb3JtYXQoc2VsZi5qc29uRmls ZU5hbWUpLCAnLS1yZWxlYXNlJ10sCiAgICAgICAgICAgICAgICAgICAgICAgICBsb2dmaWxlcz17 J2pzb24nOiBzZWxmLmpzb25GaWxlTmFtZX0sCiAgICAgICAgICAgICAgICAgICAgICAgICApCkBA IC0xMDU4LDYgKzEwNjMsNyBAQCBjbGFzcyBUZXN0UnVuSmF2YVNjcmlwdENvcmVUZXN0c1RvVChC dWlsCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2NvbmZpZ3VyYXRpb24nLCAnZGVidWcnKQog ICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAogICAgICAgICAgICAgRXhwZWN0U2hl bGwod29ya2Rpcj0nd2tkaXInLAorICAgICAgICAgICAgICAgICAgICAgICAgbG9nRW52aXJvbj1G YWxzZSwKICAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9WydwZXJsJywgJ1Rvb2xzL1Nj cmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzJywgJy0tbm8tYnVpbGQnLCAnLS1uby1mYWls LWZhc3QnLCAnLS1qc29uLW91dHB1dD17MH0nLmZvcm1hdChzZWxmLmpzb25GaWxlTmFtZSksICct LWRlYnVnJ10sCiAgICAgICAgICAgICAgICAgICAgICAgICBsb2dmaWxlcz17J2pzb24nOiBzZWxm Lmpzb25GaWxlTmFtZX0sCiAgICAgICAgICAgICAgICAgICAgICAgICApCg==