202682 2019-10-07 21:47:07 -0700 Web Inspector: Canvas: unable to click on overview path component when jumping directly to a shader 2019-10-08 13:16:43 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes jonlee mattbaker webkit-bug-importer oldest_to_newest 1577652 0 hi 2019-10-07 21:47:07 -0700 # STEPS TO REPRODUCE: 1. inspect any page with a canvas that has any WebGL/WebGPU shaders (e.g. <https://webkit.org/demos/webgpu/compute-boids.html>) 2. go to the Canvas Tab 3. select any shader via the [gl] icon in the bottom left corner of one of the canvas preview tiles 4. try to click the "Overview" hierarchical path component to jump back to the overview => FAIL: nothing happens 5. select the parent Canvas/Device hierarchical path component => PASS: content changes 6. try to click the "Overview" hierarchical path component to jump back to the overview => PASS: content changes A similar issue also happens if you initially click the canvas preview tile itself (replace step #3), select a shader in the navigation sidebar, and then try to click the Canvas/Device hierarchical path component. 1577666 1 380403 hi 2019-10-07 22:43:16 -0700 Created attachment 380403 Patch 1577860 2 mattbaker 2019-10-08 11:52:18 -0700 I noticed the problem doesn't occur when navigating to the shader by clicking the canvas preview tile, instead of the [gl] icon context menu. 1577863 3 380403 mattbaker 2019-10-08 11:56:03 -0700 Comment on attachment 380403 Patch r=me 1577906 4 380403 commit-queue 2019-10-08 13:15:23 -0700 Comment on attachment 380403 Patch Clearing flags on attachment: 380403 Committed r250855: <https://trac.webkit.org/changeset/250855> 1577907 5 commit-queue 2019-10-08 13:15:24 -0700 All reviewed patches have been landed. Closing bug. 1577908 6 webkit-bug-importer 2019-10-08 13:16:43 -0700 <rdar://problem/56085807> 380403 2019-10-07 22:43:16 -0700 2019-10-08 13:15:23 -0700 Patch bug-202682-20191007224315.patch text/plain 4062 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc3MDI1YzIyMzM2MWQyYTFmZjU0YjliYWQ3N2Ji ZjdkNzVhMGIxNWUuLjcyN2QxOTEyMGY4OGE3NDBhZDFkOTdmYzA5MzRhZjA3NDFiYmJjZjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE5LTEwLTA3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW52YXM6IHVuYWJsZSB0byBjbGljayBvbiBvdmVydmlldyBwYXRoIGNvbXBvbmVudCB3aGVuIGp1 bXBpbmcgZGlyZWN0bHkgdG8gYSBzaGFkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMjY4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNUYWJDb250ZW50 Vmlldy5qczoKKyAgICAgICAgKFdJLkNhbnZhc1RhYkNvbnRlbnRWaWV3KToKKyAgICAgICAgVGhl IGBXSS5UcmVlT3V0bGluZWAgdXNlZCBmb3IgdGhlIGhpZXJhcmNoaWNhbCBwYXRoIGNvbXBvbmVu dHMgaXMgYWN0dWFsbHkgaGVsZCBieSB0aGUKKyAgICAgICAgQ2FudmFzIFRhYiwgbm90IHRoZSBD YW52YXMgbmF2aWdhdGlvbiBzaWRlYmFyIHBhbmVsLiBBcyBhIHJlc3VsdCwgaWYgdGhlIGhpZXJh cmNoaWNhbCBwYXRoCisgICAgICAgIGlzIGNoYW5nZWQgYnkgYW55dGhpbmcgb3RoZXIgdGhhbiB0 aGUgaGllcmFyY2hpY2FsIHBhdGggaXRzZWxmIChlLmcuIGEgc2VsZWN0aW9uIGluIHRoZQorICAg ICAgICBuYXZpZ2F0aW9uIHNpZGViYXIsIG9yIGNsaWNraW5nIG9uIHRoZSBbZ2xdIHNoYWRlciBv ciBbb19vXSByZWNvcmRpbmcgYnV0dG9ucyBpbiB0aGUKKyAgICAgICAgb3ZlcnZpZXcgcHJldmll dyB0aWxlKSwgdGhlIHNlbGVjdGlvbiBzdGF0ZSBvZiB0aGUgYFdJLlRyZWVPdXRsaW5lYCBjYW4g Z2V0IG91dCBvZiBzeW5jLiBJbgorICAgICAgICB0aGlzIGNhc2UsIHRoZSBgV0kuVHJlZU91dGxp bmVgIHN0aWxsIHRoaW5rcyB0aGF0ICJPdmVydmlldyIgaXMgc2VsZWN0ZWQgYmVjYXVzZSB0aGUg Y2hhbmdlCisgICAgICAgIGluIGNvbnRlbnQgdmlldyB3YXMgdHJpZ2dlcmVkIGJ5IHNvbWV0aGlu ZyB1bnJlbGF0ZWQgdG8gdGhlIGBXSS5UcmVlT3V0bGluZWAgKHNlZSBhYm92ZSBmb3IKKyAgICAg ICAgc3BlY2lmaWMgZXhhbXBsZXMpLiBUaGUgc2ltcGxlIHNvbHV0aW9uIGlzIHRvIGp1c3QgYWxs b3cgcmVwZWF0IHNlbGVjdGlvbiwgYXMgdGhpcyBpcyBvbmx5CisgICAgICAgIGFuIGlzc3VlIGhl cmUgYmVjYXVzZSB0aGUgY2FudmFzIG5hdmlnYXRpb24gc2lkZWJhciBpc24ndCBhbHdheXMgdmlz aWJsZSwgYXMgd2VsbCBhcyB0bworICAgICAgICBhbGxvdyB0aGUgIk92ZXJ2aWV3IiB0byBiZSBs aXN0ZWQgYXMgdGhlIHJvb3QgcGF0aCBpdGVtLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXSS5DYW52YXNTaWRlYmFyUGFu ZWwucHJvdG90eXBlLnVwZGF0ZVJlcHJlc2VudGVkT2JqZWN0cyk6CisgICAgICAgIElmIGEgYFdJ LkNhbnZhc2AgaXMgb25lIG9mIHRoZSBjdXJyZW50IHJlcHJlc2VudGVkIG9iamVjdHMsIGF0dGVt cHQgdG8gc2VsZWN0IGl0LCBldmVuIGlmCisgICAgICAgIGl0IG1hdGNoZXMgdGhlIGN1cnJlbnRs eSBzaG93biBgV0kuQ2FudmFzYC4gVGhpcyBjb3ZlcnMgdGhlIHNpdHVhdGlvbiB3aGVyZSB0aGUg YFdJLkNhbnZhc2AKKyAgICAgICAgaXMgc2VsZWN0ZWQgdmlhIGl0cyBoaWVyYXJjaGljYWwgcGF0 aCBjb21wb25lbnQsIGVuc3VyaW5nIHRoYXQgdGhlIHNlbGVjdGVkIGl0ZW0gaW4gdGhlCisgICAg ICAgIG5hdmlnYXRpb24gc2lkZWJhciBhbHdheXMgbWF0Y2hlcyB0aGUgaGllcmFyY2hpY2FsIHBh dGggY29tcG9uZW50cy4KKwogMjAxOS0xMC0wMiAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2 QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdHlsZXM6IGZvciBydWxlcyB0 aGF0IGRvbid0IG1hdGNoIHNlbGVjdGVkIG5vZGUsIHByb3BlcnR5IHZhbHVlcyBhbHdheXMgc2hv dyBhcyBpbnZhbGlkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuanMKaW5kZXggYzI5NGUyMjIx NWE4N2E4NzgxYTFjMTJlOGUwNDNjMTk3MTBhOWJkYi4uMzE1OWYwM2M5NWRiYjg0MWJjZDY1NDll ZmMxNTc1MzJlODIzM2ExOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ2FudmFzU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1NpZGViYXJQYW5lbC5qcwpAQCAtMTc0 LDYgKzE3NCwxMCBAQCBXSS5DYW52YXNTaWRlYmFyUGFuZWwgPSBjbGFzcyBDYW52YXNTaWRlYmFy UGFuZWwgZXh0ZW5kcyBXSS5OYXZpZ2F0aW9uU2lkZWJhclBhbgogICAgICAgICBsZXQgY2FudmFz ID0gb2JqZWN0cy5maW5kKChvYmplY3QpID0+IG9iamVjdCBpbnN0YW5jZW9mIFdJLkNhbnZhcyk7 CiAgICAgICAgIGlmIChjYW52YXMpIHsKICAgICAgICAgICAgIHRoaXMuY2FudmFzID0gY2FudmFz OworICAgICAgICAgICAgbGV0IHRyZWVFbGVtZW50ID0gdGhpcy5fY2FudmFzVHJlZU91dGxpbmUu ZmluZFRyZWVFbGVtZW50KGNhbnZhcyk7CisgICAgICAgICAgICBjb25zdCBvbWl0Rm9jdXMgPSBm YWxzZTsKKyAgICAgICAgICAgIGNvbnN0IHNlbGVjdGVkQnlVc2VyID0gZmFsc2U7CisgICAgICAg ICAgICB0cmVlRWxlbWVudC5yZXZlYWxBbmRTZWxlY3Qob21pdEZvY3VzLCBzZWxlY3RlZEJ5VXNl cik7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzVGFiQ29udGVudFZpZXcu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNUYWJD b250ZW50Vmlldy5qcwppbmRleCBmYjc5YjUzNzE5NTZkZTA4ZmU1MGY1NzRmZmRmZmJhYjY5OWNi MjNjLi5lYmJlNzQxZDYwODkxYmY2NTA1MmQ0NjY0NzE0YmNmZGJjNDQ3YTdjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNUYWJDb250 ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9DYW52YXNUYWJDb250ZW50Vmlldy5qcwpAQCAtMzksNiArMzksNyBAQCBXSS5DYW52YXNUYWJD b250ZW50VmlldyA9IGNsYXNzIENhbnZhc1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVu dEJyb3dzZXJUYQogICAgICAgICB0aGlzLl9jYW52YXNDb2xsZWN0aW9uID0gbmV3IFdJLkNhbnZh c0NvbGxlY3Rpb247CiAKICAgICAgICAgdGhpcy5fY2FudmFzVHJlZU91dGxpbmUgPSBuZXcgV0ku VHJlZU91dGxpbmU7CisgICAgICAgIHRoaXMuX2NhbnZhc1RyZWVPdXRsaW5lLmFsbG93c1JlcGVh dFNlbGVjdGlvbiA9IHRydWU7CiAgICAgICAgIHRoaXMuX2NhbnZhc1RyZWVPdXRsaW5lLmFkZEV2 ZW50TGlzdGVuZXIoV0kuVHJlZU91dGxpbmUuRXZlbnQuU2VsZWN0aW9uRGlkQ2hhbmdlLCB0aGlz Ll9jYW52YXNUcmVlT3V0bGluZVNlbGVjdGlvbkRpZENoYW5nZSwgdGhpcyk7CiAKICAgICAgICAg dGhpcy5fb3ZlcnZpZXdUcmVlRWxlbWVudCA9IG5ldyBXSS5HZW5lcmFsVHJlZUVsZW1lbnQoImNh bnZhcy1vdmVydmlldyIsIFdJLlVJU3RyaW5nKCJPdmVydmlldyIpLCBudWxsLCB0aGlzLl9jYW52 YXNDb2xsZWN0aW9uKTsK