202628 2019-10-07 03:19:26 -0700 WebPageProxy::updatePlayingMediaDidChange should protect from a null m_userMediaPermissionRequestManager 2019-10-07 07:14:21 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1577303 0 youennf 2019-10-07 03:19:26 -0700 WebPageProxy::updatePlayingMediaDidChange should protect from a null m_userMediaPermissionRequestManager 1577304 1 youennf 2019-10-07 03:19:37 -0700 <rdar://problem/55935091> 1577306 2 380312 youennf 2019-10-07 03:52:31 -0700 Created attachment 380312 Patch 1577322 3 380312 eric.carlson 2019-10-07 06:01:53 -0700 Comment on attachment 380312 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380312&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:8309 > + ASSERT(m_userMediaPermissionRequestManager); If we expect m_userMediaPermissionRequestManager to be NULL some of the time, do we really want an ASSERT here? 1577327 4 youennf 2019-10-07 06:28:50 -0700 (In reply to Eric Carlson from comment #3) > Comment on attachment 380312 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380312&action=review > > > Source/WebKit/UIProcess/WebPageProxy.cpp:8309 > > + ASSERT(m_userMediaPermissionRequestManager); > > If we expect m_userMediaPermissionRequestManager to be NULL some of the > time, do we really want an ASSERT here? By design, when nulling m_userMediaPermissionRequestManager, we set back the capture state to none. For the capture state to be different from None, m_userMediaPermissionRequestManager should in theory be recreated. So we do not expect it to be null but we cannot ignore the fact that a wrong IPC message may happen. 1577339 5 380312 commit-queue 2019-10-07 07:14:19 -0700 Comment on attachment 380312 Patch Clearing flags on attachment: 380312 Committed r250773: <https://trac.webkit.org/changeset/250773> 1577340 6 commit-queue 2019-10-07 07:14:21 -0700 All reviewed patches have been landed. Closing bug. 380312 2019-10-07 03:52:31 -0700 2019-10-07 07:14:19 -0700 Patch bug-202628-20191007125230.patch text/plain 2421 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU3NDNkNGI1Yjk3NzZkNDQ2 MmM0ODNhNmYyZWJkYzVkZDVhYzI3OWYuLmZjNWYyMDBhYjk1ZjBhNGM0MjVkZTFiYWJlZTFkMWVm MzQzNGZiN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMTAtMDcgIHlvdWVubiBm YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYlBhZ2VQcm94eTo6dXBkYXRl UGxheWluZ01lZGlhRGlkQ2hhbmdlIHNob3VsZCBwcm90ZWN0IGZyb20gYSBudWxsIG1fdXNlck1l ZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI2MjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1OTM1 MDkxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9u IHByb2Nlc3Mgc3dhcCBvbiBuYXZpZ2F0aW9uIG9yIHByb2Nlc3MgY3Jhc2gsIG1fdXNlck1lZGlh UGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyIGlzIG1hZGUgbnVsbC4KKyAgICAgICAgQXQgdGhlIHNh bWUgdGltZSwgdGhlIG1lZGlhIHN0YXRlIGlzIHNldCBiYWNrIHRvIG5vdCBwbGF5aW5nLgorICAg ICAgICBGdXR1cmUgY2FsbHMgb2YgdXBkYXRlUGxheWluZ01lZGlhRGlkQ2hhbmdlIHNob3VsZCBu b3QgaGF2ZSBhbnkgY2FwdHVyZSBzdGF0ZSBjaGFuZ2UgdW50aWwgZ2V0VXNlck1lZGlhL2dldERp c3BsYXlNZWRpYQorICAgICAgICBpcyBjYWxsZWQsIHdoaWNoIHdvdWxkIGNyZWF0ZSBtX3VzZXJN ZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci4KKyAgICAgICAgQnV0IHRoaXMgYXNzdW1wdGlv biBpcyBub3QgYWx3YXlzIHRydWUgZ2l2ZW4gdGhhdCB0aGUgbWVkaWEgc3RhdGUgaXMgY29tcHV0 ZWQgYXMgcHJvY2Vzcy13aWRlIGluIE1lZGlhU3RyZWFtVHJhY2s6OmNhcHR1cmVTdGF0ZSBvbiBp T1MuCisgICAgICAgIFRoZSBhYm92ZSBiZWhhdmlvciBpcyBmaXhlZCBhcyBwYXJ0IG9mIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI2MjcuCisgICAgICAgIFNpbmNl IHRoZSBjYWxsIHRvIHVwZGF0ZVBsYXlpbmdNZWRpYURpZENoYW5nZSBpcyB0cmlnZ2VyZWQgc3Ry YWlnaHQgZnJvbSBJUEMsIGl0IHNob3VsZCBub3QgYmUgdHJ1c3RlZCBhbmQgYSBudWxsIGNoZWNr IHNob3VsZCBiZSBhZGRlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnVwZGF0ZVBsYXlpbmdNZWRpYURpZENo YW5nZSk6CisKIDIwMTktMTAtMDQgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAg ICAgICAgIFVzZSBhIGJldHRlciBuYW1lIHRoYW4gYWxsb3dGYXN0Q2xpY2tzRXZlcnl3aGVyZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggYjRjMDA4NWJkMTJk MzQ5MjM0YjRiNGM1MTc3OTIyODliNTE4NjE3ZC4uMDQxODJiOThjYTIwN2ZjMjJhNzRkZTE5MTA2 N2Q1ODU1NmJiODQ2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CkBAIC04MzA2LDcgKzgzMDYsOSBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6dXBkYXRlUGxheWluZ01l ZGlhRGlkQ2hhbmdlKE1lZGlhUHJvZHVjZXI6Ok1lZGlhU3RhdGVGbGFncyBuZQogI2lmIEVOQUJM RShNRURJQV9TVFJFQU0pCiAgICAgaWYgKG9sZE1lZGlhQ2FwdHVyZVN0YXRlICE9IG5ld01lZGlh Q2FwdHVyZVN0YXRlKSB7CiAgICAgICAgIG1fdWlDbGllbnQtPm1lZGlhQ2FwdHVyZVN0YXRlRGlk Q2hhbmdlKG1fbWVkaWFTdGF0ZSk7Ci0gICAgICAgIG1fdXNlck1lZGlhUGVybWlzc2lvblJlcXVl c3RNYW5hZ2VyLT5jYXB0dXJlU3RhdGVDaGFuZ2VkKG9sZE1lZGlhQ2FwdHVyZVN0YXRlLCBuZXdN ZWRpYUNhcHR1cmVTdGF0ZSk7CisgICAgICAgIEFTU0VSVChtX3VzZXJNZWRpYVBlcm1pc3Npb25S ZXF1ZXN0TWFuYWdlcik7CisgICAgICAgIGlmIChtX3VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0 TWFuYWdlcikKKyAgICAgICAgICAgIG1fdXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2Vy LT5jYXB0dXJlU3RhdGVDaGFuZ2VkKG9sZE1lZGlhQ2FwdHVyZVN0YXRlLCBuZXdNZWRpYUNhcHR1 cmVTdGF0ZSk7CiAgICAgfQogI2VuZGlmCiAK