202623 2019-10-06 21:01:15 -0700 [LFC] Add const version of LayoutState::displayBoxForLayoutBox 2019-10-07 10:28:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1577286 0 zalan 2019-10-06 21:01:15 -0700 ssia 1577287 1 webkit-bug-importer 2019-10-06 21:01:37 -0700 <rdar://problem/56025259> 1577288 2 380306 zalan 2019-10-06 21:03:05 -0700 Created attachment 380306 Patch 1577384 3 380306 commit-queue 2019-10-07 10:28:34 -0700 Comment on attachment 380306 Patch Clearing flags on attachment: 380306 Committed r250776: <https://trac.webkit.org/changeset/250776> 1577385 4 commit-queue 2019-10-07 10:28:36 -0700 All reviewed patches have been landed. Closing bug. 380306 2019-10-06 21:03:05 -0700 2019-10-07 10:28:34 -0700 Patch bug-202623-20191006210303.patch text/plain 4813 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhmMDkwMzE2NDk2NmU0 NDQ4Y2RiZGRmZWFlOWUwZmIyZjk0NDAxNS4uNjVlOWM2ZjY2MDE1YjQyNzhiOWU3YjE0YWYwMjY4 NzYzYmQ5YjI0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTEwLTA2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gQWRkIGNvbnN0IHZl cnNpb24gb2YgTGF5b3V0U3RhdGU6OmRpc3BsYXlCb3hGb3JMYXlvdXRCb3gKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjYyMworICAgICAgICA8cmRh cjovL3Byb2JsZW0vNTYwMjUyNTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBsYXlvdXQvTGF5b3V0U3RhdGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TGF5b3V0OjpMYXlvdXRTdGF0ZTo6ZGlzcGxheUJveEZvckxheW91dEJveCk6CisgICAgICAg IChXZWJDb3JlOjpMYXlvdXQ6OkxheW91dFN0YXRlOjpkaXNwbGF5Qm94Rm9yTGF5b3V0Qm94IGNv bnN0KToKKyAgICAgICAgKiBsYXlvdXQvTGF5b3V0U3RhdGUuaDoKKyAgICAgICAgKiBsYXlvdXQv bGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlv dXQ6Om91dHB1dExheW91dFRyZWUpOgorCiAyMDE5LTEwLTA1ICBaYWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10gTGF5b3V0Q2hpbGR0SXRlcmF0b3JBZGFwdGVy IC0+IExheW91dENoaWxkSXRlcmF0b3JBZGFwdGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvTGF5b3V0U3RhdGUuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0xheW91dFN0 YXRlLmNwcAppbmRleCA2ZmIxZjRhZThlZjQ1Y2NkN2M0ZDcxMzI0Njk3ZjI3YTZhOWZlYTg5Li4y OTY4MjEwNTA5NWFjYTFmNzY1Yjk3YzMwYmM2ZTZjYmE3YWNiZjVkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0U3RhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9MYXlvdXRTdGF0ZS5jcHAKQEAgLTQ1LDEzICs0NSwxOSBAQCBMYXlvdXRTdGF0ZTo6TGF5 b3V0U3RhdGUoY29uc3QgQ29udGFpbmVyJiByb290KQogICAgIEFTU0VSVChyb290LmVzdGFibGlz aGVzRm9ybWF0dGluZ0NvbnRleHQoKSk7CiB9CiAKLURpc3BsYXk6OkJveCYgTGF5b3V0U3RhdGU6 OmRpc3BsYXlCb3hGb3JMYXlvdXRCb3goY29uc3QgQm94JiBsYXlvdXRCb3gpIGNvbnN0CitEaXNw bGF5OjpCb3gmIExheW91dFN0YXRlOjpkaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KGNvbnN0IEJveCYg bGF5b3V0Qm94KQogewogICAgIHJldHVybiAqbV9sYXlvdXRUb0Rpc3BsYXlCb3guZW5zdXJlKCZs YXlvdXRCb3gsIFsmbGF5b3V0Qm94XSB7CiAgICAgICAgIHJldHVybiBtYWtlVW5pcXVlPERpc3Bs YXk6OkJveD4obGF5b3V0Qm94LnN0eWxlKCkpOwogICAgIH0pLml0ZXJhdG9yLT52YWx1ZTsKIH0K IAorY29uc3QgRGlzcGxheTo6Qm94JiBMYXlvdXRTdGF0ZTo6ZGlzcGxheUJveEZvckxheW91dEJv eChjb25zdCBCb3gmIGxheW91dEJveCkgY29uc3QKK3sKKyAgICBBU1NFUlQoaGFzRGlzcGxheUJv eChsYXlvdXRCb3gpKTsKKyAgICByZXR1cm4gKm1fbGF5b3V0VG9EaXNwbGF5Qm94LmdldCgmbGF5 b3V0Qm94KTsKK30KKwogRm9ybWF0dGluZ1N0YXRlJiBMYXlvdXRTdGF0ZTo6Zm9ybWF0dGluZ1N0 YXRlRm9yQm94KGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25zdAogewogICAgIGF1dG8mIHJvb3Qg PSBsYXlvdXRCb3guZm9ybWF0dGluZ0NvbnRleHRSb290KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvTGF5b3V0U3RhdGUuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlv dXRTdGF0ZS5oCmluZGV4IDIyNDMxNjY4MzU1NDA0NDY5YWVlMTVmZDkyMjY0NWVkMTJjODIyZmEu LjU4MDViYzE1MGMyMmZlNmQ0OGI0MjhjNzBlZTlkYWRiNmI4MWViNjMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRTdGF0ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9MYXlvdXRTdGF0ZS5oCkBAIC02MCw3ICs2MCw4IEBAIHB1YmxpYzoKICAgICB2b2lkIGRl cmVnaXN0ZXJGb3JtYXR0aW5nQ29udGV4dChjb25zdCBGb3JtYXR0aW5nQ29udGV4dCYgZm9ybWF0 dGluZ0NvbnRleHQpIHsgbV9mb3JtYXR0aW5nQ29udGV4dExpc3QucmVtb3ZlKCZmb3JtYXR0aW5n Q29udGV4dCk7IH0KICNlbmRpZgogCi0gICAgRGlzcGxheTo6Qm94JiBkaXNwbGF5Qm94Rm9yTGF5 b3V0Qm94KGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25zdDsKKyAgICBEaXNwbGF5OjpCb3gmIGRp c3BsYXlCb3hGb3JMYXlvdXRCb3goY29uc3QgQm94JiBsYXlvdXRCb3gpOworICAgIGNvbnN0IERp c3BsYXk6OkJveCYgZGlzcGxheUJveEZvckxheW91dEJveChjb25zdCBCb3gmIGxheW91dEJveCkg Y29uc3Q7CiAgICAgYm9vbCBoYXNEaXNwbGF5Qm94KGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25z dCB7IHJldHVybiBtX2xheW91dFRvRGlzcGxheUJveC5jb250YWlucygmbGF5b3V0Qm94KTsgfQog CiAgICAgZW51bSBjbGFzcyBRdWlya3NNb2RlIHsgTm8sIExpbWl0ZWQsIFllcyB9OwpAQCAtNzcs NyArNzgsNyBAQCBwcml2YXRlOgogI2lmbmRlZiBOREVCVUcKICAgICBIYXNoU2V0PGNvbnN0IEZv cm1hdHRpbmdDb250ZXh0Kj4gbV9mb3JtYXR0aW5nQ29udGV4dExpc3Q7CiAjZW5kaWYKLSAgICBt dXRhYmxlIEhhc2hNYXA8Y29uc3QgQm94Kiwgc3RkOjp1bmlxdWVfcHRyPERpc3BsYXk6OkJveD4+ IG1fbGF5b3V0VG9EaXNwbGF5Qm94OworICAgIEhhc2hNYXA8Y29uc3QgQm94Kiwgc3RkOjp1bmlx dWVfcHRyPERpc3BsYXk6OkJveD4+IG1fbGF5b3V0VG9EaXNwbGF5Qm94OwogICAgIFF1aXJrc01v ZGUgbV9xdWlya3NNb2RlIHsgUXVpcmtzTW9kZTo6Tm8gfTsKIH07CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNwcAppbmRl eCA1M2E0ZTYzNGI1YjM2YjZiNzEzM2QzMTdhMzFhOGIzOTMxYmYxYjBhLi5kYmE2Mzg4MjAzNTdj ZWEzNWNlYzM0MjA2ODRlMjUxZDU1OGVlMDNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwCkBAIC0zMjYsMTQgKzMy NiwxNCBAQCBzdGF0aWMgdm9pZCBvdXRwdXRMYXlvdXRCb3goVGV4dFN0cmVhbSYgc3RyZWFtLCBj b25zdCBCb3gmIGxheW91dEJveCwgY29uc3QgRGlzcAogc3RhdGljIHZvaWQgb3V0cHV0TGF5b3V0 VHJlZShjb25zdCBMYXlvdXRTdGF0ZSogbGF5b3V0U3RhdGUsIFRleHRTdHJlYW0mIHN0cmVhbSwg Y29uc3QgQ29udGFpbmVyJiByb290Q29udGFpbmVyLCB1bnNpZ25lZCBkZXB0aCkKIHsKICAgICBm b3IgKGF1dG8mIGNoaWxkIDogY2hpbGRyZW5PZlR5cGU8Qm94Pihyb290Q29udGFpbmVyKSkgewot ICAgICAgICBEaXNwbGF5OjpCb3gqIGRpc3BsYXlCb3ggPSBudWxscHRyOwotICAgICAgICAvLyBO b3QgYWxsIGJveGVzIGdlbmVyYXRlIGRpc3BsYXkgYm94ZXMuCi0gICAgICAgIGlmIChsYXlvdXRT dGF0ZSAmJiBsYXlvdXRTdGF0ZS0+aGFzRGlzcGxheUJveChjaGlsZCkpCi0gICAgICAgICAgICBk aXNwbGF5Qm94ID0gJmxheW91dFN0YXRlLT5kaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KGNoaWxkKTsK LQotICAgICAgICBvdXRwdXRMYXlvdXRCb3goc3RyZWFtLCBjaGlsZCwgZGlzcGxheUJveCwgZGVw dGgpOwotICAgICAgICBpZiAobGF5b3V0U3RhdGUgJiYgY2hpbGQuZXN0YWJsaXNoZXNJbmxpbmVG b3JtYXR0aW5nQ29udGV4dCgpKQotICAgICAgICAgICAgb3V0cHV0SW5saW5lUnVucyhzdHJlYW0s ICpsYXlvdXRTdGF0ZSwgZG93bmNhc3Q8Q29udGFpbmVyPihjaGlsZCksIGRlcHRoICsgMSk7Cisg ICAgICAgIGlmIChsYXlvdXRTdGF0ZSkgeworICAgICAgICAgICAgLy8gTm90IGFsbCBib3hlcyBn ZW5lcmF0ZSBkaXNwbGF5IGJveGVzLgorICAgICAgICAgICAgaWYgKGxheW91dFN0YXRlLT5oYXNE aXNwbGF5Qm94KGNoaWxkKSkKKyAgICAgICAgICAgICAgICBvdXRwdXRMYXlvdXRCb3goc3RyZWFt LCBjaGlsZCwgJmxheW91dFN0YXRlLT5kaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KGNoaWxkKSwgZGVw dGgpOworICAgICAgICAgICAgaWYgKGNoaWxkLmVzdGFibGlzaGVzSW5saW5lRm9ybWF0dGluZ0Nv bnRleHQoKSkKKyAgICAgICAgICAgICAgICBvdXRwdXRJbmxpbmVSdW5zKHN0cmVhbSwgKmxheW91 dFN0YXRlLCBkb3duY2FzdDxDb250YWluZXI+KGNoaWxkKSwgZGVwdGggKyAxKTsKKyAgICAgICAg fSBlbHNlCisgICAgICAgICAgICBvdXRwdXRMYXlvdXRCb3goc3RyZWFtLCBjaGlsZCwgbnVsbHB0 ciwgZGVwdGgpOwogCiAgICAgICAgIGlmIChpczxDb250YWluZXI+KGNoaWxkKSkKICAgICAgICAg ICAgIG91dHB1dExheW91dFRyZWUobGF5b3V0U3RhdGUsIHN0cmVhbSwgZG93bmNhc3Q8Q29udGFp bmVyPihjaGlsZCksIGRlcHRoICsgMSk7Cg==