202605 2019-10-04 14:47:52 -0700 Socket-based RWI should base64-encode backend commands on client, not server 2019-10-04 15:25:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling commit-queue don.olmstead ews-watchlist hi joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1577019 0 ross.kirsling 2019-10-04 14:47:52 -0700 Socket-based RWI should base64-encode backend commands on client, not server 1577020 1 380253 ross.kirsling 2019-10-04 14:48:51 -0700 Created attachment 380253 Patch 1577028 2 ross.kirsling 2019-10-04 14:52:21 -0700 Just a follow-up to r250679 that was based on a misunderstanding on my part. (Either way technically works, but I'd gone out of my way to do this on the server, when I'd forgotten that base64 encoding text *increases* the size... 🤦‍♂️) 1577045 3 380253 commit-queue 2019-10-04 15:24:02 -0700 Comment on attachment 380253 Patch Clearing flags on attachment: 380253 Committed r250752: <https://trac.webkit.org/changeset/250752> 1577046 4 commit-queue 2019-10-04 15:24:04 -0700 All reviewed patches have been landed. Closing bug. 1577048 5 webkit-bug-importer 2019-10-04 15:25:16 -0700 <rdar://problem/55997224> 380253 2019-10-04 14:48:51 -0700 2019-10-04 15:24:02 -0700 Patch bug-202605-20191004144850.patch text/plain 3466 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NTEzM2I5ZDcxZTM3Mzc0YmY1Y2E4MDBiOTdkYmI1YTQwMjY3ZjZkLi5jMmVhZmYzYzIxMWVkZmNl NDUzNDNmZTg4MTJmMWM1ZTExZTY5YjY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0xMC0wNCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgU29ja2V0LWJhc2VkIFJXSSBzaG91bGQgYmFzZTY0LWVuY29kZSBi YWNrZW5kIGNvbW1hbmRzIG9uIGNsaWVudCwgbm90IHNlcnZlcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyNjA1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9S ZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpSZW1vdGVJbnNw ZWN0b3JTZXJ2ZXI6OnNldHVwSW5zcGVjdG9yQ2xpZW50KToKKwogMjAxOS0xMC0wNCAgVHJ1aXR0 IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIyNTA1ODMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ5NGQ1YWJiYTZlYTc4NzZjMGM5NTUzODRlMWM1 NTZhNWU3NzJlMzQuLjcyNDY1NWMxZjk4YjU4Y2JjMTM5ZTBkNTYyYzY1ZmFkZDAyMWJjNmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMTAtMDQgIFJvc3MgS2lyc2xpbmcgIDxyb3Nz LmtpcnNsaW5nQHNvbnkuY29tPgorCisgICAgICAgIFNvY2tldC1iYXNlZCBSV0kgc2hvdWxkIGJh c2U2NC1lbmNvZGUgYmFja2VuZCBjb21tYW5kcyBvbiBjbGllbnQsIG5vdCBzZXJ2ZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjYwNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL3Nv Y2tldC9SZW1vdGVJbnNwZWN0b3JDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVJ bnNwZWN0b3JDbGllbnQ6OnNldEJhY2tlbmRDb21tYW5kcyk6CisKIDIwMTktMTAtMDQgIFJvc3Mg S2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQg V2luQ2Fpcm8gYnVpbGQgZml4IGZvciByMjUwNzE3LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvc29ja2V0L1JlbW90ZUluc3BlY3RvclNlcnZlci5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQvUmVtb3Rl SW5zcGVjdG9yU2VydmVyLmNwcAppbmRleCAxOWI4NTljYWU0YjRkMjE0NThkMTQ0M2JiNzA0OTli Y2EyMWFlNTUxLi5mZmJjMmJlYjMwMjI3MTVmZWIxMThlZDBlNzI1YTQwOGE0ODQ0Y2RlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQvUmVt b3RlSW5zcGVjdG9yU2VydmVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL3JlbW90ZS9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcApAQCAtMzMsNyArMzMs NiBAQAogI2luY2x1ZGUgPHd0Zi9KU09OVmFsdWVzLmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJl YWQuaD4KICNpbmNsdWRlIDx3dGYvUnVuTG9vcC5oPgotI2luY2x1ZGUgPHd0Zi90ZXh0L0Jhc2U2 NC5oPgogCiBuYW1lc3BhY2UgSW5zcGVjdG9yIHsKIApAQCAtMTUyLDcgKzE1MSw3IEBAIHZvaWQg UmVtb3RlSW5zcGVjdG9yU2VydmVyOjpzZXR1cEluc3BlY3RvckNsaWVudChjb25zdCBFdmVudCYp CiAKICAgICBhdXRvIGJhY2tlbmRDb21tYW5kc0V2ZW50ID0gSlNPTjo6T2JqZWN0OjpjcmVhdGUo KTsKICAgICBiYWNrZW5kQ29tbWFuZHNFdmVudC0+c2V0U3RyaW5nKCJldmVudCJfcywgIkJhY2tl bmRDb21tYW5kcyJfcyk7Ci0gICAgYmFja2VuZENvbW1hbmRzRXZlbnQtPnNldFN0cmluZygibWVz c2FnZSJfcywgYmFzZTY0RW5jb2RlKGJhY2tlbmRDb21tYW5kcygpLnV0ZjgoKSkpOworICAgIGJh Y2tlbmRDb21tYW5kc0V2ZW50LT5zZXRTdHJpbmcoIm1lc3NhZ2UiX3MsIGJhY2tlbmRDb21tYW5k cygpKTsKICAgICBzZW5kV2ViSW5zcGVjdG9yRXZlbnQobV9jbGllbnRDb25uZWN0aW9uLnZhbHVl KCksIGJhY2tlbmRDb21tYW5kc0V2ZW50LT50b0pTT05TdHJpbmcoKSk7CiAKICAgICBhdXRvIHNl dHVwRXZlbnQgPSBKU09OOjpPYmplY3Q6OmNyZWF0ZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3Mvc29ja2V0L1JlbW90ZUluc3BlY3RvckNsaWVudC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yQ2xpZW50LmNwcAppbmRleCA1 NDQ4NzRiOGQzYzY5MDkzMjk2YWE4ODliZWU0MGZhMmI2OWY5MDc4Li5iZjFmNWZlMzg0ZTdmOTAy Zjc2OWJhYjQ0YzQ5M2VjMWM3NDMxZmY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yQ2xpZW50LmNwcApAQCAtMzAsNiArMzAs NyBAQAogCiAjaW5jbHVkZSAiUmVtb3RlV2ViSW5zcGVjdG9yUHJveHkuaCIKICNpbmNsdWRlIDx3 dGYvTWFpblRocmVhZC5oPgorI2luY2x1ZGUgPHd0Zi90ZXh0L0Jhc2U2NC5oPgogCiBuYW1lc3Bh Y2UgV2ViS2l0IHsKIApAQCAtMTkzLDcgKzE5NCw3IEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yQ2xp ZW50OjpzZXRCYWNrZW5kQ29tbWFuZHMoY29uc3QgRXZlbnQmIGV2ZW50KQogICAgIGlmICghZXZl bnQubWVzc2FnZSB8fCBldmVudC5tZXNzYWdlLT5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsK IAotICAgIG1fYmFja2VuZENvbW1hbmRzVVJMID0gbWFrZVN0cmluZygiZGF0YTp0ZXh0L2phdmFz Y3JpcHQ7YmFzZTY0LCIsIGV2ZW50Lm1lc3NhZ2UudmFsdWUoKSk7CisgICAgbV9iYWNrZW5kQ29t bWFuZHNVUkwgPSBtYWtlU3RyaW5nKCJkYXRhOnRleHQvamF2YXNjcmlwdDtiYXNlNjQsIiwgYmFz ZTY0RW5jb2RlKGV2ZW50Lm1lc3NhZ2UtPnV0ZjgoKSkpOwogfQogCiB2b2lkIFJlbW90ZUluc3Bl Y3RvckNsaWVudDo6c2V0VGFyZ2V0TGlzdChjb25zdCBFdmVudCYgZXZlbnQpCg==