202597 2019-10-04 13:00:14 -0700 Clean up: Remove pre-macOS Sierra workaround for missing kVK_RightCommand 2019-10-09 10:25:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Mac All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates andersca webkit-bug-importer oldest_to_newest 1576970 0 dbates 2019-10-04 13:00:14 -0700 Since macOS High Sierra kVK_RightCommand has been HIToolbox/Events.h. It wasn't defined in the macOS Sierra days. We don't build for macOS Sierra any longer and can remove the workaround. 1576975 1 dbates 2019-10-04 13:03:28 -0700 Actually this constant has been around since macOS Sierra – as the comment in the code stated. 1576976 2 380238 dbates 2019-10-04 13:04:20 -0700 Created attachment 380238 Patch 1577226 3 dbates 2019-10-05 11:13:11 -0700 Thanks Anders 1578283 4 380238 dbates 2019-10-09 10:24:07 -0700 Comment on attachment 380238 Patch Clearing flags on attachment: 380238 Committed r250915: <https://trac.webkit.org/changeset/250915> 1578284 5 dbates 2019-10-09 10:24:09 -0700 All reviewed patches have been landed. Closing bug. 1578286 6 webkit-bug-importer 2019-10-09 10:25:16 -0700 <rdar://problem/56120950> 380238 2019-10-04 13:04:20 -0700 2019-10-09 10:24:07 -0700 Patch bug-202597-20191004130420.patch text/plain 1522 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI3Y2VhNzUyNzBjYzYz YTFhNjUxNDhkOTBjNTE2N2ZkZThiYTY0Zi4uNTg3YTE1ZTNiNGNlMDc4NmZmZGU5OWM0NDI0NWJk ZTlhY2YzMzA0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEwLTA0ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbiB1cDogUmVtb3Zl IHByZS1tYWNPUyBTaWVycmEgd29ya2Fyb3VuZCBmb3IgbWlzc2luZyBrVktfUmlnaHRDb21tYW5k CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDI1OTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBrVktfUmln aHRDb21tYW5kIGhhcyBiZWVuIGRlZmluZWQgaW4gSElUb29sYm94L0V2ZW50cy5oIHNpbmNlIG1h Y09TIFNpZXJyYS4gV2Ugbm8gbG9uZ2VyCisgICAgICAgIG5lZWQgdG8gbWFpbnRhaW4gY29kZSB0 byBtYW51YWxseSBkZWZpbmUgaXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvUGxhdGZvcm1F dmVudEZhY3RvcnlNYWMubW06CisgICAgICAgIChXZWJDb3JlOjprZXlGb3JLZXlFdmVudCk6CisK IDIwMTktMDktMTMgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAg IFN1cHBvcnQgYnVpbGRpbmcgV2ViS2l0IGZvciBNYWMgQ2F0YWx5c3QgZnJvbSBYY29kZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtRXZlbnRGYWN0b3J5 TWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtRXZlbnRGYWN0b3J5 TWFjLm1tCmluZGV4IDIzMjhiYWZmODk2YmYwYjRjMTk5MzM1ZTg0MThlNzAzZDk5NjEzMDIuLmUy ODZkZDdmYWIyNDhlYmYwYjEwNzQ0ODJiMzUxYWQ5MTY3NzgwOGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF0Zm9ybUV2ZW50RmFjdG9yeU1hYy5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1FdmVudEZhY3RvcnlNYWMubW0KQEAg LTIyMiwxMCArMjIyLDYgQEAgc3RhdGljIGlubGluZSBTdHJpbmcgdW5tb2RpZmllZFRleHRGcm9t RXZlbnQoTlNFdmVudCogZXZlbnQpCiAKIFN0cmluZyBrZXlGb3JLZXlFdmVudChOU0V2ZW50ICpl dmVudCkKIHsKLSAgICAvLyBUaGlzIGNvbnN0YW50IHdhcyBtaXNzaW5nIGJlZm9yZSBPUyBYIFNp ZXJyYS4KLSNpZm5kZWYga1ZLX1JpZ2h0Q29tbWFuZAotI2RlZmluZSBrVktfUmlnaHRDb21tYW5k IDB4MzYKLSNlbmRpZgogICAgIHN3aXRjaCAoW2V2ZW50IGtleUNvZGVdKSB7CiAgICAgY2FzZSBr VktfUmlnaHRDb21tYW5kOgogICAgIGNhc2Uga1ZLX0NvbW1hbmQ6Cg==