202593 2019-10-04 12:23:05 -0700 Allow using WebGL 2 when USE_ANGLE=1 2020-03-11 17:12:13 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198948 1 jdarpinian jdarpinian achristensen cdumez commit-queue dino esprehn+autocc ews-watchlist graouts gyuyoung.kim kbr kondapallykalyan webkit-bug-importer oldest_to_newest 1576942 0 jdarpinian 2019-10-04 12:23:05 -0700 Allow using WebGL 2 when USE_ANGLE=1 1576943 1 380232 jdarpinian 2019-10-04 12:26:02 -0700 Created attachment 380232 Allow using WebGL 2 when USE_ANGLE=1 1576953 2 380232 dino 2019-10-04 12:30:52 -0700 Comment on attachment 380232 Allow using WebGL 2 when USE_ANGLE=1 View in context: https://bugs.webkit.org/attachment.cgi?id=380232&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:614 > +#if ENABLE(WEBGL2) && PLATFORM(MAC) && !USE_ANGLE !USE(ANGLE) 1576959 3 380234 jdarpinian 2019-10-04 12:34:24 -0700 Created attachment 380234 Fix USE macro 1576965 4 380234 commit-queue 2019-10-04 12:57:26 -0700 Comment on attachment 380234 Fix USE macro Clearing flags on attachment: 380234 Committed r250740: <https://trac.webkit.org/changeset/250740> 1576966 5 commit-queue 2019-10-04 12:57:28 -0700 All reviewed patches have been landed. Closing bug. 1576967 6 webkit-bug-importer 2019-10-04 12:58:15 -0700 <rdar://problem/55992173> 380232 2019-10-04 12:26:02 -0700 2019-10-04 12:34:22 -0700 Allow using WebGL 2 when USE_ANGLE=1 bug-202593-20191004122601.patch text/plain 3384 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2FhNjRiOGRiMWRhMjEw YTI0MWRkNGFiNmI2ZjExMGFkMzBlNDRiYS4uMTE2ZjI4ZTM1ZDYzZDE5MTdkNGIxNmVkOGI1OWQy NjBjYjY1NzViZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTEwLTA0ICBKYW1l cyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBBbGxvdyB1 c2luZyBXZWJHTCAyIHdoZW4gVVNFX0FOR0xFPTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjU5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0 QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlOjpj cmVhdGUpOgorICAgICAgICAgICAgRGlzYWJsZSBpcnJlbGV2YW50IGV4dGVuc2lvbiBjaGVjay4K KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGljc0NvbnRleHQzRENvY29h Lm1tOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OkdyYXBoaWNzQ29udGV4 dDNEKToKKyAgICAgICAgICAgIFVzZSBFUzMgQU5HTEUgY29udGV4dCB3aGVuIFdlYkdMIDIgaXMg cmVxdWVzdGVkLgorCiAyMDE5LTEwLTA0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBw bGUuY29tPgogCiAgICAgICAgIENsZWFuIHVwIHNvbWUgaW5jbHVkZXMgdG8gbWFrZSB0aGUgYnVp bGQgYSBiaXQgZmFzdGVyOiBET01Qcm9taXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCmluZGV4IDNhMDFkMzc0 Y2NhMTg1MjkwNTI1NzEwZGNmMzQ0YzBiNDU0MTdlNmIuLjI4NmM1YmIxYzRhNmY2MTJkZjZkYTJl M2E3NTI3NDZlMzRiMWJkZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFz L1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCkBAIC02MTEsNyArNjExLDcgQEAg c3RkOjp1bmlxdWVfcHRyPFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U+IFdlYkdMUmVuZGVyaW5n Q29udGV4dEJhc2U6OmNyZWF0ZShDYW4KICAgICBpZiAoZXh0ZW5zaW9ucy5zdXBwb3J0cygiR0xf RVhUX2RlYnVnX21hcmtlciJfcykpCiAgICAgICAgIGV4dGVuc2lvbnMucHVzaEdyb3VwTWFya2Vy RVhUKCJXZWJHTFJlbmRlcmluZ0NvbnRleHQiX3MpOwogCi0jaWYgRU5BQkxFKFdFQkdMMikgJiYg UExBVEZPUk0oTUFDKQorI2lmIEVOQUJMRShXRUJHTDIpICYmIFBMQVRGT1JNKE1BQykgJiYgIVVT RV9BTkdMRQogICAgIC8vIGdsVGV4U3RvcmFnZSgpIHdhcyBvbmx5IGFkZGVkIHRvIENvcmUgaW4g T3BlbkdMIDQuMi4KICAgICAvLyBIb3dldmVyLCBhY2NvcmRpbmcgdG8gaHR0cHM6Ly9kZXZlbG9w ZXIuYXBwbGUuY29tL29wZW5nbC9jYXBhYmlsaXRpZXMvIGFsbCBBcHBsZSBHUFVzIHN1cHBvcnQg dGhpcyBleHRlbnNpb24uCiAgICAgaWYgKGF0dHJpYnV0ZXMuaXNXZWJHTDIgJiYgIWV4dGVuc2lv bnMuc3VwcG9ydHMoIkdMX0FSQl90ZXh0dXJlX3N0b3JhZ2UiKSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dyYXBoaWNzQ29udGV4dDNEQ29jb2Eu bW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGljc0NvbnRl eHQzRENvY29hLm1tCmluZGV4IGFlMjRjNzhmMGYyZWNkN2FiZWZkMDEwZWRjMDFhODFhY2YxZDIz ZmMuLmEyZWVhYjQyODU3NTc5Mjc0NjNlMzdiNTk5OWZkYTA5Mzk4ZDFmMjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dyYXBoaWNzQ29udGV4dDNE Q29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvR3Jh cGhpY3NDb250ZXh0M0RDb2NvYS5tbQpAQCAtMzI1LDExICszMjUsMTYgQEAgR3JhcGhpY3NDb250 ZXh0M0Q6OkdyYXBoaWNzQ29udGV4dDNEKEdyYXBoaWNzQ29udGV4dDNEQXR0cmlidXRlcyBhdHRy cywgSG9zdFdpbmQKICAgICB9CiAKICAgICBzdGQ6OnZlY3RvcjxFR0xpbnQ+IGNvbnRleHRBdHRy aWJ1dGVzOwotICAgIGNvbnRleHRBdHRyaWJ1dGVzLnB1c2hfYmFjayhFR0xfQ09OVEVYVF9DTElF TlRfVkVSU0lPTik7Ci0gICAgY29udGV4dEF0dHJpYnV0ZXMucHVzaF9iYWNrKDIpOwotICAgIC8v IEFOR0xFIHdpbGwgdXBncmFkZSB0aGUgY29udGV4dCB0byBFUzMgYXV0b21hdGljYWxseSB1bmxl c3MgdGhpcyBpcyBzcGVjaWZpZWQuCi0gICAgY29udGV4dEF0dHJpYnV0ZXMucHVzaF9iYWNrKEVH TF9DT05URVhUX09QRU5HTF9CQUNLV0FSRFNfQ09NUEFUSUJMRV9BTkdMRSk7Ci0gICAgY29udGV4 dEF0dHJpYnV0ZXMucHVzaF9iYWNrKEVHTF9GQUxTRSk7CisgICAgaWYgKGF0dHJzLmlzV2ViR0wy KSB7CisgICAgICAgIGNvbnRleHRBdHRyaWJ1dGVzLnB1c2hfYmFjayhFR0xfQ09OVEVYVF9DTElF TlRfVkVSU0lPTik7CisgICAgICAgIGNvbnRleHRBdHRyaWJ1dGVzLnB1c2hfYmFjaygzKTsKKyAg ICB9IGVsc2UgeworICAgICAgICBjb250ZXh0QXR0cmlidXRlcy5wdXNoX2JhY2soRUdMX0NPTlRF WFRfQ0xJRU5UX1ZFUlNJT04pOworICAgICAgICBjb250ZXh0QXR0cmlidXRlcy5wdXNoX2JhY2so Mik7CisgICAgICAgIC8vIEFOR0xFIHdpbGwgdXBncmFkZSB0aGUgY29udGV4dCB0byBFUzMgYXV0 b21hdGljYWxseSB1bmxlc3MgdGhpcyBpcyBzcGVjaWZpZWQuCisgICAgICAgIGNvbnRleHRBdHRy aWJ1dGVzLnB1c2hfYmFjayhFR0xfQ09OVEVYVF9PUEVOR0xfQkFDS1dBUkRTX0NPTVBBVElCTEVf QU5HTEUpOworICAgICAgICBjb250ZXh0QXR0cmlidXRlcy5wdXNoX2JhY2soRUdMX0ZBTFNFKTsK KyAgICB9CiAgICAgY29udGV4dEF0dHJpYnV0ZXMucHVzaF9iYWNrKEVHTF9DT05URVhUX1dFQkdM X0NPTVBBVElCSUxJVFlfQU5HTEUpOwogICAgIGNvbnRleHRBdHRyaWJ1dGVzLnB1c2hfYmFjayhF R0xfVFJVRSk7CiAgICAgaWYgKHN0cnN0cihkaXNwbGF5RXh0ZW5zaW9ucywgIkVHTF9BTkdMRV9w b3dlcl9wcmVmZXJlbmNlIikpIHsK 380234 2019-10-04 12:34:24 -0700 2019-10-04 12:57:26 -0700 Fix USE macro bug-202593-20191004123423.patch text/plain 3385 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2FhNjRiOGRiMWRhMjEw YTI0MWRkNGFiNmI2ZjExMGFkMzBlNDRiYS4uMTE2ZjI4ZTM1ZDYzZDE5MTdkNGIxNmVkOGI1OWQy NjBjYjY1NzViZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTEwLTA0ICBKYW1l cyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBBbGxvdyB1 c2luZyBXZWJHTCAyIHdoZW4gVVNFX0FOR0xFPTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjU5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0 QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlOjpj cmVhdGUpOgorICAgICAgICAgICAgRGlzYWJsZSBpcnJlbGV2YW50IGV4dGVuc2lvbiBjaGVjay4K KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGljc0NvbnRleHQzRENvY29h Lm1tOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OkdyYXBoaWNzQ29udGV4 dDNEKToKKyAgICAgICAgICAgIFVzZSBFUzMgQU5HTEUgY29udGV4dCB3aGVuIFdlYkdMIDIgaXMg cmVxdWVzdGVkLgorCiAyMDE5LTEwLTA0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBw bGUuY29tPgogCiAgICAgICAgIENsZWFuIHVwIHNvbWUgaW5jbHVkZXMgdG8gbWFrZSB0aGUgYnVp bGQgYSBiaXQgZmFzdGVyOiBET01Qcm9taXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCmluZGV4IDNhMDFkMzc0 Y2NhMTg1MjkwNTI1NzEwZGNmMzQ0YzBiNDU0MTdlNmIuLmRlNDdhZTc0ZDdkNTlkYjA5NWM0Mzdj NGU5ZDU5NzdhODZkZGUwODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFz L1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCkBAIC02MTEsNyArNjExLDcgQEAg c3RkOjp1bmlxdWVfcHRyPFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U+IFdlYkdMUmVuZGVyaW5n Q29udGV4dEJhc2U6OmNyZWF0ZShDYW4KICAgICBpZiAoZXh0ZW5zaW9ucy5zdXBwb3J0cygiR0xf RVhUX2RlYnVnX21hcmtlciJfcykpCiAgICAgICAgIGV4dGVuc2lvbnMucHVzaEdyb3VwTWFya2Vy RVhUKCJXZWJHTFJlbmRlcmluZ0NvbnRleHQiX3MpOwogCi0jaWYgRU5BQkxFKFdFQkdMMikgJiYg UExBVEZPUk0oTUFDKQorI2lmIEVOQUJMRShXRUJHTDIpICYmIFBMQVRGT1JNKE1BQykgJiYgIVVT RShBTkdMRSkKICAgICAvLyBnbFRleFN0b3JhZ2UoKSB3YXMgb25seSBhZGRlZCB0byBDb3JlIGlu IE9wZW5HTCA0LjIuCiAgICAgLy8gSG93ZXZlciwgYWNjb3JkaW5nIHRvIGh0dHBzOi8vZGV2ZWxv cGVyLmFwcGxlLmNvbS9vcGVuZ2wvY2FwYWJpbGl0aWVzLyBhbGwgQXBwbGUgR1BVcyBzdXBwb3J0 IHRoaXMgZXh0ZW5zaW9uLgogICAgIGlmIChhdHRyaWJ1dGVzLmlzV2ViR0wyICYmICFleHRlbnNp b25zLnN1cHBvcnRzKCJHTF9BUkJfdGV4dHVyZV9zdG9yYWdlIikpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGljc0NvbnRleHQzRENvY29h Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvR3JhcGhpY3NDb250 ZXh0M0RDb2NvYS5tbQppbmRleCBhZTI0Yzc4ZjBmMmVjZDdhYmVmZDAxMGVkYzAxYTgxYWNmMWQy M2ZjLi5hMmVlYWI0Mjg1NzU3OTI3NDYzZTM3YjU5OTlmZGEwOTM5OGQxZjIxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGljc0NvbnRleHQz RENvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dy YXBoaWNzQ29udGV4dDNEQ29jb2EubW0KQEAgLTMyNSwxMSArMzI1LDE2IEBAIEdyYXBoaWNzQ29u dGV4dDNEOjpHcmFwaGljc0NvbnRleHQzRChHcmFwaGljc0NvbnRleHQzREF0dHJpYnV0ZXMgYXR0 cnMsIEhvc3RXaW5kCiAgICAgfQogCiAgICAgc3RkOjp2ZWN0b3I8RUdMaW50PiBjb250ZXh0QXR0 cmlidXRlczsKLSAgICBjb250ZXh0QXR0cmlidXRlcy5wdXNoX2JhY2soRUdMX0NPTlRFWFRfQ0xJ RU5UX1ZFUlNJT04pOwotICAgIGNvbnRleHRBdHRyaWJ1dGVzLnB1c2hfYmFjaygyKTsKLSAgICAv LyBBTkdMRSB3aWxsIHVwZ3JhZGUgdGhlIGNvbnRleHQgdG8gRVMzIGF1dG9tYXRpY2FsbHkgdW5s ZXNzIHRoaXMgaXMgc3BlY2lmaWVkLgotICAgIGNvbnRleHRBdHRyaWJ1dGVzLnB1c2hfYmFjayhF R0xfQ09OVEVYVF9PUEVOR0xfQkFDS1dBUkRTX0NPTVBBVElCTEVfQU5HTEUpOwotICAgIGNvbnRl eHRBdHRyaWJ1dGVzLnB1c2hfYmFjayhFR0xfRkFMU0UpOworICAgIGlmIChhdHRycy5pc1dlYkdM MikgeworICAgICAgICBjb250ZXh0QXR0cmlidXRlcy5wdXNoX2JhY2soRUdMX0NPTlRFWFRfQ0xJ RU5UX1ZFUlNJT04pOworICAgICAgICBjb250ZXh0QXR0cmlidXRlcy5wdXNoX2JhY2soMyk7Cisg ICAgfSBlbHNlIHsKKyAgICAgICAgY29udGV4dEF0dHJpYnV0ZXMucHVzaF9iYWNrKEVHTF9DT05U RVhUX0NMSUVOVF9WRVJTSU9OKTsKKyAgICAgICAgY29udGV4dEF0dHJpYnV0ZXMucHVzaF9iYWNr KDIpOworICAgICAgICAvLyBBTkdMRSB3aWxsIHVwZ3JhZGUgdGhlIGNvbnRleHQgdG8gRVMzIGF1 dG9tYXRpY2FsbHkgdW5sZXNzIHRoaXMgaXMgc3BlY2lmaWVkLgorICAgICAgICBjb250ZXh0QXR0 cmlidXRlcy5wdXNoX2JhY2soRUdMX0NPTlRFWFRfT1BFTkdMX0JBQ0tXQVJEU19DT01QQVRJQkxF X0FOR0xFKTsKKyAgICAgICAgY29udGV4dEF0dHJpYnV0ZXMucHVzaF9iYWNrKEVHTF9GQUxTRSk7 CisgICAgfQogICAgIGNvbnRleHRBdHRyaWJ1dGVzLnB1c2hfYmFjayhFR0xfQ09OVEVYVF9XRUJH TF9DT01QQVRJQklMSVRZX0FOR0xFKTsKICAgICBjb250ZXh0QXR0cmlidXRlcy5wdXNoX2JhY2so RUdMX1RSVUUpOwogICAgIGlmIChzdHJzdHIoZGlzcGxheUV4dGVuc2lvbnMsICJFR0xfQU5HTEVf cG93ZXJfcHJlZmVyZW5jZSIpKSB7Cg==