202578 2019-10-04 04:53:45 -0700 A service worker process should not be created when enqueuing a service worker job 2019-10-09 23:59:22 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1576812 0 youennf 2019-10-04 04:53:45 -0700 This is too early. In some cases, the jobs will never need the service worker process. 1576814 1 webkit-bug-importer 2019-10-04 04:54:01 -0700 <rdar://problem/55979690> 1576817 2 380213 youennf 2019-10-04 05:04:13 -0700 Created attachment 380213 Patch 1576862 3 380213 cdumez 2019-10-04 08:26:07 -0700 Comment on attachment 380213 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380213&action=review > Source/WebKit/ChangeLog:3 > + A service worker process should not be created when enqueuing a service worker job In what cases are we running a job but won't need a service worker process? Are those cases really common? Won't there be a potential performance cost to your change in the common case where we will end up needing this service worker process (since you are now effectively delaying its launch)? 1576865 4 youennf 2019-10-04 08:31:53 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 380213 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380213&action=review > > > Source/WebKit/ChangeLog:3 > > + A service worker process should not be created when enqueuing a service worker job > > In what cases are we running a job but won't need a service worker process? There is some information in the rdar about that. We only need the process for jobs that will end up installing a service worker. > Are those cases really common? Won't there be a potential performance cost > to your change in the common case where we will end up needing this service > worker process (since you are now effectively delaying its launch)? We do not delay anything for time sensitive cases (fetch and postMessage). We slightly delay for the install case but I do not think this step is very time sensitive since it already requires grabbing a script, running it, calling a bunch of service worker event handlers... 1578180 5 youennf 2019-10-09 04:08:54 -0700 Ping review 1578530 6 380213 commit-queue 2019-10-09 23:59:21 -0700 Comment on attachment 380213 Patch Clearing flags on attachment: 380213 Committed r250957: <https://trac.webkit.org/changeset/250957> 1578531 7 commit-queue 2019-10-09 23:59:22 -0700 All reviewed patches have been landed. Closing bug. 380213 2019-10-04 05:04:13 -0700 2019-10-09 23:59:21 -0700 Patch bug-202578-20191004140412.patch text/plain 5673 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjIwNDlhNzY5YzZkOGQ2 ZDBmMTFiNDQwMjBhMDQwY2RiMWQyYTY2YS4uNjhlNTBhM2MyOGJhZjk4ZWJkYzY3NGNjYTllYjFj YjY0MGNhNGFkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTEwLTA0ICB5b3Vl bm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBIHNlcnZpY2Ugd29ya2Vy IHByb2Nlc3Mgc2hvdWxkIG5vdCBiZSBjcmVhdGVkIHdoZW4gZW5xdWV1aW5nIGEgc2VydmljZSB3 b3JrZXIgam9iCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDI1NzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1OTc5NjkwPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzayBmb3IgYSBzZXJ2aWNlIHdv cmtlciBjb250ZXh0IGNvbm5lY3Rpb24gd2hlbiBwbGFubmluZyB0byBpbnN0YWxsIG9yIHJ1biBh IHNlcnZpY2Ugd29ya2VyLgorICAgICAgICBUaGlzIGFsbG93cyB0byBub3Qgc3BpbiB1bm5lY2Vz c2FyaWx5IHNlcnZpY2Ugd29ya2VyIHByb2Nlc3NlcyBmb3Igam9icyB0aGF0IGRvIG5vdCBlbmQg dXAgaW5zdGFsbGluZyBhIHNlcnZpY2Ugd29ya2VyLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhp c3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNXU2VydmVyOjp0cnlJbnN0YWxsQ29udGV4dERhdGEp OgorICAgICAgICAoV2ViQ29yZTo6U1dTZXJ2ZXI6OnJ1blNlcnZpY2VXb3JrZXJJZk5lY2Vzc2Fy eSk6CisKIDIwMTktMTAtMDQgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAg ICAgICAgIEFsbG93IHRvIHN1c3BlbmQgUlRDUGVlckNvbm5lY3Rpb24gd2hlbiBub3QgY29ubmVj dGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCmluZGV4IDBjM2EwNmU0NWIyNzFlOWUxODkxNTg2YzNjYTEzMmQ4Yzk2Y2YwOWMu LmZhMWFhYmZhZmEzNmJlMDExYmFhODQyMjg2YzJiYzM3MDI3NzA2YmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTkgQEAKKzIwMTktMTAtMDQgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgorCisgICAgICAgIEEgc2VydmljZSB3b3JrZXIgcHJvY2VzcyBzaG91bGQgbm90IGJlIGNyZWF0 ZWQgd2hlbiBlbnF1ZXVpbmcgYSBzZXJ2aWNlIHdvcmtlciBqb2IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMjU3OAorICAgICAgICA8cmRhcjovL3By b2JsZW0vNTU5Nzk2OTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVtb3ZlIHRoZSBjYWxscyB0byBjcmVhdGUgc2VydmljZSB3b3JrZXIgY29udGV4 dCBjb25uZWN0aW9uLgorICAgICAgICBUaGV5IGFyZSBub3cgZG9uZSBhdCBTV1NlcnZlciBsZXZl bCB3aGVuIHRyeWluZyB0byBlaXRoZXIgcnVuIGEgc2VydmljZSB3b3JrZXIgb3IgaW5zdGFsbCBv bmUuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1dlYlNXU2VydmVy Q29ubmVjdGlvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlNXU2VydmVyQ29ubmVjdGlvbjo6 c3RhcnRGZXRjaCk6CisgICAgICAgIChXZWJLaXQ6OldlYlNXU2VydmVyQ29ubmVjdGlvbjo6cG9z dE1lc3NhZ2VUb1NlcnZpY2VXb3JrZXIpOgorICAgICAgICAoV2ViS2l0OjpXZWJTV1NlcnZlckNv bm5lY3Rpb246OnNjaGVkdWxlSm9iSW5TZXJ2ZXIpOgorCiAyMDE5LTEwLTA0ICB5b3Vlbm4gZmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyB0byBzdXNwZW5kIFJUQ1Bl ZXJDb25uZWN0aW9uIHdoZW4gbm90IGNvbm5lY3RlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93 b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcAppbmRleCAxMDhlZmY1MjBiMmNjZDQw MWMzYjZlM2EwYmUwNmY0ZjE3OGJkMGZhLi4yZjVlZjEyMzZkYjEwZjcwZGI3NTQ2MGZhYTk5ZjA5 NTJkOWRkYjM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2Vy dmVyL1NXU2VydmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2Vy dmVyL1NXU2VydmVyLmNwcApAQCAtNTM5LDkgKzUzOSwxMSBAQCB2b2lkIFNXU2VydmVyOjp0cnlJ bnN0YWxsQ29udGV4dERhdGEoU2VydmljZVdvcmtlckNvbnRleHREYXRhJiYgZGF0YSkKICAgICBS ZWdpc3RyYWJsZURvbWFpbiByZWdpc3RyYWJsZURvbWFpbihkYXRhLnNjcmlwdFVSTCk7CiAgICAg YXV0byogY29ubmVjdGlvbiA9IGNvbnRleHRDb25uZWN0aW9uRm9yUmVnaXN0cmFibGVEb21haW4o cmVnaXN0cmFibGVEb21haW4pOwogICAgIGlmICghY29ubmVjdGlvbikgewotICAgICAgICBtX3Bl bmRpbmdDb250ZXh0RGF0YXMuZW5zdXJlKFdURk1vdmUocmVnaXN0cmFibGVEb21haW4pLCBbXSB7 CisgICAgICAgIG1fcGVuZGluZ0NvbnRleHREYXRhcy5lbnN1cmUocmVnaXN0cmFibGVEb21haW4s IFtdIHsKICAgICAgICAgICAgIHJldHVybiBWZWN0b3I8U2VydmljZVdvcmtlckNvbnRleHREYXRh PiB7IH07CiAgICAgICAgIH0pLml0ZXJhdG9yLT52YWx1ZS5hcHBlbmQoV1RGTW92ZShkYXRhKSk7 CisKKyAgICAgICAgY3JlYXRlQ29udGV4dENvbm5lY3Rpb24ocmVnaXN0cmFibGVEb21haW4pOwog ICAgICAgICByZXR1cm47CiAgICAgfQogICAgIApAQCAtNjE4LDYgKzYyMCw4IEBAIHZvaWQgU1dT ZXJ2ZXI6OnJ1blNlcnZpY2VXb3JrZXJJZk5lY2Vzc2FyeShTZXJ2aWNlV29ya2VySWRlbnRpZmll ciBpZGVudGlmaWVyLCBSCiAgICAgICAgIHNlcnZpY2VXb3JrZXJSdW5SZXF1ZXN0c0Zvck9yaWdp bi5lbnN1cmUoaWRlbnRpZmllciwgWyZdIHsKICAgICAgICAgICAgIHJldHVybiBWZWN0b3I8UnVu U2VydmljZVdvcmtlckNhbGxiYWNrPiB7IH07CiAgICAgICAgIH0pLml0ZXJhdG9yLT52YWx1ZS5h cHBlbmQoV1RGTW92ZShjYWxsYmFjaykpOworCisgICAgICAgIGNyZWF0ZUNvbnRleHRDb25uZWN0 aW9uKHdvcmtlci0+cmVnaXN0cmFibGVEb21haW4oKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtl ci9XZWJTV1NlcnZlckNvbm5lY3Rpb24uY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9TZXJ2aWNlV29ya2VyL1dlYlNXU2VydmVyQ29ubmVjdGlvbi5jcHAKaW5kZXggNzY3NDE0MGYx NzVjNDU3MDhiNTI1MTVjN2M0NWU1ODY2ZmYyOGUyNy4uNTFjMTU2OGU2ZWU3NzcyOTkxMDUwZmYy YjM2YTAyMDA1NGJjZTg4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9TZXJ2aWNlV29ya2VyL1dlYlNXU2VydmVyQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1dlYlNXU2VydmVyQ29ubmVjdGlvbi5j cHAKQEAgLTE3OSw5ICsxNzksNiBAQCB2b2lkIFdlYlNXU2VydmVyQ29ubmVjdGlvbjo6c3RhcnRG ZXRjaChTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uSWRlbnRpZmllciBzZXJ2aQogICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKCF3b3JrZXItPmNvbnRleHRDb25u ZWN0aW9uKCkpCi0gICAgICAgICAgICBzZXJ2ZXIoKS5jcmVhdGVDb250ZXh0Q29ubmVjdGlvbih3 b3JrZXItPnJlZ2lzdHJhYmxlRG9tYWluKCkpOwotCiAgICAgICAgIHNlcnZlcigpLnJ1blNlcnZp Y2VXb3JrZXJJZk5lY2Vzc2FyeShzZXJ2aWNlV29ya2VySWRlbnRpZmllciwgW3dlYWtUaGlzID0g V1RGTW92ZSh3ZWFrVGhpcyksIHRoaXMsIGZldGNoSWRlbnRpZmllciwgc2VydmljZVdvcmtlcklk ZW50aWZpZXIsIHJlcXVlc3QgPSBXVEZNb3ZlKHJlcXVlc3QpLCBvcHRpb25zID0gV1RGTW92ZShv cHRpb25zKSwgZm9ybURhdGEgPSBXVEZNb3ZlKGZvcm1EYXRhKSwgcmVmZXJyZXIgPSBXVEZNb3Zl KHJlZmVycmVyKSwgc2hvdWxkU2tpcEZldGNoRXZlbnQgPSB3b3JrZXItPnNob3VsZFNraXBGZXRj aEV2ZW50KCldKGF1dG8qIGNvbnRleHRDb25uZWN0aW9uKSB7CiAgICAgICAgICAgICBpZiAoIXdl YWtUaGlzKQogICAgICAgICAgICAgICAgIHJldHVybjsKQEAgLTIzMCw5ICsyMjcsNiBAQCB2b2lk IFdlYlNXU2VydmVyQ29ubmVjdGlvbjo6cG9zdE1lc3NhZ2VUb1NlcnZpY2VXb3JrZXIoU2Vydmlj ZVdvcmtlcklkZW50aWZpZXIgZAogICAgIGlmICghc291cmNlRGF0YSkKICAgICAgICAgcmV0dXJu OwogCi0gICAgaWYgKCFkZXN0aW5hdGlvbldvcmtlci0+Y29udGV4dENvbm5lY3Rpb24oKSkKLSAg ICAgICAgc2VydmVyKCkuY3JlYXRlQ29udGV4dENvbm5lY3Rpb24oZGVzdGluYXRpb25Xb3JrZXIt PnJlZ2lzdHJhYmxlRG9tYWluKCkpOwotCiAgICAgLy8gSXQncyBwb3NzaWJsZSB0aGlzIHNwZWNp ZmljIHdvcmtlciBjYW5ub3QgYmUgcmUtcnVuIChlLmcuIGl0cyByZWdpc3RyYXRpb24gaGFzIGJl ZW4gcmVtb3ZlZCkKICAgICBzZXJ2ZXIoKS5ydW5TZXJ2aWNlV29ya2VySWZOZWNlc3NhcnkoZGVz dGluYXRpb25JZGVudGlmaWVyLCBbZGVzdGluYXRpb25JZGVudGlmaWVyLCBtZXNzYWdlID0gV1RG TW92ZShtZXNzYWdlKSwgc291cmNlRGF0YSA9IFdURk1vdmUoKnNvdXJjZURhdGEpXShhdXRvKiBj b250ZXh0Q29ubmVjdGlvbikgbXV0YWJsZSB7CiAgICAgICAgIGlmIChjb250ZXh0Q29ubmVjdGlv bikKQEAgLTI0MiwxMCArMjM2LDYgQEAgdm9pZCBXZWJTV1NlcnZlckNvbm5lY3Rpb246OnBvc3RN ZXNzYWdlVG9TZXJ2aWNlV29ya2VyKFNlcnZpY2VXb3JrZXJJZGVudGlmaWVyIGQKIAogdm9pZCBX ZWJTV1NlcnZlckNvbm5lY3Rpb246OnNjaGVkdWxlSm9iSW5TZXJ2ZXIoU2VydmljZVdvcmtlckpv YkRhdGEmJiBqb2JEYXRhKQogewotICAgIFJlZ2lzdHJhYmxlRG9tYWluIHJlZ2lzdHJhYmxlRG9t YWluKGpvYkRhdGEuc2NvcGVVUkwpOwotICAgIGlmICghc2VydmVyKCkuY29udGV4dENvbm5lY3Rp b25Gb3JSZWdpc3RyYWJsZURvbWFpbihyZWdpc3RyYWJsZURvbWFpbikpCi0gICAgICAgIHNlcnZl cigpLmNyZWF0ZUNvbnRleHRDb25uZWN0aW9uKHJlZ2lzdHJhYmxlRG9tYWluKTsKLQogICAgIFNX U0VSVkVSQ09OTkVDVElPTl9SRUxFQVNFX0xPR19JRl9BTExPV0VEKCJTY2hlZHVsaW5nIFNlcnZp Y2VXb3JrZXIgam9iICVzIGluIHNlcnZlciIsIGpvYkRhdGEuaWRlbnRpZmllcigpLmxvZ2dpbmdT dHJpbmcoKS51dGY4KCkuZGF0YSgpKTsKICAgICBBU1NFUlQoaWRlbnRpZmllcigpID09IGpvYkRh dGEuY29ubmVjdGlvbklkZW50aWZpZXIoKSk7CiAK